From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECBBEC46CD2 for ; Tue, 30 Jan 2024 10:03:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B5416B0080; Tue, 30 Jan 2024 05:03:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 63D716B0096; Tue, 30 Jan 2024 05:03:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 469956B0099; Tue, 30 Jan 2024 05:03:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 33BC26B0080 for ; Tue, 30 Jan 2024 05:03:12 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 064C6A07F1 for ; Tue, 30 Jan 2024 10:03:12 +0000 (UTC) X-FDA: 81735539424.10.7EADD78 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf27.hostedemail.com (Postfix) with ESMTP id AC4B940020 for ; Tue, 30 Jan 2024 10:03:09 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=vVZFDbYX; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="n/MERs5t"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=vVZFDbYX; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="n/MERs5t"; dmarc=none; spf=pass (imf27.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706608990; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ypvJnXvVjmaayelrbx9cC9PI4eHdK+C4dtVzpiZqLQ4=; b=kvJfpdtxbqOlYq6/oi/vXhAGWQlqfYl9mpi2t8/VlhyINOpob33ifjmGpfKngHDpQSlwTH l/dZA9tHN1UkzVIGxL2xU+DvIq4RTPswGYu1C4PvR9aokcs+K1n38H0NlbN6b9SwDHciK/ wgiqYYgPgm/KeiHi+9pMYcgwnY03X+Y= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=vVZFDbYX; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="n/MERs5t"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=vVZFDbYX; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="n/MERs5t"; dmarc=none; spf=pass (imf27.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706608990; a=rsa-sha256; cv=none; b=eDcoONj2MZDcN7Yvla4maXwNqyuHC17Ml14qRBqDaGwqxPS+/PXEb8u4no3HURrmZu8Lm0 itq/ZF3hO30Dzg17DMwfc93AsNk5laZaWWFf6x2uz9NDH79JTsGD+wgysLsbW2xFRrOhqh cYXgYMakhpmCJeuHQWGYFff1dAOTt5w= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9C9FD1F83F; Tue, 30 Jan 2024 10:03:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1706608987; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ypvJnXvVjmaayelrbx9cC9PI4eHdK+C4dtVzpiZqLQ4=; b=vVZFDbYX2wN/3NIyMU5Mb/zYfjArt0R1NdLgrRwS3sMURrlNf2A37D82b9XAdKCmjs7wF4 wpLrRvpwHJSu4lLfIrm8JehI8cFJpQhC9lhShY4VVrSTceLWFs21FtoUAvS1Mlnv7uaNi3 qIJoFKAwnNja2OGNOKTCpSfrNzvvIa8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1706608987; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ypvJnXvVjmaayelrbx9cC9PI4eHdK+C4dtVzpiZqLQ4=; b=n/MERs5tRa7fMRqwi43Nhw143nMxUdTx1DsOb2d1LYDAMF2UgoTh1FS8GACB9h52YQ43a7 w6raW35bJ59zKIAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1706608987; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ypvJnXvVjmaayelrbx9cC9PI4eHdK+C4dtVzpiZqLQ4=; b=vVZFDbYX2wN/3NIyMU5Mb/zYfjArt0R1NdLgrRwS3sMURrlNf2A37D82b9XAdKCmjs7wF4 wpLrRvpwHJSu4lLfIrm8JehI8cFJpQhC9lhShY4VVrSTceLWFs21FtoUAvS1Mlnv7uaNi3 qIJoFKAwnNja2OGNOKTCpSfrNzvvIa8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1706608987; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ypvJnXvVjmaayelrbx9cC9PI4eHdK+C4dtVzpiZqLQ4=; b=n/MERs5tRa7fMRqwi43Nhw143nMxUdTx1DsOb2d1LYDAMF2UgoTh1FS8GACB9h52YQ43a7 w6raW35bJ59zKIAA== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 7DABC13462; Tue, 30 Jan 2024 10:03:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id Z7anHlvJuGXocgAAn2gu4w (envelope-from ); Tue, 30 Jan 2024 10:03:07 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 1C92CA0807; Tue, 30 Jan 2024 11:03:07 +0100 (CET) Date: Tue, 30 Jan 2024 11:03:07 +0100 From: Jan Kara To: Christoph Hellwig Cc: linux-mm@kvack.org, Matthew Wilcox , Jan Kara , David Howells , Brian Foster , Christian Brauner , "Darrick J. Wong" , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 18/19] iomap: Convert iomap_writepages() to use for_each_writeback_folio() Message-ID: <20240130100307.5ub22s5ajanqstp6@quack3> References: <20240125085758.2393327-1-hch@lst.de> <20240125085758.2393327-19-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240125085758.2393327-19-hch@lst.de> X-Rspamd-Queue-Id: AC4B940020 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: bcu4mbcgy39r5ks9u87p7ee8mbniektt X-HE-Tag: 1706608989-41735 X-HE-Meta: U2FsdGVkX19GmhvN6ViO56+Lo5nD9whueV7OdbjahyOtlUdI6NZnu7wkXK14P8YkL1wV0+qvIX2m9Il8X3rbO5NTVZ6zh35Kz07jQ7TKkyzC7WEIK0RnEVxhCDyeYlz692CvwEUsgjFqcYnxPbQuNNlXXEeAlM5/vVZ6wGWuAP+6WKZb4qDCbdFZW5G8ulrtp1Pi4B3x52hiSIM6VtA0rojWWT41vw1X/ARUy6QkcH9Bt7tB4OVCSZ5BQJ15OfAhcO08RseJ39ukhWtCwpYK9POBV4CMxZ+zgUuikRHe+IOZDj5zBEz2un6vNqT+wETJIQc/xufgyGBph3eX/OTEH51Nq2IjIMR0ONozbz0FDXBKyjNC1W4mwxt4jXA+wNZGxIsvcXecReWtS7GhWXcmJBL6XGB+y+EaOM+q2zKWNGQoSp803p5CcsxQU17eMfNvSXF8MrqmkRThsu2gRse8mgXO16BpwsSBCDpLKzQy3p1ON4KZoV1j8cY0E7pTHjTWcJZNjCdBmkrAg3/p8zhzj1agprLvmf+ihRObdMGCNLC5QT7BUgaTEAeB6csLWd2uoFnn1q1cwGxaiziY0Dk42d4u7xdtB0ezKGJUdO5/DjIgA+VlMZ0miAu+N9Yg8dcgdmBjm++MNKbPrbtzCnxiy8k1GRsPXmtosqP5jOnps/kI656q2VsPAkwayvx9QKIVHRaT/GbcWuOwXbkO7tsLiFlp5PiCJxvHi/bLDM8UMjlC1miDDaqMM/Y3eau1qToww3vGlqfcnf+PcsuT1TmbXluA3obQa4zltYfLVDbWw/r4DLnL0RE5eKsmncVrPMEDtl3fZjxe2VW1eg8qd+akuPu8yemHncxVxTxKwfOm2Dq6ueQKHNVrEVj9J9MOhltJ4PsVqTzW2yPuHTUUNif06VoNtMq/TpyvEHXo2gKNp6CY5m5xd1znJx5V86+7qkKnuF5XH2ia6kVIyI/VPKw LNVdk5Bo +kkjekbrl95rdbWnjybtcV1AY3Hl8IT3DBeHMKHNH0KQNOAN+4bBybhV91KbcSa9hxwJ+PjAgDcjyVlkIcMB7TNHrHfGDg6Tr6ioNjT2cXh4vzG02O1dsuwFy4Hp8motVHD+KGHQjsEsbq/I9V8UxLwT0Mi+Nao8YXc0tLUItCsYjfs1Bi51YdlMQwvB1n1FoMZp768PW9wdbgX+LJrnqsZO1SFe1pz6pNzj10cvs/G9GyPS6d+O+93SUgwVXCNKke4NJqPaHqiQ3EyBp6dg6ROtedhtkQWKj9PqVUxtgQz7oTJ1OxWsihFQuaVbGf51AarFv0GRgX6k4FNkA2wAsIOLMOJh1lWFO4q/AsLqEH8IZFhjqN1aor4LKlL5p3n79Lmt1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 25-01-24 09:57:57, Christoph Hellwig wrote: > From: Matthew Wilcox > > This removes one indirect function call per folio, and adds typesafety > by not casting through a void pointer. > > Signed-off-by: Matthew Wilcox (Oracle) > Signed-off-by: Christoph Hellwig Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/iomap/buffered-io.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c > index 093c4515b22a53..58b3661f5eac9e 100644 > --- a/fs/iomap/buffered-io.c > +++ b/fs/iomap/buffered-io.c > @@ -1887,9 +1887,8 @@ iomap_writepage_map(struct iomap_writepage_ctx *wpc, > * regular allocated space. > */ > static int iomap_do_writepage(struct folio *folio, > - struct writeback_control *wbc, void *data) > + struct writeback_control *wbc, struct iomap_writepage_ctx *wpc) > { > - struct iomap_writepage_ctx *wpc = data; > struct inode *inode = folio->mapping->host; > u64 end_pos, isize; > > @@ -1986,10 +1985,12 @@ iomap_writepages(struct address_space *mapping, struct writeback_control *wbc, > struct iomap_writepage_ctx *wpc, > const struct iomap_writeback_ops *ops) > { > - int ret; > + struct folio *folio; > + int ret; > > wpc->ops = ops; > - ret = write_cache_pages(mapping, wbc, iomap_do_writepage, wpc); > + for_each_writeback_folio(mapping, wbc, folio, ret) > + ret = iomap_do_writepage(folio, wbc, wpc); > if (!wpc->ioend) > return ret; > return iomap_submit_ioend(wpc, wpc->ioend, ret); > -- > 2.39.2 > -- Jan Kara SUSE Labs, CR