From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEB3FC47DA9 for ; Mon, 29 Jan 2024 19:34:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 13FF36B007E; Mon, 29 Jan 2024 14:34:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F0E16B0083; Mon, 29 Jan 2024 14:34:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF9896B0085; Mon, 29 Jan 2024 14:34:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E05CA6B007E for ; Mon, 29 Jan 2024 14:34:29 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9CD021C134C for ; Mon, 29 Jan 2024 19:34:29 +0000 (UTC) X-FDA: 81733350258.28.FAE4722 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf14.hostedemail.com (Postfix) with ESMTP id A2E3B100017 for ; Mon, 29 Jan 2024 19:34:27 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=bdsIxLwX; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf14.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706556868; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y20SlS97Pif+eZWcli8UoWz3jQtBHyVieM06xnSycFE=; b=v6qr+XWbl5P3GYYMmvkW53HJSNOYAQS2Id3vh6SlojsId34Jz+AhASy+MVX97kZu382NMG WtLPzpPzOcvQoHhBDkIaFBuejt09U79BkHtSxDqqHXXM8POAvmsQyBxGEVwC58fDc/oDHS aFcpwMNzXa+f7iqEeoY0vdJUfI8aBpo= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=bdsIxLwX; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf14.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706556868; a=rsa-sha256; cv=none; b=M5juIlWfnlFbn5ZmfEiBIh37A3QblDbyS6VWzGgxGLSSXdHREH1YRT0e+3dxRLaoCNyVC6 M5aAGG6iOP8XOEcxm+qzi1LHJlw1kbY8VvN1PotATYrs+G2FyhVi91WvClB0+aEaG/D4uO UvRnjr+t7LuSuJx1clMAEjdUEvLORNI= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 45A6640E016C; Mon, 29 Jan 2024 19:34:25 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 4_ICJQF_PwKX; Mon, 29 Jan 2024 19:34:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1706556863; bh=Y20SlS97Pif+eZWcli8UoWz3jQtBHyVieM06xnSycFE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bdsIxLwXTfiTiQNBBuB4jxzMjtcW9WLQgDndiKuh2Dgb1Fycm7YYU1xoqIfx8WkDk ZWPNJ92VcRA1likU1aDH2DuQQ7wGisMuAlPOoUjuJESd23/x1dOTfWX9bt5UW1wmKO rHqGvrOI2XHAzgnHlljaQXh3TONXOx51jFEdh8ehAc3IT296ZK3HC4+Pam2D4/uDPq fMTRb2p0RgOZRUCeqxKFq0ATiK3GGxR9YoTj16jRNFwQN8Jfl0rhgBBWliLPOJByFm 0Td75HtzdqwyPNJj86PRwlop6u+oa52/lGQDVrYYDp2x7jNnJSVXCc176KK6TJWi15 PleiW0y++W5QfJAynv5b2KyzlzKuVHFgYHiE19YgVM7xqUnPJtXzHwg88/O5VVUGvf Ih4s4Cp5x4PlvJouh/SQWBI/8w8nnVddxJmn4cov/xaqB0Ue9l9VfcJArJOV1O3BSG pSMPG234d7SXmNE0YITi5zqaBZMRqGvjr7zYkGwoMtl6NnQ0o430Idm6aw4KArALM0 1F0CPmVk1pZzMIAcEnJDhltOfay5/dxNH6KDVIB/5hEzJoAAhGGWpa48ZrBKyJN0DB 0JacNamOknGrSMo/o4CSeVOcYWxIzE9hvOEGg4CDxDlyHSiQWj4J7LytH4Bvm1aMi7 Njo5QWcNHZ2lOUtJBw05ByGk= Received: from zn.tnic (pd953033e.dip0.t-ipconnect.de [217.83.3.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 92C6C40E00C5; Mon, 29 Jan 2024 19:33:45 +0000 (UTC) Date: Mon, 29 Jan 2024 20:33:44 +0100 From: Borislav Petkov To: Liam Merwick Cc: Michael Roth , "x86@kernel.org" , "kvm@vger.kernel.org" , "linux-coco@lists.linux.dev" , "linux-mm@kvack.org" , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "jroedel@suse.de" , "thomas.lendacky@amd.com" , "hpa@zytor.com" , "ardb@kernel.org" , "pbonzini@redhat.com" , "seanjc@google.com" , "vkuznets@redhat.com" , "jmattson@google.com" , "luto@kernel.org" , "dave.hansen@linux.intel.com" , "slp@redhat.com" , "pgonda@google.com" , "peterz@infradead.org" , "srinivas.pandruvada@linux.intel.com" , "rientjes@google.com" , "tobin@ibm.com" , "vbabka@suse.cz" , "kirill@shutemov.name" , "ak@linux.intel.com" , "tony.luck@intel.com" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "alpergun@google.com" , "jarkko@kernel.org" , "ashish.kalra@amd.com" , "nikunj.dadhania@amd.com" , "pankaj.gupta@amd.com" , Brijesh Singh Subject: Re: [PATCH v2 10/25] x86/sev: Add helper functions for RMPUPDATE and PSMASH instruction Message-ID: <20240129193344.GFZbf9mEIxZg7ZEb8f@fat_crate.local> References: <20240126041126.1927228-1-michael.roth@amd.com> <20240126041126.1927228-11-michael.roth@amd.com> <23cb85b1-4072-45a4-b7dd-9afd6ad20126@oracle.com> <20240129192820.GEZbf8VBsDhI0Be8y0@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240129192820.GEZbf8VBsDhI0Be8y0@fat_crate.local> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A2E3B100017 X-Stat-Signature: 73zs6pm3y6y466k5mb38jeswhs6ibc1c X-HE-Tag: 1706556867-990436 X-HE-Meta: U2FsdGVkX18UIfK9GTvi4gl8Eze1/pjdHg+LYBWYksLXeuWgGatSDscpJqHLrKptzBldWU6ovI2OmJaBFY/QeKTFCfWhlVEKuE1e83Lm0fYaTd7QT1NBTis8nn3ufgpkog69Com04sKdFQ1gBHxfG92qkUNGK66c6uKePbkFWh7+7roHhmNPOt3Y99wqVVNDRUfD8MCTkxfJ+fykL6niEs+/58B0SfhKjV6RQosieaaeUb3qTSX0DKuHTtUg+JQxARZnAyH8C6zcq5u7JDYTRbF2jsiJ83by7DM8lbFW6aRGsGLvSKOSYqDvHf2zXu7/Tkis7NoLXZuozrY6nKDZYaQajBsmSYLSNoRq1JxIrlwL9qjrLdB28wrLCg6K+NftoHk+eSMzUPVU4H4S57hgcJce/rQ8HKq9dnI3lJujlDZIMgMhKVSiXTeLMViAXMbmO1jmoyhuZ3DM0fRLxmE/03Xmh9IZmxltoR2Q2gpgWG3GG6XN36mwKHV/I975MfomVLa6WuWPJO+MKbuvgU4M0HZFIeQd1KyTv1Bfro7vazuJfS0PWEdS+wXkPmK9Aw5PZLe/fI6AZ9+jn0N7XvUeq6KsMlVOVERo+DbYW3zOuozZ+x4eeZP+Y8TDbbNvZ6Ci7/RTclcx4mCgCKA0LCXRA9FgHTC6c4F9oY27G9t9gnODmebYov4wLsTYyIptFanCjkir4eIOWZMgkjQ4VUupLPcEkPpUaiRj6kWRufPWhNs9sgZnueaBwhs1RSYUaCu+Jg3i7Mbf/QPI5Q7F6GHWhHKM4H0XY/EO2epDmHETVAj+LbP7E+yFQ4NMnIlVEBG4csVznGIbP9qq+ZsAZzbXMHGNutkD0lclxmLUUbJ9y+k8ZnNGAnpFfoUv+W589krt2sUf6jUOh86Yx79ivKANyqOTcAgRXYBVKIS897Qff9/W5ftWUNRbtzcMXx+k6Wb+cW4BEA+/EMwYP75HX1G cbyIXSwc hmG3Oi4Ix03YmZ42+cOrehmAjkCSBw1jj41lqIzFG2pskASh0nbWQ7eorxhn7gL3EOf9yK82J7pMmfhwEsRyUmI9Yin0ld2Vw+VhdEE9yDC4YOpt6m9xiSfMxVuwVHlVBdx0VIYcKx3vQXVC1vRUPVMe0Ozbq/h31bgbvYeppz0y8C1Q0QHWpkuHa5PmEPpyR5JMeK9rKAnDJeKPEchkFvSE+l07GqWDDINo2neV3d5psWZoWtHHJgEgRHhqXLPNAbkEY4SyURBzMc/8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 29, 2024 at 08:28:20PM +0100, Borislav Petkov wrote: > On Mon, Jan 29, 2024 at 06:00:36PM +0000, Liam Merwick wrote: > > asid is typically a u32 (or at least unsigned) - is it better to avoid > > potential conversion issues with an 'int'? > > struct rmp_state.asid is already u32 but yeah, lemme fix that. Btw, static int sev_get_asid(struct kvm *kvm) { struct kvm_sev_info *sev = &to_kvm_svm(kvm)->sev_info; return sev->asid; } whereas struct kvm_sev_info { ... unsigned int asid; /* ASID used for this guest */ so that function needs fixing too. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette