From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00B22C47DB3 for ; Mon, 29 Jan 2024 19:29:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 61D436B0082; Mon, 29 Jan 2024 14:29:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B2786B0083; Mon, 29 Jan 2024 14:29:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4468F6B0085; Mon, 29 Jan 2024 14:29:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 355246B0082 for ; Mon, 29 Jan 2024 14:29:13 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C2EBB1C14AB for ; Mon, 29 Jan 2024 19:29:12 +0000 (UTC) X-FDA: 81733336944.15.D68FF82 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf21.hostedemail.com (Postfix) with ESMTP id 9278A1C000F for ; Mon, 29 Jan 2024 19:29:10 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=R61YC1vh; spf=pass (imf21.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706556551; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=svaXdVUso9XIpSV+g65yFy2vYB9o70I/9oMzH+fLOv0=; b=ZsF3UZMMQgovBghyTmqmJ/xkx40WR+C/1AnOfYLBA/IkEYGmZY94Ez8yHsEnrEDbmGWF7r zF/7KT39INdhijde9VfQJv8bU2HR0YSY7JXyhKdUeFcJPGSSRGgZFNbSOodOgE7n9Cle14 HzTEf/mjsoj/jFxHNTQuJ+brM23PtIY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706556551; a=rsa-sha256; cv=none; b=6//gIu+Hs8WVMcfM80TpmAfntIPqZlyaGegWQhfD6lZn22UV9k8orvj0ybkXIHyZI2ul/G g63wgJT+SixrR4SEPDlOnrlXt3JvzwkBUgi9o9No7WTmKRyrx6WVLdRx5ZWD6aeyWrI6N8 S/4nNlKdUVK7J458QlwyGynp4vgqbdY= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=R61YC1vh; spf=pass (imf21.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 09DB240E00C5; Mon, 29 Jan 2024 19:29:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id aHknbiBvH0yA; Mon, 29 Jan 2024 19:29:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1706556544; bh=svaXdVUso9XIpSV+g65yFy2vYB9o70I/9oMzH+fLOv0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R61YC1vhG4HxoGwH8d9NMiAqt/ypwcQvlKP7/NVPICMBvVV7t1AM5FG/fiLUAZe9f rXTwSsUgMGD68KxLZxgNDccSBb2vRbjVIX8SYndLfknLagsvbX6/simSi66tVLOUfx JOoDqACAYKB27snRlrOIbA02RaY003wIud6RAd1y9MZl5+uBZi/JWx0KSvEAjLPRxJ bTLlLxYzX2WEgwS4q9lIA5kDrwgBlxWLx47JOTwGtXJn7Go2qyY9sfg8dGiJJpYm2a UFKuQB8CP5F3q7Ge54sEqaqdNFaqPR34dxmroO1YIGiEL18/kqrE96bU3E/prCO0HN JdlXpSx0kQdg3svTOtIElL688qRJ9lp3bJcvYc6o0tvFMBHvJHtgLAVp+nK1AZwDvL F7G/vWMl9WfLyM7TkJKUbtAn6sBeqm4QApmgxwq0xwyblmpXpOyqYQUOHCp6O4//yG 0t0QDFFhTi6Uvg2L7rerfGTNAhM0dP5mZihtHDC3zaVrubgjsgXf4FntZGS//zhlBr Bn4cO4vmOc0D/dH/QDwqsQYV2DAatN0swyETnk2BpP1Ctb5r0ZyEYakZ7ST2z13yRO RdAAuyaqOO6eyOjtkZ5CYM/idgTNpPGpL4NCYNuOrCGDiyBQwzRJJayTjrUS+VH49O l9U/vVKCVSs0caq7HcOL5KUI= Received: from zn.tnic (pd953033e.dip0.t-ipconnect.de [217.83.3.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id A636140E016C; Mon, 29 Jan 2024 19:28:26 +0000 (UTC) Date: Mon, 29 Jan 2024 20:28:20 +0100 From: Borislav Petkov To: Liam Merwick Cc: Michael Roth , "x86@kernel.org" , "kvm@vger.kernel.org" , "linux-coco@lists.linux.dev" , "linux-mm@kvack.org" , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "jroedel@suse.de" , "thomas.lendacky@amd.com" , "hpa@zytor.com" , "ardb@kernel.org" , "pbonzini@redhat.com" , "seanjc@google.com" , "vkuznets@redhat.com" , "jmattson@google.com" , "luto@kernel.org" , "dave.hansen@linux.intel.com" , "slp@redhat.com" , "pgonda@google.com" , "peterz@infradead.org" , "srinivas.pandruvada@linux.intel.com" , "rientjes@google.com" , "tobin@ibm.com" , "vbabka@suse.cz" , "kirill@shutemov.name" , "ak@linux.intel.com" , "tony.luck@intel.com" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "alpergun@google.com" , "jarkko@kernel.org" , "ashish.kalra@amd.com" , "nikunj.dadhania@amd.com" , "pankaj.gupta@amd.com" , Brijesh Singh Subject: Re: [PATCH v2 10/25] x86/sev: Add helper functions for RMPUPDATE and PSMASH instruction Message-ID: <20240129192820.GEZbf8VBsDhI0Be8y0@fat_crate.local> References: <20240126041126.1927228-1-michael.roth@amd.com> <20240126041126.1927228-11-michael.roth@amd.com> <23cb85b1-4072-45a4-b7dd-9afd6ad20126@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <23cb85b1-4072-45a4-b7dd-9afd6ad20126@oracle.com> X-Rspamd-Queue-Id: 9278A1C000F X-Rspam-User: X-Stat-Signature: ff1y3n718f4a7oby1opw9ak1a4juj5in X-Rspamd-Server: rspam03 X-HE-Tag: 1706556550-94170 X-HE-Meta: U2FsdGVkX1+GLhKtCcsjNpoXZ/eAAibC1K89KMaFDvz3B9HZRr7cOh7bZI0yu61ATuY8j4li4TZus184HBUMtZ5uQQOwBM6z4m9hXAzwIw++Dc/lnFxwsWOeoqDMqtKoLqtolYGbrWk94cZT7wtPiIKxjsYvRen7bcZUe7Y/GQTZC56i2JmQaSR/9az2RNkCtWZ4IW6eUNcWGiKWlw8eyXWR3DLs2TXUiHjBjcuLiaUbQZXxG8oRjNGas9TG8ByeR7Xq9Z1cH9z3FIVrPwGbhcmBMBXxR3mISSbjo0hUlK/AG9DN+wtFnuDMAy4b4o/ZR5iuwgOUnfuGrVwI/eVNmpk+Up+3f0ozkMObGwtYjeeaL6c24iUf9eIdlXq0F3cQPgsXBIhSCuxD4VdDdfvKxLZ1l97xuEDIKb/c4fUY8Z6CZaV4Ih+J0vioi35gnBqXvNAbo/2DNaZIFOdwXg9umzlzqrUTaDAqXtjbyW3dYyGR/Vmuk8Bj4TBq/y0tKdpzDtz9RaI9A/gqyRyaXvGqUBkA2bYnlhd7omNXsSAn4iXjjYjqscCzdW6EzqHO3ai+rXq4tfIeYzjxLXPFCL6AYc97tADVEuq25AKSaqKPxYut8xXGuuB+iOXYdJyg4BwpvzTeatxK0bdwZPP6zJu6b3/w5EErNChuxhXDFC0DxyuxjGzaF3f5qAiwyiDjECR1/YU01YDSe5gf2gc9OhbldVl/55VOFpjZieP4cmcm8oxAzk8GVtb4so7Ty7bAAJ5MDerMWLnb5z9nI+yAzuh58dGr7isQs7hqCvx2qF0l/Jzcb1hgMppaXfesdzMPs6QOkjd7VvzY3r20l6HuQlKXOy7cm3Y5Bn7x5qmCbAhax2emecPGV/gNM0ZtWgXXTa1wYGFM1lkqabfDrNFJj3N8BKKyAPE9khMyJtyQBq6CUkO0Fek/ZrniRns0yiP849mLppsItM9P4bo2Pa8DJTe LSTakU2c fSIEShObCg46+AUsjmuCFkJ28+Z0RqU/+i8lyGSIYWD+XwnsS7dPpG96k2lfWd1xc0moEglogQ50TWCgs3zT6arLM8SdJxgpvs03v2HnlubeBBKXBE2Mn589i9BkdIlIjEklan76ip1ps0mTjbO3giacRtlgYdgN4CcKAIGEMn4HTHN9H97xibShYCzX0NOfDwD8hdcM7yprkwEmSDn6yB+Q//3mZ5HSf07UHbnyLhFKAASoPy4U9y46Prpj/x+cdFyqVwyvMLoi6A+kmG9xU5ct/yzBvytzWHAjl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 29, 2024 at 06:00:36PM +0000, Liam Merwick wrote: > asid is typically a u32 (or at least unsigned) - is it better to avoid > potential conversion issues with an 'int'? struct rmp_state.asid is already u32 but yeah, lemme fix that. > Otherwise > Reviewed-by: Liam Merwick Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette