From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 661A3C47DDB for ; Mon, 29 Jan 2024 17:59:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE2EC6B008C; Mon, 29 Jan 2024 12:58:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E94486B0092; Mon, 29 Jan 2024 12:58:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0CE06B0093; Mon, 29 Jan 2024 12:58:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BC6246B008C for ; Mon, 29 Jan 2024 12:58:59 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 632D5C0368 for ; Mon, 29 Jan 2024 17:58:59 +0000 (UTC) X-FDA: 81733109598.13.A6C1DDC Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf11.hostedemail.com (Postfix) with ESMTP id 13F814001B for ; Mon, 29 Jan 2024 17:58:55 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=fail ("body hash did not verify") header.d=alien8.de header.s=alien8 header.b=Cotx7+I0; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf11.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706551136; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oDFaBsjQiHGu0v1nU5wsaBFSsPd307uurMp50Daun/M=; b=nORarHrJZx7PURz4B+7u/krIDXv3t/qjVAHcnrPrWMa2tN00wFQ8LZ/HwA3pWFDY4kvQnz 5OcT31wE18tfDg+QRlD0l5XjD42G3Kj99rhwjErTeB7LEQPqOZZyOwBl6aO0hkF1vfIDrZ 0xXqW3f0kXx/Vj8mjSfXrEKE1J1mpn8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=fail ("body hash did not verify") header.d=alien8.de header.s=alien8 header.b=Cotx7+I0; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf11.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706551136; a=rsa-sha256; cv=none; b=H9drbxzUBnYQNaJ9J/39MZN+FF0uXy7LHcF4/CXGPFtJyjlDudPdDwV9TqBZCJbV5JbKYI 6WmesKHOzFHL90i/qvIQkduzvifmEca4Uj8kSlD1f7CnpLAU1IKbpKkUrUZYOrKoFv5Opy hjLOjpubtDOMZw23yZwVdb7VDZQ//yE= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 68C1140E00C5; Mon, 29 Jan 2024 17:58:53 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id i6QaokLd0hxR; Mon, 29 Jan 2024 17:58:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1706551131; bh=haKRuQSPjwn4cZ6Nd5ze9P3MYIvIFCO4ld+rTiW5Nok=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Cotx7+I0f/7Gt9x7NWnbs/g0LaIwF6oRcwW5rTcKXCC9xkME6wAfqHrTzkkgOup7A kDUNDxWsdDds1nDmCKD58UhsVntsZo4C1fKrPqXjaY9dqRt+Z9cIJeFDdI9mLbgpKZ s4qgfyCwegiOe+c95T55T+0LMrvWz73oQGMlt6hhTINLQ9u87OV1BBkzI+s3UAMQki EiE6/lwoUIQamQYxuGWU4v8uXNZLA5BzheYMPr+4XA6EAJG+cTumWaule7SYdQzd3X CjbsbDw4O+fCxHaSfXhPPQWWT4oCT5B2SRv3OUnqAXhk8gefpEDl39LkU1ErXglmpz IihJRAoHAdwcNdjWr/KPPnqwegCBx27/RNuUlxQ340dn5QvkqTNFfTdKgGO9WwNUR1 aoYa+eaWqChUqSSrv+g/QxeICCyfZaIicFzzOIjUmKN7xRw4Wal7qz4dNYTfEzOT4q q968O/clmAVLn5qoGPNuD3WoaQS/ESk1uAeK2GLknMWm+Rh+HIO8KvXhrRTwibbd0/ rzkAqbvj5HS19afzr2rnkbYCCU/HRthEyYW3mpHBsK7JwXgWzu1WEjqZzR5jK15Yt8 mtoc0sk0JJii4l6Roz1lSmr79VPsu/i8lclUem/bo+LBSd+mlVZtNyFzNat27QDPzs SNsPorfagbq1htmTG2J6pDaM= Received: from zn.tnic (pd953033e.dip0.t-ipconnect.de [217.83.3.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id A6D1940E016C; Mon, 29 Jan 2024 17:58:12 +0000 (UTC) Date: Mon, 29 Jan 2024 18:58:06 +0100 From: Borislav Petkov To: Michael Roth Cc: x86@kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, Brijesh Singh , Jarkko Sakkinen Subject: Re: [PATCH v2 13/25] crypto: ccp: Add support to initialize the AMD-SP for SEV-SNP Message-ID: <20240129175806.GBZbfnLsqTgqoKwt0S@fat_crate.local> References: <20240126041126.1927228-1-michael.roth@amd.com> <20240126041126.1927228-14-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240126041126.1927228-14-michael.roth@amd.com> Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 13F814001B X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 7crwxbwhpygf8jygkoxbdfq8g5jrgojd X-HE-Tag: 1706551135-332318 X-HE-Meta: U2FsdGVkX1+OBDZwO5hBXOYYZ0QveA5f2gRiGEsnu7e10TaC/GpxAFxr69/8LZj95tKMXyJmoCi15L1R/Y3lwm9kXmlXZnYB8aDGZ3IhcUIR1tpSYtoDwf46qmtTGBBCIVAFFqS6tWW5dCUg9T8wljhSDloz8FA7xSTUV6oLaEgdMm5PzvbtBn405icGabjOEHlOcxobR/QG9pLcfzbQLPa7UHeNE3m5X9FiAk1dbyK1UCUQ4K8kj4B6+9UIPiq3LsR603KiIbJNaB4s6FRxjoNXOUaXsyDD0+JCrL9SOTJGsX/KhK+1XZVW3K7i8FxogXzU+SLjnExVfJuze9DI8dhFm5UiL9Jr7Yf/ktyxCx3oSV2uHBn1NQk//UWCqbjMWPZMlPCHrQwOXWlRqJJSL/KH0tp80Lbo7PGWZmffFY2LQtQh3Urpmx6bcu7QuiESIE80uUUwkJjp9ECI65YjL3aGzILCvNS9M31izUqFMo8+jmjCMqptxAtWl9b4FuKKCipasGeA1RRAnkiR+L97CiH1f2Qikx8OYZIN2VsEFmA7F9n0GkHNpL/FQM/NZeWP/Nt038PgICCB2u+apQlMdRhy3iF4WKphpeShUb31DURxBTfNqkp/4NbR0fXWV5JH2RyP+w6mkLZqdtGjYCObJKWTh0/p1f5AgwAf9onAqsKHzeEqlGi+rgofwQ3hLD/V+XhgSNgP7JncwX2RrJQUxs7xAzQNluC5r6/aR9B1C1CXfhbEqoocpqtVjro3QkMws8tCX4b5201qOksaqfQbq0KutiU1QhxCLaGMSYwGCdYgvfkRDFKnNRBrtuanFT5V1cpwnxDMm9sXPinc+RWJ5M7T3O/f1SL8ihtE4do2lAm4wR2oWx5qctZw8UKF3ZsYws65TLV3lTQpshywdU3pwO+L0Kio7V62/0RerGGtRoGtugy4BbRwLu+PtNUxkZKcAwuclzzckWmh+ThOvk4 9ct9/SXs uCuheuW3luLYt/+4PLlapfyrJ4MnnX4KruqsqTFDJxchhAqxgVieS/7QW+UX31qozn7ObeMIQDK4Pi5K12peM6xNttJ/QQ4xDsA8nwEaUHeGCEDAIFw8OCJi5X1xy4SMT5fdtadqa/2dJsWDg4EsDXxM5jArShjlvDGMjsAySkpw9djGiRyVKHCXQCEyGELZO5X+UWE7q38rslZYPrezyFCQEqQS8Z62OB5ESMFzkWkhqAzG2YPIWh4EtReA+0cEtLz4K X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 25, 2024 at 10:11:13PM -0600, Michael Roth wrote: > diff --git a/include/linux/psp-sev.h b/include/linux/psp-sev.h > index 006e4cdbeb78..8128de17f0f4 100644 > --- a/include/linux/psp-sev.h > +++ b/include/linux/psp-sev.h > @@ -790,10 +790,23 @@ struct sev_data_snp_shutdown_ex { > =20 > #ifdef CONFIG_CRYPTO_DEV_SP_PSP > =20 > +/** > + * struct sev_platform_init_args > + * > + * @error: SEV firmware error code > + * @probe: True if this is being called as part of CCP module probe, w= hich > + * will defer SEV_INIT/SEV_INIT_EX firmware initialization until need= ed > + * unless psp_init_on_probe module param is set > + */ > +struct sev_platform_init_args { > + int error; > + bool probe; > +}; This struct definition cannot be under the ifdef, otherwise: arch/x86/kvm/svm/sev.c: In function =E2=80=98sev_guest_init=E2=80=99: arch/x86/kvm/svm/sev.c:267:33: error: passing argument 1 of =E2=80=98sev_= platform_init=E2=80=99 from incompatible pointer type [-Werror=3Dincompat= ible-pointer-types] 267 | ret =3D sev_platform_init(&init_args); | ^~~~~~~~~~ | | | struct sev_platform_init_args * In file included from arch/x86/kvm/svm/sev.c:16: ./include/linux/psp-sev.h:952:42: note: expected =E2=80=98int *=E2=80=99 = but argument is of type =E2=80=98struct sev_platform_init_args *=E2=80=99 952 | static inline int sev_platform_init(int *error) { return -ENODEV;= } | ~~~~~^~~~~ cc1: all warnings being treated as errors --- on a 32-bit allmodconfig. Build fix: --- diff --git a/include/linux/psp-sev.h b/include/linux/psp-sev.h index beba10d6b39c..d0e184db9d37 100644 --- a/include/linux/psp-sev.h +++ b/include/linux/psp-sev.h @@ -797,8 +797,6 @@ struct sev_data_snp_commit { u32 len; } __packed; =20 -#ifdef CONFIG_CRYPTO_DEV_SP_PSP - /** * struct sev_platform_init_args * @@ -812,6 +810,8 @@ struct sev_platform_init_args { bool probe; }; =20 +#ifdef CONFIG_CRYPTO_DEV_SP_PSP + /** * sev_platform_init - perform SEV INIT command * @@ -949,7 +949,7 @@ void snp_free_firmware_page(void *addr); static inline int sev_platform_status(struct sev_user_data_status *status, int *error) { r= eturn -ENODEV; } =20 -static inline int sev_platform_init(int *error) { return -ENODEV; } +static inline int sev_platform_init(struct sev_platform_init_args *args)= { return -ENODEV; } =20 static inline int sev_guest_deactivate(struct sev_data_deactivate *data, int *error) { ret= urn -ENODEV; } --=20 Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette