From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C723BC47DDB for ; Mon, 29 Jan 2024 16:24:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 37A846B0075; Mon, 29 Jan 2024 11:24:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 32A146B0080; Mon, 29 Jan 2024 11:24:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F2756B0081; Mon, 29 Jan 2024 11:24:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0B4136B0075 for ; Mon, 29 Jan 2024 11:24:55 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9C22440394 for ; Mon, 29 Jan 2024 16:24:54 +0000 (UTC) X-FDA: 81732872508.03.769CD5E Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf13.hostedemail.com (Postfix) with ESMTP id 87EBA20003 for ; Mon, 29 Jan 2024 16:24:51 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ErSrsBq+; spf=pass (imf13.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706545492; a=rsa-sha256; cv=none; b=Tm1e4W2e+0AS23DsByNUbCpU6C1pyPLPFzw6ZOpISq/Rotj+jM7zqyQhjEC8FaQ1IS+YeE v6a3TcSN2q/sSbNJjYzKKjbqu/cEQoJEeRZ+4iuvYolUnJifk51nPrESNbKSEeBdIsjLFb dBjbMHw38JYq9ByITDNZFDfv4+VvDmQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ErSrsBq+; spf=pass (imf13.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706545492; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DJpc8am9Qt6N7u9hpAJqb2rpfDRqrboKABHrezfCv6w=; b=KDO2mgil9WAKFK/SX/arbfuopOSb4y2d7qeQub+JcXKecehN0AnS9TkLIJHIjV0cM/44Qo YPsCbLKNWrn4OIHFEJpegqtpw6+Kd6v2PfpRa1L3uEfXVweGNfzuJaI6ypehG/dWtDTxw+ GpK1/j80FkiXp65fKhLKz4Us7ELgtt8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 92778CE13D5; Mon, 29 Jan 2024 16:24:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C39B0C433C7; Mon, 29 Jan 2024 16:24:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706545486; bh=RF+t/ug2aOYYQWYS86JZHdcPLDQcDKP8/QueqxLvlWY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ErSrsBq+UEvOJ4YQtK1RHz3ZKlkQwkIP60gEojNdC0XRoGv768fNkG/R6exvcfYKY sPrdacnEewSskxCuP5w0SzoIBXVVEyeisF98K3VV7tsDNizY5t/Eh/gI9qzuidNIk6 9oM65DCCYKRx5NLNbZTGHwajESqRkQseRvH/MSToLus22RWfizZed+HPlk+W+cxlZR xRGgZpsnMqiJxa8WoQOQPSJKYwvjF2+2dQ1t9XDSP/sSltPCNr7tax3hv7ujGXfvKC VHs02st7Id4vLwZJp1KzKqTFq/YrLyWItxbtuhkc8J4eGL5+8b6zrEnuKHSBbsTaYT hs4Tf2IavK7bQ== Date: Mon, 29 Jan 2024 08:24:46 -0800 From: "Darrick J. Wong" To: Christoph Hellwig Cc: Chandan Babu R , Hugh Dickins , Andrew Morton , linux-xfs@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox Subject: Re: [PATCH 06/20] shmem: export shmem_kernel_file_setup Message-ID: <20240129162446.GF1371843@frogsfrogsfrogs> References: <20240129143502.189370-1-hch@lst.de> <20240129143502.189370-7-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240129143502.189370-7-hch@lst.de> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 87EBA20003 X-Stat-Signature: 6wfaijdrrekarwbxo8y1869mipyrx6ze X-Rspam-User: X-HE-Tag: 1706545491-361580 X-HE-Meta: U2FsdGVkX1890KAt62JX3QiPMIhoqV4QZl/ystezAdhOzh4PZGe8nGiHpnQIbrevjUOPTxC9BsIrm073ZA42NQ2p9gILg6JcdMGJNhzL9LnRo0Lcf/Q0wPhq/O7xC8jeKMTm3P9la0VizSGZJNVsjHGOck9997H3bJJvKvgA7ZBzMpLM5zGTaoVKvuyrTXf1XJXdoY4wC3y1+8cVKAMkVcF8Iw/4st8p/zMX+VVws+Z1MuHwr3SSRzonNCgnocq0/IW6rgixh7Cu8XW/mqbPrUUrQw/tqBeE6rqf6nvUsSx/+EjWZItYs3jjeT8tUd8rmWG5U5+x2h/wHWkega+7aeI/0DwA8VVfgF110jxJGI9kVmZFDCDjcoTRvdieNBeCqJzDz9H14uZzHOHrjT56Tw/SzfJGEUUF/keRZo4HIbg3Oi0/Yg2JUMRaq1FxoRJKXWDwHw0fppLU7rBSb0u9MpPD9f+L1cGFMaVaz4jfqpqOk1kFCmQKaqiu/tXXha1tf679aFtNxmJ0k6c7eFW+GVMwqBneRNsmMusTzeat8KdOXejht5QutHIJBAldATTvPlGrRZYPxEQ+FtHESpQIXmYvYCivxjUmUODNPQ9FJi9GGbREEpYUBaB/AUnyXOjN5idR04844DqJTw6DVUJPqRcn9DK81L4xgXz1OjNsWte9LQoXM3/o8PdMwuds/AaYKDF2tzrMm6zIuualbdxdkYINaV9ye5GJwVSZNqAdswbCcR1FxnW+DmZ7vViD6/fHr7XkpFJhKQ7DIFiupafNzALpo8U4s2pBQY/6Uf5etDKtpOmk1iwK/gY9xjF1nJY634J7eTNardE9otWOxcRpSCwOncG+SLJsbjmT7GyafYbInf7PVLCHirbahXtq1jvJY5ZYep0i/1uDHAT8kZSbKHV7QZfsh47IzHtQP429P4pC5dm2RGycBy9rsWY/7ESL5QOdO890l0Xh/xpPm+6 3n8B7uiy EURIwUKUSSrjewt23ZDYMbz8lCg6Xv8662/H9A6AYgK4SRbVmfxUSQ+vj9yRDU50MgpziWL+rBmVitws4iBphEIJxEvuZKvj1bmv9pSJW7mOHuUHWDOVy3T31SIJa7RiDDTMw29oimfwYqR+U2vF/FdUmc1m7s5USRuKN5zZNFDAxtDmtwXn1ScC9QPYLJKHDEv/lAmxT/n0piy19U/6egzJ1Vkfqt2tE0ar/wsBzeDV8M+43tXR0R4Ltqu2UMJqIUF/ZlQlyQwEjVduakcQQAv3kupijkLVR7K/RAU6cUoTU+8bnkvWsFsBoFD0z5qosK0cvS1PA/Z2+T9+q2pJrXVnd+nZI00Mz/yEG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 29, 2024 at 03:34:48PM +0100, Christoph Hellwig wrote: > XFS wants to use this for it's internal in-memory data structures and > currently duplicates the functionality. Export shmem_kernel_file_setup > to allow XFS to switch over to using the proper kernel API. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Matthew Wilcox (Oracle) Looks ok, Reviewed-by: Darrick J. Wong --D > --- > mm/shmem.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/shmem.c b/mm/shmem.c > index dae684cd3c99fb..e89fb5eccb0c0a 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -4856,6 +4856,7 @@ struct file *shmem_kernel_file_setup(const char *name, loff_t size, unsigned lon > { > return __shmem_file_setup(shm_mnt, name, size, flags, S_PRIVATE); > } > +EXPORT_SYMBOL_GPL(shmem_kernel_file_setup); > > /** > * shmem_file_setup - get an unlinked file living in tmpfs > -- > 2.39.2 > >