From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67CEBC47DB3 for ; Mon, 29 Jan 2024 15:05:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 056CF6B00A8; Mon, 29 Jan 2024 10:05:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 007366B00AA; Mon, 29 Jan 2024 10:05:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E126B6B00AB; Mon, 29 Jan 2024 10:05:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CFA3A6B00A8 for ; Mon, 29 Jan 2024 10:05:19 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AAFDA140A6C for ; Mon, 29 Jan 2024 15:05:19 +0000 (UTC) X-FDA: 81732671958.20.F975F2B Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf30.hostedemail.com (Postfix) with ESMTP id 1399380016 for ; Mon, 29 Jan 2024 15:05:15 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=CscN1g84; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf30.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706540716; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NCl5u2FekjETRT5G3FwgEZxEDuY5V1BwprwchryS7pY=; b=DkoLzUsTe9gVfqIfEK4mN2IoSoxA5gklLk6sPyurH49m5RaBLgVPOJrLUVUnMFkk005tDv ppQ8cyCoaStI/GeEEMBYzOOSCTnm8PfzWND4x/VZ/bcv2WSH/oZcxVEuS9aj0Xjxmt5btc B0fbRQ8C6EH51aLLgHpSBsCOtgmfcUw= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=CscN1g84; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf30.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706540716; a=rsa-sha256; cv=none; b=WQauWI6iGoghiZhv30zIrnv8L8MfptdmuBtVIr4b5LW5foA7woU/ox9of+NuOX8BXxBBHv OZgg3kn7Q8dRJNHCHIU3741hqyKHrad/vzUWeLemKdsuMDc6j1PLdL3Xe6yv5C6g4BbSoL NmU2o44bGJunRZnXq+tQRSUBjZGZ+WU= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id AFA5A40E01B3; Mon, 29 Jan 2024 15:05:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id AeIofEyGjJAP; Mon, 29 Jan 2024 15:05:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1706540710; bh=NCl5u2FekjETRT5G3FwgEZxEDuY5V1BwprwchryS7pY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CscN1g84Lfzvg/ZWyKLJuDdOFkStLxTKQHBb1MMVPjZqy4KxBdN9ZvjC43Q69JeSA 3oYoodsgMhia18fCuIoESMY/o/ZsrmtCtfHCjMNXWURim7qXAYDVWlvB2lbPJ2ug2Z onpxo2BfJiQKdDhZ+VCP6QaSOR6dkYt6GSM+OOxjKQ4UoJNKfevCQnWSVt2HfGD7ew /snFshyQRle9DmawuzURsgfAywzfhqaD3Wc8SJQQf2eEpQzEIbxeoFvdWKjZEVlRKB ef60bRFEKOLE4CJb8OFe4Gcg2s1uELNkDhx3INgCJmCWvnRxQzBLnUotzUBXggxc2b rElueYi3cuSNsCcmFo/3uudn2n3WLSQSxUZlfv6+gkv23/HkvhsTHhAk9aTgF7rI07 obj/Qh4SOcn0LphecJYVAFZg4jv7j4DVd7aVTk+LicBg3PbHRqEE9pxNLqvrw1Lidv tfneaRkKpfosz6bOu5WYHFf0KrunrtJD53z16LzWUO9WIbY03sHw8wA/AXLFU+sf4h naQ4m1mFdnvWiigZDcbzgKbWcNOT41dCBNWWIrY7V6/EgUTFDlE+wUy64PLhpk1uCw z8IKfXSmxdp7bVjuV8ZReog4XY646Zo7splvX460RWro5J4OngMiTHglrGQCn266eY pqvB7cVnZN9Zjn+Rofg8dBlA= Received: from zn.tnic (pd953033e.dip0.t-ipconnect.de [217.83.3.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 1888B40E016C; Mon, 29 Jan 2024 15:04:33 +0000 (UTC) Date: Mon, 29 Jan 2024 16:04:28 +0100 From: Borislav Petkov To: Michael Roth Cc: x86@kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, Brijesh Singh Subject: Re: [PATCH v2 16/25] crypto: ccp: Handle the legacy TMR allocation when SNP is enabled Message-ID: <20240129150428.GZZbe-fMDSu-dy0cPy@fat_crate.local> References: <20240126041126.1927228-1-michael.roth@amd.com> <20240126041126.1927228-17-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240126041126.1927228-17-michael.roth@amd.com> X-Rspamd-Queue-Id: 1399380016 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: rg6u3z3htzhxbn4asjb9xjuakzbmo3tw X-HE-Tag: 1706540715-281210 X-HE-Meta: U2FsdGVkX18qa9WmqsX3CmDsQ81Xx27xCbQtB8wWlcGW1HxHpx82BE+B8nDvgwhGzUZJf1pjvz8ZZxLIc0PPH+xlQY8CcuHgwpl71VELBgvZrBno43tTGiKl3ArLQtsgIsYX8HuAtLI90zNe5cgC5M7SRnhvn77gtX62bCECQRG2t2s6+UvR7C1wmX85DF6886Voj6MG9D/+dWmNeY51cPQswgfYqEjY/370urqN77YPHLIxjSMvAjq3guKsQOLK8wlMRsRGSrXkGhQqw4PPAig5sbyMcbjgGGYBjexgUx6rw5CsTa2f0hlTunRsAtXZ63DDsjn7d2+UCvwoovq2PwMWFzdTm5/rQfKkkb1rFjfqXf+GD8wwveb5y+wobAg35YrQzEPnQnHDjEIc7JTac04sFvFkZGJbdD7hdLhwir3VGbyOJufKaLhCKJvfJdpmiGiQWWOTgIcGI7fKilqb/b+T6hU7KsZGNV+BY7UxMwGMB2/9L83mHbI7Pd8EpAvjOzwfNsojgojEbLtZf9p/zTcvbjDqgrZyYS3Jfo8XyWZOhG36yEW8g8SwxJMc/amK0AOpGOJ+IY+7iU51veZVT7/TD2jTU/PimKDur7FhPsH6BUX111kotgAqYVYxWLFDYgqxIHxtMU4GF/B3OBYuP5MnOFX1/fRM2N9jIrS8iliSN3Mcjn71pattd2UO0YLMloPZlOBBDQLpYvp46lXTiRlrE96a668nliuOdAxlOxiU11H9ax/em4lIdLsUGG4XXUmeMPh6fqZpt962ryU2y8AII5Mc+/I8GyBMf2xEGq6s9JwnPl2GJIvtMBVmKk42BhUPQAkXxO0qmQ1t+39Vtn53UvYoqMm7bBeu30e9Z47QmczW//6xJHqyieHdP+fUuf/5nstA+E7jeSySqjoEE0YnU54MZt3kjWQTOnfg0IoSdXYMqDrgmxnqWkIfgFlOSCCEpZuKGPtYE5huOTx x33N5wYE 42GxuftJTsSlxMscqupLsoqm2QoeBiIufT9Re+ybxPu3s81oOPt95ovQoKaaaYrWmvIg2NNP2RxEzf6kMv98Q6fbQO+Wen1EgB+abe7a/BMinM7v6SJyRJmx2uhCqkT4OYLJJ+F218ZGt6CKL8zH8XncQQpllnXJJxKW08pd42jps/DLlfuKf3sUDYoVL4wwj5nnyyjoEjOZhvio= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 25, 2024 at 10:11:16PM -0600, Michael Roth wrote: > @@ -641,14 +774,16 @@ static int __sev_platform_init_locked(int *error) That function - especially when looking at the next patch - becomes too big and hard to follow. Let's add subfunctions for each thing, diff ontop: --- diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c index fa992ce57ffe..70aabd1d3d5f 100644 --- a/drivers/crypto/ccp/sev-dev.c +++ b/drivers/crypto/ccp/sev-dev.c @@ -759,6 +759,22 @@ static int __sev_snp_init_locked(int *error) return rc; } +static void __sev_platform_init_handle_tmr(struct sev_device *sev) +{ + if (sev_es_tmr) + return; + + /* Obtain the TMR memory area for SEV-ES use */ + sev_es_tmr = sev_fw_alloc(sev_es_tmr_size); + if (sev_es_tmr) { + /* Must flush the cache before giving it to the firmware */ + if (!sev->snp_initialized) + clflush_cache_range(sev_es_tmr, sev_es_tmr_size); + } else { + dev_warn(sev->dev, "SEV: TMR allocation failed, SEV-ES support unavailable\n"); + } +} + static int __sev_platform_init_locked(int *error) { int rc, psp_ret = SEV_RET_NO_FW_CALL; @@ -772,18 +788,7 @@ static int __sev_platform_init_locked(int *error) if (sev->state == SEV_STATE_INIT) return 0; - if (!sev_es_tmr) { - /* Obtain the TMR memory area for SEV-ES use */ - sev_es_tmr = sev_fw_alloc(sev_es_tmr_size); - if (sev_es_tmr) { - /* Must flush the cache before giving it to the firmware */ - if (!sev->snp_initialized) - clflush_cache_range(sev_es_tmr, sev_es_tmr_size); - } else { - dev_warn(sev->dev, - "SEV: TMR allocation failed, SEV-ES support unavailable\n"); - } - } + __sev_platform_init_handle_tmr(sev); if (sev_init_ex_buffer) { rc = sev_read_init_ex_file(); -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette