From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5A7DC46CD2 for ; Sat, 27 Jan 2024 07:05:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 061FE6B007D; Sat, 27 Jan 2024 02:05:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F38446B007E; Sat, 27 Jan 2024 02:05:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCE996B0080; Sat, 27 Jan 2024 02:05:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C88C86B007D for ; Sat, 27 Jan 2024 02:05:18 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 68D5EC089B for ; Sat, 27 Jan 2024 07:05:18 +0000 (UTC) X-FDA: 81724204716.02.AA93BFF Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf03.hostedemail.com (Postfix) with ESMTP id 0BD0D20005 for ; Sat, 27 Jan 2024 07:05:15 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="ZMIGHA/j"; spf=pass (imf03.hostedemail.com: domain of ebiggers@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=ebiggers@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706339116; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UJhcIChyQ2GOu70fB3AQEEo9cS+cYeR56tueR0auTZ4=; b=ItugkQvbrV578TROCeEeIdG80q10NFOP8hqilY5fOvmxRpvy/lcEk7elWxu434gnXg3Una 4ysZGuiP9q8k4Qzopuw0jmVoeDuJ6KLTIwwxUHAJuuBNyEeBjVJkGj16F9CuxfscJjgpVi t1DQPIfL50WmUQmMxPz5DGpgPwfdRRI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706339116; a=rsa-sha256; cv=none; b=oRqTyjb2vx1zYCUawQ7KShZeeEFCgoOYnc6GsIec2qi2B9pxxID5y+HZQJOXrzHzZspgDI CNeVN6wt6E/7e4RWgeoKmXSRzu2eV3U4pPWN3Rz8iQMZ0giK05yBh3VZCGkqTE0nXApOF9 7oKJxn/xFu8vH5mzXL1xnqb2n5ENbrI= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="ZMIGHA/j"; spf=pass (imf03.hostedemail.com: domain of ebiggers@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=ebiggers@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 79264CE3108; Sat, 27 Jan 2024 07:05:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14C19C433C7; Sat, 27 Jan 2024 07:05:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706339108; bh=ForPykU7IwFx2c1CLmNnFixuMgi+ep01OHJkD8/dsQY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZMIGHA/jRSUgkbd3OAZWX3lax3BmYcyT1+dqFBKGmWyJ3k79Zl7yA74B8UwxNbDC3 VoQvGbhhzKfhyPh5i+IqL0LUFCFVSiHIGlK+9MvFcps05gPX9KnhhpqX+jadG9Sgz0 +Hjbwv7JhuqRmsFgIYxdWvkb4QNAkrKQa6F3nRj8nAm8WABWS/yS41Vho3Y0VBWAmf r0L1J6LnOsN2lhW0PTYfi/X3T5cWc+M1utSPGC03PJAa9FNL6wl59gxWWPrq6j4kQD 5zlB91Qwa/RRdv7WqEX5damNjqiaznV9ii9d/wbBFtHBhXXQSENVdWtDS+7CKmWo2O 9Qk3l5TBid1aw== Date: Fri, 26 Jan 2024 23:05:06 -0800 From: Eric Biggers To: Luis Chamberlain Cc: Matthew Wilcox , Pankaj Raghav , Yangtao Li , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, vishal.moola@gmail.com, linux-mm@kvack.org, Adam Manzanares , Javier =?iso-8859-1?Q?Gonz=E1lez?= , linux-fsdevel@vger.kernel.org, Jaegeuk Kim Subject: Re: [PATCH] f2fs: Support enhanced hot/cold data separation for f2fs Message-ID: <20240127070506.GC11935@sol.localdomain> References: <20221130124804.79845-1-frank.li@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: dwaytw19cw5axaqjxhrhw1gpyqy5ghkf X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0BD0D20005 X-Rspam-User: X-HE-Tag: 1706339115-101184 X-HE-Meta: U2FsdGVkX18l67W3yM1WcjN9XGhFI31R+21SEORwzEzgs+AJ3FAt+4gm93xPNbZg0PR+YSCPiG1L/XP2YEc8BfhgFnv1WaY/obaZFvJQdL7F/mhsD1GDGAX0EeznhKE7HCgoB3wW40P8eFfQbShispFF+3NJnVcMI/DkMhBgcZMlBxpfY8K2pjSPhmST9kXx7C+RKYdJQua0zc6VX9+SEqRiEgMm99cpnoWA0lVB7y9mUV/bTm88obqMeJdDFlI1FSyRgi3V5afeftIPOWvrBT617AJj+sOLpYvVgp6Mo0x83+YvzAwBT5QGsBNLHwyPomvW7BozW7phj1+kXGnONlm0uHdxm2xjemIh268s+CiNftilbI2wPCGhOzdI3GlKBVT+YTPOSNIHzZuDDgXC9ZXtRpkTe11YAeNifRnUXp8IBHRdyCQY4Nsw4yt1P6nSybBpju0UUpNiaJ//mKJtqKkTNql3RaAu2vBF1V4fFPO4c6ryEvkhrAH8DfkGlkVTZiKAbZJxNPzxgHoMMf4+VKlWM2z/8wLvdSJRKRtreW4NmpGnT5bxXWfq1yZ/8s24FO2YV9SyjFqlOTwi5EjIIXh1Cw0WwdFfWFYGxqRVVIE8TfNihti5XjVepCt+wRRNXgo7MJG5rNxZk2D9TNhbps4EI7HLRCWbKKD/4Jqumb4OLSapQwt7g0LSo1RGocXODk6UbyKG8OU9UELzA5i9/JqTkWsp7JQu3jI1exquFpdn++e3bIFDlIEiHlz2pvJNe2sXPBrRAHf0pGDnWmvwv0+t0ltl0tRoY9kgZjDB3YUfUCq5lXVjsP69iHKUfGH2gOc2WUOY2lIvdqajlLO4RblkzMA8UDFImjmvEA+zuSjprXsu3lqOsu3H5dkpWcUmfEgn8Pu+G5ZYEbJQag8P1wZfOHIYHMDB2W/MBOCVqKwr9E2Mk7WygEeVBEwGJ6UnNssiPWUL+97YjxtecZR nrEVObGt sDJNsmhM69xDVXSK6Kfh5gSnaCMaYl2LoS4JmgBpkbXWUyyCG68WAUsws7fYD2GCvTIE4zkho/Wf1u8KO+r8e2yT9SnngPoM+16YUdL+uXvIuU8+s+pQBozkDStZ7F6a0BrXiGitwsagZdaILy5gLJwsiwOm0aetrYBg4s/UAs6CylQJovn88ydlEA5yrs5J0HPyYzz0yhWwTqjFruQRcmNXa4L/ZbF8HWdlo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 26, 2024 at 01:32:05PM -0800, Luis Chamberlain wrote: > On Fri, Jan 26, 2024 at 09:01:06PM +0000, Matthew Wilcox wrote: > > On Thu, Jan 25, 2024 at 12:54:47PM -0800, Luis Chamberlain wrote: > > > On Thu, Jan 25, 2024 at 08:47:39PM +0000, Matthew Wilcox wrote: > > > > On Wed, Dec 07, 2022 at 12:51:13PM -0800, Luis Chamberlain wrote: > > > > > Me and Pankaj are very interested in helping on this front. And so we'll > > > > > start to organize and talk every week about this to see what is missing. > > > > > First order of business however will be testing so we'll have to > > > > > establish a public baseline to ensure we don't regress. For this we intend > > > > > on using kdevops so that'll be done first. > > > > > > > > > > If folks have patches they want to test in consideration for folio / > > > > > iomap enhancements feel free to Cc us :) > > > > > > > > > > After we establish a baseline we can move forward with taking on tasks > > > > > which will help with this conversion. > > > > > > > > So ... it's been a year. How is this project coming along? There > > > > weren't a lot of commits to f2fs in 2023 that were folio related. > > > > > > The review at LSFMM revealed iomap based filesystems were the priority > > > and so that has been the priority. Once we tackle that and get XFS > > > support we can revisit which next fs to help out with. Testing has been > > > a *huge* part of our endeavor, and naturally getting XFS patches up to > > > what is required has just taken a bit more time. But you can expect > > > patches for that within a month or so. > > > > Is anyone working on the iomap conversion for f2fs? > > It already has been done for direct IO by Eric as per commit a1e09b03e6f5 > ("f2fs: use iomap for direct I/O"), not clear to me if anyone is working > on buffered-io. Then f2fs_commit_super() seems to be the last buffer-head > user, and its not clear what the replacement could be yet. > > Jaegeuk, Eric, have you guys considered this? > Sure, I've *considered* that, along with other requested filesystem modernization projects such as converting f2fs to use the new mount API and finishing ext4's conversion to iomap. But, I haven't had time to work on these projects, nor to get very involved in f2fs beyond what's needed to maintain the fscrypt and fsverity support. I'm not anywhere close to a full-time filesystem developer. I did implement the f2fs iomap direct I/O support two years ago because it made the fscrypt direct I/O support easier. Note that these types of changes are fairly disruptive, and there were bugs that resulted from my patches, despite my best efforts. It's necessary for someone to get deeply involved in these types of changes and follow them all the way through. - Eric