From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00A82C47422 for ; Sat, 27 Jan 2024 02:03:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A5FE6B00A5; Fri, 26 Jan 2024 21:03:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3319E6B00A6; Fri, 26 Jan 2024 21:03:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BEFA6B00A7; Fri, 26 Jan 2024 21:03:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E61816B00A5 for ; Fri, 26 Jan 2024 21:03:00 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C886AA1B71 for ; Sat, 27 Jan 2024 02:03:00 +0000 (UTC) X-FDA: 81723442920.20.8C80968 Received: from dggsgout12.his.huawei.com (unknown [45.249.212.56]) by imf09.hostedemail.com (Postfix) with ESMTP id 524E914002A for ; Sat, 27 Jan 2024 02:02:57 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf09.hostedemail.com: domain of yi.zhang@huaweicloud.com designates 45.249.212.56 as permitted sender) smtp.mailfrom=yi.zhang@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706320979; a=rsa-sha256; cv=none; b=YsPObHbuxvvnepuaO0yJscLgOJnSB0Y8hUBf8Lexv98ys9qpjCJFRQLXPl9bQiG5uqwxk8 mj4FnJihe5FSuzjiZP/50eswMV2bgVOvufu5BETKMs8mEMwinQkvb+Jwxo4Z6gLztNltp1 Zfmo5xF+QZpstwLp+wXGtcQ4l0ZFfPE= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf09.hostedemail.com: domain of yi.zhang@huaweicloud.com designates 45.249.212.56 as permitted sender) smtp.mailfrom=yi.zhang@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706320979; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DIcdqiMoOH5wnufmVPOCwbErzSVlQnTOpemmkCPNNtA=; b=P516mRZW/AN6ddnbewQ5UGMEugDc025BRjpQ4JBuvYk00O0Zkr4MPCSoxsRCmUCDnZsz2K AQ3gK0GK1acU+bZ5qDAheuewPV0TJUGw4eDNgxEzMW+XBtQtVKfQqgc71rlvzRlTBYBpAr Kjunlybe2xhCq1UqqJyowVc+EmXb+lI= Received: from mail.maildlp.com (unknown [172.19.163.235]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4TMHrp43PDz4f3lx3 for ; Sat, 27 Jan 2024 10:02:50 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.112]) by mail.maildlp.com (Postfix) with ESMTP id 8E72B1A0232 for ; Sat, 27 Jan 2024 10:02:54 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.104.67]) by APP1 (Coremail) with SMTP id cCh0CgAX5g40ZLRlGJtmCA--.7377S27; Sat, 27 Jan 2024 10:02:54 +0800 (CST) From: Zhang Yi To: linux-ext4@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz, ritesh.list@gmail.com, hch@infradead.org, djwong@kernel.org, willy@infradead.org, zokeefe@google.com, yi.zhang@huawei.com, yi.zhang@huaweicloud.com, chengzhihao1@huawei.com, yukuai3@huawei.com, wangkefeng.wang@huawei.com Subject: [RFC PATCH v3 23/26] ext4: fall back to buffer_head path for defrag Date: Sat, 27 Jan 2024 09:58:22 +0800 Message-Id: <20240127015825.1608160-24-yi.zhang@huaweicloud.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240127015825.1608160-1-yi.zhang@huaweicloud.com> References: <20240127015825.1608160-1-yi.zhang@huaweicloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:cCh0CgAX5g40ZLRlGJtmCA--.7377S27 X-Coremail-Antispam: 1UD129KBjvJXoW7Kr1fCrW7Jw1fXw17JrykAFb_yoW8Krykpr 9Ikr15Kr4UXas29rs3tF1UZr15Ka18W3y7uryfW3WxCF4DA34IgFWjkF18Aay5trZ7JrWa qF48Cr17Wry7G3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUP214x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2048vs2IY020E87I2jVAFwI0_JF0E3s1l82xGYI kIc2x26xkF7I0E14v26ryj6s0DM28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2 z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Cr1j6r xdM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s0D M2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjx v20xvE14v26r1Y6r17McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1l F7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4IIrI8v6xkF7I0E8cxan2 IY04v7MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAF wI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVW8ZVWrXwCIc4 0Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26ryj6F1UMIIF0xvE2Ix0cI8IcVCY1x0267AK xVW8Jr0_Cr1UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVW8JV WxJwCI42IY6I8E87Iv6xkF7I0E14v26r4UJVWxJrUvcSsGvfC2KfnxnUUI43ZEXa7VUbCe HDUUUUU== X-CM-SenderInfo: d1lo6xhdqjqx5xdzvxpfor3voofrz/ X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 524E914002A X-Stat-Signature: 81fzbaubmotu5khqrpx8w7oqia6g39ap X-Rspam-User: X-HE-Tag: 1706320977-322414 X-HE-Meta: U2FsdGVkX18u2NFhGARPO+bQZdYG06+WVSb0PAmEGv/vAZHIa8aILWRsK9D1iV2GFSZRZbus/ANyZTorpIIavgk8MSD+uS4YUqjusNLu35KOpSzUOun7OESznhm1o90QxeHdSkJFvEuCtFgH+z1mygOu3k0KQifUGbEDf/UInM9gPxFp/7CcEHeIfqH9KQZei2d981PzjiOSsRUm415mjEP1SgH3HbqOubGmKxh+iKBz8KU4N0bOB8gmBxsLJCEOmC1/THvVhYyjrTzrEK62ggbECmPD5GJR8s59j+DoOQOqwXvJ0z4SaU4ri+YIqYnrZl5mbGaYv3FWVMEmNjTQSo+J8qhEpSyrJIL/mm8DryF4HUTSPCyduC1YKWF6G7XxtaWZKujeAFbeQFqY4k3svsEpctpDj14XFXcpRT+R3mSnN5Xw6eIVt/KDO9uk+yqaprjO8pBAEKBw1loMk652UJC3gADzyQ9KgqmUu15nQn6yCSK9ImWY5eUKg4hqyuxEpAlfVT50Kt5RYyeN3yEkAd+9kNaCEFnuvMIJw/QpLZqCbzeowDZryHN/z6ub5bLUxEbuEm1SZU/puOfc7oQhOZemD/9FqbL2y4oLC+d9X8wfki2Mhdw1Qh9/2d5dEnHtjHm8ZJorv9fv5200L0QaVjdjLCAxf0enQqrs6HyA1stSOaqz+sXPZme1UQu4YmhTcqcdFD2OM3kcR+VW8KA01pfEHxlIOPHaP7KCI/WwJZ73Q3WhZSPhUiZf3yqCU7mHzC7hAPkEdbNTf52ZbwDJc6llyWtJ/qnxQc/8WqUOKKFtAn913HynVHs5njq+Gb77KJMiMC9N4RWQLy5Ymq35ZXU6b/cCOKlBmWniyVvN0KMpyNAeRxGXjvAspJ4VSGETebsuEQXAczA9+tIGaQCvgnXw/ksx/8fgxB14Yq6fvtCPMlRiGdQg1IImQMUqZUnpFux4BrrqnHeR8mhE2yj FZwzwxc2 tgZ4HcvUaNJAX1FMFXXMYL6n7eC3IbG/6JCscUBmzWubGNldXYiJ+EC1YYFAnChuUeGnfSQQxDzyvZv89Rsv7vUegtdS6Ut2PT7Vznwykb67YAaam/W11mPzwluiz1qY4vS02q3aj8pljkni8ZiHJ3kv++OT3lo+Zu27jwSSSE9+FFUQzp1VbPkd0R9ogxqGEnbWp0lMgEVsLA3Uq6EAKq5AbSckdvgJq3DEw3jPHAVy6H4Yh+6LoZFPgfVe+Jng37jVbZP6uqBqBMGF/NHSRhN/SYeOKnwp8EyYX4xRi30hgml2c4EkvySrO1XIs1bM1hzQMDjDPRqtW8SAKLDoGLZ+kVg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Zhang Yi Online defrag doesn't support iomap path yet, so we have to fall back to buffer_head path for inodes which have been useing iomap. Fall back active inode is dangerous, we must writeback and drop all dirty pages under inode lock and mapping->invalidate_lock, those can protect us from adding new folios into mapping. Signed-off-by: Zhang Yi --- fs/ext4/move_extent.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c index 3aa57376d9c2..7a9ca71d4cac 100644 --- a/fs/ext4/move_extent.c +++ b/fs/ext4/move_extent.c @@ -538,6 +538,34 @@ mext_check_arguments(struct inode *orig_inode, return 0; } +/* + * Disable buffered iomap path for the inode that requiring move extents, + * fallback to buffer_head path. + */ +static int ext4_disable_buffered_iomap_aops(struct inode *inode) +{ + int err; + + /* + * The buffered_head aops don't know how to handle folios + * dirtied by iomap, so before falling back, flush all dirty + * folios the inode has. + */ + filemap_invalidate_lock(inode->i_mapping); + err = filemap_write_and_wait(inode->i_mapping); + if (err < 0) { + filemap_invalidate_unlock(inode->i_mapping); + return err; + } + truncate_inode_pages(inode->i_mapping, 0); + + ext4_clear_inode_state(inode, EXT4_STATE_BUFFERED_IOMAP); + ext4_set_aops(inode); + filemap_invalidate_unlock(inode->i_mapping); + + return 0; +} + /** * ext4_move_extents - Exchange the specified range of a file * @@ -609,6 +637,12 @@ ext4_move_extents(struct file *o_filp, struct file *d_filp, __u64 orig_blk, inode_dio_wait(orig_inode); inode_dio_wait(donor_inode); + /* Fallback to buffer_head aops for inodes with buffered iomap aops */ + if (ext4_test_inode_state(orig_inode, EXT4_STATE_BUFFERED_IOMAP)) + ext4_disable_buffered_iomap_aops(orig_inode); + if (ext4_test_inode_state(donor_inode, EXT4_STATE_BUFFERED_IOMAP)) + ext4_disable_buffered_iomap_aops(donor_inode); + /* Protect extent tree against block allocations via delalloc */ ext4_double_down_write_data_sem(orig_inode, donor_inode); /* Check the filesystem environment whether move_extent can be done */ -- 2.39.2