From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF3C7C47422 for ; Fri, 26 Jan 2024 16:55:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C2DE6B0088; Fri, 26 Jan 2024 11:55:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4731F6B0095; Fri, 26 Jan 2024 11:55:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3623E6B0096; Fri, 26 Jan 2024 11:55:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 24BBF6B0088 for ; Fri, 26 Jan 2024 11:55:52 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EAE061201AE for ; Fri, 26 Jan 2024 16:55:51 +0000 (UTC) X-FDA: 81722064102.28.76A1835 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 46FD540017 for ; Fri, 26 Jan 2024 16:55:50 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=V7cZvYLu; spf=pass (imf12.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706288150; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cXxBY7dsyeQ3gdPieRqOqVFBvnzG8kgoZ8jgMhWWdKE=; b=KE6D9PhV3nT0Yv7GHEif2+yZ2IUx/H7628Yp21tnh/cMFf3bsXEFCuNLyPuhKaFvCF58+K NY+nAghH0571XP03N6MGWetp0rNmp81rNRWxDqZbLj39W6iqorYlVKppEvV/qOx1X8KEuW DxTcBfV7ydLMf9MGrFbw22IbGMUiipk= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=V7cZvYLu; spf=pass (imf12.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706288150; a=rsa-sha256; cv=none; b=ZM6qT02VdCJDdzUzWNTru9AFcf5j1OMpJizFWvZzDv11xvICVIZBjtbRIiuaFfax5bA4xc yDw8WzKKoya7rTcbqyS+OxXlHyQUq/Y5xO3ala+yVj76cZ2R8PdIYJlmZycoznCY+CJ4Gm qhRL7tWcuf0qLhBQRmJF3PaQIKaS1Tc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 61EFD62554; Fri, 26 Jan 2024 16:55:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2900DC433C7; Fri, 26 Jan 2024 16:55:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706288149; bh=cRc0miYazSjnGEd+EQoiEWD4pNFHkgnoD6TA9pNiYlY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V7cZvYLu+Wz9uFxVonT9zlS3FvJSUyrMyP6TpGq1zuwC3etAQTOn1RgzVri7HWcTl nkh8KjKyJsybignhIRrIsWILpmEU+EeHdxVAw3vedr/E5tTqOEeX0Vt/MJBL+fbwW4 SSfEiq0PkBwj1005vnpzN2TyEcULNjBqbcHMqTSjS3FttDsztWzVe2F24GRm3enKjQ x5uCZTpP2WD4QQ4Q+NFdzJW3EARbUrOoeCRdUjdg7/s692SCAQVRR+DvxFiEnO0XQ0 3WEXk+K8qqoEGtaCNxhcUFNhmEFnoFcIdJpsF2tJ2nBe1g1CeKGC7TZuDMbLwptgND H4t064ocy7B9A== Date: Fri, 26 Jan 2024 08:55:48 -0800 From: "Darrick J. Wong" To: Matthew Wilcox Cc: Christoph Hellwig , Chandan Babu R , Hugh Dickins , Andrew Morton , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 17/21] xfs: add file_{get,put}_folio Message-ID: <20240126165548.GD1371843@frogsfrogsfrogs> References: <20240126132903.2700077-1-hch@lst.de> <20240126132903.2700077-18-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 46FD540017 X-Rspam-User: X-Stat-Signature: fr16guqb6fmnbqrmjww58idydsowgctj X-Rspamd-Server: rspam01 X-HE-Tag: 1706288150-344415 X-HE-Meta: U2FsdGVkX18NRFa+5Z6//xb1nsdq3gYG/igWzt4RfpDmOi+27c5Ri2dRN47x+q4JuUR+jtO+Iy04qxrYi2UMKqL4xbAdQdG3Uu0zqWW2y1wzvXsyJsB0ggUuve8UQfIKjFqQnS3BIEfRFAupqcMRegCRxUnWJ+cqPAeMeLEa7keTGEFb/HXAGLSNwEYHnVk+l8SPd+yBvYA49JkV5PRX+5JxXn2bziXrbz7sW7UErxECXIsU+D7+OBIb+P/MzZLOD7zuAcCkk8wgGcrsjjKo1xy+7aHZuvN1R5G0FvctJrRcejXWF9n+w/nzYHBfOQ4uPGujO1MDj0BBVMOpDJDC6DxkRp0RJMVQh5+btC7mXr5w683VLc0S/Lh8G+aPEz4UcJ+ysRI42otQcnWMRHUnpmFTobFACKFL2Jn4rpG8r2nI5qZGP8DihgiDW9HfyLu1zP3FMBpgrSozeLqnsGkj8BKWs+tDzuhBrVW/Sbz/9dB2MzQab5ex5GL8hOhnEIuN6AO0rXSZJUdCGa9FoEiHU0Dcwwh/dpnPKSJ+dvJxVlAqHm/OvKXYMXrLLAQ/F7Ur+K1IPH9hTQjiTF9BkF1svJVH+coaL7fCmgJ6APZNe+ZRnBolMdhYr0VO2uI6Q6Ks38r7szinpMFrfVZ6VA+GRhsht5823XASrxvP86Ror+tAS3P7t3gxPjTUOjxBKESdO/ppBoKpr1w5VIcn7EqyzUf8oUQTEZGhyFhgZBlqtftAxdAq1k1k2H9Qjq3foB1NL7awowmMUNjST0+Vkl69Z3/8EQP9+KmDCRvyJh3PgUCEC6ShOtqbeByBu8dL1NlOf5KS87vKWsWv9ES+kALuOR7+k+KWSLlISfgocX1GGztkyxFg2koqRDo+2QmQa6j6MJlfi6VoJM11qexawZS92rqvn2zkqw0b5ixFzgs2ahjJ9lk0cAraEAf8V8iyy7xgb4swagjVe7Zjj8uc5VG 84pS4SaP zF4lKnLe30TgQ/1/nHnWoWewpMCx86pbzWpS9DjGTeHHa7ERKsu46Q6BKeU1DTzjWiaR47aUDoX0oTPLl1sBur861EUR01U03FfkQ9trmoemRXYHLPnf0GoTAn60MPAuf/OULCVfdv3B+P2whZh/nC79Vn7JOJI3rl+Fa17gthZNV6g1tPVOuMIBspHWqkwFN5aKTOPMiaYV6EPyTEUYKxDoqtwIg6ii5hg62dAkvDllDdvQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 26, 2024 at 04:40:57PM +0000, Matthew Wilcox wrote: > On Fri, Jan 26, 2024 at 02:28:59PM +0100, Christoph Hellwig wrote: > > + /* > > + * Mark the folio dirty so that it won't be reclaimed once we drop the > > + * (potentially last) reference in xfile_put_folio. > > + */ > > + if (flags & XFILE_ALLOC) > > + folio_set_dirty(folio); > > What I can't tell from skimming the code is whether we ever get the folio > and don't modify it. If we do, it might make sense to not set dirty here, > but instead pass a bool to xfile_put_folio(). Or have the caller dirty > the folio if they actually modify it. But perhaps that never happens > in practice and this is simple and works every time. Generally we won't be allocating an xfile folio without storing data to it. It's possible that there could be dirty folios containing zeroes (e.g. an xfarray that stored a bunch of array elements then nullified all of them) but setting dirty early is simpler. (and all the users of xfiles are only interested in ephemeral datasets so most of the dirty pages and the entire file will get flushed out quickly) --D