From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B7D7C47DDB for ; Fri, 26 Jan 2024 16:48:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C9AA6B0089; Fri, 26 Jan 2024 11:48:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 02A436B0095; Fri, 26 Jan 2024 11:48:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE8E36B0096; Fri, 26 Jan 2024 11:48:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C34446B0089 for ; Fri, 26 Jan 2024 11:48:03 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 82138808AD for ; Fri, 26 Jan 2024 16:48:03 +0000 (UTC) X-FDA: 81722044446.22.9400208 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id BDB22160002 for ; Fri, 26 Jan 2024 16:48:01 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KrYpJ4UI; spf=pass (imf08.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706287681; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OWO7GH0LbBGdUgPPbwrfs9iZTc0vqtjSUIzPnYjWM6A=; b=A3Bhtsxq3hiQ6Jn/pNpgsREYSBcvTKJsIjRSamk8zMQVOpM451L4iVll6vwp8i53/r/eUa ghjsbdLO4Ctk4cYvom63eS691zDnBY4CKjifAD+RL9+BTl82/rDRr5WQF92oFOmAkfSPHt M+8/Q1Uld0QvhXRFnkUS5UNxpZ7FAMQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706287681; a=rsa-sha256; cv=none; b=izFaVsOuFS+QRISRuQR7T3RxuFBLz/KPU+LNVGzSV9Ov1ttRZn/Ob93NEMgPNhQIp+gSCP uPcy/NidLJ0K61bO4/gVSqC9+YTaXjtmtMldPv9dMsYGAFM10RASrmZqsw4lPVpTk54avC /kbi4/BWyUnmM7wYRVft2S/K8rpwYrs= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KrYpJ4UI; spf=pass (imf08.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D06DD62554; Fri, 26 Jan 2024 16:48:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75AB4C433F1; Fri, 26 Jan 2024 16:48:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706287680; bh=QAuBut075bQsFpMytI6aLemdKVuNtYSYhaBjCjTmBWM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KrYpJ4UI6iPm7G0mK927Pbz7ii2aJw7ZMv1sf7jPDYdDkKfvegIXfEbDm8XfyGzA7 AXTBmP/cBFNS4IyCOyt0w0Jx6XyUObVKWMz++k3AqbvzOLPsqSMfp10n2+V0bUBCoy StZ4gNCWnWvbXOl/zsA0zQclTd+H1oRnqDWbOGX1qfs3Ha/aiOjqJ8md7oRUaUWbkG u4SR/yFLqxzbPoqexqGcjUoe0P5JcYnjvhN3o9qCBTRo90eG4m394HmWRE6tdE6xY0 S1KQjOz4OKDy9uD/xEciKJplmj7HAaRKCepVNx0JofG0ir+Cj/LBRpGnrcatJSx/Tv b02bLFM+sIpEQ== Date: Fri, 26 Jan 2024 08:48:00 -0800 From: "Darrick J. Wong" To: Matthew Wilcox Cc: Christoph Hellwig , Chandan Babu R , Hugh Dickins , Andrew Morton , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 09/21] xfs: remove the xfile_pread/pwrite APIs Message-ID: <20240126164800.GB1371843@frogsfrogsfrogs> References: <20240126132903.2700077-1-hch@lst.de> <20240126132903.2700077-10-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: BDB22160002 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: rppife3h5ui3idps7iiz1d1qibzgd9aa X-HE-Tag: 1706287681-560534 X-HE-Meta: U2FsdGVkX1/vILoU7KTn4YgQiAEMSb5B/k3HT2uIUv4b5dL/YqhKqh+IF6VmWowFO42EGQWT3vfpI4Z928IjuYWuwypoRtonBz00ObwMPxzZf1Wi/9S7IT679KCsodfmNyYPblGjiXSCrLeIBXoKNFHSkZBZU+wJSnVHZq0UPuXyuJ9JMXk/OrwQs7w7IcAB/YqWdX7csSBxnV849uGOD7sWBH3iboltXR+RH9aW8QllGxH/EF+ApPWvXimaH6+QXRhAUZWM5CgK1EpHA+nVN0GEJG3AgRqdsccN5+lE1inGwNrASrKUcQTeyZd1CeuRCWNS0zWo5v4bBiSXceWHuyOpn7uDgCDeA4Zs9+s7d2yq163mm89hpeqhIP8BZrLCDsFK4nDL+omhP9tRF9I2+HY8MqoKVfeERsEIP4VUEvruUWS8IYh5IiLIEt0Lgswa21RVEyg7chNO3zpxLKb9YrJj9V0j1QFKVOk3ORgU13sx3dSxk06tKnm/ScBGmVwbCiWaLE805d+YyO2AdKl6Ba4eKqfJZ7Rfb9PrN84t/mJlsYttlH7E3HBWCqO5iVMKoGpe0NznE6kQlIwfbamngee1x1R9PuM/1LfuCr6HUEEv+XzayomLpYHEKn33NdWDSdCQ0RFz8Nwp/qJVymIsaaChgHVo1BUafjpyWvnMKYjMtTToJci4penrGMOpiJg670FCBsZdGpnSVCRA6p/uma7e6mIE8t71oTCu5iLLBTx2r1ozlX/Yk9bOzqLo7jpxfq2g3AKxeSjhGB//ju+EDANBq9wz1zwRXkT7rLd/rKUiSPgeND7Oq98p/9jV9M5CjiZ4SguEJTsJA0IsdkQ6TtQB0QJvmQNVza8yMxkoxFdMS0H+lasLi6IHdrw7+itDn+ALpiNKINaJnafvTcDfRwKzwAl0vT9B45MInAEHJq5lCtXT7D3AZ7EG8J9qTT1zh3TkkSON+kU9AQ0vVxz F7FM4bxS h5lJA2EaajbP5NkjW2wVetumGLo7GP1vkZUXNQ5YnCzr6CtyWA1Nie8cb5SIxojdDB610vzcO9IwC3PRBSgqz6p04KLT1/31hyok6w7lrAQgo4sReIzHDQQRQaNszgkJvTtRsgenChj31ugeIrEMViO3msGjke+vNcfGt3YWW2pH3Dnok2PPZi7/Ae14JngzQVa7YZC7ROa5vE3QFfEfRG0WQNbgA+YaNi6dhvyhkGt8vpPo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 26, 2024 at 04:21:52PM +0000, Matthew Wilcox wrote: > On Fri, Jan 26, 2024 at 02:28:51PM +0100, Christoph Hellwig wrote: > > +++ b/Documentation/filesystems/xfs/xfs-online-fsck-design.rst > > @@ -1915,19 +1915,13 @@ four of those five higher level data structures. > > The fifth use case is discussed in the :ref:`realtime summary ` case > > study. > > > > -The most general storage interface supported by the xfile enables the reading > > -and writing of arbitrary quantities of data at arbitrary offsets in the xfile. > > -This capability is provided by ``xfile_pread`` and ``xfile_pwrite`` functions, > > -which behave similarly to their userspace counterparts. > > XFS is very record-based, which suggests that the ability to load and store > > complete records is important. > > To support these cases, a pair of ``xfile_obj_load`` and ``xfile_obj_store`` Nit: s/xfile_obj_XXXX/xfile_XXXX/ here. > > -functions are provided to read and persist objects into an xfile. > > -They are internally the same as pread and pwrite, except that they treat any > > -error as an out of memory error. > > +functions are provided to read and persist objects into an xfile that unlike > > +the pread and pwrite system calls treat any error as an out of memory error. > > It's a bit weird to refer to the pread and pwrite system calls now. > I'd just say: > > +functions are provided to read and persist objects into an xfile that > +treat any error as an out of memory error. > > I wonder if we shouldn't also change: > > -Programmatic access (e.g. pread and pwrite) uses this mechanism. > +Object load and store use this mechanism. Yes. --D