From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77308C47422 for ; Fri, 26 Jan 2024 15:35:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE9CB6B0099; Fri, 26 Jan 2024 10:35:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E9A856B009B; Fri, 26 Jan 2024 10:35:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D62096B009D; Fri, 26 Jan 2024 10:35:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C85456B0099 for ; Fri, 26 Jan 2024 10:35:43 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 70E7BA08B8 for ; Fri, 26 Jan 2024 15:35:43 +0000 (UTC) X-FDA: 81721862166.08.CE0E387 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf01.hostedemail.com (Postfix) with ESMTP id 312C140010 for ; Fri, 26 Jan 2024 15:35:40 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=e1N5s1Dc; spf=pass (imf01.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706283341; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P7Oe6KlLPTo7Wpl5+l3vTi17r9sFPMt5tYVi1N17yxE=; b=gI0ikOX9c2qOV3ng1To6G3lphYzsIKJRoHOG5I9iVBm0jIJKGYCU7Gri/pRpqQqsVaeHGZ 8oJXXRhLujBHZQ20YNS1oER6iGAl3qg8+5ZSyDbWuE2SUMzkybrjGMb3vYGKN2/8wgJMm1 iyb5wianVMgO0Y0lymH1qeFzqlQp1pM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706283341; a=rsa-sha256; cv=none; b=mr8E5a1iK0d0I1/1jVJBTh/Nw0WB3AIek7XlMSi6VhNoXhg8W7ubw1ArxaY7T6uFMFMugd yqTqdEUXkpe9g6I8BRbScxUR6u1NODCVvUaHlCXgUL+bkEUzO/idusm/U1Ug+17rv4JiiT 4A5vz/ewMH2yqrh/fobGuC+UF08m4xY= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=e1N5s1Dc; spf=pass (imf01.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 01BE740E016C; Fri, 26 Jan 2024 15:35:37 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id GaR2USFls6AC; Fri, 26 Jan 2024 15:35:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1706283334; bh=P7Oe6KlLPTo7Wpl5+l3vTi17r9sFPMt5tYVi1N17yxE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e1N5s1DcEV7OiU5ueEYz3Jxa4whCu+ho0B6R1fOpyyV+Iv+KlFHIhB9EW9cLnU0Ln zva+78aCi2XO9l9jtkUIqqWPS+3xzfiB8Yvlr3S34dn3sIn4gSxL3uyVLrY7J9lDCs NOG1rnlnfuOSQNqMZgr4kbkKNL8i+V9Bo8F3tNfhufb9DnPpUjs+TT5+evf2sGLyjS i8nfDJflpmurujqBU7N92Bc7SpVkczSbBq9xp1xljfk46HlzCivDoZQpeyErkUFZiE 94QEUkF118r3VnQlWKugUtvQu7tNF+JUI91yJChdl8ltXa8AR3u6lVp4D/zzuxqgEi MNVoV5Fb1TTudu8Gb/AAX0dl0RW1TPy+Y6xQ1sGbX8O/OvRnWmDheR5aCWKuHfip5g R+LHCSSifjGrgrmVZVypkn+7PxMJFrf3rVJIxOH791SzmggCT9Vt5pj3F2/ZrYTMlb P8WnVnvXwlSt7mvO17dEIZcNtBgKPsf7RG4R062ogzhkZSdu1XAzI+bfRRqJNsRerp cwJKPQZxDWk8SWv+UyMnNO4W5xDrPnuElc8jmGgdFNcZlucu4hVIMuZDyGJTDvjbMO qHa3FNM0namjZivxU/Rj3ymRYCZLeq0P2GGQxYYMsq6f8QFN5HAxtQ1+LASrFWoH55 hfiAarXcIepWsdBBMxjYqSU4= Received: from zn.tnic (pd953033e.dip0.t-ipconnect.de [217.83.3.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 2982F40E0196; Fri, 26 Jan 2024 15:34:58 +0000 (UTC) Date: Fri, 26 Jan 2024 16:34:51 +0100 From: Borislav Petkov To: Michael Roth Cc: x86@kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com Subject: Re: [PATCH v2 11/25] x86/sev: Adjust directmap to avoid inadvertant RMP faults Message-ID: <20240126153451.GDZbPRG3KxaQik-0aY@fat_crate.local> References: <20240126041126.1927228-1-michael.roth@amd.com> <20240126041126.1927228-12-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240126041126.1927228-12-michael.roth@amd.com> X-Rspamd-Queue-Id: 312C140010 X-Rspam-User: X-Stat-Signature: ho95shwbtn6feafn8ap1a7f6gqcw5zny X-Rspamd-Server: rspam03 X-HE-Tag: 1706283340-434825 X-HE-Meta: U2FsdGVkX18ugD1/1Cd6DHKDOQjzyZeMhCddqErod8WEa1ZN5zseSgHH3Y0/9d4XSOrGbKe0+qh1yihA3TCEqZGBXDZBZXUz/h58I7A8/iARudsIF56Rr9QXPqJT0s9CEghXird3Kotz+eDXmRHaPRYpcF+jlAyx5+IYw8NcSlmJclk5hjSOyAigogYgHV6M3I7CsGZP+Dy/DgZWl9MFZMPBaLCoRxiSXzKmUDXj2BB1F9bIyi+2x2xqh4LxKRaODo2Hqbfsy2cei/bHY5WY/d3kTst/lI2pSGiwJqtLw/o5KXu8qAXYapmHzVRTVCmxpWtpFCu/ns4ZWOVLTCIF9SYT0QKRBtOf9ZxEZLzQCFI9GUKmlWsNX1V/cab9k0pCxPZfsyp69ZyTu0K5idYCOhuA3hCBgYnuPwet07WWG2DtSU8UEBaY8vhzptuj8+1TGYFOwQnxixzbcX1uH/coINEO3EB+8jlPMcb9y1HEefe5QgHf0DooVRnRdV1nN71eutRHJyFyL+L+1+oVbkDzsqKH0JJ6Nju+jdJPtfsTaASpCwzLv2ONaF31yEqxfK8xrVTz/jlJDQHAJJ/2Les+8Rw3nRxXtrCRs//hkLRl5o8Q0u8q4bQdnASzou9Jb5gSoiiVYSO5KOPFViQKeK0/7cYZy+CWTfOJO4SjUyzO5/8LC5i6n295P9XWIf5YeLRCOJLyeESMzbSAtilRtDtTAqWljL789VGnqKS7GimADgrbjYLS4Jfsjr9gAlQnVX/aWOE7f14BFD6c1ea1W4P4B0dJ3fEwW9lhTlmn5uRhfkrqIE0wDsR77IgcZUL4wWjf8j2E4Li1E1/bRpXjEf9EOngBfLgahUj740l6q4IZyhylG74/LSiIIX5vbgFA8Ji0OBkIYjH8WMqxYGUJEZjm5LOIX8ZsJKiEHvMo3zZJSA3esTXth4eqCQ/fwZGkWuiPZCFcW9x3v//aUpd6UL8 2wD4Eyp8 SR70ED/UndPLdMYvPkbvOH6H1AeZdYg+biP/RJuW9E92pWfg6NL6xVZkEJtoOiqQa40UKkdSBWP2qVKLmvH5xs8WFCPBFiqIjAM3HgoR46NzunUiQVCcPmdejqc4NE6f0bt6O0Zfa01upp+cMczpK/5EnmLKeXYySfJwLU40Ye0MMhtJh/kBQsQhVTTDKZR1yzHznBVFCdq0Xulo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 25, 2024 at 10:11:11PM -0600, Michael Roth wrote: > +static int adjust_direct_map(u64 pfn, int rmp_level) > +{ > + unsigned long vaddr = (unsigned long)pfn_to_kaddr(pfn); > + unsigned int level; > + int npages, ret; > + pte_t *pte; Again, something I asked the last time but no reply: Looking at Documentation/arch/x86/x86_64/mm.rst, the direct map starts at page_offset_base so this here should at least check if (vaddr < __PAGE_OFFSET) return 0; I'm not sure about the upper end. Right now, the adjusting should not happen only for the direct map but also for the whole kernel address space range because we don't want to cause any mismatch between page mappings anywhere. Which means, this function should be called adjust_kernel_map() or so... Hmmm. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette