From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9A96C47422 for ; Fri, 26 Jan 2024 14:18:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EDAE16B0083; Fri, 26 Jan 2024 09:18:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E8A1F6B0087; Fri, 26 Jan 2024 09:18:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D521F6B0088; Fri, 26 Jan 2024 09:18:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C4EA36B0083 for ; Fri, 26 Jan 2024 09:18:40 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 92AED405A6 for ; Fri, 26 Jan 2024 14:18:40 +0000 (UTC) X-FDA: 81721668000.29.1BD5AD8 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf13.hostedemail.com (Postfix) with ESMTP id E4A2F2000B for ; Fri, 26 Jan 2024 14:18:38 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706278719; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Co0LwkclpHCMaQUFO1TnyQC50GH5orUD2I1L9p3nto8=; b=H3Kug0a+Ea16gKhpC5Mbj3bOML1KtU2A+Dci/u9yfbv018f5JXIUEvhN4oxwX7v2fbQmih hdrHlS01ct2+1h0i13MORhwVN3ASaOOJ/IRMO7bAEAKeH6nkkb/+rSey3xkiwfiY7sFDnH ilqN2xRpo1/JS8NPC19NxmTva9KvfH0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706278719; a=rsa-sha256; cv=none; b=WZJ47vWWseNPjxWTSBics//IRjP9NwiG3xf6GUv9H/RWjzfkaoPOO2P3fgKt7Q2oIyZaQR hTaENl2fvgsGsahkDNcr151FRW8SuN/kDlkdEC8K1Tt+DCT6uCJCFeTCeLH6k6e0mUAjzr gVOp8YkCUGFuxPByLT2syrrl9YgswbY= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none Received: by verein.lst.de (Postfix, from userid 2407) id 13A1968C4E; Fri, 26 Jan 2024 15:18:35 +0100 (CET) Date: Fri, 26 Jan 2024 15:18:34 +0100 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , Chandan Babu R , "Darrick J. Wong" , Hugh Dickins , Andrew Morton , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: put the xfs xfile abstraction on a diet v2 Message-ID: <20240126141834.GA4288@lst.de> References: <20240126132903.2700077-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: E4A2F2000B X-Rspam-User: X-Stat-Signature: 7hzpgn34tppyg5derissyqg1kteiwh5t X-Rspamd-Server: rspam03 X-HE-Tag: 1706278718-385453 X-HE-Meta: U2FsdGVkX1/haug6XSfilMK7N8DIJegrK7f9kqgJaZLAhdcZxG2nxeB3f2Xqxyr29C1uWOxDC//EmAXsshDuj/sfZHysYIHXs+VaN+hQqZL3K+gFCMXbLrMRZNPlbfzBNQdj6+HoOhM5VnWSFdRKRC5USPXTGtMPKIuVFz58zbGysMz4R8MTO/YUhW4xdSnBSzg/sjqMrBPRkXvnAyVZtbdy8WUOCqjHiWmE4O7A9K30kXAna5nnQOt6NXx5ecNal6/4dAg6lrZwYvS2UKHbBZ6kFiqCJjcGv5R2qQ+FYxdsUQvWYJkJdWHXbKY07DSc6texX/sGJR3LGznN9qN4v73rdy9Fy0qu3VnsFzvcxktjB0/JEzttbRyRKDXFe89VaMCcJ/5VcqA1/ASwJ4avCb3xsg/NHlBlWH3BW0gIuGba0jsEaWpqnvzarfxiczk7ngdlLCL+9tT1dGXS9fI+C9rxUFnHCIKV0eKrBH5i1nVWZ4ddShEWZnfELrnRj6XifkWz8pll/LVKn8+EfhjTRl1JL1J4tPAhrDi2ShszdhHHrJ0i84R6O71nkFb25ZNODzbefFu8phkb2xJHN7qOG5HBWxROoT3HZjxSdhREfgVCQEOYOSgZRUCNwMBMu2iQL6BPfD+3DnTn4JVW+IIPX67ofLNjgGq6hoKUt+02xYBQyWv0JZYxinnpSFILrwPHoyqAgTRIrp11IR4jS8WWP2xWkxtPb2PV6bwJZom0yso= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 26, 2024 at 02:15:44PM +0000, Matthew Wilcox wrote: > hwpoison is per page not per file. That's intrinsic to, well, hardware > poison, it affects an entire page (I'd love to support sub-page poison, > but not enough to spend my time working on memory-poison.c). > > In general, I think there's a lack of understanding of hwpoison, and > I include myself in that. Mostly I blame Intel for this; limiting the > hardware support to the higher end machines means that most of us just > don't care about it. > > Why even bother checking for hwpoison in xfiles? If you have flaky > hardware, well, maybe there's a reason you're having to fsck, and crashing > during a fsck might encourage the user to replace their hardware with > stuff that works. But the sentence is stale actually - we're using folios now after Darrick coded up a helper check all the hwpoison cases and others. I should have removed it from the commit log. Crashing is never a good idea I think if we can easily avoid it. Note that I still find the difference in hwpoison checking in shmem vs filemap rather confusing.