From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76022C47422 for ; Fri, 26 Jan 2024 13:52:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0BC576B007E; Fri, 26 Jan 2024 08:52:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 06B906B0081; Fri, 26 Jan 2024 08:52:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9CDA6B0082; Fri, 26 Jan 2024 08:52:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DADF66B007E for ; Fri, 26 Jan 2024 08:52:32 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 67425120FB4 for ; Fri, 26 Jan 2024 13:52:32 +0000 (UTC) X-FDA: 81721602144.27.9E845AB Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf02.hostedemail.com (Postfix) with ESMTP id 6ABAF80022 for ; Fri, 26 Jan 2024 13:52:30 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706277150; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J7GM5aCwzj+ZhbzMfZPkOXnZG2N7cwwosfVTElAtH5Y=; b=BXX+4PnOewlIna6uqCTyEcCaOEHYi85AZU6HRrrHSbkGEps6d4OwE1+2sjfg6KroVUPe9J 3LFSAgP3VoCTxBwNF7RaJ2/PxcLPhrYSOY+YK1ChTziJRqtbGCDykg7XDQn5XPXdZuSePA fRoQJwirElSnXB4Go3C++Rebr9VK3Xw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706277150; a=rsa-sha256; cv=none; b=L+wNULlm1wpO4SHgIgnCrFgdMCORBSoCFYam3o9WCT62O2YKs60q8yi27V3iBBCJIVLsX/ 15t6Tswc4W2IVMbGjpzGuSpIjxVq3HcTwpTOHhdVNNBuqAeTL1tuNSIkjxG92sao5KgulX A85+64mHJFnanbXjDAazQqE4P8RpU0w= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none Received: by verein.lst.de (Postfix, from userid 2407) id E935B68C4E; Fri, 26 Jan 2024 14:52:24 +0100 (CET) Date: Fri, 26 Jan 2024 14:52:24 +0100 From: Christoph Hellwig To: Jens Axboe Cc: Matthew Wilcox , Christoph Hellwig , linux-block@vger.kernel.org, tj@kernel.org, jiangshanlai@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH, RFC] block: set noio context in submit_bio_noacct_nocheck Message-ID: <20240126135224.GA3368@lst.de> References: <20240124093941.2259199-1-hch@lst.de> <20240125081050.GA21006@lst.de> <07de550c-2048-4b2f-8127-e20de352ffde@kernel.dk> <6c4a4cf3-c5ed-4236-a6b2-9d53e927f979@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6c4a4cf3-c5ed-4236-a6b2-9d53e927f979@kernel.dk> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: 6ABAF80022 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 61dszdkea8g48qzqzpspyjqyu5me95fw X-HE-Tag: 1706277150-717596 X-HE-Meta: U2FsdGVkX18ITIZ8Kf2HOvB8MXokBZ/lW1/tvOtHQmPKQcSQhwPvtapBOkcJeQQk8vgcp7Xglng8Z1juYfgt9hT7X+8HDUjhoEMh4OQ29WElNiImImNK7t5+oDHUcb7VQcwHDmQZtLJGG1NbmXU4dYQ68yER477zMJBnS9gRVtsyAFP+WaelxoWq4RRwHn+VSPHUp0v5Cqek6kdFXIibE5cuj+jH/h6hmRIu/9jh+BL9vqxn6ZKuPqcO1On3XSi22h4eClu7hhHIErdnTHKB/RkuYfenuRpG+VT2ui8JZDIqdb2sMOTiQLLLeWSGA7iLy+71mR/9P0WqAxsCM5GI3kCX+AyGiNy8AIm4KefcUk1YpEjMqhn7FNzpWK4NgahAOzR3q/X2WOF3xM2Vq5nAkU6wqWL7qo4kseS1YDcP4lRJOYUAbCwSemu+iHoCUIuDDkYC8qg8z8GRpsEnLHEghrpC/fAXRlVCYAkioXc79MSvOEnmCYSEL+HtZ67a8BMKoPR4HKgxhqUPq4xCZ1iOnzxfjKHO8PLDHo6nKqoS5i9XaUB0Zp7RMfvxeq4T4u90qIq2aKvTpwFfwCAnvwcQx5fYChzjQdVThsdBCNckIz667krGg5Y+IliPpT4A7+0Y8+FMML5lDKudE1L4phYEHkMne3OKR1C8/s608EX8zqcwoNtq7KHD+Yk3cKoeys8utBw9t1+2GsZlJ4Dbiuyhr8feeA6R52Dx348mJ0EclP1uI8UXSpgTJuvD54qBBOuLER/z8kJQDgyu4XJAVrc7bcKRUVn+qixOfRJACUh/LJ78Jc+53q4tkes+DtH/av24dBvdWcr6wjmU0SddSjROUxgcC93CkQkh8OBvnij5VvPbnrFfC/ZBQf8KcFrju3EHA3YW5Qm1yz3iUN6IXuVNa2GGHqcyY3qE/N4870DzeMpCqBVA32KQhRi0JJkPpSxU8a5jzCtHMOA7m/ncpdv 0Es2Genq 63N1QwFQdUtgbNYfKFGKT1tdntYw+gaPYInJEeJL/Std/lE2ip6e2M2CwYMKjSKHyQejN2syC+bKYyugbQVVZSQ2s9w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 25, 2024 at 09:13:37AM -0700, Jens Axboe wrote: > > Nono, you don't understand. The plan is to remove GFP_NOIO > > entirely. Allocations should be done with GFP_KERNEL while under a > > memalloc_noio_save(). > > I do understand, but thanks for the vote of confidence. Place the > save/restore higher up, most likely actual IO submission isn't going to > be the only (or even major) allocation potentially needed for the IO. NOIO is defined as allocations that will not recurse into the I/O stack. So for anything block based, entering the block layer is literally the defined boundary where it should be used below. So no, wrapping every submit_bio into a context annotation doesn't make much sense.