From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D6F1C47422 for ; Fri, 26 Jan 2024 13:39:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 282D06B007B; Fri, 26 Jan 2024 08:39:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2330D6B007D; Fri, 26 Jan 2024 08:39:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D4216B0080; Fri, 26 Jan 2024 08:39:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id F31746B007B for ; Fri, 26 Jan 2024 08:39:30 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BA048160F3B for ; Fri, 26 Jan 2024 13:39:30 +0000 (UTC) X-FDA: 81721569300.06.3996941 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2044.outbound.protection.outlook.com [40.107.244.44]) by imf05.hostedemail.com (Postfix) with ESMTP id B9EF8100028 for ; Fri, 26 Jan 2024 13:39:27 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=SgJJOgf+; spf=pass (imf05.hostedemail.com: domain of Michael.Roth@amd.com designates 40.107.244.44 as permitted sender) smtp.mailfrom=Michael.Roth@amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=quarantine) header.from=amd.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1706276367; a=rsa-sha256; cv=pass; b=jhRrtcAG8SKK8MfFxHyfIFkDTXlZ1p/6pHIn7doyzOXHc6M67c2YTR0NbOTVGIeqEa6NcC F21Gk07aV2IFY8jezA7n8m/+7X4EXVmVVgCcL0wGxGudH4SxN7QHJwFYYTHsClhtJCRjRR pwHS2mY62ewDzsQ+ldV3SJ+GsGJhsvE= ARC-Authentication-Results: i=2; imf05.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=SgJJOgf+; spf=pass (imf05.hostedemail.com: domain of Michael.Roth@amd.com designates 40.107.244.44 as permitted sender) smtp.mailfrom=Michael.Roth@amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=quarantine) header.from=amd.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706276367; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=puosVlpQpS52Ge3Gq6Zq3LUdc2fSyxH6zIuXs7Ico5w=; b=KB/Of/n/qhGbPFEb39HKOibDAG/46BmBBA1h0kHy6xnXJpaZZKncNQJgDecG+HprUTGH5U +eDNiR4V/rG81RGA64PjqKWiYsh9OxBtnhpf6gRUS7Zii8FyfDRbAX0q4zbpNa+SILegyu ALzjZU/41FQnmTCF2YbaVR161yL4t08= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gn7ZVLZS58vayPogvEKeCYrUemCNbQMUJ1ej6pKi9V4y8FexNOQrbwV8DeP8IEmKCLaKZhw316MtDLWcewTyA8EtrlLfxYosoZdh26y2krB8AtfFODTpe8rlrJPZUXEZUxKzzXLYr/Vyp5DIeIlRa7U5L+7+Eq+aGMtplGFDCl3aTccLoDMHfreH93K3JwftPlcpKQ8ZtchEGik0jVoq8HtFUv8nRPH3pqsYJ+ukLR4oSi053oTA1gz/5/SfZwgapkf48B4gztaItt5nTIzYqe0LTS/LLPb/h5HyMG0UxAlwDgbKvHpGUG4AaCdwXHaJ3bAPTowe+BI0ZmE/v8+i4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=puosVlpQpS52Ge3Gq6Zq3LUdc2fSyxH6zIuXs7Ico5w=; b=eIRRMjX88sThLGicQ0QWakBVASxbjLOQ0UNIhT5E78qlTGk+vRNqJVAI2QAUxHuMqjdUkcNt2XLcRDC03fttiNQdligMrs9jPWnNhy2IyQNHCDVRM3cE71g+4wQNKBvY3rpFcISYzHJWKB3hKniEFFbuyu9BtqEE52dfsQWZiizOynIWnS3M94fyrf0GmBY/MxH7VHqKcpe2m1xIBr7TM/4SW5cwY0wP/a5GQCeUkHv+tin1vTgOgoSASf/ULDl4hF9XHpSIlh9P+jXxOyJRocad7I1JWLMZ+ByLrGBQJbOn/v+0+2PxXQhQBFbOP+NnUeYvz3IXs8LrQbkM3upLkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=alien8.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=puosVlpQpS52Ge3Gq6Zq3LUdc2fSyxH6zIuXs7Ico5w=; b=SgJJOgf+fXpXpDZuIyhFN6Nnin7jOKvPhFs9/SFwF8jtycNgVTf6rzvK3kRZl6f1xwBCGfdxnkn4BzdHEUXyMsPMiMOmcsuD2upl7ieW8spHJeuGw5OOjDSreEJ1T7KzUSSB1UED4CHWFKNz3mwMxuCEuLM5KP47FoaSbwdvk9M= Received: from BN0PR02CA0027.namprd02.prod.outlook.com (2603:10b6:408:e4::32) by LV2PR12MB5893.namprd12.prod.outlook.com (2603:10b6:408:175::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.22; Fri, 26 Jan 2024 13:39:23 +0000 Received: from BN1PEPF0000468B.namprd05.prod.outlook.com (2603:10b6:408:e4:cafe::d3) by BN0PR02CA0027.outlook.office365.com (2603:10b6:408:e4::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.28 via Frontend Transport; Fri, 26 Jan 2024 13:39:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN1PEPF0000468B.mail.protection.outlook.com (10.167.243.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7228.16 via Frontend Transport; Fri, 26 Jan 2024 13:39:23 +0000 Received: from localhost (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 26 Jan 2024 07:39:23 -0600 Date: Fri, 26 Jan 2024 07:30:36 -0600 From: Michael Roth To: Borislav Petkov CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Brijesh Singh , Alexey Kardashevskiy , Dionna Glaze Subject: Re: [PATCH v1 26/26] crypto: ccp: Add the SNP_SET_CONFIG command Message-ID: <20240126133036.q2o7of7yqeroqupj@amd.com> References: <20231230161954.569267-1-michael.roth@amd.com> <20231230161954.569267-27-michael.roth@amd.com> <20240121124102.GPZa0Q3oBHLG0fH_yn@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240121124102.GPZa0Q3oBHLG0fH_yn@fat_crate.local> X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN1PEPF0000468B:EE_|LV2PR12MB5893:EE_ X-MS-Office365-Filtering-Correlation-Id: 4a644811-8888-445d-b87b-08dc1e74351f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NMZElG1faHv2CBAVc/uAOPK1iJBPR1isDJ35dmkzoduXpiGRz+leNH5Ar+mmKSrXvvE89Niy1adpZnz87CPuS2hoP+NV/3c5FbqYmC9eEtI46/D31nBPUZbMeXv2WIyDx82C71uIzN2HMpeIuHcPREr+rTUHHMPdvE/rpIsNjtaOPZvfr/WaKnYQUS3kuKJvDja6QBdgMlGa1ze9M0seYqeQ6wlBa/U8kfLHM9HhhCgerf1Ws96D2I/DrrqLsSBtSoZdb7xT5K8cVuyvl0aXTHmGvsDZdAicINtUMDTsl0XqcjHnlfI2Tqq3wq/rZHUQS0vGTaaEFD2S3peztiaXqmgDt29t7XZpZAxTSIZ4ZNix+WbiB9xgZtwQ3OYGIi6XlZaxJnZIfckM/0AHeVU0YXFk9nWsQ43PXqfwtbhaLwy45tnDlH73FrMMzJg4Wkp7PkJz2aZoUaoPGyw0yIzKkDq+Jt74WcezZDfzs9yxd0VAst0UJxLgLIp69vP+lk2MCHKwTTIjnWXzScGB+wzlaiTf8fAzQj2hoOHmH3JRqU/iMdd0Ed9y6TD/B3kDq9QEMoEKT4hm2dTFjlSYpJ5uoHxX1DpX8Pf4D5FQ3VtU4ttR7DMFUJ+A5cezpwnzwdwK7ZMBujfWKg36pehMKGQDXQEzmLbPZ2wS0uec14odqLLy29kSfG3nJJXshSDpDxdgLym9EmLk4YQkjzkOeyKEGDayrVFXj7cHiO1RenK7SIfOMEhsf4b8vXxoTQKNUNYrvl7Atf719G+HwUc4e9wOJA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(136003)(396003)(39860400002)(376002)(346002)(230922051799003)(451199024)(186009)(64100799003)(82310400011)(1800799012)(40470700004)(46966006)(36840700001)(1076003)(40480700001)(40460700003)(44832011)(2616005)(82740400003)(47076005)(16526019)(6666004)(36860700001)(336012)(966005)(26005)(426003)(478600001)(8676002)(8936002)(81166007)(4326008)(316002)(70206006)(6916009)(54906003)(70586007)(356005)(5660300002)(86362001)(41300700001)(7416002)(7406005)(36756003)(2906002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2024 13:39:23.5297 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4a644811-8888-445d-b87b-08dc1e74351f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN1PEPF0000468B.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5893 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: B9EF8100028 X-Stat-Signature: sfduxgcx8fhkwgudjdapycuh5eeobyoe X-Rspam-User: X-HE-Tag: 1706276367-815524 X-HE-Meta: U2FsdGVkX19IkwCWLv4FTp1dPVxFrApyShFnzHm4SmjcWeumL4Jr55cByJZvZDshmVpzc+KRWA8YKijxQt+Bkmkj3rcW0OXjMH7QnHYvo/IkuOqv76EANHkaGCB0wwqpDDbDNoSHGUbbaiCW+40oRX1WHCTl65pxxcnlaR+sEiEQSMXAARSmTjcfIzie3STd3oHdIEu7MdX9ddgT8uP1w4fQSKvzeOmHW2f0V8ArBaL1RWos+4LP9JmWdBh31kLeVTF+sTfFOukmVQlPDqW+NR5Z/3vEeZLHwA8D1tQwvCgy1TZOljpTiyjPC7oVTcBsjX+QiDsfVpYx4NFSKGtpH6onhV739ZLN5mohZJHvyHF5c+ubaHZGHWNMcAF0hHBGgTmetoHMba1roQZcC2MuKZD4p1VrTOaCSMv5bDRlf02Uye34pPAbrWKt1N8PS+xsi4iL4Ed2w2+Q1VHG9J5dOZHWJYFPwbMKQC9EQd0DiOfo9tZOrzk2ilSd5w+G4T5XRG+14e7Bm3bHR9v8n7lpwCAHM6vYdUTjGrFTc8BiEJP6Nvdk8yYggNqAI1Lh/yYTeHA6COPJhocOHIMg7U2dhdIdDtOS8kA2VSai9E5G0PZOU3MbNBchiui7iAGcqZGlDf5fCIILKf9DTWtqLWEG2Kt1Ho367tr7n7oeKmIYKpFt/DdtmKD2Sv2C5onV66FKScxFNZIlG0lBpTucL6vEmsv+UEV+hqM3Ziqt1Gz/b0K977bxxXQjCRrkCgOf03bbKNZNvuuBkLhwSVWiRLH0GiBmb8Ez37XcKJcGtqWqkzMAoLJFubDM/Nt7RkPJRtchoN8BcYQQjcDoL81B4Bx+gxhWzS3HOOkz9odPOm1D6bauFc//Udd+uWvGpd9xjrI6FHNJ4td7TJdf8GEtYgRRUKFOWjtAqb/TOVOGjMVxi49yek+GdBpKzkFTmoE0R57o3utV3wVK8dRPFfopVLx UArQYLXD WtjrYS4HtV1osemHAA5vjOeFYba3uDTRm8wRtGXpCH0kEyElMW4cdiry2ZPe4rasjCLiBm+tQJhOmHlDb6nmWqr2itICRk+3I8n4NGjJrj0lmrjCEpFmM7X9s9wPcBgB5X42/FKLwMAsV+0tL/dTveKVQQldgOzRIKK7oVKLj4xcp8Xc3jaQnZYvgSLPA4a9+g9wm3QqHiE695KDY3LFZ1zm04HbclH1SI+gLcoBWhop8RwoKMlp/a0ji9edKqGQAweg9sxh+mjbKLc2a9A43w9niGmf37+OILTtS6rrBKZKuiwi02zuTsNNrOkVydCPEswTXENBESFt5Pmj8TJR3NCFsCfKgzhZ5sQZ8hBp0E2hGGiq7Je98FncxjbEQcrpLPT3+xQjaPUF4pJHgxC4LO2xCaHti8cs/eSbB35bTiepyAdPVMoOBK1M8cUV9TiAN2A2f3EIIg9x8QPXPP87A3RcfCw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jan 21, 2024 at 01:41:02PM +0100, Borislav Petkov wrote: > On Sat, Dec 30, 2023 at 10:19:54AM -0600, Michael Roth wrote: > > +The SNP_SET_CONFIG is used to set the system-wide configuration such as > > +reported TCB version in the attestation report. The command is similar to > > +SNP_CONFIG command defined in the SEV-SNP spec. The current values of the > > +firmware parameters affected by this command can be queried via > > +SNP_PLATFORM_STATUS. > > diff --git a/Documentation/virt/coco/sev-guest.rst b/Documentation/virt/coco/sev-guest.rst > index 4f696aacc866..14c9de997b7d 100644 > --- a/Documentation/virt/coco/sev-guest.rst > +++ b/Documentation/virt/coco/sev-guest.rst > @@ -169,10 +169,10 @@ that of the currently installed firmware. > :Parameters (in): struct sev_user_data_snp_config > :Returns (out): 0 on success, -negative on error > > -The SNP_SET_CONFIG is used to set the system-wide configuration such as > -reported TCB version in the attestation report. The command is similar to > -SNP_CONFIG command defined in the SEV-SNP spec. The current values of the > -firmware parameters affected by this command can be queried via > +SNP_SET_CONFIG is used to set the system-wide configuration such as > +reported TCB version in the attestation report. The command is similar > +to SNP_CONFIG command defined in the SEV-SNP spec. The current values of > +the firmware parameters affected by this command can be queried via > SNP_PLATFORM_STATUS. > > 3. SEV-SNP CPUID Enforcement > > --- > > Ok, you're all reviewed. Please send a new revision with *all* feedback > addressed so that I can queue it. Thanks! Unless otherwise noted, I *think* I got everything this time. :) -Mike > > Thx. > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette >