From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BF93C47DDB for ; Fri, 26 Jan 2024 04:14:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1CA56B009B; Thu, 25 Jan 2024 23:14:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CC096B00A0; Thu, 25 Jan 2024 23:14:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86CCF6B00A1; Thu, 25 Jan 2024 23:14:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 749786B009B for ; Thu, 25 Jan 2024 23:14:53 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 380F41C193C for ; Fri, 26 Jan 2024 04:14:53 +0000 (UTC) X-FDA: 81720146466.25.9D21CCE Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2056.outbound.protection.outlook.com [40.107.93.56]) by imf06.hostedemail.com (Postfix) with ESMTP id 4EB51180002 for ; Fri, 26 Jan 2024 04:14:50 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=sWifEGm6; spf=pass (imf06.hostedemail.com: domain of Michael.Roth@amd.com designates 40.107.93.56 as permitted sender) smtp.mailfrom=Michael.Roth@amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=quarantine) header.from=amd.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706242490; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KuTLI/e4rw8UMbyjzDaRsBOuInrsZy4AaAHurzAMwYc=; b=hvwLiDJsjhag3OLNWNY0QrJqUf8uOALDadGuCXl/mvirsT2FB8iSCoeHUtwRs6d9Gel4nf IgsY6M0d5C0JJrIj5bHqHVawl8gy7zkyjBkuURVULzZpWwP81Acy/d9nNKRLAMcPgBLrrX UJmYDav3/tUQFzqy6ASQEIv3zcX5Bj4= ARC-Authentication-Results: i=2; imf06.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=sWifEGm6; spf=pass (imf06.hostedemail.com: domain of Michael.Roth@amd.com designates 40.107.93.56 as permitted sender) smtp.mailfrom=Michael.Roth@amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=quarantine) header.from=amd.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1706242490; a=rsa-sha256; cv=pass; b=X0jBCbstTH3vsdbO3GTGbfxClcMe1eudy+h2j03FdknB+dMXImcgCgS6Cvk5g32+WZMbPq e9gXriLTIS/csyWFMPo0lkkvAA4eBm73AR+n6bNpjCBkctRJ/Ug0EsHRBQw9+LFFZGlkME MHaop0dbeuwYak4tckefYE1uWyjSBoM= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RZoTGzaeH2DUQle4e1T15iL0gjhgPgSSNyFtKoX2gU1a2PjSMPWellzBoY6Co91vRYmV27mYHVqf2KVrzvhxKBdUKsRJ0y0adyHETk0zjUCuMtPSHhQZfTsIaZBPdYawbONPtXmFGfmt9awcb3tTU4xNP2Oy9A3lPVBgM+Yx/5pKBJcjs/JkRXhTYSXtzFCqVCsgSL41ViVINYvPhvOkLSzn5AjB5KxdbK5qeAnWZ3X33asMA05sHc2NFUeK8/5vvpM0wUtwzUTKwb31cVZbmzLHH9/CkKn/rrU2JGZ/S2CVfSmuaZT/O4eIIZTM6QXdTHwKsaXbFNHLaXfsZw8WjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KuTLI/e4rw8UMbyjzDaRsBOuInrsZy4AaAHurzAMwYc=; b=Jm0OBTh3FpHxrpFXU9/V9eE2ZvCTQRpaS5lJOqYq1auMS1msZF/TXTNP5tu/WmUuicofebbDjW/gSVolDmq3hwYpF+n327WIHNISbVMFcXt7LelxM4N6S7VhThpuDbB1Vg2N4Hgo1z/KVi/GS52Oe4XTsKvlSivPQotphn7YOp3LTyREuWaSQtJfx8jjyXQbTT7ZHmEO2em1NhFV1pmadkG4XrHczdx1HjpjsdfFsggmn7lxB6DZbVPTIPQ5yZkIrfcDODTe4uWezLgMebkhx7mcVxtJVcD3DkQZWzfbimGk2X/coot+P3uoe43NfZPwMo/NBO7Up8h4VezKOGRb4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=alien8.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KuTLI/e4rw8UMbyjzDaRsBOuInrsZy4AaAHurzAMwYc=; b=sWifEGm6CmbrjuvtsIT4rI3rUARgvntc55exjKXtSg7xbrJEBsmP70X40TzvF9OGOP3WMSC6oEpGXg8YHyqs3IQ4vK6Gx0mf4CKy9GtnsMSJtZgN1C0deX6FrZ+OkPtxcIQ/fUalaD9YseGzLi/dRzzyxqo6VEGzUSJsh9cUEw4= Received: from BY3PR10CA0008.namprd10.prod.outlook.com (2603:10b6:a03:255::13) by SN7PR12MB6672.namprd12.prod.outlook.com (2603:10b6:806:26c::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.26; Fri, 26 Jan 2024 04:14:46 +0000 Received: from SJ1PEPF00001CE3.namprd05.prod.outlook.com (2603:10b6:a03:255:cafe::9a) by BY3PR10CA0008.outlook.office365.com (2603:10b6:a03:255::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.27 via Frontend Transport; Fri, 26 Jan 2024 04:14:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CE3.mail.protection.outlook.com (10.167.242.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7202.16 via Frontend Transport; Fri, 26 Jan 2024 04:14:46 +0000 Received: from localhost (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 25 Jan 2024 22:14:42 -0600 Date: Thu, 25 Jan 2024 21:44:26 -0600 From: Michael Roth To: Borislav Petkov CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Brijesh Singh , Marc Orr Subject: Re: [PATCH v1 22/26] KVM: SEV: Make AVIC backing, VMSA and VMCB memory allocation SNP safe Message-ID: <20240126034426.f2v6p7sjmaaopwig@amd.com> References: <20231230161954.569267-1-michael.roth@amd.com> <20231230161954.569267-23-michael.roth@amd.com> <20240121115121.GMZa0FOViBESjYbBz7@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240121115121.GMZa0FOViBESjYbBz7@fat_crate.local> X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE3:EE_|SN7PR12MB6672:EE_ X-MS-Office365-Filtering-Correlation-Id: bcef9d13-4e26-47ec-4bb9-08dc1e255496 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zkhqXp9OOlKdenbyecaDpwVqz2w6LzER5rt9/VtD0ulPp5jjf71eJzFM/DDjp2QdNY+RJvh86rhs10oL1upwtafkBOH71fDujFDbfLAF1UbkeZVaH7sUtx8VErvzgom+WOJC4ta0qfj78yAlBkTV/pUyap5eiVh2UGqHyQuAy+vR8Fzmtm4WZ4Q80ysCNEt6HQE9LO3kQrF6YAYv5rnLyFBMzJ7LJF/RH2qYY/MNLb3zguQ7AgO2RUOCSOnqZPBg0lpUJtE/C2THJiaLswOF2yRXEjasYD8eRUq+HcEHWbu7MsdamJjR/lWAu35gOA72tMYN+vvMe8nq1OFTHu7MdCHZau1wR5Rq02HuBr7w7RfykGVypiZUOK4W7Zyt2LHwkxnAa6f5CwARVtS7rR+jugQpuDTWAgrBk/pHyiZv8cBwqCtg/htFetPosmJTltThqWY7Fn5pli7wOeGO1hKUD5nesrKWa8VIGccNOvNBPTRdrRg9L3+58O1p0vFxbJYcND2q6eYrpj6QCvqQdGS6KxviCHgB2V9jAavJ4etX5wLrQ1MlDXicSd3qUz0DuapIeJzp+XWGttsTQGqFrzTiJLLZXvy4mLDbZ6p+zv4aqOUv1VzksqnC04laxKs0u2W8OfLBt3aQ3yYSRenp2coX3TQMF83oJpccYiBZDTAUv9X12QGXSKswAgv/iy8eM7ZKpEdpeYXDVhZFoZzbXh3qflz3adxUCG6tDRjk/RHPe6crqC9J4vB+cY8MdqgAHFwH X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(346002)(39860400002)(376002)(396003)(136003)(230922051799003)(82310400011)(1800799012)(451199024)(186009)(64100799003)(40470700004)(46966006)(36840700001)(40480700001)(40460700003)(966005)(82740400003)(47076005)(478600001)(44832011)(1076003)(6666004)(86362001)(356005)(336012)(36756003)(426003)(2616005)(81166007)(83380400001)(4744005)(54906003)(70206006)(316002)(6916009)(4326008)(8936002)(8676002)(70586007)(36860700001)(7406005)(7416002)(5660300002)(26005)(16526019)(2906002)(41300700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2024 04:14:46.0276 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bcef9d13-4e26-47ec-4bb9-08dc1e255496 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE3.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6672 X-Rspamd-Queue-Id: 4EB51180002 X-Rspam-User: X-Stat-Signature: u65j3bm9s3cqci6pzdrknbputmcut6w5 X-Rspamd-Server: rspam01 X-HE-Tag: 1706242490-687726 X-HE-Meta: U2FsdGVkX1/+Vs8UP/D3IfcZqjRag847aX3WCbW0mCHONRbAiM5Gj2WOKH99DpkNn66/CtyUT9xf6FdP9le81KnBpq64LC2fCPyyxmOMIuRuIfiYpixoFmVH+pbPsn1jHq65xiQ0RSnfBWglhiiFsJmwsQ3+0PKbTcGJN0DQhYX5ZBgGODevwB5BoWUY9uJELccDcYeTXGVkFcG5jy/vew9M3Ly+OchqDWNvTBVdl9jfNo6k8f7e4ht6c8suV8ug3YAP7Z/smFXx4GWWZyxzsSKW+GmjbqZ+rOcCUCKPlIV/p9ogUTVvX9EfFLV0fULV35J3DO7FUT6q0ovqt1nG7QnC5+8SuSFO8fH2eU0iAERaGG6nYgMoFOKLD1kZp7GY3O7GuMaVodthEW9VY3BOsS5AZq0Dt0ygt8tAkddOAY1brQajTzMJavQUty5gpP22OfJP479tJoESugnqVkviw54R0+k0wxDiIU7c7LReGXt3DIJT8UpIHdMmO0j0OINCYS4djIwm8OCIZ04jW88rLzoSK4cq3nHC+Ky8ggm0Yr4eFRdHixdSF5Dw6TMSGydd4W1wb6HApgCpgy6Mb8rMNxQ9POYhQoouHdwItvKM5BEmAUeJ2QKHIiIVJ9syvmY9j9aDFJ3ZYzkNqdEzI9gqJRuKHVTDRPpoARyXZTRDbqlgVLSu6PUOo/ZK+wT/7aT1MTGiSFsK3c+z8+KxAYXYE5nqb9Wb41E3vuDQRwq0Fme7T9bFtoQnugolcXX+1ydFzv28+xpQ5Mjrvz7K0Pmp7dEIVAKLH26IUxvc7LXMKPXqmnlzoByE775qh2qi2Z9e0YAFyBxIk0vhnYdXrup4JSP9nga3HSewspVDVTWueAnnLP6QD8pxIFbmHVxnngA+RenONXbDvN9WJum3CC5D+pqk7DLUAVc6vD+ng2ve+92yzpqfe0mboqWWEbca2gOR1eYU4V4JeyDgFP+1qeH 3YLjkMq8 8IvY3L8+Dt18CYui/wmfrKECQH/NfEm2jw3VJVudbojoO3viJ6VMwB8WPMr3T9pnyjTImO2unIh2Ai3CtJQO+x3qb0T20jExsIFVN1VUDquZGXAAjKIa7XDS1rwUpgPyUIkANMw/dkzYtJWvSN+Grlby14QvoFpPYgMgRYpgH2XNJ/1E7QqXIEtRHbmkAzgdgWsFXuOEJx2ugTe1tSeP3SXITXB3kb5NRyeRLHrOcLmDFFsxGkvGirdj9r5SKhfIGV1AJVS5IbxLqzFkkNJxczrqk4EHemUx0NcOLs/ZfgDX1DyupGXkjzgNz2XcU7gSU+upT/p+A9Y7oOuaFgzFiMfgAscA5FQsjEXWYQ2nUGUn3QdikQ5NxnI+i3ds5xe4/cKIflLe1LeVq5Aoo3w753p0BjhXiKupDAF+x X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jan 21, 2024 at 12:51:21PM +0100, Borislav Petkov wrote: > On Sat, Dec 30, 2023 at 10:19:50AM -0600, Michael Roth wrote: > > arch/x86/include/asm/kvm-x86-ops.h | 1 + > > arch/x86/include/asm/kvm_host.h | 1 + > > arch/x86/kvm/lapic.c | 5 ++++- > > arch/x86/kvm/svm/nested.c | 2 +- > > arch/x86/kvm/svm/sev.c | 32 ++++++++++++++++++++++++++++++ > > arch/x86/kvm/svm/svm.c | 17 +++++++++++++--- > > arch/x86/kvm/svm/svm.h | 1 + > > 7 files changed, 54 insertions(+), 5 deletions(-) > > This one belongs in the second part, the KVM set. If we enable the RMP table (the following patch) without this patch in place, it can still cause crashes for legacy guests. I'd moved it earlier into this part of the series based on Paolo's concerns about that, so my hope was that he'd be willing to give it an Acked-by if needed so it can go through your tree. -Mike > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette