From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F48BC47422 for ; Fri, 26 Jan 2024 04:13:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E59E6B009E; Thu, 25 Jan 2024 23:13:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8939D6B009F; Thu, 25 Jan 2024 23:13:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73D5A6B00A0; Thu, 25 Jan 2024 23:13:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 634436B009E for ; Thu, 25 Jan 2024 23:13:47 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 321E3402FF for ; Fri, 26 Jan 2024 04:13:47 +0000 (UTC) X-FDA: 81720143694.08.61221B1 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2059.outbound.protection.outlook.com [40.107.92.59]) by imf26.hostedemail.com (Postfix) with ESMTP id 5DEC7140004 for ; Fri, 26 Jan 2024 04:13:44 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=yTAm4tuC; spf=pass (imf26.hostedemail.com: domain of Michael.Roth@amd.com designates 40.107.92.59 as permitted sender) smtp.mailfrom=Michael.Roth@amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=quarantine) header.from=amd.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1706242424; a=rsa-sha256; cv=pass; b=UCqjiHz4NwqsdEso2XqPB1Pab5q9xDnmRrKxIcRIHXxpSbh58udL66HCMRLSW1tCM4SWxy XhI9bZy+nIB24nHmNNE7X0Gv6SQ//QzT+RF61kz6ugx6rR8rzVYN/6qF4c3Nu2Iz3bA7TJ CW61cvZ/z5XyHgVGnNScdGooZf1rTJY= ARC-Authentication-Results: i=2; imf26.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=yTAm4tuC; spf=pass (imf26.hostedemail.com: domain of Michael.Roth@amd.com designates 40.107.92.59 as permitted sender) smtp.mailfrom=Michael.Roth@amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=quarantine) header.from=amd.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706242424; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FfHEA9E7gZpwVx73Oys9TdNFY4xCLGTn8/pb7CJVLzk=; b=kQii61jDB9lgy80OCdbVDc1FHgNbejLF5tBtu0R+cFpeV1We9wUIlTnBh3sAFLhjY3BaP7 cYjCzDZUujHR1Ph6wenn7E/LxFH7xKeQCtxjfUQlyW3ckB/HLp2gp8JMnu0ylNqtgKPK4U 6zF65DZ8WvSM9HNSMVqsx+ucRsipVG8= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jwdWdEizj3ouZSuWmVBoHWCq3MueDhXkRD0JDPHJU6sF/NAOt59mo4jryScfvNhGuIBhsq17dEaKrQEtZCOHREdVGhRvbiqzDIGY1AsvjvoWUX9/2kB0/ALbrZ3GXoKxF0NviL2wVB/KarvNXCz/8L7zFGYfBLPsaxuAzKbr1dldVBWmBjuyxPDN4RZ6iQXVhHOVOFecRCRgFil/apiAY/GEGLQ5gFf5wdcXmPAznL3+QbiG1JGGacuJYjcM4lDQa0jZLUWXCcdYY8FzjazM4ovRYPnFsD75ic20ZFsDhlryrlSTj1wzl2elwVopa/YPgIFZde3gcNeMGnRtpP5JMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FfHEA9E7gZpwVx73Oys9TdNFY4xCLGTn8/pb7CJVLzk=; b=BjaVwfoeWc5NC2qWPsKQeYor1EpULdV4qRJ9WaW7FPwXgIjZbw6JcYGatDxwAeNZlql9dbItVc+GR8y2UwAzVGFPzc04YLaypU5SBOiJfmrwciO6DvAjRunZZN65ZPdls8XD7/sKv4Y2HBSARDawa7FN+6Duv3ofJzOimFsk3gFCnk6iT1AIb2IJDu3DUjGt/qnuRMABjPRdOhn1J8YrCdIO8G+hyKyyRDE4Y/5EwbB4ueuweaFO2EKd0vdcLxlo3Q++Vq8NP4cKNzhG9qtTR1n0nTGTNg5NC5Vddd16ZfyAOAtOT0HV3DtN1Rzu7xEIpGbWuCJiBV69fOmHM2kUHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=alien8.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FfHEA9E7gZpwVx73Oys9TdNFY4xCLGTn8/pb7CJVLzk=; b=yTAm4tuCldxyvBViKdL12JuxFu3coQVa7KYiWG51w9Exnz0zWSyMYYMVeyp67P3z1isO0UBk8U2Yd+QeUZatut6UOKjfF7anWytogprMsdNrwrExK9c7zvbDP83L4QSVCwRFF/aqXX0KramAmXXHPt6LjUz1YAl2n6htLnzDZQM= Received: from BY3PR10CA0021.namprd10.prod.outlook.com (2603:10b6:a03:255::26) by IA0PR12MB8205.namprd12.prod.outlook.com (2603:10b6:208:400::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.36; Fri, 26 Jan 2024 04:13:41 +0000 Received: from SJ1PEPF00001CE3.namprd05.prod.outlook.com (2603:10b6:a03:255:cafe::1e) by BY3PR10CA0021.outlook.office365.com (2603:10b6:a03:255::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.22 via Frontend Transport; Fri, 26 Jan 2024 04:13:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CE3.mail.protection.outlook.com (10.167.242.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7202.16 via Frontend Transport; Fri, 26 Jan 2024 04:13:39 +0000 Received: from localhost (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 25 Jan 2024 22:13:38 -0600 Date: Thu, 25 Jan 2024 21:32:22 -0600 From: Michael Roth To: Borislav Petkov CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , "liam.merwick@oracle.com Brijesh Singh" Subject: Re: [PATCH v1 24/26] crypto: ccp: Add the SNP_PLATFORM_STATUS command Message-ID: <20240126033222.roi6j6pqv7s6mk2c@amd.com> References: <20231230161954.569267-1-michael.roth@amd.com> <20231230161954.569267-25-michael.roth@amd.com> <20240121122903.GNZa0OD21W0UxLmOAm@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240121122903.GNZa0OD21W0UxLmOAm@fat_crate.local> X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE3:EE_|IA0PR12MB8205:EE_ X-MS-Office365-Filtering-Correlation-Id: 231d92b8-9de6-4aa3-0c67-08dc1e252cff X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C3COM20xgensVgZQ2nXnJ1SXdG2ejSnXbJ7FGRZ/Y1GPUGxtoSE64XJYr52ZVErYzBExnDtK89XqRcPPHtlJ+RyQ+1W9cs29OAruY4bNDjX5j8iHCWQMICyD+oM85K3fyCTuQF0uWFs5+LxAAkufHLgbLd4hU9UF7nkzOF7OsVPH2p7W1CIk+s7ZDQx2xvq7MDIAEXs5qlAeIVzgN4RRlptybVaxiyjXQKJ9X8yci9e9vdyyFmvlRvY7tZO1t86gb6/11pV6QA3Y1CAy7iprxufIEOVXzNxaTdUvws9/9Y2c/tAQiMPiwuTz0ytZ/SAm5o/9zX8LpiElAzUC5hNTXE9t+eIoDu4SVdTedEvG0KqmPmD/+xWoRnT2SZnwL01PshOyaYvqzkHqMPKm407j+KgrguA51laXz9wT64euJM5oZ44FWQnVSyO8pA1AOh1sIEgf0sViMLcgDU4Tn9KNW85F5rHs52+UsMsh9GZ2qQCI11rFy4z4p6dEtzfK1n/jcgbc4tKkJtMa7a3IfCJ9y69XVBBj7nrO1F+9qcdokg1kX0jRb3EukFRTrip8v4MmntmisGL9YXPo1dhQLnMbdigj7AEx9KT9C6wvwspSwtyeoUxogsGZCcJsV2SFZeiBHSmiT1SHkKqBxZBcYplAI5hLm0WjTMaSLYnz5OSqnOC1kVpIdfLwARyMAQHjhEEnbxHidNfNAWHkLqbUgxq7PDofXkK6ZUNzKZ7LI7+fRxq51YlDUpB+eiEAmmMWAbpC X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(396003)(376002)(346002)(136003)(39860400002)(230922051799003)(451199024)(186009)(64100799003)(1800799012)(82310400011)(46966006)(40470700004)(36840700001)(47076005)(40480700001)(40460700003)(36860700001)(6666004)(966005)(478600001)(356005)(81166007)(82740400003)(336012)(16526019)(2616005)(83380400001)(5660300002)(44832011)(54906003)(7406005)(86362001)(2906002)(70206006)(8936002)(4326008)(8676002)(7416002)(36756003)(26005)(70586007)(316002)(426003)(6916009)(1076003)(41300700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2024 04:13:39.5897 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 231d92b8-9de6-4aa3-0c67-08dc1e252cff X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE3.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8205 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 5DEC7140004 X-Stat-Signature: aet3okpp3qmeba36hm74jjr9o8hg4idq X-Rspam-User: X-HE-Tag: 1706242424-583560 X-HE-Meta: U2FsdGVkX1/5OxzdbAnGgCuqzIt37QLSDJX380eLRXSzaw8rSYF/bgJ/Vn40PXDGwSRCTj8m5Z6VyQRVx+ojsq0b2EReH4tqii61easRAQhhDdjOaJYWFGVa55yE4Lz5gi87h8dnx3cvQGD1Mr+lQvw7RTTGDJD2Weh5wx1BWSJIg6NfMPMKle4kkRWsOOi4UoqlGJHzTHx183/Rw7Nebuc/0Xx0L8WtZT3RDOIHm2bWFVhF7EX34t70BVihOxzilIHDV2BS8N6IROqrx4EcW1yG6jBS0O03Vm7MWjYm6hwlq9mKNDw+ZS6rpnn12toJtTirSYTzfP+pcOSTdtLOria8z4PXORDDRMKXkXp/7Rf+mNmDFqD8Qwr6e0UaVTUCyt/c6RSW5rFuY8YZYdgW6umZA+fbj0QNgE2W/Pgt1fbXXUrsC7KIpFixMKc5Sdp1gvxh7hMu7Vk+DxP/IyWM9CXU+3XnOllR0wB+Mue9fC8m+Uc7KV0ddVGth9KB17K6ZIIdTHPwZLBINxhW5Rhez3OXAnx05VaDX5g3YAfJqx4Kvuxa+bwS51jv9tW5YuYFfOt1DmxysiexLKIlm/3dzuaf8Enwtzgws4tsXZoBwZhjUi9BRkx53rIpAMUa0rttRXmxIGQIVawpgFJACST8evwl+iSL8IkGjMHoYKTR+lQ4VbpUuOXOu2HtM1KXeO+4wuL2ynb+Skepm/JHcRQdsDKtoUQdgB0dzeGP4tHzpWqnnZ85q9n+JNd7wjd+pKoyB4t1UuuPwJbihqRT+K8HA/Xgg8PJKik0L6AtsIN4ogIZObNH29Q3koLViXn6zlDzI7ZoPEgD0qkzQOD0SHUXWxREDo5Ia7KdNvZERu7e9cXCzVeoeOdO1uuL18yVqnaPvugrIFKxohTQZQHftssoXCTcESayHdsMpg1HWO3cUPKWL4CUsy8GxJn2ibiDlyezlQ2gH7X2ebpSA+yHeF7 qFnguLI+ ZDTWKGLaipBPPpMhdzEF8erjVin+3A66/Ym4BbGrBK66f1UjpabqwqYVCvcdMl1ZRxYYamub30uPx2q52loXyQkSP15PzmVQGePtq7An+uFMSljOA6UxOUKLKAWaElRhZRj03pGSn76OSa1XZ6E3XWLlxdR+8kzfRMsFwgmS3t+9dA8Cf8grTqCzeAtyp2jmVOQeTOVwQMYbTm6+IgRRIE8+Gvq6du6IQSsa8C9HLyFrr/hc05pHU+Ez846B0KoUVqr2fuDMiBLkZQ7jm6B9yV0llb/Hbqu/p8kjSEZwpczH8KiErbsQXBMy1BZlfCjfShU6chfTxAY+mrwtlP65bZwbPd5I57uJWgMiSR/O/jq6oYAPbi/Jw8kh+FQ0yvhMtPMlJ1oLqKuVUASBGP61QFc0RWkpYcNz4wkJ/9O9MF6yrw/YsbmEJvjfwLQx7eaQMIjhK2+HBF2I7NSyliHDi2BYglw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jan 21, 2024 at 01:29:20PM +0100, Borislav Petkov wrote: > On Sat, Dec 30, 2023 at 10:19:52AM -0600, Michael Roth wrote: > > + /* Change the page state before accessing it */ > > + if (snp_reclaim_pages(__pa(data), 1, true)) { > > + snp_leak_pages(__pa(data) >> PAGE_SHIFT, 1); > > + return -EFAULT; > > + } > > This looks weird and it doesn't explain why this needs to happen. > SNP_PLATFORM_STATUS text doesn't explain either. > > So, what's up? I've adding some clarifying comment in v2, but the page that firmware writes needs to first be switched to the Firmware-owned state, and after successful completion it will be put in Reclaim state. But it's possible a failure might occur before that transition is made by firmware, maybe the command fails somewhere in the callstack before it even reaches firmware. If that happens the page might still be in firmware-owned state, and need to go through snp_reclaim_pages()/SNP_PAGE_RECLAIM before it can be switched back to Default state. Rather than trying to special-case all these possibilities, it's simpler to just always use snp_reclaim_pages(), which will handle both Reclaim and Firmware-owned pages. However, snp_reclaim_pages() will already leak the page when necessary, so I've dropped that bit. -Mike > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette