From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C272C47422 for ; Fri, 26 Jan 2024 04:13:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 931C76B009A; Thu, 25 Jan 2024 23:13:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E17C6B009B; Thu, 25 Jan 2024 23:13:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 783136B009C; Thu, 25 Jan 2024 23:13:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 608206B009A for ; Thu, 25 Jan 2024 23:13:07 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E83F416012E for ; Fri, 26 Jan 2024 04:13:06 +0000 (UTC) X-FDA: 81720141972.18.5F58CB6 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2040.outbound.protection.outlook.com [40.107.244.40]) by imf16.hostedemail.com (Postfix) with ESMTP id E93BD180006 for ; Fri, 26 Jan 2024 04:13:03 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=QDScF4xs; spf=pass (imf16.hostedemail.com: domain of Michael.Roth@amd.com designates 40.107.244.40 as permitted sender) smtp.mailfrom=Michael.Roth@amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=quarantine) header.from=amd.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706242384; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2aoYMd5BFF3lA5I85qP6E8VmiI1tgcmMTa2P650tSGc=; b=U2KaycBb6PADzti9qzNWMcNMwaNknm+ayITfGRL6FTIp44EOcYnqrbFHeDrrZcLaVXW6sd dKpLgZNYPxTxo5Jl50yGLyVWpvlWGmN8aNBOl403A1s/I+hrgcg2AcmQN1+CF2OK+cNvET guizC6wgP3RsByjK5S0N/1GBF6SBaq0= ARC-Authentication-Results: i=2; imf16.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=QDScF4xs; spf=pass (imf16.hostedemail.com: domain of Michael.Roth@amd.com designates 40.107.244.40 as permitted sender) smtp.mailfrom=Michael.Roth@amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=quarantine) header.from=amd.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1706242384; a=rsa-sha256; cv=pass; b=BPxh418ixbfIQ09orX32SQuQ0t/QqHGcTrcpLc7XcY9IhdA7bZzCOgMM5mCA4LkgMJqsPP +rI+uxiBGrjKAkCDRxNsRzsAKDljJ/hclV8JPAJchU9/vxPniWYjIRUEYatKywrdi53xBm u/+dpkt+niYUBXcbxvI5pnk9B9lt1g0= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hMsYq/LfmVzVD8JLkGFN4ZloqEeSLgBz4X8Omf+1AjS1Ill3veouq3QxmWzLhnGeZUm0Nb1yhRMrkn+pRh/AcaJdVlwCm39uf28XpnilTIcIiUzYFzNxzwazxvhqSOW96DxDncfYHwjTHl9pib7EBXbrWtBsZ4si3t9qcB5mTUHzEaPwn409nOn1M/GG+VFWuBSv0AI2WulH/z9mVb+jKPavAA9aPFkEIeicqrce0Xot6fwjAEm7QcsqP1KbuJV3vDPouPGjBTKjEXWkbjNZJv7eJ3rYQ8yyF4mqL15xdJvFvifbiLzfWcJcJP+fHMV8TBJasBSUQ8g2Ug5JrkonxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2aoYMd5BFF3lA5I85qP6E8VmiI1tgcmMTa2P650tSGc=; b=PInTksBEzY7Yh9Zz408KP9kZ6jQaQOE5hjNaUVKDxObspqoCC4ViJHEmvA9HoE7jU00lpVU5pzdyPupGWIFcKiMeYnWNJUvQHnGtcebmETHT97Cy+PLVFrZYeBJ0GHlTHwII6Me1W59yNLwoljx+MrsVMmMEAL8a2IKe35b6cD4f98Y7c7AbO7x7hvB0e7AmVXRUzK71jwg8WlrsFdOUJMCZh7F7Rrk8DtmntHF7BKCCXqpCA/RdEqmdR3JL3Gs52EiANuMHxhAH8sDnqAgSoOYp5deqa8xfdZGjmN7tFRMmP7wgG1cF2UminQCjT4dJm7czMPr6w4q++yhBDuR6jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=alien8.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2aoYMd5BFF3lA5I85qP6E8VmiI1tgcmMTa2P650tSGc=; b=QDScF4xsK/8z+eTMu6Zp+3WKnM8pnXcbiQLc4hTMphSsubDFY8Vi2fHj0Mau3YppjAiHNwwVBDyXhyuBn2Mbkdj7ZyYao0odQQ7Lve1zkO/+HlHOVhdfWcIG8wOM46qIMyHzIr/kCxe2nPqcq6Ehf8RkMFYbQCGWnGERLkXOQRc= Received: from SJ2PR07CA0023.namprd07.prod.outlook.com (2603:10b6:a03:505::9) by PH0PR12MB7488.namprd12.prod.outlook.com (2603:10b6:510:1e9::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.26; Fri, 26 Jan 2024 04:13:00 +0000 Received: from SJ1PEPF00001CDD.namprd05.prod.outlook.com (2603:10b6:a03:505:cafe::47) by SJ2PR07CA0023.outlook.office365.com (2603:10b6:a03:505::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.27 via Frontend Transport; Fri, 26 Jan 2024 04:13:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CDD.mail.protection.outlook.com (10.167.242.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7202.16 via Frontend Transport; Fri, 26 Jan 2024 04:12:58 +0000 Received: from localhost (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 25 Jan 2024 22:12:57 -0600 Date: Thu, 25 Jan 2024 19:56:19 -0600 From: Michael Roth To: Borislav Petkov CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , "liam.merwick@oracle.com Brijesh Singh" Subject: Re: [PATCH v1 12/26] crypto: ccp: Define the SEV-SNP commands Message-ID: <20240126015619.rjcid65vgo3s27za@amd.com> References: <20231230161954.569267-1-michael.roth@amd.com> <20231230161954.569267-13-michael.roth@amd.com> <20240115094103.GFZaT9r4zX8V_ax8lv@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240115094103.GFZaT9r4zX8V_ax8lv@fat_crate.local> X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CDD:EE_|PH0PR12MB7488:EE_ X-MS-Office365-Filtering-Correlation-Id: 0ec5f402-94c8-4efe-4593-08dc1e25143c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l8X6yHzKrzsEolfGLpWoMnfuis0XOfeD4+LECyxP9eRIvLAejlGDUwiMZ8nDjJ/xKe0Duj29olEJAyiU+wqLNU4NqFAzO1LAa9RhQHEiIMQdrkiCYU2dct20H9faN0NV2yBS4p1vg8wKlE43izapxhkmvZTyjJth1UP8vR6QQaCUmUsp3RngIr8bBs076tacSoNdwOD/zcxdQqVb6lojiSSyArJVjsbY9Idm3xH6VW0beoKjqkF33n+L+fVmW8TJS3zx9qdNqLqhBd4rxBjPhbI9DzlPjEAhcqu/BujdtzoBzVtqxibP0MnlQrkloi/J4HlPyxY5CEzywxv+UQZ2Rs1g6xbSTbtfydf/ESoBcGE0w5cx1czECnrqJQYibdP/SbBMEOG9Hh7DiAUIfFnVj4SAdWWDpv+vuxdKaNCDVbSjQCT9rBdVe9K97M/H8OFjsus4whR8bbw1XLqqM6xn70v7IFIqliuXO8KvxEQRmglDVFRbOp9zSmU25bb5/uw3UKOvzrJDpdm48yQ1435uoClZqSZ0nV7rgBWQe8QhXnSqx1eKTMtjv7T+T6Ofn3zOIUzuq6bnzqm699QY1mwRFmwHPttvCgiAZtlXFb4tGcG5gLSsI1eq5cJ/zeCebFCbrDtc3xGgImkHSNXjWyZNP/XlhiyK27FbjdMwFU9QUZ+39kVr/znr4iAz4TNuChScZQ39n7bRmL9ryMBnd3meDoSVEeNoR2BIcl/715exlkCKvd3FNfdaxyqm+TvmZei9h++H6t+DvNgN8630tZHO2w== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(39860400002)(376002)(346002)(396003)(136003)(230922051799003)(82310400011)(186009)(451199024)(64100799003)(1800799012)(40470700004)(36840700001)(46966006)(83380400001)(41300700001)(1076003)(47076005)(2616005)(16526019)(336012)(26005)(8936002)(82740400003)(356005)(36860700001)(966005)(81166007)(8676002)(7416002)(70586007)(4326008)(5660300002)(7406005)(44832011)(70206006)(426003)(478600001)(2906002)(316002)(54906003)(6916009)(6666004)(36756003)(86362001)(84970400001)(40480700001)(40460700003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2024 04:12:58.0635 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0ec5f402-94c8-4efe-4593-08dc1e25143c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CDD.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7488 X-Rspamd-Queue-Id: E93BD180006 X-Rspam-User: X-Stat-Signature: 5rz1ccagz99x3x84dr31twisjkmp6bph X-Rspamd-Server: rspam01 X-HE-Tag: 1706242383-940325 X-HE-Meta: U2FsdGVkX1+ExWZH05KWABsSx6X2UcQZ7xnSfqgsbrj5i40hOvJSpeRGTB/l158PAkuIaJxVdZFfbWEmC59LX9SbIjN47uqTGEFHb9yYD28VlNXnUiy7/wBYP7jVhUYmUympyBXS3/U0kAJwwJY+Wsbj9CW+heoK9Z5fLx5MBI9ubFjx/Uuq6Yr6FnDa2V53D3DGGJtO/HOFeY6hhoBHO8jdXqW/bmluUTtyAXqDywLKB3+FvZq5XUCgs44JreCEcYaVJ/z8oNjtQggUXaoX5AvWOZB2qJ7tRV3k39fQ2neXL0/Lv4im+FiruUbT/Gjts+ILpZkzCQ/uhPcTu8EjQhFBzx6fciZTBWBIcnsINO3Yom//bVnTnac4nU5geCXcvPkw3AqmVmS34f5aG5ZFUuRC+4jcZA2rlnZpuPhi+74X1WgfWtIirM9z6QxfNKXKwexc1EFQPUZohELRT9UgldRihpVPV63WmFsyCbmkGTzECanx3DdkTg+WNAnJQvS2aLt24DfcFg98JBMi/OXIwf4sOUmG+jmr7B0sbMLR60zdiYEZfjxwwfundX1EWyi9lyXW2dDG94yLLF645KDEnfGLscIl2qcsN5jal6NAiw4xpUrFX3+yoC9GgiMK9dkr3LXwP1Af1CAJm3sqeiXnw9NbhCmasmA03X5zTNfDN2Danks/8mz9XQMIlvyuv+FdWO0H0WAJbKuWs4htQdtlA0tr8eZdnWjEMWPTjzzUswVAGAnNV8996J08q6agc9d9HHUNn9ILJxAlG3+py75mGtjbO24zUjLDgRiYkZ4C9kr5cEG4E5snV90FsrMy8/cEtTMKm7nlKqmK3C0Ta15dQjTO54FIAM4LEFkrXFisrqtKFF3TPkYBPyRXkOgW00oBubvuuFxSzCso6ND3TGhPYIiyHNcsaDWXjXV8mhGZ+63/uy6kf9o6W9O+tIavNGBpzM7TNdUM5gbkiL/wH1d 5GJHP9rs 7gk56QsMo+2gegUs+AXQvGzgkyGF3ZfRHjUNe6KqFwkviuGq4Fa+EOS9zRk5XJ/4dhyF8c3IWyfZYyDY6x9n1srCPUExF9wuirBFjW0T4zDXxfZj6KvVdLeS6Rst+UoN4kBRIXxTSrSieapvOeGY0661FCUMTYwXSpDg3aubEbzI61X4f64o/UnfTAxlgRORysrpmXMCnCgYMECh0KhzU574SCUeXYVZ+iam6H4heCJElspf4BKmYrBAvdmWZwy7xE7Q7k5/qoMg0LMwn/YEpJb7KZk5vpv5Y/7XMQaGiuixSj/19XxsFNKrt7A8yEeycLZnOdOfyh6j+GmohLulXAgqCu/EU8gn2tsIA3kNcDsaJWlYmKlBKYe1tc9mcjN/TsrF9pfCP136MMaX385IyIhChtQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 15, 2024 at 10:41:12AM +0100, Borislav Petkov wrote: > On Sat, Dec 30, 2023 at 10:19:40AM -0600, Michael Roth wrote: > > From: Brijesh Singh > > > > AMD introduced the next generation of SEV called SEV-SNP (Secure Nested > > Paging). SEV-SNP builds upon existing SEV and SEV-ES functionality > > while adding new hardware security protection. > > > > Define the commands and structures used to communicate with the AMD-SP > > when creating and managing the SEV-SNP guests. The SEV-SNP firmware spec > > is available at developer.amd.com/sev. > > > > Co-developed-by: Ashish Kalra > > Signed-off-by: Ashish Kalra > > Signed-off-by: Brijesh Singh > > [mdr: update SNP command list and SNP status struct based on current > > spec, use C99 flexible arrays, fix kernel-doc issues] > > Signed-off-by: Michael Roth > > --- > > drivers/crypto/ccp/sev-dev.c | 16 +++ > > include/linux/psp-sev.h | 264 +++++++++++++++++++++++++++++++++++ > > include/uapi/linux/psp-sev.h | 56 ++++++++ > > 3 files changed, 336 insertions(+) > > More ignored feedback: > > https://lore.kernel.org/r/20231124143630.GKZWC07hjqxkf60ni4@fat_crate.local > > Lemme send it to you as a diff then - it'll work then perhaps. > > diff --git a/include/linux/psp-sev.h b/include/linux/psp-sev.h > index 983d314b5ff5..1a76b5297f03 100644 > --- a/include/linux/psp-sev.h > +++ b/include/linux/psp-sev.h > @@ -104,7 +104,7 @@ enum sev_cmd { > SEV_CMD_SNP_PAGE_RECLAIM = 0x0C7, > SEV_CMD_SNP_PAGE_UNSMASH = 0x0C8, > SEV_CMD_SNP_CONFIG = 0x0C9, > - SEV_CMD_SNP_DOWNLOAD_FIRMWARE_EX = 0x0CA, > + SEV_CMD_SNP_DOWNLOAD_FIRMWARE_EX = 0x0CA, > SEV_CMD_SNP_COMMIT = 0x0CB, > SEV_CMD_SNP_VLEK_LOAD = 0x0CD, > > @@ -624,7 +624,8 @@ enum { > * @gctx_paddr: system physical address of guest context page > * @page_size: page size 0 indicates 4K and 1 indicates 2MB page > * @page_type: encoded page type > - * @imi_page: indicates that this page is part of the IMI of the guest > + * @imi_page: indicates that this page is part of the IMI (Incoming > + * Migration Image) of the guest I'd added it in sev_data_snp_launch_start kernel-doc where you originally mentioned it. I've gone ahead and clarification for all kernel-doc occurances of IMI. -Mike > * @rsvd: reserved > * @rsvd2: reserved > * @address: system physical address of destination page to encrypt > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette