From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92B03C47422 for ; Fri, 26 Jan 2024 06:58:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 23D726B00C2; Fri, 26 Jan 2024 01:58:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1EDAA6B00C3; Fri, 26 Jan 2024 01:58:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B5386B00C4; Fri, 26 Jan 2024 01:58:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EB9C76B00C2 for ; Fri, 26 Jan 2024 01:58:53 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8E68680ECC for ; Fri, 26 Jan 2024 06:58:53 +0000 (UTC) X-FDA: 81720559746.24.6F9BAC2 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf18.hostedemail.com (Postfix) with ESMTP id 036701C0002 for ; Fri, 26 Jan 2024 06:58:50 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=eGjdKbwF; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706252331; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K//+qEtbvSyqWiGx8WtkDRBDbsRbJpInUNmggqit5fk=; b=KH2t8obh3Q8Qw/kmNbClFN4HxF2uhrPVQaHAZTVaqy3VCVDBVWxrqW3NWwceYWl1OFki/K A33aDk7Lrtx8HdBbfQ4vvwsWJWDgoG15J4Lw4IGvoERbELJY0mHZJf63376pocTyc0Un9h 20VXPpdiDSo1ukssWBTEAv8UpRqWtkU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706252331; a=rsa-sha256; cv=none; b=8WDukI81cbF+zAnDSI8CPKrDtDFWP2iDu+dRQZPaMOiRHewofdCeq38GFL4arwPlBpaLgO sTi28WGP/sw5rWef1rLTYAVursJ4FLMIa4kuusnLFR4WrNXcf1mYkO+d78c5oYlMHAZDz0 6C5Ttde3inPViVf8f0uUKgKYvtBEoUg= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=eGjdKbwF; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 76C15CE3602; Fri, 26 Jan 2024 06:53:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8ACD2C433F1; Fri, 26 Jan 2024 06:53:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1706252020; bh=5Yl9F+CzoZAtWpDOn5PuDO6yaUyXOId5gbApjRdJtCg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=eGjdKbwFc9UxRkSyUUzwJbhtW8McrA527Ae/OLxda04DU7du3mvcIO2ZW+Xm7oOIM 8dlvGytlqESnRE+vm5e4nUA918xJjIt0zcKBrYpjmhzP7gV5+yZgOuWGAbBW3BDq5/ nvZf1i1uzI4LLde0Mu4t7fkFM/Jw8AD5Tjv/Yxd4= Date: Thu, 25 Jan 2024 22:53:36 -0800 From: Andrew Morton To: Sergey Senozhatsky Cc: Jiexun Wang , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/madvise: don't forget to leave lazy MMU mode in madvise_cold_or_pageout_pte_range() Message-Id: <20240125225336.6a444c01d9d9812a23a6890b@linux-foundation.org> In-Reply-To: <20240126032608.355899-1-senozhatsky@chromium.org> References: <20230921174101.8e6271422a857af5414ce0a0@linux-foundation.org> <20240126032608.355899-1-senozhatsky@chromium.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: as9gfqn6arnyp8qctushy9x85yiujgxk X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 036701C0002 X-Rspam-User: X-HE-Tag: 1706252330-243358 X-HE-Meta: U2FsdGVkX19iyVcL1Ay6m9j6Ao/WyhGbQ1B88UH51JCvLi+qX6aCtuiXmobT3abIPKY+KjgpuVduDmfvJlo1v9MhtCzJ+afGEOg3irHzU6H0MGKkQwxCGJbuEHf/N3wOL/VPf+KP+A65ezLtLz1ZQPpun7BsR3xaKc8NNyL21WpLp06PCMOKxhLTsjN569RPsFvCCDlZtz5LDnxPuNDnncKE+RKooXxFw4q/geXSWuCQi25JtCPNMYG8vaGBxslwtj9+L9m9rwA/FiioxnmUCkmpjTdbI62joGHkOmhr51mwi081HO4WR7/5GJjvpaWPSA04F8dIdh4eRiklQgbyR2NwmFF+WbsNYZb0u3GKMo6aeIZgv/MOzzhYMOotoSJZGbZFnRfIOEHOpew9kH3ApQXnU3DzxbMG66B0Ql2tkOagBq90lFTft4bZfdvDYKSrNlIbLyhKTUuo5xvNX4muqHl8dXEo/Laqi6IWu/1Wy+6KCl2av3ldHDmQsfcIBgMS+ehG7wgNQ54ssVgHiy/W9V7uMGVdd+69Jcy9iH1nun97/J0tRknxhXND83xolLRuej9PMx7ZbFxeWWzt7tDR5u5/vS4fpPtUBfh+dcMlJ72EDL0dl+mD3ZIWmqh7XEU59C1NeQZzQ7HozGiAvkXyEu2gnMOLXej1SOWFNUR8TNJQt4GEZNoZ1Oxea4aZ3dcwPu7q+eywLSGAZ+BRsu5q+leXnVfhZow/F/YRCFlrvxoHxtM72Ati/PT61rnydisry1edztF3KPoCsz7Q5yrnrm5VMHLRM/VDlo46aNJR1jMe+evaf1q3oCBdTmmK5oXV28kx1r6nMGAGuC9i0jeQIicQMOHbcQ4BF+tHDZnMyhiU/iR1dMOvSFtruA8iup1rXnx+UxueW03R/RabJHylocYwnzY2LklzmZlkUeUSwQPeMViIOQYfAfQpDQOhXLKXKyZAEXzo/g3qlJP77FN neUkdLj8 CBmORPTKuCP2wj7TMXo6FbEDZfYLIcsLebuVAouI1TzTQUQZyt5BKauBm2m21/NYorcLqArIBXNAo0/uBqZfqCScYvGcoA0OFbi87TNzWzw7Jz8iFpwtC3lBsU7/0a0WBkGeOLfSQLfjoHm96zEbl4Zx3EjuyJXrWfBS75c7dll9RvGJBXPH1tVf+l7tGQV+grFEBTL0X3tKmC3HK2lVk4vHclChNZEJGn67eROZ4dyiCcL6a6nD3kiA1fSTgUwzBYnvps+xyCnJXX+rMNdWASZNwnc+OnnIEpeQo5IXiNhmFHgwxF38tGxP4Kr4hdwls5tBu+3/wPCq4Hlo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 26 Jan 2024 12:25:48 +0900 Sergey Senozhatsky wrote: > We need to leave lazy MMU mode before unlocking. What might be the userspace-visible effects of this? > Fixes: b2f557a21bc8 ("mm/madvise: add cond_resched() in madvise_cold_or_pageout_pte_range()" > Signed-off-by: Sergey Senozhatsky I'll add a cc:stable. > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -451,6 +451,7 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd, > if (++batch_count == SWAP_CLUSTER_MAX) { > batch_count = 0; > if (need_resched()) { > + arch_leave_lazy_mmu_mode(); > pte_unmap_unlock(start_pte, ptl); > cond_resched(); > goto restart;