From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30C98C47422 for ; Fri, 26 Jan 2024 04:09:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B7C516B007B; Thu, 25 Jan 2024 23:09:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B2AC36B0098; Thu, 25 Jan 2024 23:09:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1A0C6B0099; Thu, 25 Jan 2024 23:09:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8DEB16B007B for ; Thu, 25 Jan 2024 23:09:40 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0DAD3140E0C for ; Fri, 26 Jan 2024 01:44:04 +0000 (UTC) X-FDA: 81719766408.29.A6E482D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 52F8414001F for ; Fri, 26 Jan 2024 01:44:02 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=mmWYdPED; dmarc=none; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706233442; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=isaim4Uy5m+IymQdNyF/MvtdUfuWxhX3VlYp39PZPYE=; b=j6ZGaHl1X6DmlY3RzY3NhdsDxpH05PY7QhPXzc4kh4pxIl34mMBITRMy6nRs4N2X8cghT/ ODT/hvw+6V1zClTF3sCQXd9he4Br6EEOodnt1uTgVdVECSOu9bjQwDu4mbSS3d4E3L6Lxu MiGyZ0XF6RmdJSgEXTzu77KsxVW8pZM= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=mmWYdPED; dmarc=none; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706233442; a=rsa-sha256; cv=none; b=tMnq5qfMQ/Tup4O85OH1BFeKYDWQX6p2jOixstHThUYWNbni+5G8taQxurdri7ZbAVndGj 0duZ5hJkiiScTMuQaOIwcJm62g6IMho+KiVj/rGqZTJu3DCQ+A+ehWH2rY0bw+NcDMZDuM V5uFLdZDJeHLA5LmIK8XGF6ikwT8yEc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4ED4F62256; Fri, 26 Jan 2024 01:44:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 153C5C433F1; Fri, 26 Jan 2024 01:43:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1706233441; bh=wWiDiMeWoSlCCvhLdyjnd8NOVWU10SYkwMYuvm1Cvwo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mmWYdPEDIXpbLZGTVzSt0GPSULdfPOK/mNSysWrmKiUtTJ1nu601UGe6phcaZjVJO EkvZvMOcdEU+OvqVSKp0y9r74UhZ3NV5yoZKQTSP4yVV1xf0Dwis1BtKPLiy6TCErK 50XiBG7d11gOUz1XTopcBJSsnAbeHgGVY5FaTROk= Date: Thu, 25 Jan 2024 17:43:56 -0800 From: Andrew Morton To: Audra Mitchell Cc: shuah@kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, raquini@redhat.com, Adam Sindelar Subject: Re: [PATCH] selftests/mm: Update va_high_addr_switch.sh to check CPU for la57 flag Message-Id: <20240125174356.199f44f329e137f9a6437648@linux-foundation.org> In-Reply-To: References: <20240119205801.62769-1-audra@redhat.com> <20240121143153.5dcfe26dea53ba0e896dbf85@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 52F8414001F X-Stat-Signature: zaowjxq81njumptj6f8jruk969siswhz X-HE-Tag: 1706233442-720839 X-HE-Meta: U2FsdGVkX18TzOD1p0VVE39iBqNrqfFshzn6tIO6brP/Iypk0hA0lxOj8dz0dDoCjAundixdnlA13tGpnlWjO4z8pZF9XIWmQ0pYLEK4Hnq9hSOjBzTPzMNWiEQUbjU3w+RUsbuldYL+oI+U8VAX6WDrw4orcDoQnmyaRAOKgrqh1bRXgmh0tlZD4XMcr42JhxhX1i1vo0G+bNwTfb2vybiXpECHT75rf8xz3pnvGnLT053nzf+DeBs/AnA8fFd2QTuVEWQeO0NOo5vN6AyuCS8dvCj3l3zTtIn81lgXyhsxnWC17gZT4ZIsNsRM2+9nY2KdBvUurBLfDgbZKv4KtxFoHnLRMQnahkjwzgp8yuQ7ndga9o/5xfk+7OZPWNfgGakQPluZs7GIxcfJUYlWsVHX2qtzBZgWHhaA7d/9CUgrmCjItRuIqJ/BtJt3kAD0kTeL/fbIXBCvTN1W6aNDxVK9VqZex8e9+rO2iEIp8SRox88ub7SBsgH4xCWPNX/NLJ12DNgdVOVBD9fTxQ5CA2LIo64PU51+m/0ifeCHpGbed5xkOqMYrdc/+nU+kce/e09x5cMiMlI2AVko8t4iCrjX5ZNX2B4QB6Il0DjXNFlcuuMHXdfIqPCuXOrihnFK17RPkyksJsXeTy6EP3eGkvj69stFpxTPwtKK4GOA6oDx8+o/NdAe7SLVQHDxJy1SQs58RZ2PPSBr+cdXUttJFAtGiVJxthCOYq4LZv9uCQeXnfYjFsIBV49abI+/veMGdzHYxdXTte3/FY9UvLPSJMR4EELtO30FojnpZeSdD5204oNwHHI7zM+x0gtei8ASe4qJW1mPYT+bF5tIurBsl2e3oEkVG0uz+cbrWAAkU7LIahlq5Pn6ui1b77Z241bKPR0gybcECVUFT0BwpMzSgyuAXGJME/8235+JjJQjI8qxio0YGzXknIyXvVak8bu8h3lUWINh9ta5WE8urvy MWnHZzDp kAj65sjUd4APS3FQyS2bPKVzLOXMmRw8IR2B/1YQ8u9glsHUotbm+fYpzyGpxfI4o6XhEXql7loeTJbna8TA7cFYXVVoP0YQT7zawKGAOXGGFGKCOV27tFBYadVscRY3YlQWEUF4RSCIxGOZsYhMQ7DEi/iAv8tz5YH5qgTswOPstnH9pQas6omRQan0r5zvWoLbaAen2J+67dJrUUYX59tIpX405CDNa0R0JjR/c7yLKJvLotEISlHKKFsRR2jbDlxfExIP2Bh5NjrGwkbwkBTHnItMJ51Uh3t0UWHldNdeX0rM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 24 Jan 2024 08:39:33 -0500 Audra Mitchell wrote: > > A more complete description of these "test failures" would be helpful > > please. > > > > Hey, sorry for the incomplete description. The test does a series of mmap > calls including three using the MAP_FIXED flag and specifying an address that > is 1<<47 or 1<<48. These addresses are only available if you are using level 5 > page tables, which requires both the CPU to have the capabiltiy (la57 flag) > and the kernel to be configured. Currently the test only checks for the kernel > configuration option, so this test can still report a false positive. Here are > the three failing lines: > > $ ./va_high_addr_switch | grep FAILED > mmap(ADDR_SWITCH_HINT, 2 * PAGE_SIZE, MAP_FIXED): 0xffffffffffffffff - FAILED > mmap(HIGH_ADDR, MAP_FIXED): 0xffffffffffffffff - FAILED > mmap(ADDR_SWITCH_HINT, 2 * PAGE_SIZE, MAP_FIXED): 0xffffffffffffffff - FAILED > > I thought (for about a second) refactoring the test so that these three mmap > calls will only be run on systems with the level 5 page tables available, but > the whole point of the test is to check the level 5 feature... > > If you would like me to also update the description on the patch let me know > and I'll update it and resubmit. Thanks! I pasted the above into the changelog, thanks.