linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Audra Mitchell <audra@redhat.com>
Cc: shuah@kernel.org, linux-kselftest@vger.kernel.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	raquini@redhat.com, Adam Sindelar <adam@wowsignal.io>
Subject: Re: [PATCH] selftests/mm: Update va_high_addr_switch.sh to check CPU for la57 flag
Date: Thu, 25 Jan 2024 17:43:56 -0800	[thread overview]
Message-ID: <20240125174356.199f44f329e137f9a6437648@linux-foundation.org> (raw)
In-Reply-To: <ZbETFZX33L2ELujO@fedora>

On Wed, 24 Jan 2024 08:39:33 -0500 Audra Mitchell <audra@redhat.com> wrote:

> > A more complete description of these "test failures" would be helpful
> > please.
> > 
> 
> Hey, sorry for the incomplete description. The test does a series of mmap
> calls including three using the MAP_FIXED flag and specifying an address that
> is 1<<47 or 1<<48. These addresses are only available if you are using level 5
> page tables, which requires both the CPU to have the capabiltiy (la57 flag)
> and the kernel to be configured. Currently the test only checks for the kernel
> configuration option, so this test can still report a false positive. Here are
> the three failing lines:
> 
> $ ./va_high_addr_switch | grep FAILED
> mmap(ADDR_SWITCH_HINT, 2 * PAGE_SIZE, MAP_FIXED): 0xffffffffffffffff - FAILED
> mmap(HIGH_ADDR, MAP_FIXED): 0xffffffffffffffff - FAILED
> mmap(ADDR_SWITCH_HINT, 2 * PAGE_SIZE, MAP_FIXED): 0xffffffffffffffff - FAILED
> 
> I thought (for about a second) refactoring the test so that these three mmap
> calls will only be run on systems with the level 5 page tables available, but
> the whole point of the test is to check the level 5 feature...
> 
> If you would like me to also update the description on the patch let me know
> and I'll update it and resubmit. Thanks!

I pasted the above into the changelog, thanks.


      reply	other threads:[~2024-01-26  4:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-19 20:58 Audra Mitchell
2024-01-21 22:31 ` Andrew Morton
2024-01-24 13:39   ` Audra Mitchell
2024-01-26  1:43     ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240125174356.199f44f329e137f9a6437648@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=adam@wowsignal.io \
    --cc=audra@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=raquini@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox