From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06755C48260 for ; Thu, 25 Jan 2024 16:43:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95ADF6B007B; Thu, 25 Jan 2024 11:43:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 90ADF6B007E; Thu, 25 Jan 2024 11:43:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FC956B0099; Thu, 25 Jan 2024 11:43:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6DA326B007B for ; Thu, 25 Jan 2024 11:43:24 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4BF041C1869 for ; Thu, 25 Jan 2024 16:43:24 +0000 (UTC) X-FDA: 81718403928.17.D782980 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf15.hostedemail.com (Postfix) with ESMTP id 916FFA000C for ; Thu, 25 Jan 2024 16:43:22 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706201002; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sJlbLFwFZ82BrxHaABwdnVINM7HdR/JOb3sQoajXNFk=; b=7PWWoGJH98ZUluLfgdbdUkfkRQiKjdkdJ/e5FSfe+DKQ8xjD/fu9taBjeCgyCcDJIcj2t6 OPxvGcBqmZRlsBgiaPQJJkSb02aUdcuHwArTbPDH5++7vjuPLFwZiel6hwkMIlmyBtQGlJ u07KgqzL4m1gYGy/H3x6WlwvMtrie0k= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706201002; a=rsa-sha256; cv=none; b=y0GB5vTd27UsdS9K77zpZ/sllxrJtamFoQRAlrhsCWMb8ty93W0mMG3oI4kpObqvFOWvqi tYvr2NHWjgviYFasfaLtYrY1HKFrDFOK0gc+FQSTQ65XjdHuN3jWpJVOV0KsT91yol78rO ZjgJ5duJNJ5+XCITs6j1z3VJovsrCzM= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2BBFC150C; Thu, 25 Jan 2024 08:44:06 -0800 (PST) Received: from e121798.cable.virginm.net (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3BDCC3F5A1; Thu, 25 Jan 2024 08:43:16 -0800 (PST) From: Alexandru Elisei To: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com Cc: pcc@google.com, steven.price@arm.com, anshuman.khandual@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH RFC v3 06/35] mm: cma: Make CMA_ALLOC_SUCCESS/FAIL count the number of pages Date: Thu, 25 Jan 2024 16:42:27 +0000 Message-Id: <20240125164256.4147-7-alexandru.elisei@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240125164256.4147-1-alexandru.elisei@arm.com> References: <20240125164256.4147-1-alexandru.elisei@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 916FFA000C X-Rspam-User: X-Stat-Signature: zf35nes8t81r6nwq889r4i19qqdhjn1o X-Rspamd-Server: rspam01 X-HE-Tag: 1706201002-414733 X-HE-Meta: U2FsdGVkX1/XgQXRfJMxq2xIlviIoFjbY4B7brsJlgOSCU0q9Dp5/sG9lzFp+DbkRiKkzqDT+MYtCEHzQoUdnRu4o/TlrsVF2rLTFPGjYfiHIzF3fSc8qBsXvgEdHMCz6k3mBiV+ZX+SugdmdJmRcsgsgiUG5lfCaZG/UDj+smNoaalZL64SIMEk3em3wU+qbhf9i+L0aZMG6tKGyIrJ88wltcPW1i6WcF0/iWTlWafoJr6cYM5KXgv1nC2P/u7KMNYTGKmaIp6e/0uYlZL5NuLRMUPxie6JxbmJSPi9TND7UQ9aBy093WR8t4Pzi1f8SsDOTsla2hK0zRr7UeeLDuPRTwrzq+qfraol8/oc22OzLJ3wQSvtb5uIcEAKaSDdxnpXQDgFWQshBE8vjzuS2Cj0PANaFpGCPj/kkomqo1WdXRVHwmedjyo5xfUMLqlMY7/qLNVlwD7Ur2H2BJI5ORqd0SbKBKvDHAja1NF06XnLmluDC3UvAK1ZDKO686a2/1C8moncVrSRqTGZ5kb4eCHe3qH162LtZfYJrfBFviRqD5mN8UfRu9nog528Y2CnIhs+s7bYTHSUwpMMLjjEopyEqSi9cCMsL2E8c98T8h2Ju8gJ11jfOvuwtpL/PzqFdkQ+9hvSjW+SsWnM01nRUKBiIs/qiUoLRO2xT74T51xX5y1FVNkPMb/kaeqYCc2pZbzUdatpsufVfxNoaQkMUvZCaXU+KDZY88zG5HV3r1xTv/esQMGRr/eHYkTrelQS333LNAWWHW1q10L7Fs4hfXUAAwiGfTNKxOlN9fvQVeivNoo9BHKO8WAXgPmhnGPe3JKgZfkc8Lq5N0l3TbwCRlP9AuEi4Av7VBmN7+nNQ9IKdjHZ8VhMxwZzT+l2Qs3ohlcL+/6A65k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The CMA_ALLOC_SUCCESS, respectively CMA_ALLOC_FAIL, are increased by one after each cma_alloc() function call. This is done even though cma_alloc() can allocate an arbitrary number of CMA pages. When looking at /proc/vmstat, the number of successful (or failed) cma_alloc() calls doesn't tell much with regards to how many CMA pages were allocated via cma_alloc() versus via the page allocator (regular allocation request or PCP lists refill). This can also be rather confusing to a user who isn't familiar with the code, since the unit of measurement for nr_free_cma is the number of pages, but cma_alloc_success and cma_alloc_fail count the number of cma_alloc() function calls. Let's make this consistent, and arguably more useful, by having CMA_ALLOC_SUCCESS count the number of successfully allocated CMA pages, and CMA_ALLOC_FAIL count the number of pages the cma_alloc() failed to allocate. For users that wish to track the number of cma_alloc() calls, there are tracepoints for that already implemented. Signed-off-by: Alexandru Elisei --- mm/cma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/cma.c b/mm/cma.c index f49c95f8ee37..dbf7fe8cb1bd 100644 --- a/mm/cma.c +++ b/mm/cma.c @@ -517,10 +517,10 @@ struct page *cma_alloc(struct cma *cma, unsigned long count, pr_debug("%s(): returned %p\n", __func__, page); out: if (page) { - count_vm_event(CMA_ALLOC_SUCCESS); + count_vm_events(CMA_ALLOC_SUCCESS, count); cma_sysfs_account_success_pages(cma, count); } else { - count_vm_event(CMA_ALLOC_FAIL); + count_vm_events(CMA_ALLOC_FAIL, count); if (cma) cma_sysfs_account_fail_pages(cma, count); } -- 2.43.0