From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2862C47422 for ; Thu, 25 Jan 2024 16:45:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A04C6B00A7; Thu, 25 Jan 2024 11:45:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 64F066B00A8; Thu, 25 Jan 2024 11:45:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A0076B00A9; Thu, 25 Jan 2024 11:45:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 33F776B00A7 for ; Thu, 25 Jan 2024 11:45:26 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id F055D1404E9 for ; Thu, 25 Jan 2024 16:45:25 +0000 (UTC) X-FDA: 81718409010.10.21AC171 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf01.hostedemail.com (Postfix) with ESMTP id D688140023 for ; Thu, 25 Jan 2024 16:45:23 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706201124; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=loubURgXZSCdTWE+xpQRByZLITqEZMmk9LYVAauFzxg=; b=DL4TllMvzUdR/4SiAlTmjvXBFU4iQCfw8qoQZsN72gBTkpD3QvFZ3fupxb+Tv6otgDHdWu FMFjprHlMWcqMcUlwfFtM+n2to+UDudnj1ruZRXu7ManTn8GWf0nYkvm688UFpNb3QQHtR g7DvQbHbomDCz64L0dTS1PTJBczTKbA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706201124; a=rsa-sha256; cv=none; b=T9PzANzAyIt3i55ozLT0zNYlQJQKVZwZdPuGNOVB4LDo8CduNWuMaXHuLumdI5teTawatE eHMDER+uZXEcTOGCTLja1J2Z3sSJB0KKfGTTh839eHFzQtIDxEgu6mS9/GiQuQct799yIu N0CSJeqGM0b7ACThDiJ2zrAI770Vms0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7EA3516A3; Thu, 25 Jan 2024 08:46:07 -0800 (PST) Received: from e121798.cable.virginm.net (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 963B83F5A1; Thu, 25 Jan 2024 08:45:17 -0800 (PST) From: Alexandru Elisei To: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com Cc: pcc@google.com, steven.price@arm.com, anshuman.khandual@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH RFC v3 27/35] arm64: mte: Handle tag storage pages mapped in an MTE VMA Date: Thu, 25 Jan 2024 16:42:48 +0000 Message-Id: <20240125164256.4147-28-alexandru.elisei@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240125164256.4147-1-alexandru.elisei@arm.com> References: <20240125164256.4147-1-alexandru.elisei@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: D688140023 X-Rspam-User: X-Stat-Signature: z14nn6zae4zt9ncheatzweptjomyffgb X-Rspamd-Server: rspam03 X-HE-Tag: 1706201123-580200 X-HE-Meta: U2FsdGVkX1+dp66kcB6zCGi2ezU6aCJjBg0Kg3BijS3vN8l4FQ4STucLW+TvUU3fK8Y3rHegw/1wAAME7YHF0BNJ26su5YF3gMF4RZqeOabl7EEzLRfhiK6QDbeEpgAtejGwduK67TQRePUeIEoPiWg80aI1C0mZMjarBnfuhItwHy9JXfRD2vZTDkl5MbVFGFjygrzAHuqBKRF36bmXms5GDQtS5RERdGtvZnzpzRQB+2dSd29xvaJNmsg9tXa3x7S3K2LPNmF6s1zQ10sgrX3v4bGURyoMSY/YBUHwBfUUwJ7WBanNyz9BVqybB7vbPmJE8TS6kzcO/JxIKL0Lu0eJB1Lf5Ht0rvinoH/STnqxdhiO2l7TkA9fiAkiMW8dOgT5TMQ/tO8SjOoqtvm5ixziEKLOFBrFHag8I5IoWqHBOuEDQPr4AvbwLff32nd0QKUtb/aK5NwV+SfDzykxorepwHJby7dwfxPc0KqNdzD8LaGUWSWFzEayFYTcgU9o5fEqttZ5HeG9ucrnL3N1sICUSN6QR7lokZ2ez9r4UPwEz1kzKRfKC3x6211XUi1VfHBItcHy/Ikb8qfdIrlwaNC/Epa1S7oaeiBe2oIyLwsUg0hO0Sf4AHPXv+nJN3AIPXkcNH+X916L4WBRPPz8ouoyic+y7dllmPe3KMXTUQcjj0FTVnTh5voNe7L/5pzjtOCw9ojXWFn69J0ESHI3M9tBesFk7bW8drpI68xRdpZ5DN8otCJ4WG/l4+EfGDCQQhsNl50y2ZD6Bnnzv8StKofFCcaFYjWStzT3wF7JV7v726/bciOq4jL43t6UEjpLCqaJCJDJ2VymYvMSOMQeukNrRLnq/5JP2nXejuptsebwcam1SP5xmTaAEwuzcQIG9bwYzHy9Ww/P60ZS2xxBqzbpabw6qA3PL8ypgxHnt2kSO2Bni9/9pZ3CJ1k+HpfjgChs+aPEiflyMRpZxb3 2vAAUeWe 73w7zwC5p634Xj+O48b7++fApZu8yMk8RqArcqcPwIq0DZXrr7LEM6oDoiH/ulQ8gEsrsJBpi5/sFf0GIsfzo9xc25Mwi4KkMmIg3JhRSPzplLN/6bsDiWGtaNv7mw0edjZ/DnZhnIXUie1lbBDILgUNd2ITPCwcYJrfj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Tag stoarge pages cannot be tagged. When such a page is mapped in a MTE-enabled VMA, migrate it out directly and don't try to reserve tag storage for it. Signed-off-by: Alexandru Elisei --- arch/arm64/include/asm/mte_tag_storage.h | 1 + arch/arm64/kernel/mte_tag_storage.c | 15 +++++++++++++++ arch/arm64/mm/fault.c | 11 +++++++++-- 3 files changed, 25 insertions(+), 2 deletions(-) diff --git a/arch/arm64/include/asm/mte_tag_storage.h b/arch/arm64/include/asm/mte_tag_storage.h index 6d0f6ffcfdd6..50bdae94cf71 100644 --- a/arch/arm64/include/asm/mte_tag_storage.h +++ b/arch/arm64/include/asm/mte_tag_storage.h @@ -32,6 +32,7 @@ int reserve_tag_storage(struct page *page, int order, gfp_t gfp); void free_tag_storage(struct page *page, int order); bool page_tag_storage_reserved(struct page *page); +bool page_is_tag_storage(struct page *page); vm_fault_t handle_folio_missing_tag_storage(struct folio *folio, struct vm_fault *vmf, bool *map_pte); diff --git a/arch/arm64/kernel/mte_tag_storage.c b/arch/arm64/kernel/mte_tag_storage.c index 1c8469781870..afe2bb754879 100644 --- a/arch/arm64/kernel/mte_tag_storage.c +++ b/arch/arm64/kernel/mte_tag_storage.c @@ -492,6 +492,21 @@ bool page_tag_storage_reserved(struct page *page) return test_bit(PG_tag_storage_reserved, &page->flags); } +bool page_is_tag_storage(struct page *page) +{ + unsigned long pfn = page_to_pfn(page); + struct range *tag_range; + int i; + + for (i = 0; i < num_tag_regions; i++) { + tag_range = &tag_regions[i].tag_range; + if (tag_range->start <= pfn && pfn <= tag_range->end) + return true; + } + + return false; +} + int reserve_tag_storage(struct page *page, int order, gfp_t gfp) { unsigned long start_block, end_block; diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c index 1db3adb6499f..01450ab91a87 100644 --- a/arch/arm64/mm/fault.c +++ b/arch/arm64/mm/fault.c @@ -1014,6 +1014,7 @@ static int replace_folio_with_tagged(struct folio *folio) vm_fault_t handle_folio_missing_tag_storage(struct folio *folio, struct vm_fault *vmf, bool *map_pte) { + bool is_tag_storage = page_is_tag_storage(folio_page(folio, 0)); struct vm_area_struct *vma = vmf->vma; int ret = 0; @@ -1033,12 +1034,18 @@ vm_fault_t handle_folio_missing_tag_storage(struct folio *folio, struct vm_fault if (unlikely(is_migrate_isolate_page(folio_page(folio, 0)))) goto out_retry; - ret = reserve_tag_storage(folio_page(folio, 0), folio_order(folio), GFP_HIGHUSER_MOVABLE); - if (ret) { + if (!is_tag_storage) { + ret = reserve_tag_storage(folio_page(folio, 0), folio_order(folio), + GFP_HIGHUSER_MOVABLE); + if (!ret) + goto out_map; + /* replace_folio_with_tagged() is expensive, try to avoid it. */ if (fault_flag_allow_retry_first(vmf->flags)) goto out_retry; + } + if (ret || is_tag_storage) { replace_folio_with_tagged(folio); return 0; } -- 2.43.0