From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 680A4C46CD2 for ; Wed, 24 Jan 2024 15:48:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5282E6B006E; Wed, 24 Jan 2024 10:48:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B0A76B0071; Wed, 24 Jan 2024 10:48:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DC776B0072; Wed, 24 Jan 2024 10:48:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 18A976B006E for ; Wed, 24 Jan 2024 10:48:08 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 67F13C06F8 for ; Wed, 24 Jan 2024 15:48:07 +0000 (UTC) X-FDA: 81714635814.27.0F961A1 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf18.hostedemail.com (Postfix) with ESMTP id F0F1A1C0013 for ; Wed, 24 Jan 2024 15:48:02 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b="kODYqAT/"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=JfpDIgOa; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf18.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706111283; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7v4k+dArpkcWJo3C8YkOs16QSuG+gLYdH7aSjeg8rO8=; b=LptbnvztwK3vaArhVexib9ljuDE3Vyj72y9VW6rN3NISDG65+cixcmmu6Nx68jv+RIyNvY AcIjhhHxz31nSt6XND+vq9ghPElw+/afnDtFETK5uhFODlz7gnS5+gEBuLclyziyJiN7Sc k5SqIkjWTw+SoNNqW6S7VflrE/qOk2U= ARC-Authentication-Results: i=2; imf18.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b="kODYqAT/"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=JfpDIgOa; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf18.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1706111283; a=rsa-sha256; cv=pass; b=jkkQLGKbuXLuLPFZlJ3gJA403AogyjumFFpmOgzHqUy1wg/M+UY5rUDkJbfXX9g+hzj5Mj 9bGBswQXyuByMif42dZZoeTi/SfdwXeJSs0WCD1iiUvJP9Za8DKH7P48S6IL7CdSaLm2L+ S1Ljbm9a60MKUG+gFy/YPT7u93qHftA= Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 40OEtvIt026118; Wed, 24 Jan 2024 15:48:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2023-11-20; bh=7v4k+dArpkcWJo3C8YkOs16QSuG+gLYdH7aSjeg8rO8=; b=kODYqAT/gx+ICdebR6AtMBJbJAMJeGWkBU/qHmq2rI2gc2ApS7OZ2DgDPQeDKyjb/13N YLP9lbt7F9hKibQimoAEFfNwXl2I4YQ06ae5RW4PkBMcqirt4SVlztkijq13xk6g0r34 +Z4bkEqS8JQb04T4V0jhGEMg7W/aaIMzipEPat2eRtemTsGnXIM/Uw4y0j/MSgA4sT6T Iiqd4DhYI+aa7GDxdP+0UkzgkRyMEwCiAPPVNgGh6psYTAZIXC1PHft2uY5SLuKsbB+r S3o1zDYFacTp/e+I3D4Kob4/OhZ7DZ6NnZIxcPc3hvWvlgfRn1b0N2z63BHrQqDN2PXx 7Q== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3vr7n841u5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Jan 2024 15:48:01 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 40OEfCNh029468; Wed, 24 Jan 2024 15:48:00 GMT Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04lp2041.outbound.protection.outlook.com [104.47.73.41]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3vs33v4hvh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Jan 2024 15:48:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QdSrj2tZC3ZVAfnHV5GSm28a/AfoAvbhlP+Dv0k3gy/+wRtwsnrDK0CeU+PJ9wszti1l0ZZC6zFVuFbUPdh+MJkS9ZR5BC2CEtNoxjQf7Wbd7UJq2IcgFv9nhShlyxgP+sjfalDt8n+HlSTdqhxsf6uQqlRUT2Vis2OYYB8Dui+h+b78m7oW6kvSaeJMHYf2nyZeFIBxVMmSCkyhvoykW0HesLF1Q/Inlb2DC91UpB0DN9zZ3XEV5i/OuzTiXAfLLZnt4GlnCz+5K7779wWNjU+0MhHysG6Qmcxib1o5LJGWL0pfDKQ+lAOtZ2DHSW6s3YJbfodOy5AULNAoLEaxsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7v4k+dArpkcWJo3C8YkOs16QSuG+gLYdH7aSjeg8rO8=; b=e5J1u5lKipTsd5Ryj+gAiD9jd0mGSGD2TdLKjo+2YL+RbdVXXR566krQ9DkoaQ+u1+EGQAwFk/E+w3coserKgYN+mBwWlGJupCYq2+BcRWP+rSFQbRqfXJkve1DDqh8OoTLGfJU7mBTiI5xRrJLNVr8xNNaUt2vj/UBiim/EG+nkD50jbYSeVA72VHuPa7Y93/5Dp+9/NVa5hE1H5WJdR6o4yVg2PvOP9etS20tsvo9vtpNvrEV9HRQhSWxXEiVOvRjp49IiAxa3sTLDZXmBjM01pKbHkhhM84mqaoGKCxfFOC/vavECRBPav5o6BFQTkyy4aHmVYnFcN/0QnpADrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7v4k+dArpkcWJo3C8YkOs16QSuG+gLYdH7aSjeg8rO8=; b=JfpDIgOaXKpL076QB62IbB89qUQ2I0EWJffytyQge4Y5IJlNSy/xrcsdQbRjELR/0i/GjsGYssm1y3zXWznMeaeN9dQfrQ94Tw5PnBNpF2GnrGCtDgjKlicNXDAkmEQiGehg+K7fPMGE/jh4MGrAoi/zBQu73pXAqArwjkXel9Q= Received: from DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) by DS7PR10MB4848.namprd10.prod.outlook.com (2603:10b6:5:3a2::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.22; Wed, 24 Jan 2024 15:47:58 +0000 Received: from DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::20c8:7efa:f9a8:7606]) by DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::20c8:7efa:f9a8:7606%4]) with mapi id 15.20.7228.022; Wed, 24 Jan 2024 15:47:58 +0000 Date: Wed, 24 Jan 2024 10:47:56 -0500 From: "Liam R. Howlett" To: Yajun Deng Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/mmap: introduce vma_set_range() Message-ID: <20240124154756.edja2u2rjzlm23vy@revolver> Mail-Followup-To: "Liam R. Howlett" , Yajun Deng , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240124035719.3685193-1-yajun.deng@linux.dev> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240124035719.3685193-1-yajun.deng@linux.dev> User-Agent: NeoMutt/20220429 X-ClientProxiedBy: YT4PR01CA0438.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:10d::9) To DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB7933:EE_|DS7PR10MB4848:EE_ X-MS-Office365-Filtering-Correlation-Id: c3082955-61fb-480c-4161-08dc1cf3d63c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sqbPduAMR9LCZkmz5cTVvZj8ctcwtyEbc37Q/iL5oXjRGWC4zmLaUSPIOn8EmD02nlXusVnHSjClFbvfzZtoTTibMpDnDRX/VrHeEWyM/1fDtfh1w0ZiKoLZe/sI4jbD15rRkT0UguR9S+/LJjOYG2gIe+jh3Ea4FzXyUWsAJjG2gff3DPQ7J8xg2cpfpAQ3jdvoImUzM8/yHHFIxoFS13/kFjhJv76F/li88hmNdNWcYFewhGrrqf3HI9QogNayl0OH6gn5Dw/7Bda5Tds0apIZhgknvG+uCn9XlxXhqEVm56T2D3POi3lv5cQFOFyjkwV4CSLOZKoV44KinZ38ackljftTmrgM8sq3qKG1STDG/lC/siIutPHe9dvV65GSldfUdRp4E+hdMda0JhbBv2jE0Hse1/pq6Bhqkm0ys7QDUSchzx4xxPcus3+Y1886blz6NCalsoQzPAmPzumW5/xZF50jYBi2OdYDXZQ/EsJWLgHKfUcfVfOjVduHHCXB363S80zCmD26bMxxd807d5cBVDcYM+HInymNChIHaoU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB7933.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(7916004)(39860400002)(366004)(376002)(396003)(136003)(346002)(230922051799003)(1800799012)(186009)(451199024)(64100799003)(41300700001)(33716001)(26005)(1076003)(478600001)(6506007)(6512007)(9686003)(83380400001)(38100700002)(6916009)(316002)(966005)(5660300002)(6486002)(2906002)(66476007)(66556008)(66946007)(86362001)(8936002)(4326008)(8676002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NkFJhX0kam1hdB9cbquM2rCqSAG/plaRqZSs6l/0Q4z84krMZMKfNmnWx60v?= =?us-ascii?Q?hpoipBxP1VXSVNyW6HFslpzZGC8itEhvBznKLxqaGHXbe61WaxMPooBrItq/?= =?us-ascii?Q?aOmWmdEbFtxnMlNApPxgI2VJK4o7xlCiy/RzEb3PmhOlg4OKDBLqvY47djc8?= =?us-ascii?Q?7ByQkwBunaejhrMvKngiivBd3l3ZuYCdlGXQzEtDoIysIQXwwBBnUsXnyTcJ?= =?us-ascii?Q?kuFJJtxiR5xJGHBaamB30vFBZVbc5diP7gWoWpI6v+90fJB4stI5PL/5tI9x?= =?us-ascii?Q?N74hhQzCC8g1OrTtrDt/xjBzVFbZree4gWGLLu43vnW2WIoMzKGrP0OZWjEd?= =?us-ascii?Q?SCM3Izi/tiHRc9/0V+PYWCaa/piwKe/Zvi+yRkAyahpwHd++phiACByiYWqQ?= =?us-ascii?Q?/n6Kc/s/lWsCVn1q2SrDsMH/ZqWUK27lQjCl8TlVJb86+6h4QxcRCBA9gMCI?= =?us-ascii?Q?UCIo4auXf53IzyDx0gZQVbC/wz290+Q6d5c0kMZ20lb+724tQE+QGR8GeJdy?= =?us-ascii?Q?4uWym6a3zCHWfdeIL4H/QJAZkrTRIw05EaR12Eg7VGRdKlreHhLmLsKtNiNC?= =?us-ascii?Q?9DxR6z62xzIzMSm15H2Jz6gRXb4rhkjtPp3IuyF5J6i7hN6v1lv02LEJKGqm?= =?us-ascii?Q?E7Cmz1bZUwnCyacTWdC2Ph0sdwobY7OQDiiF5Ycco/i1GUig3lAy2QFjcSZ+?= =?us-ascii?Q?KM/HQMhgzUzLU7DpewEY2VqpnH4Vo9BuTaPJeMHbdgRHFSBOdRvHhpVflen6?= =?us-ascii?Q?KaGVKp5E6RAvraNvkg1u+YbIsEjxnXkurl54v7yrlK1iZVjWiGrKKwHsgtgy?= =?us-ascii?Q?TIScbvLcLor88b/gZZ8Lf2jOzSmdaSJPQgg/R2QB3dH5GEryq5HvhQn4QRwD?= =?us-ascii?Q?Yf/idq2rDtV33GgVCAcaxgPzCw5qfFQAkwEU00YB10xSgJjOlztMoVIBU4EO?= =?us-ascii?Q?7q9tiFA/vUKVay1Iu19IYv/9j0isDpjGLFDZ7WxO2Ko0N11vmJs1/V2A50hs?= =?us-ascii?Q?iCAzde9bJjYea7zmO0QcujsFEOlVLL1zWEK4NIN7C0hBHDBW0f768Tq3WUEX?= =?us-ascii?Q?VM5Qm2NK1hmD9/TfLt1TjJJjYEL+ZpqkdojKnho6kphkfrQdBi5eiOz3e+He?= =?us-ascii?Q?JFVOm9Rgn+YMp4bJHSEGEjA+jpNyLvSNknXC9Ha6qTcGPyCFIu+7O/ocmwN3?= =?us-ascii?Q?MQiNQLRH+q18/wH/O1mXaM3fKCmNlsFBnnf6EeIAx/a5NfGka/V0lvDI35vq?= =?us-ascii?Q?JAEJIoOGt/fRiKOpF6dMeXwYralzCYJ/8Oa5XX8FNCcXfd/zFvyDTuTIVgpA?= =?us-ascii?Q?eON+jkFFhmTcABHL8oQB09l88By7XX6Io0v9+QyadOO5FvXB0voHbFK9Xr8Z?= =?us-ascii?Q?vCs+q7FSGafldc79cIk15B7HogjsuFJ6caOR9XvZP6KIXYiAMkF4eOtDzhjs?= =?us-ascii?Q?46v5pHHdne0jH72Pr1Mf54bHNe9POVkFdda/+MmJonSpaEtju/C1NAy+391H?= =?us-ascii?Q?LWFhIScWlkRtPACKDtYZJNY33bqcScympjv7L8Ug0SXdeqJOeNtjhu7fvGGL?= =?us-ascii?Q?BNNb8IGisos3Qsxq5UbwP/DBw8m5w0+G0DoB3U32?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: muSoKg5ikiofNot7crykaa0PlqzdsStK1izw72PnwJEb3GNP4bnVY/30RcDkkYc7ghUYjCNsbdbo9prLJqpJBLIAKmohtWAB5HGke0IaAZ2RQKniXQl9+muvceVeClrB/jQG0hsJwF8yJ4pQoE/3B3YSHQgD0C0zapRyCC3X8zY9DFts7GIn1VuJxLT9CCnLarSfcU30VhlxbnO16WS+ZDLQDoUSRu4ZZ5nFf2K0FJh45YKpDjKr17x6NGwICAEHeMmZ/OrEVYzbYTBBdc4GwD1qdkHrqwruDz5W47mCIOb4/VFqIuuwTrbeFQX4XSr9+YECCOoUMlUfGN1CUjnOWHp8fSFcQPTMtalDEmsFyhEgOAeCFn08Nfd6K9RdPZQIqQ8y+fBZpaWbU9S03eMh9be91+IfVt3DTxgVsv9sxx88tqR/Cgn3nHx/rGVg1w9G/NutQSky1EuFT8+M2p4I72iPot2J4mCiuxGJNtr5cKpMN6NKfQXAI3HXjVoJfTVeMCo0btW8iv3BFH3rqUmMMaWWcvepW8EHM0/+xnBifos59/eeOELmKYS/N8+eNbELAfyxJ3SVLsj1MNFPvGKI1ETQE1v0OaYPuvohtohcUXM= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3082955-61fb-480c-4161-08dc1cf3d63c X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2024 15:47:57.9046 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SOjiHAzKbnXsPncsT7KrB6A/JmpZBbhtC6a4CiEBoAg2dIfQuInzPW5ozgmbavfFjUG2AoH9vxUCnkZ8fffH2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB4848 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-24_06,2024-01-24_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0 bulkscore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401240114 X-Proofpoint-GUID: 1TKyZr8kYn-no-Kj7Tub9dmNzI0Jsca0 X-Proofpoint-ORIG-GUID: 1TKyZr8kYn-no-Kj7Tub9dmNzI0Jsca0 X-Rspamd-Queue-Id: F0F1A1C0013 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: nbws7f3qy7wrdb83cqngnnbygerb6iui X-HE-Tag: 1706111282-445347 X-HE-Meta: U2FsdGVkX18iPUMKY0622JxJPCAgOupLdlI9i5G5OdqFb2ddsp1kXWFzfY0VmX9rWl5S66ODuk66gaQbRFMRoYj5SqxBnw/TzeGWGOWW/sd/evw3bD8oSINpZZwiVchofYLJPb3bAiXze0G69P8afPdWfi/lR7fupdh/IwSGtHucJ6DoLblRXfFZVigJZhytZqHLUXIZu72Sx8W85qSzlRMZESzRz6DSbDUjbWqYP9xPtaf+GnunvpquHS2rxEKJnT/+JYCD464hDBzNXhXjRpVEt1v3xgHJE2GN8zqiguZMBfHMcPSHwuhq5fpqwFXrzgyoMt3uaS1bNnr954x7A1ZcsUPlc0FTOj4yx8FSvzcs/7QF8hXUQQfHy3mpvyxIyPPdupQEtIbF+e8KQoZiKyDtgaKB9QHX3KEdYpCiRY7ZbUzkT4biV/RpGtlQkUeLmHCgXR3xu7GJMj3SaJz8MV4l/Ef5AxRfecsU4tEgcGUThqVxJoKe/vCzFIo8XXQe/+ZNH58vWVjOLvZoozxkSSSbd22kZX3RuflV7qH84xB+owC+QIo4fJFF5yiyr5BUNCmKzk0TK3UBbGB0cwXUH55/cfJX3ZKLkO+ELoy5Ow9BStYjzGs7s4RtfFWlCJ890XHBGmMCK9DS9R3tan8dEyiiKyiIvMIs0/o98c3zHs3Ohk6hoh8ji2qt2QBoXpC8QLyt2/nGDYMB/V8cV/WCzps8ZAIl1Xf+Y0eCQToHqDsrxWdb5gtUHlz8ptC2zpcaOkHOxHIiU1c5xZGaphos6z5hwC2XDI3yCt2Z8caf3nSNDXEOzyeE2wv/hyb/oT6+1x9fkikHwLgNzx9PdWk5i7ZHnVAEfWGRYx3W7JeeWSZHSxvb2jChbe3izp3k7kFHREmtquRet9SROzzLsCR30WuNJxmgpNwEMSgDSzO8jhVo1w/qA1RZgZZf9TtxklKv/E9PXQ9aBj8rCzK2T8s Xive2DL+ kfmTR8aHnrwTmQ+Xp/86akUehk/zf+5bP5L1lj/xD4qTdD3Mo7QQ2ItJ+zQHsgvPJTRcz9M6vj/Ufx5wFcwkQLvrsQFJF04kMUcXF+c8Q7sHoOeNFyw2X8XChn9xJxyQVylpUFCmo4AAsdeCgMruvzd0DjLZpbb+Aax+BryVg/FreSNMDpw/3TRMpFkP+v+Q/2g8j5foOc+oumlIPDVvm8a4PsMbc7ea+AEz4z3RHd6s8rZBIycZ1fPtLTcweeIXlv1usv6/hTW4SHKFDYtM8jDCHIgBgRN48RCuDg7nGC50NEdjPlMQtVag7IwYPtd4f1AuzgWOKPPSZUO9XjnIM6MN1YMWuGqF/y8F15uKvymFZNzfuzaCSNCDVISdI59AdrkruAWtNgZBpbgrqJa68m8nh16SDkOqokLGChtCMYlYaOxOXZ0E+qpHr9cgdXptbdoa6rp0BUoaSY+Ba3ActW7D9IXewMvBGBSM4O89WpEQ7MqvVMpdxa4mzo5llSq1Z6+gjCQXMGcPO5towT6uA04z4Aw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Yajun Deng [240123 22:57]: > There is a lot of code needs to set the range of vma in mmap.c, > introduce vma_set_range() to simplify the code. > > Signed-off-by: Yajun Deng Thank you for making the suggested changes, I have one small comment but you don't need to re-spin the patch for it. This looks good. Reviewed-by: Liam R. Howlett > --- > v2: use vma_set_range and put it to mm/internal.h. > v1: https://lore.kernel.org/all/20240111021526.3461825-1-yajun.deng@linux.dev/ > --- > mm/internal.h | 9 +++++++++ > mm/mmap.c | 29 +++++++---------------------- > 2 files changed, 16 insertions(+), 22 deletions(-) > > diff --git a/mm/internal.h b/mm/internal.h > index f309a010d50f..1e29c5821a1d 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -1114,6 +1114,15 @@ static inline bool gup_must_unshare(struct vm_area_struct *vma, > extern bool mirrored_kernelcore; > extern bool memblock_has_mirror(void); > > +static __always_inline void vma_set_range(struct vm_area_struct *vma, > + unsigned long start, unsigned long end, > + pgoff_t pgoff) Nit: This isn't part of the style guide, but if you just indent with two tabs for arguments then it is easier to expand the list without more lines. It also allows changing the function prototype without re-indenting all the other lines, so future changes can be smaller. I think you would save a line here without affecting readability. > +{ > + vma->vm_start = start; > + vma->vm_end = end; > + vma->vm_pgoff = pgoff; > +} > + > static inline bool vma_soft_dirty_enabled(struct vm_area_struct *vma) > { > /* > diff --git a/mm/mmap.c b/mm/mmap.c > index cf2f058bb3ae..7a9d2895a1bd 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -663,9 +663,7 @@ int vma_expand(struct vma_iterator *vmi, struct vm_area_struct *vma, > > vma_prepare(&vp); > vma_adjust_trans_huge(vma, start, end, 0); > - vma->vm_start = start; > - vma->vm_end = end; > - vma->vm_pgoff = pgoff; > + vma_set_range(vma, start, end, pgoff); > vma_iter_store(vmi, vma); > > vma_complete(&vp, vmi, vma->vm_mm); > @@ -708,9 +706,7 @@ int vma_shrink(struct vma_iterator *vmi, struct vm_area_struct *vma, > vma_adjust_trans_huge(vma, start, end, 0); > > vma_iter_clear(vmi); > - vma->vm_start = start; > - vma->vm_end = end; > - vma->vm_pgoff = pgoff; > + vma_set_range(vma, start, end, pgoff); > vma_complete(&vp, vmi, vma->vm_mm); > return 0; > } > @@ -1015,10 +1011,7 @@ static struct vm_area_struct > > vma_prepare(&vp); > vma_adjust_trans_huge(vma, vma_start, vma_end, adj_start); > - > - vma->vm_start = vma_start; > - vma->vm_end = vma_end; > - vma->vm_pgoff = vma_pgoff; > + vma_set_range(vma, vma_start, vma_end, vma_pgoff); > > if (vma_expanded) > vma_iter_store(vmi, vma); > @@ -2809,11 +2802,9 @@ unsigned long mmap_region(struct file *file, unsigned long addr, > } > > vma_iter_config(&vmi, addr, end); > - vma->vm_start = addr; > - vma->vm_end = end; > + vma_set_range(vma, addr, end, pgoff); > vm_flags_init(vma, vm_flags); > vma->vm_page_prot = vm_get_page_prot(vm_flags); > - vma->vm_pgoff = pgoff; > > if (file) { > vma->vm_file = get_file(file); > @@ -3163,9 +3154,7 @@ static int do_brk_flags(struct vma_iterator *vmi, struct vm_area_struct *vma, > goto unacct_fail; > > vma_set_anonymous(vma); > - vma->vm_start = addr; > - vma->vm_end = addr + len; > - vma->vm_pgoff = addr >> PAGE_SHIFT; > + vma_set_range(vma, addr, addr + len, addr >> PAGE_SHIFT); > vm_flags_init(vma, flags); > vma->vm_page_prot = vm_get_page_prot(flags); > vma_start_write(vma); > @@ -3402,9 +3391,7 @@ struct vm_area_struct *copy_vma(struct vm_area_struct **vmap, > new_vma = vm_area_dup(vma); > if (!new_vma) > goto out; > - new_vma->vm_start = addr; > - new_vma->vm_end = addr + len; > - new_vma->vm_pgoff = pgoff; > + vma_set_range(new_vma, addr, addr + len, pgoff); > if (vma_dup_policy(vma, new_vma)) > goto out_free_vma; > if (anon_vma_clone(new_vma, vma)) > @@ -3572,9 +3559,7 @@ static struct vm_area_struct *__install_special_mapping( > if (unlikely(vma == NULL)) > return ERR_PTR(-ENOMEM); > > - vma->vm_start = addr; > - vma->vm_end = addr + len; > - > + vma_set_range(vma, addr, addr + len, 0); > vm_flags_init(vma, (vm_flags | mm->def_flags | > VM_DONTEXPAND | VM_SOFTDIRTY) & ~VM_LOCKED_MASK); > vma->vm_page_prot = vm_get_page_prot(vma->vm_flags); > -- > 2.25.1 >