From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E39C3C46CD2 for ; Wed, 24 Jan 2024 22:09:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 696C58D0005; Wed, 24 Jan 2024 17:09:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 61F378D0001; Wed, 24 Jan 2024 17:09:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4985D8D0005; Wed, 24 Jan 2024 17:09:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 366B48D0001 for ; Wed, 24 Jan 2024 17:09:44 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id AAB961C0DA9 for ; Wed, 24 Jan 2024 22:09:43 +0000 (UTC) X-FDA: 81715597446.23.B0ED3BD Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf20.hostedemail.com (Postfix) with ESMTP id E082F1C0011 for ; Wed, 24 Jan 2024 22:09:41 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=gNG4RLvg; spf=pass (imf20.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.177 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706134182; a=rsa-sha256; cv=none; b=V8zRw8z2MXqyOKfb9lYA7k/rZSjBa3iTO33GUI1iEcZXT6eTS9jKqt0zfnzTEYAmti157/ n/8O5f8rIYPzI1HzMgeHUN6/cHMZfDdQE3GscR1igi2lScco4J2xmAYs7hLOUNrhFbwF+/ VbgXFgH2h05rcV8Os+TA918LxOFBTAI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=gNG4RLvg; spf=pass (imf20.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.177 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706134182; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+2HfF9lupAEm1OXAQn6hzn1NaSwJWDcoC+WNHu+TurA=; b=vRqlehoyzmPV6zy1/jC/L9dr6pHUMpRvj1vT8MslKHwiGGa7qv2h6u85rmXNyydBxKCX9a cHuQp1FGWbM60H5sPgsh9fUdxmR/01pwWbVEdeNc7yaC6rPkRO5zsVK0v0Y3T0uRk8PbeD 82ZOGU9JY06kVbgNhh+G1mcRZDYpwKg= Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1d71cb97937so38549115ad.3 for ; Wed, 24 Jan 2024 14:09:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1706134181; x=1706738981; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+2HfF9lupAEm1OXAQn6hzn1NaSwJWDcoC+WNHu+TurA=; b=gNG4RLvgcBaej3ZWZXvBPUnHszAKdH6CwHhOG62qBSCl0D4ggv5VOzi3fWEfjRTb+k faFxKW/304azmslhZOpv3cYUSE7ghqFDWO16pSDL4snsTr81IbyJ6mwCf9RfJCmfEj9Z nIdhNKILRkgFW+A2lPvx4kyQLhzQ8laccWGCc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706134181; x=1706738981; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+2HfF9lupAEm1OXAQn6hzn1NaSwJWDcoC+WNHu+TurA=; b=ok3n0eQLbp+Zoy2OzPpMri0FOhah3PmBqbExfAvdDKAjtpZFN7MIBACHyTrPUAMJab gFrcl30C4daME/CXlH2pLjm5bB+rENtbfATtjB1vOTfGCxQh7pxP3NBi/jAjtZqkKwD0 b0nxdSyPa+sYK+AgnXN4Kn1+w/2h7EahVW8O2eilvxmbcGEa2us91YoU9ofGj7rhXngT hvX8HJs7E8azJ8rZgVVobUDsMvCzQNNtg/uOqQZYantWrwIZSz4ZCL1Gfd9Zx2w52+UU AbyCNYZjOnaZ2s0iMXE/e3PDtwOuRTpELjP7as5PD3bidWOHs5z7kfwP2HqpRhoJBs5a HFlg== X-Gm-Message-State: AOJu0YxirVkswVN4o373itdE2Fkf4sslrd457gOapelWz9Ty4lQphM/+ GMNsxdum3gAhOTCrRKtREoE+F9fRSFM/GFvR6pkvaUXe4nSDsi0I3wdDeL9ayg== X-Google-Smtp-Source: AGHT+IHwjfVcQfQSMaltTGpvSx5H8mpO1d+72MKHAgocTXkrSUI+xD0uCoBa7P9UapqyrXYteTG9ug== X-Received: by 2002:a17:902:c3c5:b0:1d7:1b61:579e with SMTP id j5-20020a170902c3c500b001d71b61579emr51632plj.89.1706134180745; Wed, 24 Jan 2024 14:09:40 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id g9-20020a1709026b4900b001d75044fb5bsm5572290plt.141.2024.01.24.14.09.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 14:09:40 -0800 (PST) Date: Wed, 24 Jan 2024 14:09:39 -0800 From: Kees Cook To: Kevin Locke Cc: Jann Horn , Linus Torvalds , Eric Biederman , Alexander Viro , Christian Brauner , Jan Kara , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] exec: Remove __FMODE_EXEC from uselib() Message-ID: <202401241409.AD68CE57A@keescook> References: <20240124220619.work.227-kees@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240124220619.work.227-kees@kernel.org> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E082F1C0011 X-Stat-Signature: 8req31rjeac7qte9hjt73wgn3rupyzjd X-Rspam-User: X-HE-Tag: 1706134181-348362 X-HE-Meta: U2FsdGVkX18E7Fu7uPeXw03n0QUMSkaV3lpa//M/YQ8UgpuX244fRntaafwTBmZ2WXBib2/Hl1aXmLAJX2H9fqwdp0WlaXsEQblcTnCT+melqVlzMs7CpWQBVIzGF4n6PVt92exD1PL0lnpjl3f6vXRmQPjRfolIN7xaAbGg7GZCS3zMZEJiPuwRVtD/nuiNCXzTqL9Zbi3GyJJueQTcEelZHtenuzidJJXLxI6WCVUDw1cpw3UoTarbnIRRwTWKJzg/ytJ48JNboY0SLEyVVau6E4xzIs2h2BVG2JVaOH+PhpWwnIEbc1l1KjS0ssu//2X5s3oZPQWEg9gRDhUJ/qoOVet/OrGywcmSb+DRVATMw3pqXqacDs5k5MsLi/iwdZm11dhXgk6VJ7nkvbNG8b9F1ZA7BJOGhJZcMadkEoKTBaeKeoLu437mD7uYYKrv0x77WVXbyhriCYQS/4ve1CqVb4oBuWm0p0/jsaKfWbDeV2wyrj7S/cZEuTdOhMJnleCYIMCYZbK7+NFTy5G6rd/9ynQTs0M8jHoE9LRLO+Tf7Hd7gk5Z9L9pERWod+T9ph42Ete7Q7r+R0j3/vz5lsZRzZ4+4FWxWaPdcMEdYBAD1OBCvU3xBd5enKxQXkKKXiWbtMzTq4+9c+wsFRGx/FdhLyaCVeWBzUJCSos/ApIzq1PrC1/rG4cehtGBNCbAexDIoVjAkWdt58CxT/UkiA1y2hr1dfR/UUvqHwFinsQf3zUdo/XGRroemAE4IHFxgzhoCtXm5bAxhiylUDJJM8G7azWEY4clSYIt6ACGJelk2joOuFiScamJsfiphSOSdXBjEKpzpHfuhsz7NgLZQecCQ0GmsFlNysQl/bEgylhH/ajDxKmzI/xzQJEc6UelvDhPWnKeg+j72L6LCtxCmOun9GB9t44KaCunXMMQf8lh2YsBtS+pMj4bMbFC9GMhn8CkJJS3UFeXlbR8dUq Hb7aMhwc AlbjqQ8rd4oQEFviE7eiEnh1pivynEGHh05M3vctf1D5PediZtcCJNVrmNQ5moa0LTSSMF1f1tBbjJ7qBDNe2JqDc8gmu2Fq8i4Yo+yozQ59BPQMDTTB1WMD3A72iZxJ/PBZBhZl+h2nAjrUaxFA6MWTPLODP9XsSo8ubnywYlRFauWP5psFm7R/l3j5rnxyYTMI2NKpPyBkMLuHtaGuQEe4Po3kBy0vpp+kqalSYeFCgTbGnihSpKH4gnddB4dZcyGkmC1y/luzifJgm2RJfO//lLUsLMADZNcwYo1zML7p95kwP9kH9LoEwcdaB6TObgX5+jsM6h6uspPUpk2eYHUJ6w8I4ziKC1/YI+AfTbJ9uTFtQiU+x6kvIF/xvn7Si/w+1il4aFhQEiXoo9a5MRh2ZWgBKOnkw4gf/ZocU2lirR2qNv1/Wu+/7N/3COTVWs7UyUy9wA7w+0PM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 24, 2024 at 02:06:23PM -0800, Kees Cook wrote: > Path-based LSMs will bypass uselib() "open" checks since commit > 4759ff71f23e ("exec: Check __FMODE_EXEC instead of in_execve for LSMs"), > so don't set __FMODE_EXEC during uselib(). The LSM "open" and eventual > "mmap" hooks will be restored. (uselib() never set current->in_execve.) Ah, nevermind, I see Linux's commit has taken care of this already: https://git.kernel.org/linus/3eab830189d94f0f80f34cbff609b5bb54002679 -- Kees Cook