From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 575EFC46CD2 for ; Wed, 24 Jan 2024 19:51:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BACAE8D0008; Wed, 24 Jan 2024 14:51:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B5B3F8D0001; Wed, 24 Jan 2024 14:51:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FB818D0008; Wed, 24 Jan 2024 14:51:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 904378D0001 for ; Wed, 24 Jan 2024 14:51:54 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DC6DEA0D10 for ; Wed, 24 Jan 2024 19:51:53 +0000 (UTC) X-FDA: 81715250106.21.A434573 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf27.hostedemail.com (Postfix) with ESMTP id 0D37140003 for ; Wed, 24 Jan 2024 19:51:51 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=WwNnvYrc; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf27.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.178 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706125912; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kA0mFxG1k0QSiOKDeUD/WDcdNFn8yF9DrGJFsA48PEc=; b=hk+bMC2k7GSUbNe3RzKCT6Fi0fozY3mCrG4OIladmQILQ3fNDdCCj0BpAufeLYSIlbpkUV 3GFExB9DU7Pt2y4WJZwr0Af+DBpCpG3W/8fd34oGS+95dEPdJ1lp/mfr5B9atypYIf2Z/6 tEH059JUdQeWbo47bDqcBZ/6PvFdeHE= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=WwNnvYrc; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf27.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.178 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706125912; a=rsa-sha256; cv=none; b=io8v82RKGk5wlRUXhZIMTWWS+EJAAKoiMi4weo5Ad6VGoWn8X1Cwsb9tbR+Gqp1Pbs0qY+ bsMlkQkna/5xTDPBmPBQGeQonZ+iuqecZ2tTJB57ysG42u3AsxAbpnQlXqg8Nl+tEXnJz1 7NNVQqbtGIe56de65enhenF5VO76Xio= Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1d71207524dso25863425ad.1 for ; Wed, 24 Jan 2024 11:51:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1706125911; x=1706730711; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=kA0mFxG1k0QSiOKDeUD/WDcdNFn8yF9DrGJFsA48PEc=; b=WwNnvYrc/O+292S75Wpt/KM+LXGFt20jYYxY4RBjceNu1McPbM1mF+K8kxNWUg+tO3 RvhiCoDkeQC8AZ9uiQusWOywABdpRMWSJUYoFoqRPw8dmfw8Pe6m6hrM6AlkmnWPIXhx txOsgkKE9pZ8iN86HrkRAusfW8MnaMcn8JIqA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706125911; x=1706730711; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kA0mFxG1k0QSiOKDeUD/WDcdNFn8yF9DrGJFsA48PEc=; b=nUOWSPMOkBQ/IwPElm7SpkJnYnQutXO9C4U8bEziJIWlUjSjUwoWpsjgF2a9P4G6hx jSy7VheS0YtIyv0U8essH7Kje8C3OHLDZL6LIl0YQqdWj9cbj89aV0uWTSs+f8AsXVvf tvFvbgiYodcAUJIhEORVcI6RWaatzhslAk4V3G03MFINWCJ5EzGYr0aZRuvII+A74z6R zFhC8bp5dh2KjE0R8AT1sOW7CsuP7nmmL18qyWDLfSJM8yyiXS1e+QdOSmWR9QwxXG9O OGA3moImJv+/+rv6X/5JmdTN9J8ZWI/vKXfwNV+Y73kL14wR3uNtFRCvl3CWj1wECV7F gc5w== X-Gm-Message-State: AOJu0Yz+Uq1C4/COnNxU42gN4MkhivJp+3ciE7u+0RYDHLmJ6OXkVorl LFD41g5ZL0EWF/xqwdGjCq8alzj4FZXZ3j1Ld21fVVR8qDFDsrAqNxwxKeP5Gg== X-Google-Smtp-Source: AGHT+IHOo2S4XZPrJkJAVWNIUu5O2sihiMmNygdfJCCs51/i38ljraqICbhZ/brbhlRxs5RoeWJoDA== X-Received: by 2002:a17:902:8685:b0:1d7:70d7:c05a with SMTP id g5-20020a170902868500b001d770d7c05amr1210754plo.98.1706125910737; Wed, 24 Jan 2024 11:51:50 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id d9-20020a170902c18900b001d707163122sm10456896pld.7.2024.01.24.11.51.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 11:51:50 -0800 (PST) Date: Wed, 24 Jan 2024 11:51:49 -0800 From: Kees Cook To: Kevin Locke , Josh Triplett , Linus Torvalds , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Kentaro Takeda , Tetsuo Handa , Alexander Viro , Christian Brauner , Jan Kara , Eric Biederman , Andrew Morton , Sebastian Andrzej Siewior , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] exec: Check __FMODE_EXEC instead of in_execve for LSMs Message-ID: <202401241151.25D468FE@keescook> References: <20240124192228.work.788-kees@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 0D37140003 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 5t4ii9ntkybrxryqpurukyj1pszn9m67 X-HE-Tag: 1706125911-619204 X-HE-Meta: U2FsdGVkX1+cmITGre0Ec2CUb9RH6McTRkso6kOsQeyHgoSSCbyZM0C1+LrPOwfPycLvrGexaqSaC2bwSCAxhEF9sFsNnBNJRbg6gzhKLxDohIHHgpbWdJTpXw/lVxqz125NhR5IdUz4RqHjUrIT97pAvCTJFqOOfD83D3Av34IpFzLcVFPaieFNQ3VuSSzNmpECbvBizakYH6vDDZQq7PHl3eGXzi8wcev0HCx8wsSKDqTFW+VgVIkTy/Baoo7iZSEHEvRQAJY/MswUeH2J+W+5yFiEJYoaXxviLtkDJQzey3KgN3SpEw6IRhlRSPNLhQNokbc3F5W/mANJxSybgDwNqLxmlPCcaFuFASBNKTmeKvwccEEW1gGR1Kt6+eDJ/gDBM+i02MZLDIov7SXgwxG/gCKrZRc9tgJtl9GsZ5Dt/SvExTaPEziGd94N0DeTQLoA1Ut/p3BOfLgXfezkEpQDGLfGU6X/rm6MzwAhJhjG2L0jTz9vxTgYi9Djv9Ubp3NgwbXTJvg1gXXOgz1BkVCytm+E9XbYr/iIc1ZleMJUj8FMy9UtIIbKOxcJx/y7uYdaAeXyjhxjD9R5q+Q/Ra5YDTz4Lft4uekcM/qB4rw+dAJdaa5kiBmIqVOY2tFR4zVGOovuRNx+gKywQlXrwg39an3lA95/aeEK4iMbyNJvxQ/uL1iMYh18drE6GDFNih0b7cCDwnoOivC/Nx6HBbnaBcnkBFCOZqRTw9852FN38qe12w5tGHh6UJFF0vLVckYW7ZS2PTa+oLfSeTmyLSTCKJfs/goJtnAUhTshQ8SHNBysRJ1ILOBs4pJ6YeVjgA/wbgorNpmThB09l8X4utrVk/NayHdz3q+WXLGOeuH+cnR3K6VoAw2C13BIKITBWyySYyxkZ2evm5sgdti+M8jCpM3x2ikVVNrweFP1lVKxWUB0YFD6yYjzAHVDkhouKytUq5LOx/zfhDSwZt/ ua+IYude uS7eByrjHUu3R8zlrxf+ZRusaCSzvv1Jg/Nom+H1En+UVIAbj2YNOKDOoyd29YCYRUWTPqkUYraINQCdeGP0FvQ3bmXZHHN6z7u26xGle6eBMc4ZVEDznGPzfcnGLvvIoWq9Vtm49m6foY11O0z3oszGaDJgKlO1W+9iJtzx7j7qgXs7tB8AH0aFDq17zMdIrSy22/pFQUCekoDZ67Xn5CUS5Ykw9SfxNMB++dCdkBpHdJqgZGJA4qT220+MlivC1P+l2f9wUBNEn7nDHkvjyAcYAqXaabJoIVTWjK7t0pWvabiq0XnFAl3uMkLX9NAwilmWLM4CxXYnc7Fg6jJ0shAn7rJxFOHyQ0krng1g7Ddkaw50UlPmpC30ucV2Hcebr4AoBn9aZpJOhoGHOwRBQSAjgbQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 24, 2024 at 12:39:38PM -0700, Kevin Locke wrote: > On Wed, 2024-01-24 at 11:22 -0800, Kees Cook wrote: > > After commit 978ffcbf00d8 ("execve: open the executable file before > > doing anything else"), current->in_execve was no longer in sync with the > > open(). This broke AppArmor and TOMOYO which depend on this flag to > > distinguish "open" operations from being "exec" operations. > > > > Instead of moving around in_execve, switch to using __FMODE_EXEC, which > > is where the "is this an exec?" intent is stored. Note that TOMOYO still > > uses in_execve around cred handling. > > It solves the AppArmor issue I was experiencing and I don't notice any > other issues. > > Tested-by: Kevin Locke Thanks! Sounds like Linus has taken the patch directly, and I'll send a follow-up PR with other clean-ups. -Kees -- Kees Cook