From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65BEBC46CD2 for ; Wed, 24 Jan 2024 16:35:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F2D9F6B0078; Wed, 24 Jan 2024 11:35:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EDE1D6B007B; Wed, 24 Jan 2024 11:35:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA54C6B007D; Wed, 24 Jan 2024 11:35:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CBAD36B0078 for ; Wed, 24 Jan 2024 11:35:33 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 91CFC1405D6 for ; Wed, 24 Jan 2024 16:35:33 +0000 (UTC) X-FDA: 81714755346.23.4E94690 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf11.hostedemail.com (Postfix) with ESMTP id 7945640020 for ; Wed, 24 Jan 2024 16:35:31 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=G2Pd3v7G; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf11.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.170 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706114131; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Dc2ne9DEtozuAA7QWnRNqqOnd5KtqxPd0sphMP9Q6c4=; b=EQbImygF4Rqt31ygURA9dl5ljdKq4CWRKD/xD22oKLBcrXyfhOQH3VXvllU+V03LL007c9 4agME6kJ02+Z80ZUc8lThcdS1NVobdM5cY/DpU3AmKQA2m3TXZx2ow3vDNrIVjUvasAQJR dd2IefYE+pbpVgkmDHq2IYxmPZljEuw= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=G2Pd3v7G; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf11.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.170 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706114131; a=rsa-sha256; cv=none; b=c7qZykQzwPycnHb1akHzN7bhyrlM8fvTyXHVeayZ5jwjr1gSziMGJCk43EJqmuQlC9Mg4+ ORJS0Ck1+Ej6ZOX3UQ+N13U2uw00VumlF3fe6i2Fg3Xwjfn9WQ5FytHAQDer118uTPKsuf ICx6R919aovYkNyo3BGKcpYxhhEK9tE= Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1d711d7a940so49999395ad.1 for ; Wed, 24 Jan 2024 08:35:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1706114130; x=1706718930; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Dc2ne9DEtozuAA7QWnRNqqOnd5KtqxPd0sphMP9Q6c4=; b=G2Pd3v7GU/mQ7r/PVcyegKo/5oKlARWemGQ9PPm0PGbwEbWZRAVWR/80NLW0IiWNVG S5vTxd36Irl8I8MdwdWse6l9ZN4sTyPYD6ghXvoUMSD9JAm0ReWTzC/ht1//5783gleJ ivryBnBgF1K97Nx3yXfmF2vim7ZpH9YYaIkgs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706114130; x=1706718930; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Dc2ne9DEtozuAA7QWnRNqqOnd5KtqxPd0sphMP9Q6c4=; b=aQdkAmI7w9D6WSIbcJRO0s9ht13KEsSm9agjQNr8CxRNEL8/63kAu+JQEsZ6Q5+v0n zetKK0m/JIuUGVC6Jt839BMtCa4C7/nbDyZeywQUow5krkIE2uUXJVobSBrJkqePbATu f7sN6OoOIUGGGyIo6Ao/tSeaULr5GwrJEKjpXA0DR5J25DUhLPkjrie5aK7FM5pAQUiO kygxZvPBxp4AHWag4nh4Djmw9sKQEdIkSz/s4VIO21piJ33dcwXTRzn1grQU/R1EFfY9 16iwk3DXTS+QykQS9LVbh5kRnIfYZKiJYkjl5og/pOHr9lHyqidvWClfJwAPvTxyfrQa GMBA== X-Gm-Message-State: AOJu0YxowxY+UmgGXWZYI/zmagktzwAh2F+tokLD0UMljSCy9DSk1NrY E6YtbWRkaxuXVJ5DxyNN2Fg2BGRRcV61yhnxXeKm8CYbenJQI0EMt8FvesMEjA== X-Google-Smtp-Source: AGHT+IERyxG8hB13JvayvVAKVYQEmEi/M546PMHAK2ELkrVVnnL9t5Wu3jy7ccSeDT6NM+9XiRls/Q== X-Received: by 2002:a17:902:c20d:b0:1d7:5eef:4ed with SMTP id 13-20020a170902c20d00b001d75eef04edmr1176992pll.38.1706114130308; Wed, 24 Jan 2024 08:35:30 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id l12-20020a170902d04c00b001d73416e65bsm6909726pll.63.2024.01.24.08.35.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 08:35:29 -0800 (PST) Date: Wed, 24 Jan 2024 08:35:29 -0800 From: Kees Cook To: Kevin Locke , John Johansen Cc: Linus Torvalds , Josh Triplett , Mateusz Guzik , Al Viro , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [6.8-rc1 Regression] Unable to exec apparmor_parser from virt-aa-helper Message-ID: <202401240832.02940B1A@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 7945640020 X-Stat-Signature: kt3r7fzpq6grj54bibomhw3hmtzec34u X-Rspam-User: X-HE-Tag: 1706114131-705917 X-HE-Meta: U2FsdGVkX1+JX7toJ8udgN5QEfA0xZL4ceue7w7tYyHFcgnrOOuvTdOjXjoObN/o/uWHY4E2w8fvVgsiWAZcU1r+EaoSXhmac51NkvKtGL0dFXLC096DwPSCnOCXve+jMYT8dVBUNHnIjaM87wuQpLdvFJngayFb6PBkU3B0ki+ZKUFNtl6eAGwvPmr1LnTk1s5xYb2T85UGsT32RpoeTEzdSxO4LPosHl13tY1PFeAU+BUnVhWKTRzrr6g3aUW0zsNIIdgjjmDb3KkJfXy61eUeFsLsOwmFnfWaudLAzPuu1VLAA1QQRPAd1AfihZJzEWAeoRPX5lNyUyb74OGiwQeFK8bZx8C0aSqjUSqPZRdkXHUx1WJ9Fd81SV/UbNfO+d6xLERvwmItdkqGzW41CVg5U3+2ZxLIcX2DPbg/+r7rdXSZGP/OSHSBixw/g3SavqU2T5Wppl4qLPgJDts4Edohbel2ejS8LxwSVdidnCT2ypW7aTVN97i0cbfTimeI3uiHnXsQSwR0mZPd4rtiGrvcBoINlNNZZaonIlXCnCWuFkebPGgXfId/OYl2DUzH9yGsmci43YHT3sqKkjwdsbHTcOyW8EvEihBftpeqmAEPW+JAp2gszav/+kLQGWRZtQGYCnlw6cCoS0ZdQs4DBjFeHCrL9Niw9AHEhabJharqXd0Tll1+eDVd1gJOS1w0Tdmc2we6ycEK9YO63/K8CNfK/4SE+JGMnRL7b0HgKxKDzUh92d7H7n4PI+ER/KqrpklClWTqzyjOzaEudbjNOHSKX0fa/eE6C/u2SWVUIFDfaT4l2hE9X4sl/FX5di1yQEsUV2iHrEaG6/3g8DR0EgU6ihDdOP77hPdTiG+AiAWj4HGYTSxUQQecuPTXqMtgEO7MBrWAANd50D8Xb9jMmX6KEeu9Ww4IwTeeiHvmSNNv7PauBB+TBwHJQH8Lbyd2kli2q6Gtsgq3LHRXeco MNUx9A1C S2H0oPkFZqaGJYuyoBKi915+QwBsLFwl6nU7EI6AGmTxBt3SqOwuth5JCrmoMp1R+4jf1fipl7a4jNAvU+rX5AesI4ZzMVeF/Ve8C3wIBtxPuPs3vmOLjFjfp+UGagi5NzC6ID6HGCY3jc7w6XWeUmzkvhlanYKzHR/fgKDlbQfXFq6vy+V/EJcxwMlzzF62fcgMBzXF3r2loLTRI0ICUZfIad3mPtta/z/RUzjnU0U7juoAw1g02YQIoVvPOLZL4yr6a3jRyo2BmCptt5JvJvI85ekXxaaEMXLThW1k+/ZlkYP8q81I+OlJSfKCz4CAnAmIP9srl/EbyCq3YU/YHwOpH3TsxrkPhI4avo8Aof1652mVEv0lw7D43yCbKPcG0+l5cfQf0IHihuRj29oT2RqVjWg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 24, 2024 at 09:19:54AM -0700, Kevin Locke wrote: > Hello Linux developers, > > Using AppArmor 3.0.12 and libvirt 10.0.0 (from Debian packages) with > Linux 6.8-rc1 (unpatched), I'm unable to start KVM domains due to > AppArmor errors. Everything works fine on Linux 6.7. After attempting > to start a domain, syslog contains: > > libvirtd[38705]: internal error: Child process (LIBVIRT_LOG_OUTPUTS=3:stderr /usr/lib/libvirt/virt-aa-helper -c -u libvirt-4fad83ef-4285-4cf5-953c-5c13d943c1fb) unexpected exit status 1: virt-aa-helper: error: apparmor_parser exited with error > libvirtd[38705]: internal error: cannot load AppArmor profile 'libvirt-4fad83ef-4285-4cf5-953c-5c13d943c1fb' > > dmesg contains the additional message: > > audit: type=1400 audit(1706112657.438:74): apparmor="DENIED" operation="open" class="file" profile="virt-aa-helper" name="/usr/sbin/apparmor_parser" pid=6333 comm="virt-aa-helper" requested_mask="r" denied_mask="r" fsuid=0 ouid=0 Oh, yikes. This means the LSM lost the knowledge that this open is an _exec_, not a _read_. I will starting looking at this. John might be able to point me in the right direction more quickly, though. Thanks for the report! -Kees > > The libvirt-$GUID file is not created in /etc/apparmor.d/libvirt and > apparmor_parser is not executed as far as I can tell. > > I've bisected the regression to 978ffcbf00d82b03b79e64b5c8249589b50e7463. > Perhaps the change in this commit causes AppArmor to deny opening > /usr/sbin/apparmor_parser in preparation for exec? For reference, > /etc/apparmor.d/usr.lib.libvirt.virt-aa-helper contains: > > /{usr/,}sbin/apparmor_parser Ux, > > I'd appreciate any help debugging the issue further. Let me know if I > should take it up with the AppArmor or libvirt developers to better > understand the issue. > > Thanks, > Kevin -- Kees Cook