linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Kemeng Shi <shikemeng@huaweicloud.com>
To: willy@infradead.org, akpm@linux-foundation.org
Cc: tj@kernel.org, hcochran@kernelspring.com, mszeredi@redhat.com,
	axboe@kernel.dk, linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH 4/5] mm: remove redundant check in wb_min_max_ratio
Date: Wed, 24 Jan 2024 02:33:31 +0800	[thread overview]
Message-ID: <20240123183332.876854-5-shikemeng@huaweicloud.com> (raw)
In-Reply-To: <20240123183332.876854-1-shikemeng@huaweicloud.com>

We initialize bdi->max_ratio with a valid value (100 * BDI_RATIO_SCALE)
in bdi_init and we always set bdi->max_ratio with a valid value (< 100 *
BDI_RATIO_SCALE) in __bdi_set_max_ratio. So the validation of max_ratio
in wb_min_max_ratio is redundant. Just remove it.

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
 mm/page-writeback.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 5c19ebffe5be..f25393034c76 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -198,10 +198,8 @@ static void wb_min_max_ratio(struct bdi_writeback *wb,
 			min *= this_bw;
 			min = div64_ul(min, tot_bw);
 		}
-		if (max < 100 * BDI_RATIO_SCALE) {
-			max *= this_bw;
-			max = div64_ul(max, tot_bw);
-		}
+		max *= this_bw;
+		max = div64_ul(max, tot_bw);
 	}
 
 	*minp = min;
-- 
2.30.0



  parent reply	other threads:[~2024-01-23 10:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-23 18:33 [PATCH 0/5] Fix and cleanups to page-writeback Kemeng Shi
2024-01-23 18:33 ` [PATCH 1/5] mm: enable __wb_calc_thresh to calculate dirty background threshold Kemeng Shi
2024-01-23 18:33 ` [PATCH 2/5] mm: correct calculation of cgroup wb's bg_thresh in wb_over_bg_thresh Kemeng Shi
2024-01-23 20:43   ` Tejun Heo
2024-01-24  2:01     ` Kemeng Shi
2024-01-29 21:00       ` Tejun Heo
2024-02-08  9:26         ` Kemeng Shi
2024-02-08 19:32           ` Tejun Heo
2024-02-18  2:35             ` Kemeng Shi
2024-02-20 17:34               ` Tejun Heo
2024-01-23 18:33 ` [PATCH 3/5] mm: call __wb_calc_thresh instead of wb_calc_thresh " Kemeng Shi
2024-01-23 18:33 ` Kemeng Shi [this message]
2024-01-23 18:33 ` [PATCH 5/5] mm: remove stale comment __folio_mark_dirty Kemeng Shi
2024-01-23 14:07   ` Matthew Wilcox
2024-01-23 20:46 ` [PATCH 0/5] Fix and cleanups to page-writeback Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240123183332.876854-5-shikemeng@huaweicloud.com \
    --to=shikemeng@huaweicloud.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=hcochran@kernelspring.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mszeredi@redhat.com \
    --cc=tj@kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox