From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60BEDC47DDB for ; Tue, 23 Jan 2024 01:54:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E563B6B0087; Mon, 22 Jan 2024 20:54:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E06716B0089; Mon, 22 Jan 2024 20:54:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCE3E6B008A; Mon, 22 Jan 2024 20:54:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BBB7D6B0087 for ; Mon, 22 Jan 2024 20:54:17 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8A5231603AD for ; Tue, 23 Jan 2024 01:54:17 +0000 (UTC) X-FDA: 81708905754.13.26FABBB Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf24.hostedemail.com (Postfix) with ESMTP id 7D7EB180011 for ; Tue, 23 Jan 2024 01:54:15 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of "SRS0=P69r=JB=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=P69r=JB=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705974856; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wbkI4hbJH0Omi1vH0U0mtEeNCIYZJkwSkqihpVTg/+o=; b=aZiEhpGEwZMrCxgtqH46t9/wKQDIUDZuYskWpekzuIiOQnX6odCHkdKLm7QQh2vupSHota SZEeoKyDPR5ELwVdLrus2XxR51RBrjUpw3IugNasw/Mq4uMO8oITyk/58dj6vmnfUFMYUZ MXf0+g8vBGq6TkAldILZyJx19ryWZCA= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of "SRS0=P69r=JB=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=P69r=JB=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705974856; a=rsa-sha256; cv=none; b=JTjQHGe9QTz5wRiNW9r2ZjvnZZXQioCHdEwMGVzhmzsag6Bun17/oJAS9f6wplFRwLFRyZ DwsYvdv9HO1w1gfj5ZjMz3PGJS1xyQc4dOwMeGtUpccQ9e5OSA1W+/TPePijq29mO0v4Gc 5vde34JwqeRMLdHOH4cV7Nkv/mNrrqc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 09D80CE2DBD; Tue, 23 Jan 2024 01:54:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D3510C433C7; Tue, 23 Jan 2024 01:54:09 +0000 (UTC) Date: Mon, 22 Jan 2024 20:55:39 -0500 From: Steven Rostedt To: George Guo Cc: Masami Hiramatsu , Mathieu Desnoyers , Dennis Zhou , Tejun Heo , Christoph Lameter , Andrew Morton , George Guo , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] percpu: improve percpu_alloc_percpu_fail event trace Message-ID: <20240122205539.705f5701@gandalf.local.home> In-Reply-To: <20240123094443.00007b20@linux.dev> References: <20240122073629.2594271-1-dongtai.guo@linux.dev> <20240122105700.05e5ee46@gandalf.local.home> <20240123094443.00007b20@linux.dev> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 7D7EB180011 X-Rspam-User: X-Stat-Signature: jbk87q4wsq3pcwta6ijtauueh75ahcga X-Rspamd-Server: rspam01 X-HE-Tag: 1705974855-797520 X-HE-Meta: U2FsdGVkX18733jW9FtdFD16J/GOS0jVIcoXJ1Ve+YKG/jhb5Spk9W4LPQJpIcY5IbztLmq31L41chY6rpfyicW9gNA+JSNueqE3vEoVVFNE3tjqgZKatZNl2DLq9gkGqAz9cPfSist/z9AyXP2+zZIl3KRaHeZeoUaHeXydMeYbYGgJ9WAQdyCfYBFc+C6u7itaQ5bjnDocHytu9n/6UfaASbDBxa6fMQqTsD0GNiDpOiqbWCIs23E7uv12/nXUXXlENV3Y+/tH/54YfLJAcAhSv/eRprcIyf24z8jzWLhqWcscgLBaslQiCgrvV6hWD95+hxPqT5clieBjbUcMacHHhgEOoWarSmE9UX0qsFoiq2Dy9+E4zLtU/95HwiMFofRhxj0UwfQTYMsL9OkfdhxegKr1znqfpql/Cw+Ybh7Q9yqwyo9HLZVXAQSOc+nUzCK+xbx0fazDwgWmGfBDKpxy+zpoK7PqOqtjUmTSNZd6dHKzSQBcq3/1+hM6amZH9qYAaGJkl2t6aenjXYj64Ng8NPK+3Qe5DevPpvMRZDtQKwcS1QEK9DMZWDOOwzGElO03d4LoNIKI0I2nhakoML3roBTXA+uSp3WNQW/P1Mwb5/Mp/masbXqhdiCodc2JNjq987ll9XuUp5r+OOa3ixETUJ2vKiGRxgxU/BTNyVc91RRgJT6Z3/0yQb7r0ifnJy1majpgszuuCNF32BtpgxoIpTrJQ5xaWRdcWtOmsPB02NQGLhaPUGKwips7WZc0426m7i9dd7nhf86VRHel/vSws9ubNtus0naRC3QMYGFAEPnWL+Ql9PrDaAEgUVpbqoSm54iP5mCVTzMhKiQ3MCQtemypFA6WFPfnpVJ4Nz8craPAWVCNMhL1qYgr80VKIQRJtV1+j2a718d4CzsA7hMhXtuF5bukSc1omFq/70kTUoeskVQpGQekoYgEka+bcKILZ2e0f3CkPkCufyB 2uKCvK/O IKLXeL50bUMcvfwJxIiMqu1IHQEAdWOq4lEdvkntbpSlPCi3KlvwYtQfj2OR06/MhCzvP+4FqyNrskE3KqE9Tsq+5HNlqReyhl0iffrpqAgA3WIJmidkUr7904kZmAM6RoGGnZxKBZa30D3qY0XmpgE2HdBiujqk5A57QLI4834Z1rxYvWAjE/IiXivke29GQ/NhhaCQagndbzlv3cD8OKtpTisoBsDzvKy6rQuzSLLNbjPQjNiC94n7++496ZxqpvsNzKCBMNE1xFF99xbPQUwz9ncPbxlhWdushfCuhm/cVfag= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 23 Jan 2024 09:44:43 +0800 George Guo wrote: > There are two reasons of percpu_alloc failed without warnings: > > 1. do_warn is false > 2. do_warn is true and warn_limit is reached the limit. Yes I know the reasons. > > Showing do_warn and warn_limit makes things simple, maybe dont need > kprobe again. It's up to the maintainers of that code to decide if it's worth it or not, but honestly, my opinion it is not. The trace event in question is to trace that percpu_alloc failed and why. It's not there to determine why it did not produce a printk message. -- Steve