From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86CA0C46CD2 for ; Mon, 22 Jan 2024 23:40:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBCB36B0099; Mon, 22 Jan 2024 18:40:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C6C5A6B009A; Mon, 22 Jan 2024 18:40:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5B416B009C; Mon, 22 Jan 2024 18:40:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A63586B0099 for ; Mon, 22 Jan 2024 18:40:39 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 789651C10FC for ; Mon, 22 Jan 2024 23:40:39 +0000 (UTC) X-FDA: 81708568998.01.8ED1CA7 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id B851A40017 for ; Mon, 22 Jan 2024 23:40:36 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="nAr8c/6t"; dmarc=none; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705966836; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=758p9dvwgphmgDQjXvCaf/r5gl7Wa4re+ezrNtGjgIA=; b=tJYeoh2Oo7iQnLx2oZDstv3XVA8TJywnn11zQZQEjFohAWhkHYrtKLB38MkL51KxVqRqfP pRBWh9t/Wn6f03Kktw34z52GwL69Apy2NyQOCGT3fofx9Dfkbc85dNaSjOeO4iomfK5OZl MSy0szeXx6xqIqus6qP6p1hkg5/Jxz8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="nAr8c/6t"; dmarc=none; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705966836; a=rsa-sha256; cv=none; b=VsvQDa1itH3K7OUYnLUUb/DuKO8nwh5YJRwiYmC5GsKBdWBtwZgElx21LBJRw+1kIWs73K NAaYNHl/dGNJReW/xeN/gVte1IZ/rRKvoX7Blq+pNQ5SWEoLUjbKqOSs9p/P8SF8fXr2NL ysIWiNpBgLZDnANN4QQ5Cj9ysUttNEk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 004CA61B4D; Mon, 22 Jan 2024 23:40:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CB2BC43390; Mon, 22 Jan 2024 23:40:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1705966835; bh=0UEy2va11olg9s5mtm+VeIjV/EWP3UBwsC93Xz1hgKA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nAr8c/6tRK+JsCr5vqpn2a/5cp6X59mrnA4Q7GQ2BB/eS3wT8ihgSZGGOS01OA1dv ZtctHjbIEinh69W5JaSlIXMdgeP71/FkwrU8jfGICW0ebU8kddHHxlb56UM+fQWxat 0MSNT49MYgUAm4MSQZMGxwkgITXsArxZFb9e3Pqg= Date: Mon, 22 Jan 2024 15:40:31 -0800 From: Andrew Morton To: "Liam R. Howlett" Cc: Yajun Deng , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/mmap: introduce vma_range_init() Message-Id: <20240122154031.b710f834b14d9027176f439a@linux-foundation.org> In-Reply-To: <20240122220031.pwiravglee7o7k34@revolver> References: <20240111021526.3461825-1-yajun.deng@linux.dev> <20240122220031.pwiravglee7o7k34@revolver> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B851A40017 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 4t93cnd818qb4q1mh37kasmgf4kkmsh5 X-HE-Tag: 1705966836-211837 X-HE-Meta: U2FsdGVkX1/py01h5v/IDoxVTlGHeJrBvfNoCw426Z8L/dd7LYew1I8rzDrljJFWczCqKofPldEM9xBXwTAVQh35ufMa1DBa1ajsaFdr9RdoGlM0ghEV5pigu0kASTugi9vJPokYP/pxi1fPuATmqgUZHZC0tPVkTV0JBlU0zpyXQloDiziVdVyMTWhIC34mRW/o2QXOG7CrQIsWWOIJffG1OMGoSZS1omqJw6n9vdgGARlRIN1NxyQUa/pu47n/Bff+K+AE5bN3jXAHAkJWrX7HjGQ1VGTnYjMLA4WV+gX4CEPoggXrFzxvVZKM0shRQ4mID+51B7qZP6imVdg/V63OAHw6/F03B4fypricK9JbWiVQIv3bdTKDG78Q0IICexc+RZCscwrxSPxWl2TrlhWnRmwhsz9Qjb/gz4kQv/tR5bAg8P9J5xE7jsMPQIh2qA+KDhwQOWHxo3uceZ52ZcHMI4YoB0xIUeHrUL0FRnfyPfVKhRAivlBjicQZcph4wrBeGgDM3I3dovjFzF8T76vS0L/4Ky4UgsxubNeQA2p1EjMJwEVQaNl5SYMems/WoYQRFoH8ccE88xsoJ4xVo6uwtJYUjxoOgbmZmih7zEeRAEcYuDD6vew8sIn9nvjviiQstBhD9nbHzUQ5UoI+33sY/TQ4EejuunYSy0GsriOUb+12mFe6wAzOGB8Xv+E8jLoTKr123O+cBfOlUqVOAl1oCKh6rRhTZI+10xCiC/XQxyAmvX+U0aEWhmSAPFjQoOR9G07eVadohQ4TPU717i3JFkR1QkSaGjsTODzS6HvDaWKD2vnkOjSxHWwBrRvnjzEcp33tpABHBEKQroL0cNFKstkZwPj3Xf1/cw6nkFmd4fvr/H1MFrBmvEj+VEhmslTFU7gPQ5czWrpiIKzYmfiLEqDxGEEOzun/8QT3me8G7ifxBS8eNrNwjvEHBzxdeFCHtMxdBFdGYzWbxYz gZGCfn6u bZ8qZXHMfkHLkg4vd83u0VG+msJcOmK2Xmi83FV7SLb8Ep+NQYQP5Lv4ZK+CAee0nSPjfXlyVP+D3Q1Y2JbzADQh+BhEOHoq65bzJ2lESxbELLtqimlof6l2VB2LAyrI4QIuIMYhWjhqXUTZhmQl4v38xnyYx+GmJlDGm6Lg1kMLSTdrbMNWOmHJdezlImSfxEQQC72bDUQaAAqmSpmwOfOICWZuG2WtwmQS4FG3Ly24ycwt+S5THdQIVKFABZClbrrKiHY+AHZPcjDlttA8KWGYvhDxldb3T9H+Z/GF0uZcgj98= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 22 Jan 2024 17:00:31 -0500 "Liam R. Howlett" wrote: > * Yajun Deng [240110 21:15]: > > There is a lot of code needs to set the range of vma, introduce > > vma_range_init() to initialize the range of vma. > > > > Signed-off-by: Yajun Deng > > --- > > include/linux/mm.h | 9 +++++++++ > > mm/mmap.c | 29 +++++++---------------------- > > 2 files changed, 16 insertions(+), 22 deletions(-) > > This isn't a whole lot of code, are there others? We're losing code > clarity in favour of saving 6 lines? > Oh. I thought it was a nice cleanup which made things more clear. > > diff --git a/include/linux/mm.h b/include/linux/mm.h > > index f5a97dec5169..abb4534be3cc 100644 > > --- a/include/linux/mm.h > > +++ b/include/linux/mm.h > > @@ -3516,6 +3516,15 @@ static inline bool range_in_vma(struct vm_area_struct *vma, > > return (vma && vma->vm_start <= start && end <= vma->vm_end); > > } > > > > +static inline void vma_range_init(struct vm_area_struct *vma, > > Any reason this can't be in mm/internal.h ? That would be good. > vma_range_set(), vma_set_range(), or just vma_range() might be a better > name? My thinking is that some of these are actually modifying the vma > and not just initializing it, right? I'd vote for vma_set_range().