From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BE01C47DD9 for ; Mon, 22 Jan 2024 14:58:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ADEAD6B0081; Mon, 22 Jan 2024 09:58:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A8E5D6B0082; Mon, 22 Jan 2024 09:58:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BA246B0085; Mon, 22 Jan 2024 09:58:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 777956B0081 for ; Mon, 22 Jan 2024 09:58:29 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5782C4095F for ; Mon, 22 Jan 2024 14:58:29 +0000 (UTC) X-FDA: 81707253138.21.18DE767 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf07.hostedemail.com (Postfix) with ESMTP id E86E240010 for ; Mon, 22 Jan 2024 14:58:25 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=m60pKGml; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=xOxg2WM5; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf07.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705935506; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7XOtOUJbUvwMEjgZNJUyrfG6Fv2tEoTZeO4lRjHiTeg=; b=Iz1hKkPqyyfv2lsqk+qecXvbSUzTvZ6XjLXl2rdmLi8c/cePEm3UoMZYjF4TJTPtr3imcl PQU6c38LAdrGC8LG52Zagow63Tu87djIVayTBvitkQGVH3PzAwg4RP4z/2ufsmztaQ1BAi lmavlJkQtjOP4SZqpRcJAL7Z0jceO/E= ARC-Authentication-Results: i=2; imf07.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=m60pKGml; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=xOxg2WM5; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf07.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1705935506; a=rsa-sha256; cv=pass; b=u5Kg+pwuohkgnnVq2skXaJuKWgv9aA4Ta6+P6CVll+KbPR/mXblOrBT47PtKJ0iLv2cS23 Fp5lwbycgiPCaYMb85EugnZL2ZyOtboiIO3QgBoVPupm+b2RvVXVcZIxx2RBBag0Zvg5Cj WF6JHhD8RHtLu3n/KmUYMndGTczzUU8= Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 40MAZFaD008546; Mon, 22 Jan 2024 14:58:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2023-11-20; bh=7XOtOUJbUvwMEjgZNJUyrfG6Fv2tEoTZeO4lRjHiTeg=; b=m60pKGmlWR28G96CnkT76/+mF981Cas6lwnvQEG+BZLE9SLWqPkq+eAJtSKr2PXpv23h kiIBTNZIM2ySRKoFEPUZuufRjOUeXXLWdLFWHdfnnv90kd91y15yRkmMRdZrrjTayOMn UR6zfwovW8R2n3RhFIb49aJNVmLISMIC147G2CeNEcjgEq8Rked/oJOt2b+n35mgi3Ai 6mjm4zP+Odfqti0e9luPoUouIwfAsrEgje5HaC+6V0bd2vxIVz/Eqhrrr1xa0IflFSQJ 2HjDdNagJkNP0Ax5HiTnXFemfB0bViIfwBi6p2P63V3bukbUyzYWD7kelytkJfUdfx6R qw== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3vr7abusax-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 22 Jan 2024 14:58:23 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 40MDrtlm004287; Mon, 22 Jan 2024 14:58:22 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2101.outbound.protection.outlook.com [104.47.58.101]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3vs32p9bkf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 22 Jan 2024 14:58:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W4ZOHTugMd9rUoMCijE85S++/dGPK4YaDJ97jZ7cJrkgCwjn+YklOJ0pRkbq7ev9IHJp04tmEJ1ybV0eei0EXST3oudpSR2QiNa7KIXuleDx/z8RRhA0DDzfjZr8Kbgl5JJaw9lYK2hYygQwusxIdBLYOV0IrOluKdb84Ra7NYHAGJcAClLVq4/DysXIfWUfaBVJ3OxiZT3z5Lh63K1ALHktl+X8n/lBhfDh1aRLAUPQyNS6yuScgtuu4c6GMqIkQPM708Ok2b/zfFI0fXTXHan9lzAtj4N1r/VZviv9yi/GGGrOE+AZUZuDyy0NVN7QDhQXPk0qwaYKB1dvgHuUhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7XOtOUJbUvwMEjgZNJUyrfG6Fv2tEoTZeO4lRjHiTeg=; b=EzWRNxiRY3/uxLdQG8XvEQijNiVWcNB6symVzac1zSUNfl2ZICTxb/pasG02XPCWaT0EZA4IsE2CnlT8WXweDu8GRZjkZqfJ482SM0BHokqbMU6ugi7G+b70I4FSvrgIs4IVh7sSeEsnC47zyrt6BPCywQqLOYCbTjuUL8ZCV7cSBsmdUUwA1XOOZrwDCqkPHeSPps9bvkEyNCYJD7XUYFnehpAG1FfCRW8+cTrZ5JV/yK6UMZ1bKQlRkekuTN8vWyxzfXTyMe6JJN+Z7LIykXyZfnOfiIB/oULxdUJreo3IUcHRVC9RGVaDbwGFNYcdoYOCsjivYi07IzVIMyn4pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7XOtOUJbUvwMEjgZNJUyrfG6Fv2tEoTZeO4lRjHiTeg=; b=xOxg2WM5NFCft8wAHl+Sn4M8bUHc7kQ3WvJv8nf0TLexFckufCoFnupb2UzhDYK7+vf1ba69svdQeYyRlXAr07RANNrg+YmOXnIckrCsgF4ZAuiwIhxT6WBhnMz7pp61N+IkeGjS0k/ybPCgY8TL5JImKY6lN4rwTdkcjYNiT0s= Received: from DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) by BLAPR10MB5300.namprd10.prod.outlook.com (2603:10b6:208:334::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.36; Mon, 22 Jan 2024 14:58:19 +0000 Received: from DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::20c8:7efa:f9a8:7606]) by DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::20c8:7efa:f9a8:7606%4]) with mapi id 15.20.7202.031; Mon, 22 Jan 2024 14:58:18 +0000 Date: Mon, 22 Jan 2024 09:58:16 -0500 From: "Liam R. Howlett" To: Lukas Bulwahn Cc: Andrew Morton , maple-tree@lists.infradead.org, linux-mm@kvack.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] maple_tree: avoid duplicate variable init in mast_spanning_rebalance() Message-ID: <20240122145816.unmy537vtaqflhfu@revolver> Mail-Followup-To: "Liam R. Howlett" , Lukas Bulwahn , Andrew Morton , maple-tree@lists.infradead.org, linux-mm@kvack.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240122102000.29558-1-lukas.bulwahn@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240122102000.29558-1-lukas.bulwahn@gmail.com> User-Agent: NeoMutt/20220429 X-ClientProxiedBy: YT3PR01CA0107.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:85::20) To DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB7933:EE_|BLAPR10MB5300:EE_ X-MS-Office365-Filtering-Correlation-Id: 7373f1ca-e5a2-4900-b5ec-08dc1b5a91d2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GydpTpJIxAXygf0f0v7oqazANcKsJBd7yh3qKRMYeB6YFCLWAo3HuZAwIsK/0tAyv7p6hksf1sJ0o9sCgcwYHOSO1y/GAYZWLfLmXVCQOBIvTQNkq05+EKAZ2UuYp7A+AcmcIMmJ67hU1KZ11i69luSyi20smX9mYejAPFvbKuw2n+OwSPdU5ieXZdb2fdIFzWzRTsuoTHFrTHnPV770Hn2Zr9ig5lmrQkd6Az1SMgxHoICBd7st5a4W5xT6Om78eEd+/dKEEa1z4qicvK2LMNRMsyjCROeg3rFfUXwCT0jUwPrtVesyGFMotk/R/DcLsNVwcIapSwrH1sEVZ2EfwVOiPEKtGJBCF02C3YBCYMjrYl3hWVQ2s+EIxcXI6c0V8g4hz2cngoQbU+q3h3YM4hVnlnxFeRuY85T1IXMRe7nswatruMzsV8YbCOeOkRGfMFxXlPCii76YESfUPLKWCrpIz2nr2wvWOc1p7aw/+M/lbfFCNpTqkzc7RjrSOmXSVBwBOG62dByDp/OSr5SvlxFsTPi1A/Z9SKxDY88XkUXgJ0WeDNKgH7xJb4msnpVD X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB7933.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(7916004)(136003)(39860400002)(346002)(376002)(396003)(366004)(230922051799003)(186009)(451199024)(1800799012)(64100799003)(83380400001)(86362001)(9686003)(8936002)(8676002)(4326008)(38100700002)(1076003)(26005)(6512007)(6506007)(66476007)(6916009)(316002)(66946007)(66556008)(6486002)(5660300002)(33716001)(478600001)(41300700001)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pn8vUaXFpLZ9TF2FccVL2eJPwQUC8Jm0Ori0Za3p7zXqHSVYnoApxfTz5Sqz?= =?us-ascii?Q?5Ml1eXfP05FID9gwwhmT6tY8KIP6u5k1BLBFexa5EIdEEDFsHnvZnxl3Uf/H?= =?us-ascii?Q?NLgQQsPJV6+wLNyMhEg+rKoHb4xTcwUqaeNqVd5gvF7i6GGbzFXGjwIdR3FD?= =?us-ascii?Q?L3gA883QKbMU93ZtTxxQEAHTE+1kbcWyW2JfHwvyJwzGHzj5PUssi8WaFDDD?= =?us-ascii?Q?1FAEK+fdtlGxhKG9qmior5heZJZ3CFcNHJhSqnAqtjDLa/XTwnoM01pW3V/f?= =?us-ascii?Q?WwOoy4jgGb6Xk6Ksor9F0nS3rwU+R8a/R811B4rDuX9twFnKsSj+gDslgAtc?= =?us-ascii?Q?5CKHj1At+13HiUWDdmc8mA5PV1cSXf8ujbADREvZiMft2Avbo6ZAlwuL/NqH?= =?us-ascii?Q?/EdP7Ck+QovUKWIZBeqasbthWiVqfA7fUpWgZB1uOweFJYVAgOz0Q3gjFRJW?= =?us-ascii?Q?6L6boGDFf6uD4/dJ8rYN/8TlPO9vtiXw/NVMfqdiG7nv4Ed18+ycl2mmrIN7?= =?us-ascii?Q?KsZNU6KqESQz/R2XZo3w5Xj9fkT7IQlH/VHEHcX8sWuXeRnxOjyXvNLF5bhr?= =?us-ascii?Q?tXYEX1elmk4WWu8qHbfnxOaeq5dLoAZMFnToV2AxJFCOlndfWRhHNq1C68F2?= =?us-ascii?Q?loePPwijMSrzwAZ2xS+x0eQZ5kE7crtoXhDWdt6NC9m98hID9pAwGujaO6+i?= =?us-ascii?Q?8h9pvNeRoTLEXHlrnqHwL6pHmtettHagJhtcKyA3itPmC642b6cU1QcZKD3b?= =?us-ascii?Q?I6eDG001UfctV7ztES/Yzm28kYYXf4WbHxuagQFwDST2773S6JNvY35shW5I?= =?us-ascii?Q?NY9WXhNtsKiJ26j+JmZ9Bl4jxrNJ/u9GTRSsZUQ95w83qClDuSdMakCGBO4I?= =?us-ascii?Q?GGM1r82gAAww2e2TGuoaxHtVVR10DXZNPRF0KKypLaiX//RDNJ2RjTHpxIsT?= =?us-ascii?Q?mdyxN6ylDgpinNJ1ZbW+tr0BgDBigpzNqKOmHybsURlmyU9EobaLSlVD0JPL?= =?us-ascii?Q?390FwglmTZSzvnTFulK+tyJVg0IEZ8+oNLp0Uy9CLZDs1Ih1cuVH1Kq6Pske?= =?us-ascii?Q?o/TTJPBZNwSnADDh/KPZQeVw/nYpucgBwbVzV5LdqDhojC1YC8nURLfVAhG8?= =?us-ascii?Q?a/gDiOXSjS4p0LKxVJWxRP3KZ/KHRJr0G7dz2RdPw2KsWFtu6vO+LMTzIfLO?= =?us-ascii?Q?YhHUnq5Ro4U2jRwZuKR7mjhfFDZ0r/+K9qlQATZUkfUaZB8Edna43VHFrt1u?= =?us-ascii?Q?EvlP0c/+3uxzda25pREh52TBU4pA8WyLRk88ydOLsb1pPdk7qUOt9MFPjSD+?= =?us-ascii?Q?2QE31y7jOoBYkrMQ0bBNAOkWfPMon2hVQc2A9mt8yAZsHnWl1c1VaQohNbmu?= =?us-ascii?Q?u+g/pWpgbnowg7r66OnsHTbtHzFJrKvCrUXRAD71aKpM7T1qlETrkIuL23qw?= =?us-ascii?Q?9vfAzNqDHdfEpqGN6ext51sPjunxe0amZT8sEIG8R39p+NhVrQdJ3KDxVFbm?= =?us-ascii?Q?ooRH5caF373p2JUTXPoEdSnHbOJh6r6rRFo34ANXuCRq34qof7uQinczJ6dp?= =?us-ascii?Q?rCWU0ykxD/3VulTEuYgSd86H4XC20Ftrtdt9AMus?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: adSCpGZXI0yGb3aKtdCPx0ndyRAHl11ZYkRVzFsSodM3gOdrNzC1wbozxrtBWPW83/WmcirjrBPAXc4SW6vQDi14bZ3H4yTbwcUcMsbA9dRXMGViaAz1F3MXEK77Zkg1umBInEqY10bR5k1yfbCIjl4ddpBKvzsTcrCq5Rir96o/VU+1/3qsZW7ay8dh3vzkAZCbjw24TBIarhjeXLr8ZULMeqVyScSa8yhbAvNeuMWMe8D9FHwopF7K9L7sDv7FPUla4hoc/i3X0ZQ0N6W0tRc4L2dz3TdDzKBH4FN0ybikv4s9r3qWUDXHQnRI55mLxJn7PACrUgQOketDoWz2cHdT0VwaWL+g8dOwqCiOT0V0nh73Cuq7811QpNdlOtcmwGkd7v6CX4AUi6wyua+I/73a0doT5Rgb9riLbEpfcu7GRFkAhaZYIweZfij9GLbXy8RLHGrSjyYKD6bDWZH0bOgnheediJsj3iQ1Q/CZo06SDfQf6QKjQlLbBb24YYoznq1oqHuHQpmDZA5+R0o+GJEAAe+9it27QAm6v6SCSb94MBq7fr3VJpnz38fEdvEgMXuaHkTJf/k9WI564MpSGvBCHL5M91bggns+nHMedTA= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7373f1ca-e5a2-4900-b5ec-08dc1b5a91d2 X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jan 2024 14:58:18.8892 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DnKOl8Fh+Kr8tpzmtG6LhWI5DSITOEcP0u6/MJAT66iw7yT49lR4Phfxp1PEEL5z8ZK3YGLvQdue2JlyG1tTJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5300 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-22_05,2024-01-22_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=999 spamscore=0 mlxscore=0 adultscore=0 bulkscore=0 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401220102 X-Proofpoint-GUID: fE-YOL2dUeQt03jrMcjj-Njs5j7CSH8W X-Proofpoint-ORIG-GUID: fE-YOL2dUeQt03jrMcjj-Njs5j7CSH8W X-Rspam-User: X-Stat-Signature: kze8t8pfhse17uoq8oyxuejjp5qitg41 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E86E240010 X-HE-Tag: 1705935505-808428 X-HE-Meta: U2FsdGVkX1+SJ7tGe/hq7+b+S6tF+ezZGLu1BzBC7iGbDK1Ox4NRYhTsdJ0F8kYXnQjpERW30muPi+nMXgz3qWop50cvDOyGp16fVCsGgsUL5UF0/wxhlwRJrIZDJzQnn1NUjg6JpPZsk1jStaPuC/O1yUydjNxXCCYPIvXXBNU91OD4PTWkxjpaqUDXq/TJpJxKTSyhtSYJRERXyZDmNOChOOudG27ockv+QE86NjUFc5PHWUQxn5Dz1BpeSIAAaSq5KD5/SeM6JNiTtwv3F4SEJSN+97eA4Yg2JLwRcw1dgYWb53wtERWtuKWvBEHRdHMhi2J9kQGMiysRip0DeN5XA3YTOnU1HvCVnzEr8JNJmc6xgd92A4TBtF4//CBCGMC6Fjr3dbo3OGcFtgIrJ6CsWwc6cjhBUF2ZUUFvNs4si0DkBDJ/6ZNgwK5PRdRDggHBK1P5zN4zIZQ665Jy8GJtTVBFFc32TwgytI3aRRlt3DpQoCXMnqkdwgdmOaM6Ch2iB6oVMDzZneP6Gvxou3VG85x9bZbWTrRBuh8CS4J6IYXlMKk7DPfpJtBB7wUAJvFNaMHJFR5RrHcLSBi4uuEsvD3bnd/1N4h02WVL+4OenZsqlvWJg70T+IEZHAkAgACLApkpuWxV5IVL6HVWKd00yfCirHAK99DvpUOKAj42L6sVCKrm0q6ZIixNIKZZMeL7hXwgoOWen4ntuwXBnQR52HzEAcdE313+dJ2HOSJbG3gCRWkkV7CqDofKaUrsPgAOjm/IhnTF1P+wwGY54Y/Ja5mxWT7I56SOXap4P2UQ2BCs+YbLYfwszjiP1R6JvP5UeDze0DukkBljcE9rUiCGlSLT8r4r5Y1KgmC3PIBgZBKu+/JZaXluDKL3hIbfToQfEQ2zYnb774hsopEEx+gMQff+T4oSOHkf7xZhUPdwj6D/2v/7fkpC7k/xtBy6DFm2wFdslQlr0U0TGDh vlabqpbd aM3ttoxPnCdKKl6Nr4LlePcuGr6hLktWQAwnqOiljSdSZFbI/QA5KFFyDDX92SvtesEyayPGJe+hcqiqaOrggvBe+i3813E0zfVCb53sdtH4JNyesgm7LgIblwXa6OqGyZW7F3MT48jiMf1hwwUHgGgKFlPBixtnJ+LFHuBoXj2+47HioPq+dNN79SgDuvYNIrKKdy7X7uaxvrSVoLOAkapZ7fsSpeKmIQVtSN5/9f8MnmKhV6ryL8V5VqTYfw0YFbX9ak5pTLfOBHcUqzhe9KTu16SndZzKT0HM/++09OzWsQa9pUnfMTg9DXh5SW7TR1NGCP/bcLE5fdBAulfj2TSsr0HVOGP4cHK5jJrY7rMcDMd8a77lItvO9TnhFXXyM1fUbsYO3nvHK3O88pYQa3lNj2kUrYyIUIQG0UlnM2EPum9dyPi0OZ1v60RSIjsZI6byl7ofD2TYhuuC15d/e0eIQOjvTqXd+HbdznVcIIm87BX36kOf17UJ06zXGJZ8GmJlpX/SyRPFVxdzLar6nyA5RKebV/1LAMQCWw/XzOCZbdS4/0PDfLI5H4w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Lukas Bulwahn [240122 05:22]: > The local variables r_tmp and l_tmp in mast_spanning_rebalance() are > already initialized at its declaration; there is no need to assign the > value again. > > Remove the duplicate initialization of {r,l}_tmp. No functional change. > Due to common compiler optimizations, also no change to object code. Hello! Thanks for this patch and well stated change log. > > This issue was identified with clang-analyzer's dead stores analysis. > > Signed-off-by: Lukas Bulwahn Reviewed-by: Liam R. Howlett > --- > lib/maple_tree.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/lib/maple_tree.c b/lib/maple_tree.c > index 7b161802860b..82fb5195c235 100644 > --- a/lib/maple_tree.c > +++ b/lib/maple_tree.c > @@ -2271,8 +2271,6 @@ bool mast_spanning_rebalance(struct maple_subtree_state *mast) > struct ma_state l_tmp = *mast->orig_l; > unsigned char depth = 0; > > - r_tmp = *mast->orig_r; > - l_tmp = *mast->orig_l; > do { > mas_ascend(mast->orig_r); > mas_ascend(mast->orig_l); > -- > 2.17.1 >