From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA773C47DD9 for ; Mon, 22 Jan 2024 15:55:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 806096B0074; Mon, 22 Jan 2024 10:55:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 78E836B007E; Mon, 22 Jan 2024 10:55:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62F596B0080; Mon, 22 Jan 2024 10:55:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 50F106B0074 for ; Mon, 22 Jan 2024 10:55:40 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F308DA0664 for ; Mon, 22 Jan 2024 15:55:39 +0000 (UTC) X-FDA: 81707397198.26.02B497D Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf15.hostedemail.com (Postfix) with ESMTP id 3F681A0011 for ; Mon, 22 Jan 2024 15:55:36 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of "SRS0=hYLL=JA=goodmis.org=rostedt@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=hYLL=JA=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705938937; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WeztMH++F2v1ngvCHkG9pQNZmPheS4h/WGzhGYFvzK8=; b=8I3d0pNiq/jgm4c4+xkh26N8QtvZz49yV3Fwe1xF+sWeeoBzCjHYqUsBRGmEr2EIlLWEhe QkLGfryDRLEM4uTGeO1e0rHykicbNXwGF+RZhB3T+2geNQCqqXSK0+LD2ULo6FLB44HdZl Ivimy448b9IR7wdJYWLGYmvanzMgzx8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of "SRS0=hYLL=JA=goodmis.org=rostedt@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=hYLL=JA=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705938937; a=rsa-sha256; cv=none; b=qtkRP3pnTnKq+rdL+AMh/uTfD5AsRBSh5I/ybVySKBJ0NM30O06oIa4OKd67WJWJkI5uOf /MkOK6I7fdE6e2emTq5DvJ0XdMWrHMkXPzCmdDXAwxgznTOaW4vedCD88jW2CXJOIK/5jo E98zq87W/87qOaHUq3tEaELunVfHDrc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 6CE85B80EAF; Mon, 22 Jan 2024 15:55:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6071DC433C7; Mon, 22 Jan 2024 15:55:33 +0000 (UTC) Date: Mon, 22 Jan 2024 10:57:00 -0500 From: Steven Rostedt To: George Guo Cc: Masami Hiramatsu , Mathieu Desnoyers , Dennis Zhou , Tejun Heo , Christoph Lameter , Andrew Morton , George Guo , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] percpu: improve percpu_alloc_percpu_fail event trace Message-ID: <20240122105700.05e5ee46@gandalf.local.home> In-Reply-To: <20240122073629.2594271-1-dongtai.guo@linux.dev> References: <20240122073629.2594271-1-dongtai.guo@linux.dev> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 3F681A0011 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: fz1ud7uuaiqrcm36h8kohuyteozgdjrn X-HE-Tag: 1705938936-145968 X-HE-Meta: U2FsdGVkX19eiz6TjCjuQo6i3gIl2gooWF9uJKI8FWvyveJVIpcBCR09PNFSu5UsnKQ2Yg0IoU2GRa42keKn12H916883sMRi3+iz34JtDozfnfzqisddad6vbC4ReS5iah8TvX8BUXchtmgNN0rpWhmZbWqfKYXlUMWITMDG6t4cEa88WvnS/JC6QH/4D1vQx5WlLNmZ49k1/39EoMiiw58v+C/7nIwtSCsQ8D5jpR9UO4XSEHIlA/FDMAcQT2JU9IEJtFAHC7AubUu1pNpOKIgIAqnvYQM3FTirQKq1+64gZ/k36i9gI78e3V1LSx43gABaGOdePiliFDq5pqxRvSDziRFXPllhy++LKi+wKIpI3zf+iDiDqTt3gWMfnBKH5YuRKKkFRDTQ/ID5nF9jDAkMniaGu+k5fdPi0Ad7kdktu5FAQ31icv41G4Oz2Q6OJ669Siqxcvq61TsD5gB1G/+P4XoPH9JW29TYGX/42CDr4nxWPHZ9iui03B0MFdHBFKlrfXfL8jnC7lKvVNiaZVsZMm3TbSr89qvAOvOWEuLTLbbqkpIwdlYvvnV41wtKeexQp7reOdXMZ53zPcSo60inQ6LsQvNuYPiyV0ty9qK6vXm60x+IgYuICG0fTlyAi5VmjIaRacLEDwXraTUeJ/6tNIg9+dtYhm39YJ1B8YgoBJXIZFhhAhvie08ojFURE6rvMrGB6ZooKoRI1OdXpH1q0O17iR1edpw4KRqVMXea/D0zqqILkniLB5dd/6aMLE+QR2f9AKNZ3VevyqQQ+egZAVJImlJpsfI+5ATfgQkDVmD1vrbSq2M++sC0UuaD+6QNkrlB1+qF3vxKZI4f3crfMfNzqdX+gKO8FFTRhLWcQeAGhKQ5vyBymVuAlL0ccVl7mJrvH+eJxGOqXpiZRIMfJnD+q1UuflomepjfNUpQT+pICaUEG7xBemxu81iuiyMTqz7jnCqZUX2XcK +5ZarLjR CcsDJTxSLPocnCmZpfyMu1HSdboaXMFQG0R4iOFurY7lD7ZD0LykDnnpwHQWt6D9hKg6i6f2F+mDWYh/LYZ0ndelbfWnfu05LcLIy9stbA7Hfr/M2KwURTIjauLO4RGwkDUCZ4Lr8+33++ETQYgbB0bYpLp8imu4wRmVUFX66zovAbf++KwI9dEJygwr6wwvcuoYR8h7xHjYCt4Enve+07kXwT6FOq7BqNJM/cdgtr/HUuH5zPRuARYDeh/AzDJzJNI151Yl4JAAo48cHTfUj+8hqw0UXMn/WT1+jt3oyLKW0aSE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 22 Jan 2024 15:36:29 +0800 George Guo wrote: > From: George Guo > > Add do_warn, warn_limit fields to the output of the > percpu_alloc_percpu_fail ftrace event. > > This is required to percpu_alloc failed with no warning showing. You mean to state; In order to know why percpu_alloc failed but produces no warnings, the do_warn and warn_limit should be traced to let the user know it was rate-limited. Or something like that? Honestly, I don't think that the trace event is the proper place to do that. The trace event just shows that it did fail. If you are confused to why it doesn't print to dmesg, then you can simply add a kprobe to see those values as well. -- Steve > > Signed-off-by: George Guo > ---