From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E153C47422 for ; Sun, 21 Jan 2024 12:41:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E1C258D0002; Sun, 21 Jan 2024 07:41:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DCB598D0001; Sun, 21 Jan 2024 07:41:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C92DD8D0002; Sun, 21 Jan 2024 07:41:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BAD908D0001 for ; Sun, 21 Jan 2024 07:41:50 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8438AC0480 for ; Sun, 21 Jan 2024 12:41:50 +0000 (UTC) X-FDA: 81703279980.02.2E2F9CB Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf15.hostedemail.com (Postfix) with ESMTP id 85FA1A0007 for ; Sun, 21 Jan 2024 12:41:48 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=RZTMuyMX; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf15.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705840908; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DdanBUUkzmEiL4WSI9ML5YIGh668EwCLp/CMKO1Dfnc=; b=dMfkaUUKVuL6vqBXAwODnJy6ZQuC0NRhpMUdRvwZbN3Fz1lIK7kaloGnCbUKjVe50gkvAj o6cKRYNv8XqqbtkSkXpnow2j5omlAAqcr1ekx9hz7pqsM87U28/ePm93xCUeJoIIPTFVis rmitkvUagSpfvZqq0fDACN54OuBDb2g= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=RZTMuyMX; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf15.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705840908; a=rsa-sha256; cv=none; b=7eQN57+2qKKrnQQdEGCCRqmB+uNX+mTvdtLGpgNNRFRIr9TbqhgzmQikFAruK4NW2B55FM 1hlySDDmQsJsjGZ/A+QLKaNVvbcR6rYMXN/fLsuZeQqSaqnM4ukvvzBGUZHsDzd7zFt4eA jyHAqQw2ACmxxN+Ls7v+UiTxhq0Y16E= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 3174D40E0177; Sun, 21 Jan 2024 12:41:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id n2xllazxIvv4; Sun, 21 Jan 2024 12:41:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1705840903; bh=DdanBUUkzmEiL4WSI9ML5YIGh668EwCLp/CMKO1Dfnc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RZTMuyMX3VgHk63OanWHbKzjFKwZiqdXLYCiVXJhzB9i3WpVpKJ+3d6zftj9gSVIu 77xLCZ1tjQvsjiwNzqySdXhaV3DVPeAkW7s2edCI3z2wUsyhmbWQwv1qUyLv/3eZu6 K20T0sIVPQp9u2CcqztXJnr+dDoELbMEVVCpUvp9pTO1erBkf/id+HlwoiDMl68k6F LHrQLs5kOa/9KSQF946VvtBl6Lo8Jr7Q9eeLd/MPMLaZZn7koA4cQJkBQkXpaElTSz pnl7ekltsypo7YyGIefJlpkGg8cGkK78qVbdj03pRewqW9RFwHk4iBph9+nKBJpWE8 wB5MdGS/taoN5YeyhbdJGTQBNoSqkmcYbWdRB4dQi0PQQI1SteJOAcDTb4fTzu99dc z18R/pNaxbGy4q7gV2dWtMN7Q+6lYimR58vxr3O5ZgPQMsfkTNNbzI+E8y1fI5bKDE W1wasiStWVkB+t3kGq6tmnX6TcFmaFZ8sQbvGS6w6fr5k0anDm+Ddvhl9Z1B4dbrA6 G9lkDN+ZCwy+lEoJxh8xDRQDTwPqENL0bomUjFV975KK2npNCLfKK6U8JUZKTmwPq5 uUmzyeDDN/p0tR1uyS3ajxEg/gVjrbvq4hiUKq8D8b2m8guGhuodYpWBp0qnba2W5M LwAkg6N092PjLvUSz+CFsiho= Received: from zn.tnic (pd953099d.dip0.t-ipconnect.de [217.83.9.157]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 9771940E016C; Sun, 21 Jan 2024 12:41:03 +0000 (UTC) Date: Sun, 21 Jan 2024 13:41:02 +0100 From: Borislav Petkov To: Michael Roth Cc: x86@kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, Brijesh Singh , Alexey Kardashevskiy , Dionna Glaze Subject: Re: [PATCH v1 26/26] crypto: ccp: Add the SNP_SET_CONFIG command Message-ID: <20240121124102.GPZa0Q3oBHLG0fH_yn@fat_crate.local> References: <20231230161954.569267-1-michael.roth@amd.com> <20231230161954.569267-27-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231230161954.569267-27-michael.roth@amd.com> X-Rspamd-Queue-Id: 85FA1A0007 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: y1ioejqsznzdu5qhk64ds5u55hdd6p4p X-HE-Tag: 1705840908-774306 X-HE-Meta: U2FsdGVkX18381WuZ1WtA0q8g52hCkzt78w2uTPHy69x09mi06j9u+XmqsVQY8HRW/8WBaSfCUvLPs655iLcqb4kfn8bSI68ZEPmUJihJPdiUKVDAAc3ngtf3p/xvu+ljxn2Ru6wZ2jMlprhYxilTuUnddHC0mws+48m19NgL07RMjp24H9b+i/V1U7xt4GiQgePlvELS6YwdQwe3KfdSf0XO0DmL3NfSYwusnCv28Is87dFM/cjq1N8XvNuENJX6VDl++lrIV0AhPdYQfanttyEcRDm+JQ7FbgCBG2fOA7/nqkvSwI9oxLYbi6bkqax3tCpJHA2pJPJByNQKBUFb3mUoKUB2Neu+qmLucNYWw/n4sHk59RDMfs7zemJtujvWcEaP+hGho7uCluyUkFi/0DTnHggm98Y5MIdWznQZbZZxaSZHXKR31mGBkyaNm7z6RX32nPjCL5RcTRT7NWoxqT/EsLIvhAbpfTkIUt8Lu+0wCDrVbXghe+KYcRPBaGrrIS8rUkuUoaLHReH4N9V5KAvN7N3UYpVS+muDTu43z9jFeLJXtItKFwxEi8cqdQaRaDwFziqSRQ5jlE/X5YUs5h76KDUUN51dEn7chLhyhx3Hp78eqIw94f8Iuqa7OCOu0AhwiaIkPUADBR8yg3Xn5bOJHs3BnAG3oVbkx9aRkeC6feeJ/6Iol3DzSTCOmGS52qjum6aDpZkKl7Yvw8yzWjJi0SGbLZP4b6oVn4pFDkKgagC0y3jse3RgWlhd3AzxXkqwgCF60Uy2Qag9hAniZzloziN8tfkOXLQHZgr/tDHdsyPVp7tYYFpEEN0ordvkH5tr0u6f5ET4MVk+xw47T22f/pghiXPl8hviULT2MVTalUupsPMlkAyjgWp0DjIDZ+oo5kYbVKA1XT4bEu+OMkGRNYwcMUKhwzEi72gXNmkumO75rCF4yDMrcVovof5WVRdmlyPi+zsZwTwJgO AZZnoKK/ ZZkhvV3+COx8cccTpTrbgyaeeXqYWijuFnLbDnF6oXbd0Bw0LSVUEIklQKJ44ue2O7CyBrIuBXeNNSqVTcj5btTgT1n2F9h2Cuj5kXtmjuS2ni0pNUT8KYVxqab9hnwe9UdugotWwypDlkIzBNQn0P1kEwwfNUj+ra+dKsNi0CxFhh6FpcBS+9AYRMujW5446JzrDy66jhqr47N7XE1uZvTkKIaJfQrRKxBhCO6iR4nOJ8xyfZHDzb+8sOg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Dec 30, 2023 at 10:19:54AM -0600, Michael Roth wrote: > +The SNP_SET_CONFIG is used to set the system-wide configuration such as > +reported TCB version in the attestation report. The command is similar to > +SNP_CONFIG command defined in the SEV-SNP spec. The current values of the > +firmware parameters affected by this command can be queried via > +SNP_PLATFORM_STATUS. diff --git a/Documentation/virt/coco/sev-guest.rst b/Documentation/virt/coco/sev-guest.rst index 4f696aacc866..14c9de997b7d 100644 --- a/Documentation/virt/coco/sev-guest.rst +++ b/Documentation/virt/coco/sev-guest.rst @@ -169,10 +169,10 @@ that of the currently installed firmware. :Parameters (in): struct sev_user_data_snp_config :Returns (out): 0 on success, -negative on error -The SNP_SET_CONFIG is used to set the system-wide configuration such as -reported TCB version in the attestation report. The command is similar to -SNP_CONFIG command defined in the SEV-SNP spec. The current values of the -firmware parameters affected by this command can be queried via +SNP_SET_CONFIG is used to set the system-wide configuration such as +reported TCB version in the attestation report. The command is similar +to SNP_CONFIG command defined in the SEV-SNP spec. The current values of +the firmware parameters affected by this command can be queried via SNP_PLATFORM_STATUS. 3. SEV-SNP CPUID Enforcement --- Ok, you're all reviewed. Please send a new revision with *all* feedback addressed so that I can queue it. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette