From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A740C47DAF for ; Sun, 21 Jan 2024 12:30:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E43E6B0075; Sun, 21 Jan 2024 07:30:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 693CE6B0078; Sun, 21 Jan 2024 07:30:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55B056B007B; Sun, 21 Jan 2024 07:30:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 46CE46B0075 for ; Sun, 21 Jan 2024 07:30:10 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B840040591 for ; Sun, 21 Jan 2024 12:30:09 +0000 (UTC) X-FDA: 81703250538.20.77EF02C Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf07.hostedemail.com (Postfix) with ESMTP id B8B8040011 for ; Sun, 21 Jan 2024 12:30:07 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=HoXqq8RL; spf=pass (imf07.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705840208; a=rsa-sha256; cv=none; b=QfGFEttKV77XCTfg+e2jQajPl50s/uVcpWixx+SwgkSo30XWmvPqPrc6yB8uNAr/Mg5KgE 9knHEKjIrtjOSr4in2OdkWBU31Dh2S1nyPrSoDbd2b/zPEm5vhiXRUMa/vKyP5TInZsfBj GQ1EsYmdvH7JOUNCQEugXxvUwGPUktE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=HoXqq8RL; spf=pass (imf07.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705840208; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lJOxa1NCDjYe68V4/rORBTiQrTtE7y7uT1l5Klq2ts0=; b=7mbIAuO3MgSRzA/3tJjvx9Az/Rl/IN6IGReeyQlgSiwdK+roO+rg7p00x9FPb3Fod+X8eh YByA8PJOjCRpFmVyy6bkGPCZppcKfCqJeE5vvEXmr2BB+GlNA0es2Aj9/gcgGqmPI3z5DW SCyAFqN53g19GRbHlR8Y8tQksGVHOoQ= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 258FA40E01B2; Sun, 21 Jan 2024 12:30:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ajngsX_v5-la; Sun, 21 Jan 2024 12:30:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1705840201; bh=lJOxa1NCDjYe68V4/rORBTiQrTtE7y7uT1l5Klq2ts0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HoXqq8RLCkrmpO1QjbLu1QiCwSLvezQ5ioigMzvYr66LSize0qo3TpiqiL3Yn2Nmh HC6JckuX70qENvSuyYR8ynjc+jc3rdWJUaCamJgQMsw427FJCNEKl3FualnU2PvdVH yffKTLyLwQQh9694fcNi3HYSkuUUB0+QKxYAG1fToyzyAZZypqqvja562aJYk5HIu4 Pc79qQYcWZkrNeyEsSyMfj9v6Tz6w71IvHPaao5IBMVRqyuf7M/YadI910GrXWgvaf 6KS6s2sxb98gs638wTLulRLGl6WxkJZDEVSlJT2Rwl84d+0EG18EBWShkc00G+NRr/ ZBbnsB6y2TpRZMWVPTOTcccrHBENDFcQXegSCBsijmZ5QdO0krPWcARIBe1I/4Ecyk UxFz7hnMgjqvlImjR4pDQgRplQ7gREMljXGRcMmzcdIL2Dc9+MeIPoAG6jdzrbzeis zqtdBGy1inZ8R9eLSmVTczviJ1TqlYF84k4uwFhnknnmVT1srVdxPjf8z2ZDGrb6Yw oWLDfB0TUkNXFMr/uqyWAx69H+1gKxH1SlAohCZkG0WG1qP18s1rev/U/HW5qLV9RC YNoGWwIkXh3xKJxGtSxtzXMZmq5oxCn2V9bvdgJMBqMXtC8pkCwJJJp9X6klrUC8AX hBNfZ6xIXOm+lBiCqr0HWBy0= Received: from zn.tnic (pd953099d.dip0.t-ipconnect.de [217.83.9.157]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 5303540E016C; Sun, 21 Jan 2024 12:29:25 +0000 (UTC) Date: Sun, 21 Jan 2024 13:29:20 +0100 From: Borislav Petkov To: Michael Roth Cc: x86@kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, "liam.merwick@oracle.com Brijesh Singh" Subject: Re: [PATCH v1 24/26] crypto: ccp: Add the SNP_PLATFORM_STATUS command Message-ID: <20240121122903.GNZa0OD21W0UxLmOAm@fat_crate.local> References: <20231230161954.569267-1-michael.roth@amd.com> <20231230161954.569267-25-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231230161954.569267-25-michael.roth@amd.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: B8B8040011 X-Stat-Signature: tfpfj91fuxhxutt6ee6fn8cce6igqntj X-Rspam-User: X-HE-Tag: 1705840207-311309 X-HE-Meta: U2FsdGVkX1+wninsWS6v3oh9xplxIBEFRorBuo91USP7ZKpTIdi8Skno0hvM/YE4mdXWToS8r0QLcJAm8ooJAyfr5iEDtB5zC+wMpcgfzdKEB79syHREPMnHilO57lFFJlZePaEJgZojkMzqf+3rsvCvOw2RASV7EtVV/siHMOYTsEPefgIDj9zbHtigN4J4o0NeqcxLK0d6ElTF+7xkwYIv6wezlyT5i9G7ehons85223bLQcO8MfPyaEb1QEN9canPPecIaijPFjrQLsvcsoAWJ1NvgayArtjxTUKZU2H41+F9kAwnWoDJmI8Rd/e0QhJ6tFCjdJ7dm1/cc/wlAWVHvQg2epHgOFsbsnnrzKy52GwOqUj/sPCeTA88jaQFCPY5b6RUUyk7Nq0BfwUmwWk1aRXDc03LKI9OtVsCsEmV8R2IDYLjPtSc8zZ4o4Zv9q0l+oUDloWtBAP4ISoBrvckhJoFJ0PmzOyGuScPZfuc6XVLAhB7qhO2eo3KLCoeJSiSB7KcUOD7K8cVswVusF0Oes98ji2cNIXm9ErVTYANDDv6YpenieURmPeUMRkQeZ/VaX2FNtf1ES0vVEDlyqoGnsyQ0C3IAGuaSLTCWZ+UNXB3UhCodVFv8VvyPAxDmA6HySQjxIuCqy5hi2368zBU640wz3/KKkxH7mUe0qnArUpSmB2t+NgAwIi9Yt7rwQIGQoDuQQWPbOCPyjk/dBCaLkZGxa8s0/MaZBS/BpiZTKD4EpJ3qJCkqrKkPso0mVst/JBfxfCHsZIm2ABJb/oGSWSr4WPePit5bnD2oSipqDoJ4J7REOlJW37kdnJwEfPIRnFQKrE21qoMfWFlSR/S+esEAH73bSNP4Oz595KUzMgOEQmVSu3pvl0INVz8z+xC9Pc/SL8Y0u2hF0PObEbe7x4Q06bGQ27oxpGRf4DuhE5XGj2FNnFZLOKx4J902urEMxiZNQND9m3wo53 F5ZHKwAD Yx7nfZLfmw2bCZER1Wj/1lh+MJ2KMt8zoAVTy5H+hgO4SouRWc/J5gwQYLdaHhlZZ8zVMymUqUDSGfNjuGSCWcRk11jJRdXYaTOwnYvEa7RV4799tT10eTvAudMOdhKka/retRt5s0lnPNxRWl9n3ojyvh0zuAELxksYRTBT6rlq7gSkWQwa6riB/3Kazy2JUSdqldNvLIDQylfrr7D123zycx9g8vrMn/sk6Ndk6isUiBz9dlwKhbzj9lQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Dec 30, 2023 at 10:19:52AM -0600, Michael Roth wrote: > + /* Change the page state before accessing it */ > + if (snp_reclaim_pages(__pa(data), 1, true)) { > + snp_leak_pages(__pa(data) >> PAGE_SHIFT, 1); > + return -EFAULT; > + } This looks weird and it doesn't explain why this needs to happen. SNP_PLATFORM_STATUS text doesn't explain either. So, what's up? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette