From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF717C4725D for ; Fri, 19 Jan 2024 17:49:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F1736B007D; Fri, 19 Jan 2024 12:49:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A14F6B0081; Fri, 19 Jan 2024 12:49:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21B706B0083; Fri, 19 Jan 2024 12:49:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 11EFD6B007D for ; Fri, 19 Jan 2024 12:49:17 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CDEBB40D25 for ; Fri, 19 Jan 2024 17:49:16 +0000 (UTC) X-FDA: 81696797112.08.AF1675E Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf19.hostedemail.com (Postfix) with ESMTP id E9D371A001D for ; Fri, 19 Jan 2024 17:49:13 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b="Lv/MxRHu"; spf=pass (imf19.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705686554; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N5P0OP32u4vYYJkcq5dn4rKE4JvHTAglrfVwbhPG/40=; b=EGQPha6AUzcQGZQZchjKx8yXLojStmuXKec83TV9x7IV3wuhFO7RTe+ALlwfcXmXmIMj2m 7yYZ1HqFWAcwsPxL3aLz+eN6M8P7A7O/EkhohvgAMS8rxB5VRNMHD+KVsQnxi5Rzbw5kNR ItYXMvKW0jEeapQ4CXldSqarvyXwq8Y= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b="Lv/MxRHu"; spf=pass (imf19.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705686554; a=rsa-sha256; cv=none; b=3WjeApQWWX82q1ljRt9zHGjL16gf5YDLJf9rktKQv+aPelseR8C4Wb0B+ajUEjWZte53Ap Z+IBLAPlGycJk7FKuDpY2Qx8nfHDWffo6V+B1HpXJ09D8tSpl9yFqDTYJrQkdxKAqqZn+a MWsgyWYgj8B6GZAvxEs79abtJn72pCs= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 6BF1940E01B2; Fri, 19 Jan 2024 17:49:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id HTqOCos1itEC; Fri, 19 Jan 2024 17:49:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1705686548; bh=N5P0OP32u4vYYJkcq5dn4rKE4JvHTAglrfVwbhPG/40=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Lv/MxRHuM+pgkTF76WNf6wAea7SiPxjGNWgw1Nq3sSFEEZ8LcLa46XqpYcjzNVefP W9IaeVK4fmGl5MD6SuR5Tk/HPtnNdx58IqpmYbQE9xrBrZR2i1Dtrv8v9tmIfs+nGf wioqmCGxileSNFUb7EeP6sfZtg2z7oP12PJ7odFCG0+oPpCsn9bSM3LjOX20+U5LXm zlIxeaWfXn6vdZdWaO1sigObmx6erxqACnQyeQ0/vs3TReFNN0Zj3ZOepDmP/JIJgl 9ivSuwG0HA3QfDXI+hi0Cd9WdP0qxNC07hgjf/iMWHqcLSe/wtmD3ALRLb+rI6Ef2/ odB1fOjl8dVl7C89bBrLoeQkdfeTyxi4IH6mcO7uXeuAJMxKBvN8Ue+av+vd7ThsGZ ZxMmeUGyzcZDgTT5sv2DfM/Bbzi0dzASOJsBzdtz0ID2gRDBsQgTEoXVt2jXG0kgFx Z0k4POTM2hje1aJMgArrmB48zGrSXoslJ4RXAva10jaqXdZgSRt1f6j51eNm0+Hcwy PLsslv7VxhOyoXvaGyMPI8sa8+dRSXCcK9hOdb3rAtKm4fhBgZieh0IRosICOgIafa GoVX8FCOfcom8e5wkECW/r3UCPpIcR8mzBpPVQR6kosBqL9H9j8kpv8/tNSl1uTFkk MLifxaMoPKPq4u/YBhDhRKys= Received: from zn.tnic (pd9530f8c.dip0.t-ipconnect.de [217.83.15.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 9691B40E01BB; Fri, 19 Jan 2024 17:48:31 +0000 (UTC) Date: Fri, 19 Jan 2024 18:48:25 +0100 From: Borislav Petkov To: Tom Lendacky Cc: Michael Roth , x86@kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com Subject: Re: [PATCH v1 18/26] crypto: ccp: Handle legacy SEV commands when SNP is enabled Message-ID: <20240119174825.GAZaq16f0dlfle65To@fat_crate.local> References: <20231230161954.569267-1-michael.roth@amd.com> <20231230161954.569267-19-michael.roth@amd.com> <20240119171816.GKZaqu2M_1Pu7Q4mBn@fat_crate.local> <6d8260e3-f22b-68c9-03c7-5e0fa351fe05@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6d8260e3-f22b-68c9-03c7-5e0fa351fe05@amd.com> X-Rspamd-Queue-Id: E9D371A001D X-Rspam-User: X-Stat-Signature: uj9go3cfex79fipqonah914xronj34zr X-Rspamd-Server: rspam01 X-HE-Tag: 1705686553-853611 X-HE-Meta: U2FsdGVkX1/sGfWaMDvOvS414VjansOZPrCmybfFtW9WFLYCtGCiJD6thgZyPTIgwt1z415nkES51cLwJn+NxBPmBTd2bfY74lKhmkU9YYucSLn21lh7BkOplQgoo/yEIrcmPmd3LqYlNunOzf25bkPYxRzKY+V8403QDf5W4prRyQq17BW9ckiZU9PI+0QXjlVuYvp7isXi182EUQQOjavoJTYpCm4+DcMZu62NbLGcWaRc1JyncUGn1aL3zfAebrhmz4W6t6iOpLkgp8uvnj3LU8htoOwEy71vpZH28/yHOcuD1obPngoP6b6epREvAMTfMSgq/8QdFTYNF9WKcqdqQ+CV7nnUK+Pwo83BuoS1fCj9GIN6zmRxa1p2oq/BTYMHnFw23KHbg07yYp5bMFR582ZUMy5ngAUAGfYknlgwJGej6iGrScX1i02qkH4V9BXLFdOxZa0SJp29EDHmqqD/2C3RDoYwGgZBKMGY/lfIk+FCzGWK4FK/BJgku+GvqybH7S5AxZnGCwjecf5bVKxahOsCQvn8cHRjbwLd6MDC0niCqNh3zbRoy/k5fzF1beK5ifyDKTOIyqM/O2NW2yi0UVtVEo7JGh2s7pKIVo7qTiqXR0FR3hCYaMXizHvOr909RbeG9MGkd2UK0UQl+5zgYyZBupfBHqS7IhDg8IaNGiNI67XL7DXV0paMDKDbznPb4H/QaAcACXcsGFLohj211eA9nP0b+2iJFd0/4I64OkBm99Jp4tbfCDotbOzosXsw7OOFBiChyYKmbA2Q/wWYLe0dzBvhoan8JnBP00oq41sHt1CvdJTADqcHbTMCZqlCCbBbMwDbyAA+I7aGjEbwm8OKLRJEvuyYdpTO8qg600XGLweBE0mOm9SOHBXN4E/7fdUDGt3UhRoFKYgtj5JNttr+IbBpvO6qq5Z4e0dp2ll6230KbZSkSeP8M8C/mqU066PGQmXQ8sr1pTE NtvRWFL2 DSw6UQKxIm9qedFVsaElEZ5ro4n3s234fdbiqBiNBpUOxJLNx+yDG0Z6lH29II1I1BnSgBF7J0YWWBesCBPF2aA7iVTNimcmW6CG5b9h5O5dCU+DSd9GMQnGhdZrHbgixszPonxVDi3z7DFkiPOnfGe8qw1c+nEQxZcShivIgODIP2aHqHSly3FyvgAJjaccWs4fKCihsejz1HzU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 19, 2024 at 11:36:44AM -0600, Tom Lendacky wrote: > Using %#x will produce the 0x in the output (except if the value is zero for > some reason). printf-compatibility: # The value should be converted to an "alternate form". For o conversions, the first character of the output string is made zero (by prefixing a 0 if it was not zero already). For x and X conversions, a nonzero result has the string "0x" (or "0X" for X conversions) prepended to it. > So I would say make that 0x%x. Yap, better, unambiguous. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette