From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BA4DC4725D for ; Fri, 19 Jan 2024 15:23:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B2F36B0081; Fri, 19 Jan 2024 10:23:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 862BB6B0082; Fri, 19 Jan 2024 10:23:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 703756B0083; Fri, 19 Jan 2024 10:23:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5F22F6B0081 for ; Fri, 19 Jan 2024 10:23:19 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 12841A0740 for ; Fri, 19 Jan 2024 15:23:19 +0000 (UTC) X-FDA: 81696429318.20.8246CBF Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf01.hostedemail.com (Postfix) with ESMTP id 73A6740012 for ; Fri, 19 Jan 2024 15:23:15 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=p4dFb6GM; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=7GbZmExG; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="uv6/I8/D"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=TjocpMhx; dmarc=none; spf=pass (imf01.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705677796; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UlMhYNvxmdwU88x2GiClfz7jLnVbiymkQwkKTqSWf3I=; b=wSSgjxAUKxJZmz9BEPrdQmAH9u2tlPhcQqxaO6lwsUoi/AVwPVWC6s229qIT6VbygVYrPy /GBo3/juvxQEzzrwlCPDQsMUDn7iAdpuqwqIEFKyD60e8Peo5LpmFqxA9/JhLQnsAa7Dhu SGDl8tm72Xf86NIe1pRa8SM551nv7n0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=p4dFb6GM; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=7GbZmExG; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="uv6/I8/D"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=TjocpMhx; dmarc=none; spf=pass (imf01.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705677796; a=rsa-sha256; cv=none; b=siwGMYpv+zI003ddfqhMDg1Xwz1nPBEOgx6MFFxSPxxgsswtegz7giX+5jfz/9ze2Tz0mc gP5ZMMG4/Lltp+AL7eywfCEofoL+cTYEPTX0ic1edCadv+D61SybpmfJ5USwrSVlKyCLnU 4kYTfloA6Dx14/yEErTI+9XIVgKL9b8= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E42E921F0E; Fri, 19 Jan 2024 15:23:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1705677793; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UlMhYNvxmdwU88x2GiClfz7jLnVbiymkQwkKTqSWf3I=; b=p4dFb6GMSRo0tZhknWp0pJnU0cXnMMRmhs/hkaguOiNRiUJHsE/ioFUyDkg/V2qD3QVgzp AXhqPWksFbJZvehe8aMjyxJNPs5uwTy+lrH0/UrfAHBEZZ/Ob1FBKQsaVZu8hwXeU7Dfj0 tvoFqMZArauYQLSc6F3Nr4PKRU/ryDg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1705677793; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UlMhYNvxmdwU88x2GiClfz7jLnVbiymkQwkKTqSWf3I=; b=7GbZmExGbUuvg8YHeHRlbRjMJkr4BYJT1xm9jzKqY+Cz95B2DX/dKt9p4VWRSDSo+lb3Nw SUMfM2Fp4AMNVjCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1705677792; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UlMhYNvxmdwU88x2GiClfz7jLnVbiymkQwkKTqSWf3I=; b=uv6/I8/DAEwdii5GhOY2DDxek1tbLfwtJJeQnDG5/iM33eCjj5k7OTy6CxNTGvwRyra9em IlvkNGZQaNCzIRfqulB3WYnKdsno6wb+LTR4alLPqugEiSiQ8IvBBqcZqMsY5fY0UpI+oi EgCTg3SNd0HB5Zac4bZuMc/3+V6YCMQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1705677792; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UlMhYNvxmdwU88x2GiClfz7jLnVbiymkQwkKTqSWf3I=; b=TjocpMhxinabRrhyYc09GRqMbbXQIjoZ/y+OdQ8zSfuYh+5s+nDjTuGdcF/ifi9+pNr98H 1P7ed6EnA18ACfDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D96231388C; Fri, 19 Jan 2024 15:23:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id X0oONeCTqmXeQwAAD6G6ig (envelope-from ); Fri, 19 Jan 2024 15:23:12 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 8D682A0803; Fri, 19 Jan 2024 16:23:12 +0100 (CET) Date: Fri, 19 Jan 2024 16:23:12 +0100 From: Jan Kara To: Kemeng Shi Cc: akpm@linux-foundation.org, jack@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] flex_proportions: remove unused fprop_local_single Message-ID: <20240119152312.qb4xd43zw6jtdihv@quack3> References: <20240118201321.759174-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240118201321.759174-1-shikemeng@huaweicloud.com> X-Spamd-Bar: / X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 73A6740012 X-Stat-Signature: 66533ytrim9zhtyjnnc91b7fwqx7qwhs X-HE-Tag: 1705677795-798356 X-HE-Meta: U2FsdGVkX1/JyrO/43HV55RKvYNR+RPCsce/SG+/pAhBHp6kNAt28qQ7MKsaTSnfPRLXF1G0c+4MBAzsNyFpkZhKFGY0rWAkZNETU6W3yhef+3nbrxhcg2z1oQyZsVWXLfZXqwDd8tfV4cudkS9rg8KhduJXuj1Mg7P/s1xRTmdY/VLkOzeLv36pWPAO7hbAhiiyHMrFY0mgE5Y2R9wbeIRCrTj2CP13siG7CVNNeU4itraDSiiIZRiay1+Ds7WPqMz7ukaiV6zDMzdF/8hp/q+pyyt+6ZFczlYxrpDzaL3tuA5UElS8xz7dg4rhVTQgIYASTphcDcBq4DglAeaej47dnEI0Gk46LBrdsGqMk5cWAzCWgnyh4GLs4z6G/IvlddteZCHLrcY+qzlkmlSOQ5JiLDoutM4JlDsaYHkH51zUz9J0nqCpywnoPxk/RIBEEebvpL/ueh67yXnfbBMVhzYqcllRYsMxckyOMbC3CnilFqwJnDIbCGh4owQlYoHKfyUk5FrcZdyYFZAeYZntW4GqcSGOgzVeNF0ED6q8cWGjzDBrieE3vewFScoKL7Dkm9UwQWjhKWLqejw9YUQodyfBMU3Zq8xhQkI55dIQzP1/8J0kyMN5HpbpE1IUJa6tD9hS6XSTAuaJlpR38S8+392SHdoocBqx/rPYWRkkn0wS1RNPgGBS8R5P0MAH0rL66QFboimLTe+eiotB7ySm/oijOS1qesUhj+Z/C6m9z129G38lLbKDOIKmGGAGOPkOLzEi+EWDBGcax30xm/K7KCARC7rU3iFb93x8R9+MgvVOSnobyqvEdFeVBZ6+Ci3xeJsPsgXebN3RCNYEHugYx0jO+olRz5k22NoNGhw6EBM5OfQBVAuZGDCYeoDGPSmwZ5O2gsbRcBkx2Sl8pPyAaStj81jsUSeGIeaCBVW8S61Wd9kgHBWagPUcFiQhHBGY1DhMkGmtwNso2Qg1w+t Nb/9AgQY M4F1OlUlySFh6O6cGqnRb5fl1/B9JTNTG1d7ZKjk5iaK2Rv/hu84VjH2m2/2DmF+7DFg7VMxMAzDowLgMJf9fftLV/dR41ZEuSVYsS0cD2vbpHhOlMzSn2dJRri2sCuFVr6GRS1Y6POKRVuaLnF8RskBj7e/m6uKtDOnkK8ZwqAdDiaRC3pMmSbGBHnRc1ogqgwSgkqJpkSy4owKNaJxuU4GF3j+qUE19xuz85pGnx3O7zHbV/otuHTWAFc1Xztkv/7iuLVk3d2LOJZFQhRWT1+DXQLX5tRE9h969nAwqJy5IfZ0jLuv2LZ09QQyyfN6IiDirTPTS5+BABgcO6hN4YSXlt8riwndsUjqsqLITdhr1mHT4lHt/OEHw1JExaxQeWhcd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri 19-01-24 04:13:21, Kemeng Shi wrote: > The single variant of flex_proportions is not used. Simply remove it. > > Signed-off-by: Kemeng Shi Yup. Feel free to add: Reviewed-by: Jan Kara Honza > --- > include/linux/flex_proportions.h | 32 ------------- > lib/flex_proportions.c | 77 -------------------------------- > 2 files changed, 109 deletions(-) > > diff --git a/include/linux/flex_proportions.h b/include/linux/flex_proportions.h > index 3e378b1fb0bc..e9a72fd0bfe7 100644 > --- a/include/linux/flex_proportions.h > +++ b/include/linux/flex_proportions.h > @@ -38,38 +38,6 @@ int fprop_global_init(struct fprop_global *p, gfp_t gfp); > void fprop_global_destroy(struct fprop_global *p); > bool fprop_new_period(struct fprop_global *p, int periods); > > -/* > - * ---- SINGLE ---- > - */ > -struct fprop_local_single { > - /* the local events counter */ > - unsigned long events; > - /* Period in which we last updated events */ > - unsigned int period; > - raw_spinlock_t lock; /* Protect period and numerator */ > -}; > - > -#define INIT_FPROP_LOCAL_SINGLE(name) \ > -{ .lock = __RAW_SPIN_LOCK_UNLOCKED(name.lock), \ > -} > - > -int fprop_local_init_single(struct fprop_local_single *pl); > -void fprop_local_destroy_single(struct fprop_local_single *pl); > -void __fprop_inc_single(struct fprop_global *p, struct fprop_local_single *pl); > -void fprop_fraction_single(struct fprop_global *p, > - struct fprop_local_single *pl, unsigned long *numerator, > - unsigned long *denominator); > - > -static inline > -void fprop_inc_single(struct fprop_global *p, struct fprop_local_single *pl) > -{ > - unsigned long flags; > - > - local_irq_save(flags); > - __fprop_inc_single(p, pl); > - local_irq_restore(flags); > -} > - > /* > * ---- PERCPU ---- > */ > diff --git a/lib/flex_proportions.c b/lib/flex_proportions.c > index 83332fefa6f4..84ecccddc771 100644 > --- a/lib/flex_proportions.c > +++ b/lib/flex_proportions.c > @@ -83,83 +83,6 @@ bool fprop_new_period(struct fprop_global *p, int periods) > return true; > } > > -/* > - * ---- SINGLE ---- > - */ > - > -int fprop_local_init_single(struct fprop_local_single *pl) > -{ > - pl->events = 0; > - pl->period = 0; > - raw_spin_lock_init(&pl->lock); > - return 0; > -} > - > -void fprop_local_destroy_single(struct fprop_local_single *pl) > -{ > -} > - > -static void fprop_reflect_period_single(struct fprop_global *p, > - struct fprop_local_single *pl) > -{ > - unsigned int period = p->period; > - unsigned long flags; > - > - /* Fast path - period didn't change */ > - if (pl->period == period) > - return; > - raw_spin_lock_irqsave(&pl->lock, flags); > - /* Someone updated pl->period while we were spinning? */ > - if (pl->period >= period) { > - raw_spin_unlock_irqrestore(&pl->lock, flags); > - return; > - } > - /* Aging zeroed our fraction? */ > - if (period - pl->period < BITS_PER_LONG) > - pl->events >>= period - pl->period; > - else > - pl->events = 0; > - pl->period = period; > - raw_spin_unlock_irqrestore(&pl->lock, flags); > -} > - > -/* Event of type pl happened */ > -void __fprop_inc_single(struct fprop_global *p, struct fprop_local_single *pl) > -{ > - fprop_reflect_period_single(p, pl); > - pl->events++; > - percpu_counter_add(&p->events, 1); > -} > - > -/* Return fraction of events of type pl */ > -void fprop_fraction_single(struct fprop_global *p, > - struct fprop_local_single *pl, > - unsigned long *numerator, unsigned long *denominator) > -{ > - unsigned int seq; > - s64 num, den; > - > - do { > - seq = read_seqcount_begin(&p->sequence); > - fprop_reflect_period_single(p, pl); > - num = pl->events; > - den = percpu_counter_read_positive(&p->events); > - } while (read_seqcount_retry(&p->sequence, seq)); > - > - /* > - * Make fraction <= 1 and denominator > 0 even in presence of percpu > - * counter errors > - */ > - if (den <= num) { > - if (num) > - den = num; > - else > - den = 1; > - } > - *denominator = den; > - *numerator = num; > -} > - > /* > * ---- PERCPU ---- > */ > -- > 2.30.0 > -- Jan Kara SUSE Labs, CR