From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25499C47DDB for ; Tue, 23 Jan 2024 07:34:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ACA3D6B0082; Tue, 23 Jan 2024 02:34:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A495A6B0089; Tue, 23 Jan 2024 02:34:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 789EC6B0083; Tue, 23 Jan 2024 02:34:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5798E6B0080 for ; Tue, 23 Jan 2024 02:34:45 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DF7171C0C9A for ; Tue, 23 Jan 2024 07:34:44 +0000 (UTC) X-FDA: 81709763688.30.63D72BB Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by imf12.hostedemail.com (Postfix) with ESMTP id 9948740003 for ; Tue, 23 Jan 2024 07:34:41 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf12.hostedemail.com: domain of huangpei@loongson.cn designates 114.242.206.163 as permitted sender) smtp.mailfrom=huangpei@loongson.cn ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705995283; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QPIOK8SAIkeZoWyHnuCN7V1zeUia9cF3Irzg3BDt5Wg=; b=Pkb3O6JAOydHqpvKUtOXan3vBtrSZOovAFFHZ40D2rgK+/HwBju6HOMcekUu2CLixElNxL d2ktgCU09P/BJG/W+zrCvm6P9cE5B93KNl7f7V9p8LsO6YYJWPQzrNVPRAAvct2Qnnmtae ErN3uVB6obR389gBQqlam9IN8Lj9Fpk= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf12.hostedemail.com: domain of huangpei@loongson.cn designates 114.242.206.163 as permitted sender) smtp.mailfrom=huangpei@loongson.cn ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705995283; a=rsa-sha256; cv=none; b=bGTdwDebLNYcBaP7EQL/0XM9nYPzJSzFrjwAwMSBaqeQzwwl5l9UZR88Zh7XayuKssj80J GBeb7YI8iN5G64RxijmvgrWGUPA6JwZhUvwtP1BY4FeaJytepkaq1QA46OO3HrobogDa+z f6EmjPY9lxG3rlb9uEt1d5oa7Gjlx4s= Received: from loongson.cn (unknown [111.9.175.10]) by gateway (Coremail) with SMTP id _____8Dxfevk3allUOkBAA--.9066S3; Fri, 19 Jan 2024 10:26:45 +0800 (CST) Received: from Board-3A3000 (unknown [111.9.175.10]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Bxlczh3all+OkJAA--.1584S2; Fri, 19 Jan 2024 10:26:43 +0800 (CST) Date: Fri, 19 Jan 2024 10:26:41 +0800 From: Huang Pei To: Mike Rapoport Cc: Yajun Deng , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memblock: fix crash when reserved memory is not added to memory Message-ID: <20240119022641.xyw4n4dj2iw2deas@Board-3A3000> References: <20240118061853.2652295-1-yajun.deng@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-CM-TRANSID:AQAAf8Bxlczh3all+OkJAA--.1584S2 X-CM-SenderInfo: xkxd0whshlqz5rrqw2lrqou0/ X-Coremail-Antispam: 1Uk129KBj93XoW7tF13Aw4UCrW8Zw17Kw1UXFc_yoW8GFWrpF W8G3WF9FZ8WFykuF4DJw1Ygrn3Z3Wxtay29rWYy34kZF9xWr9xWF4rW3yq9F98tw4xWr1S vF4vva43X34UA3gCm3ZEXasCq-sJn29KB7ZKAUJUUUU7529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUvGb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_ Gr0_Gr1UM2kKe7AKxVWUXVWUAwAS0I0E0xvYzxvE52x082IY62kv0487Mc804VCY07AIYI kI8VC2zVCFFI0UMc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUAVWU twAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JMx AIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMxCIbckI1I0E14v26r1Y6r17 MI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67 AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0 cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z2 80aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIF yTuYvjxU7fMaUUUUU X-Gw-Check: 325535f2152225ab X-Rspamd-Queue-Id: 9948740003 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: xp55rtc77fdje79aceue1xp58pibst9o X-HE-Tag: 1705995281-816501 X-HE-Meta: U2FsdGVkX1+hudmWTrJjMGFT48M0AR7Ku+9yaHC8Jkav49vVOH9fl3pQqziYPkVDckteI2ntKJUghOzhE5quYenRIcGIXm+a7JXj3ULj6zhc3xC9l3lo6bxNQwEhSzjT7di/slfFsWqRt9W3rpzYWJrelUG0QkZtyHiQ3pLomUbaBu+DSUmPYFRjg4rAd54h/JDafcxc0ScIIkZDX9tnkmcW14dvsjkhbYBMaF1YVL/4+LbTMUup32W3sE/nt1mZArqfs0I64p7oKOvgGG/m+adBhO8ctVx17HbsE+iNgBPzsM0eU7zjxm5PSePO6xBYHnNv0F2r/vNFF7uUeIU9dLnaON3Z8o7oORiBzZ923FLh3vWC0dcyyvMEAuFzMSlQjA6f4QDKptuQjMSXZuKvBPMGhJDmysa1NKZ+06mW/8yAye+iAJfwBB5o8VXbcBYaOeu4ldOKe7r6q2ebkb1ODOenJ8H6ULMj4LMY0kHUg3NO6EdyB8C5kCFkm4r6zf0DFQRXoENKSH0aKahkfea2lkkJ6uidovtYdGOSgNJaXkOw20L/UI6A+L+M7IOGLI6xCBS2acyGvP0pX8yRJueXlDcBRKgrVDKRnYday49DQIHtPTwAAl7uhsPBtq3lGjBBxweWGM74/ZWDjS6w+lJDuXi1Vs+vTal31Gw8xhyDGkHkSt1dnGnE+tKxsRwhsOP4L7Tj4Q/oqaXIaepn+hlDsL+av7mXPgjBRLTCQcFb0b2tm0FAw7Ru3hNgClklcayzdwyvE39oHBFA/ADg5NjeOReaxmaIZUwa5Aoh7SYo0VZo9GP7OLe/whfE93om1QY7HY7TlBqsd8zamokQqzJoIpqzgokjj0Oli/vkL6AaEgnI1nw9WfA4pZvywqei+2DWORU4LacwLnPvzUc/GUGOyyKXDN8mtCHR7c+n04AOLDE0Lb1eCgKdVKdH1Jj7muCYUzjxg/76k2psUnmUAm0 vSEAqZyE qvW8KS9kctsGxgQE1YzL2hcn+v+Zr6QJpSDiR4xgGbJwHihay/lepY2Z5K3/sAaXA+UDQ+MBhIW7HUWmYv+UIP4H2UI3ngDOlpNhJBJP1EZhbAKEjxhPp5/5CitSi7PkGUaUC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000219, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 18, 2024 at 08:42:08AM +0200, Mike Rapoport wrote: > (adding Huang Pei to verify this fixes the crash on loongarch) > It fixed 61167ad5fecd on MIPS/loongson64, tested on 3b1500 with only this one; My loongarch64 machine is not available now, I can not test it, sorry. It is already applied a arch-specific workaround in v6.5+ > On Thu, Jan 18, 2024 at 02:18:53PM +0800, Yajun Deng wrote: > > After commit 61167ad5fecd ("mm: pass nid to reserve_bootmem_region()"), > > we set nid on all reserved pages based on memory region, but some reserved > > memory may not be added to memory on certain architectures. The nid is > > invalid. > > > > Add the nid check, make sure the nid is valid by early_pfn_to_nid(). > > > > Fixes: 61167ad5fecd ("mm: pass nid to reserve_bootmem_region()") > > Signed-off-by: Yajun Deng > > --- > > mm/memblock.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/mm/memblock.c b/mm/memblock.c > > index abd92869874d..4dcb2ee35eca 100644 > > --- a/mm/memblock.c > > +++ b/mm/memblock.c > > @@ -2176,6 +2176,9 @@ static void __init memmap_init_reserved_pages(void) > > start = region->base; > > end = start + region->size; > > > > + if (nid == NUMA_NO_NODE || nid >= MAX_NUMNODES) > > + nid = early_pfn_to_nid(PFN_DOWN(start)); > > + > > reserve_bootmem_region(start, end, nid); > > } > > } > > -- > > 2.25.1 > > > > -- > Sincerely yours, > Mike.