From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77009C47DAF for ; Fri, 19 Jan 2024 00:52:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B5B9E6B0081; Thu, 18 Jan 2024 19:52:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B0B0B6B0082; Thu, 18 Jan 2024 19:52:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9AC476B0085; Thu, 18 Jan 2024 19:52:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 87F516B0081 for ; Thu, 18 Jan 2024 19:52:18 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4CBDE120216 for ; Fri, 19 Jan 2024 00:52:18 +0000 (UTC) X-FDA: 81694234356.25.50F7FCA Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf30.hostedemail.com (Postfix) with ESMTP id F087A80009 for ; Fri, 19 Jan 2024 00:52:15 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=nFMQPorI; spf=pass (imf30.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705625536; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oF67GCNAv9+8M2ChueVxTjsAv7VEnxztWRGPjq2NBYo=; b=FepH4FY9YmU8CkTvBlipcN3pkGlG6zgpxYzgHaAXiReedWUlfC62Kwp04ZLpwQ7Ib20z1Z omNOw/AlcKxp5uYr/ExyP+n5zbkeUaDxxvkoPGv5i4Eo8ZbqTT3/6yW/Cgi7O8+hDiNlm1 acY3mBWwaEfRv153PQTZS071vWcR0hU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705625536; a=rsa-sha256; cv=none; b=LgyKG4EJ89CqExz3BXV/QrTz8fN2RNIN2ZOEHZ/6y64JKmDkXhkP4eVrpIVxbAvbtk36Ny 4wEDLBkOpivR4z/LyOdAn0OGffogqhg3+R3+hJbnZ2JAM/F6uzTRSbtl043eOLfIczSkmo jYpHsWWdgA+NLQ2IEfQ5mucOiXLyuYQ= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=nFMQPorI; spf=pass (imf30.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7B27FCE0222; Fri, 19 Jan 2024 00:52:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AEAFDC433C7; Fri, 19 Jan 2024 00:52:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705625531; bh=3w17LugFdSzUHQ3RR1rCxmfhElgZLX6v6gvtqwdR6MY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nFMQPorIPUbIxWv8XbX1uBprLU26fn4z+CbG21CAcfQZIUeRBplSOhQMFcL4XRtIq 9zC0UtSgBZRxRcrPWSdPu/vEMff0mEUrg2cuqzjlnec0VGNJ2usjif2QN6M1jZ1R3h 32pXNME5EvokjIRu4oS2o/PEuI3emoRjthd4xg3XA6/+180NsIIFAnRtCkchcqGZfJ kXCawN4QAoVmwE50Yxi9kxLoYMfhV8NhCwwv+6C3HK5YRTJdH2nzDBpugBmlFi/Zn0 QWiO8dsJssUkAMprflSVeZvWpzD6QAezfjsGIDCtmGyjeGQ6eMqds1p0j4JPoRXzsc NXqbUcmJ9c3Mg== Date: Thu, 18 Jan 2024 16:52:11 -0800 From: "Darrick J. Wong" To: Dave Chinner Cc: linux-xfs@vger.kernel.org, willy@infradead.org, linux-mm@kvack.org Subject: Re: [PATCH 11/12] xfs: clean up remaining GFP_NOFS users Message-ID: <20240119005211.GO674499@frogsfrogsfrogs> References: <20240115230113.4080105-1-david@fromorbit.com> <20240115230113.4080105-12-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240115230113.4080105-12-david@fromorbit.com> X-Stat-Signature: sibj47y1nq1uqfxozhxg1dbq6eo5i1wu X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: F087A80009 X-Rspam-User: X-HE-Tag: 1705625535-547893 X-HE-Meta: U2FsdGVkX19mKnG0H5qLNlP4xfrvcFsRyzf368wBjfuePU0KHWOY4GyczgFzU2gGUZgkewWbG+aK0tOYNRHCedzjpHiM5YIH13MLJFprkZoPA9oIcbsabMCxWKieug5t6ZeGWoGPQS5YkXefP/PqYslNHI/VxiQ17BOn/tRcMJaSiGAfg+QIINLfkZEPJRZVPyM8IvNKbxEQy8AcOQexKLzeOaGKV/S76vxhFS1MVoNNiMIpjNx0hMTi8Y7TfQ5EVY4mcGsTR9oKchmE3ztXoW469REZ12gQT4p6njJdiM7kovlEAgYgkeHIKJcjr3PfMz89CLMKilQNXpeJz2NnHTzr72uslHSK7T90yvAZ5qAQSv2DTBuIcyhHAcGGWItZXUddZiR2KEGtD5Lxg622mOToNRVpNhjarhLOaALz1xE7CUtlmS7DRzEqfoR0wkBaZbW9GhofYewzU4Xlxy9Kp+Y0bXE6NdUFtTw07V65zRZ6o4and7eaNzFDEZGn2dW/pe0vsGNb9O42htGPhmUuxy6RqSTArp5GtF9pndEr6Wbp3I2czVTjyjncckarTMoLvamVceoPpf5+871WtNKe2eCFqilyrBUpU453xZW7mWWyx7ROZA2NT7xedTgojcVqeRxipceP5nErFH+37e3wB3geQ7LaDnVg2r75Qw/ebMu6CGy82GNCpn6k1GN6b6d/jBCvRjqHBGCh+1VcY1ooKSAe8nlaolBObsOT0TtFtX1vTcf6bpBXKfwy1M5WO8B/8XqutNr8Z2DvpfS28RdZYaiFaySAShYf8Y0AsDvLwi48oyC7hN01QUgMkNq3VYKRcNH42B8QjQ28UVrSi4aiq5Sw5mOfQ/qzPH62PytBvJqH2MNvsQB2eH33hLO+mkwYW9IYaXmk656vouzXgafJzEXXcxW8vvx9L4tXEU2KSLXVD0EtOx2NnBvVheKQZQJLXcbM22nB1AKscxpaPP4 2xORlKby kWodBkrfaH8naQC8xmqWb+h0UvGTX1WyRBtpgpkSjXww7rorNRBtlt8RQdRhTTmSN6nyCjMYjnNxpX/37neLhNS4hJbpTj1fZeqB5aij59sVSFXbyv/Zny7cR4xBolzgcjEm6BwGYZ2VHvGiQ/7lsWrctvE2X58yWuEbpqYABi70rKIFUgp4+E/2LpWqkaOIZpTwEtqNOmMOe3SDHIhOk9mgBdRVO5AV+UDunKEXbwNerm3WofDv+bkxvOoRoGaojqjpWZco5GyeMLKLb4ytgxJMFMnTYGmv8w+SJtyBE4Hrv3uw/UN/L4Dfx0w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 16, 2024 at 09:59:49AM +1100, Dave Chinner wrote: > From: Dave Chinner > > These few remaining GFP_NOFS callers do not need to use GFP_NOFS at > all. They are only called from a non-transactional context or cannot > be accessed from memory reclaim due to other constraints. Hence they > can just use GFP_KERNEL. > > Signed-off-by: Dave Chinner Looks good, Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/libxfs/xfs_btree_staging.c | 4 ++-- > fs/xfs/xfs_attr_list.c | 2 +- > fs/xfs/xfs_buf.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/fs/xfs/libxfs/xfs_btree_staging.c b/fs/xfs/libxfs/xfs_btree_staging.c > index 961f6b898f4b..f0c69f9bb169 100644 > --- a/fs/xfs/libxfs/xfs_btree_staging.c > +++ b/fs/xfs/libxfs/xfs_btree_staging.c > @@ -139,7 +139,7 @@ xfs_btree_stage_afakeroot( > ASSERT(!(cur->bc_flags & XFS_BTREE_ROOT_IN_INODE)); > ASSERT(cur->bc_tp == NULL); > > - nops = kmalloc(sizeof(struct xfs_btree_ops), GFP_NOFS | __GFP_NOFAIL); > + nops = kmalloc(sizeof(struct xfs_btree_ops), GFP_KERNEL | __GFP_NOFAIL); > memcpy(nops, cur->bc_ops, sizeof(struct xfs_btree_ops)); > nops->alloc_block = xfs_btree_fakeroot_alloc_block; > nops->free_block = xfs_btree_fakeroot_free_block; > @@ -220,7 +220,7 @@ xfs_btree_stage_ifakeroot( > ASSERT(cur->bc_flags & XFS_BTREE_ROOT_IN_INODE); > ASSERT(cur->bc_tp == NULL); > > - nops = kmalloc(sizeof(struct xfs_btree_ops), GFP_NOFS | __GFP_NOFAIL); > + nops = kmalloc(sizeof(struct xfs_btree_ops), GFP_KERNEL | __GFP_NOFAIL); > memcpy(nops, cur->bc_ops, sizeof(struct xfs_btree_ops)); > nops->alloc_block = xfs_btree_fakeroot_alloc_block; > nops->free_block = xfs_btree_fakeroot_free_block; > diff --git a/fs/xfs/xfs_attr_list.c b/fs/xfs/xfs_attr_list.c > index 0318d768520a..47453510c0ab 100644 > --- a/fs/xfs/xfs_attr_list.c > +++ b/fs/xfs/xfs_attr_list.c > @@ -109,7 +109,7 @@ xfs_attr_shortform_list( > * It didn't all fit, so we have to sort everything on hashval. > */ > sbsize = sf->count * sizeof(*sbuf); > - sbp = sbuf = kmalloc(sbsize, GFP_NOFS | __GFP_NOFAIL); > + sbp = sbuf = kmalloc(sbsize, GFP_KERNEL | __GFP_NOFAIL); > > /* > * Scan the attribute list for the rest of the entries, storing > diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c > index de99368000b4..08f2fbc04db5 100644 > --- a/fs/xfs/xfs_buf.c > +++ b/fs/xfs/xfs_buf.c > @@ -2008,7 +2008,7 @@ xfs_alloc_buftarg( > #if defined(CONFIG_FS_DAX) && defined(CONFIG_MEMORY_FAILURE) > ops = &xfs_dax_holder_operations; > #endif > - btp = kzalloc(sizeof(*btp), GFP_NOFS | __GFP_NOFAIL); > + btp = kzalloc(sizeof(*btp), GFP_KERNEL | __GFP_NOFAIL); > > btp->bt_mount = mp; > btp->bt_bdev_handle = bdev_handle; > -- > 2.43.0 > >