From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B052DC47422 for ; Thu, 18 Jan 2024 23:41:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44A4B6B00A8; Thu, 18 Jan 2024 18:41:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FAF06B00A9; Thu, 18 Jan 2024 18:41:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C2176B00AA; Thu, 18 Jan 2024 18:41:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1ABD66B00A8 for ; Thu, 18 Jan 2024 18:41:54 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id F0669140374 for ; Thu, 18 Jan 2024 23:41:53 +0000 (UTC) X-FDA: 81694056906.08.BCB4006 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf24.hostedemail.com (Postfix) with ESMTP id 3CE56180011 for ; Thu, 18 Jan 2024 23:41:52 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZHUxZh0+; spf=pass (imf24.hostedemail.com: domain of djwong@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705621312; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DXJsG7wCn0OMFAllm1EjWhQcTXZcT0kTY8gjeSTVEko=; b=GCZ1t5o7K2bhbh7p3ArM3SzXmtQAh6DlS05kLkjvDmuS07v3z8Ve5QNhVn2U6HK5g0+uq5 8l5AAuiAnwxYTaL/fzLP8i3lz0sLrioWtoMXHGzxm4vYpD0/ClMLm4e0MdrUrkkuNxesWj hg7gZPqKb/rxaJtOuQZJgOi2N9NZiuE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705621312; a=rsa-sha256; cv=none; b=vvUmXYAW6xL6xuoMb5z/2r94KigOUsyp07MgHb28KaPAhwPRBg01ZoeqsaJa4cz8H0mDfB 1mujwqim4LzQnSnJBkRJiPj7zvTTFwhqDoJu6NqdvjR2yn7bxXoN6FCR73mvHc7KJ7xyh3 TL3SN58Goye6Q6T3i9yFwA64/VW2Jg4= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZHUxZh0+; spf=pass (imf24.hostedemail.com: domain of djwong@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 6C0DBB81059; Thu, 18 Jan 2024 23:41:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BACDEC433C7; Thu, 18 Jan 2024 23:41:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705621309; bh=vo8aTkMp0KITMxB2WdEq74+s6IXX1f9jXCxVNisE3fQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZHUxZh0+IAoSd2ycAGDwxNMlRK3FYNOJPLZtWp18ZN/LsIeQt6lY5utv+3WZ5TcUL SZjqpJve/V53IV1YmxVOuHgZZ6I1oeHFRFsxc7NxSUsPLLOMFyMaL8U7g6O657oj5Y OFjtRPf+aYWrDKG+5jkZmYy2ZwmwP0OH8yFUfv7S3sBwBF/XTs0Q3d0kGY326dRN0J mk+gBzId/WBdqPzmx/MYVCEXvWj2yLbf5vq5gXk0lRlDqxOBCIhHqZxNb0UafaRKvN KtNWlt6gqDk5k/vljVgWE+YZP21ceknYRRzMBR+evn3tsXeQpy8hYw3LW+cjP9kPaY zoQId2lsRNpNA== Date: Thu, 18 Jan 2024 15:41:49 -0800 From: "Darrick J. Wong" To: Dave Chinner Cc: linux-xfs@vger.kernel.org, willy@infradead.org, linux-mm@kvack.org Subject: Re: [PATCH 12/12] xfs: use xfs_defer_alloc a bit more Message-ID: <20240118234149.GN674499@frogsfrogsfrogs> References: <20240115230113.4080105-1-david@fromorbit.com> <20240115230113.4080105-13-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240115230113.4080105-13-david@fromorbit.com> X-Rspamd-Queue-Id: 3CE56180011 X-Rspam-User: X-Stat-Signature: w5c5turf6pzqdmawtt4yhaw3pts7ccwq X-Rspamd-Server: rspam03 X-HE-Tag: 1705621312-504354 X-HE-Meta: U2FsdGVkX1/cK2NTMKiuzLwDBLDoaS7Z28pSUgNDv1j1PTQ1USqbf7b3Oi1ZU/+dZgh85RxkvPoUDvIYA3mwYmYE11Sd0cc7DrdJvS8MAHXiral2/xhdAJkOJiKQ6KmPbt/ezfEWYnjHYxuXr3PUJNPFigS+/+itFoa+lJDc0lpa3vSfYuz0ohQ6EEHb3lsi7oHBEvhUTleXq2N36s8abv+4MzzpLpRb8YjFN4oxfOSlp97VG7FkV4qXqE5q+sxj8tkIc0b1vcfgfwOCgEGsm7b+vnuWFSJtR7/GAsMiqkynUsiDjEng1YyhAVGVqF/4hLnRmXJfegMxbozqrns1O7lMJQz9FTqoPQLo+Up4KbCvIYV6+vS6sY7jY12ir/Ps7Kkp0jfteuZ/p/gh5kBeTrQZmUMWzdlv7eDInsceUzBC77ncBkDf1JfZoVrYG58+jKvrDxqc9vM8GMOcZWf2DmCOURQBVsFKMd+3v4WGuClh2P5TDfXz8mws5KUGmE/OC9ASANnsZwgaNQtfD+7FdX5LrsJNkIVEU6ukoB3RKU6qeGyCWHVb54e6qnkSzlCkSFOP/rRdrDt0cXG8Y7lb7nz3VR9GdXsP5sWhdz1kuy2EL/Xh9cFer6i9U1K5Mo/EjumDnd8NJzSSoOIfqCkCWqBjJv7N8M3mAy97ryt6ZCCEyubNB1j7oiA6XZe4LVEAHSnVLnX/XsiWYLF9fonZPHgd7bBj4M4hZBwqs0k818+Lm4SQYLtZyAV9ZCm3I2VvfgT/YyTIP2eHUHBUM5vsLLk5ivDLstPoLbNCqF8mzVEJKh67x9RixWOams/xI6O+syShAmNJnWVHmhkbc3+nZVOyZX0Y+LYK5Zqeydo0vR01fpcGxAvisFoZYvMEzeUCd1ChJkHIXJmDSEk8xbM8RFlsi8bDF1b9qUlK8/WCNSi4KhE5w9NDCN+qhKXyB0M0XG5V5EKtc6KnsbEQR8M KuGRuPYI q2knq/Rr6h5oazCte6E90CNR+q1pSX0bbm30xVpo2xwAsoYqZRQtmUOrlqHmzR+tNXkOqzDn8B6ZNGSkc2VeFGYUpxIOSPSTwtMeLA8kLu1UpAZbty2T9vby0kWxP4BXKK75q/7CdruOdxOjrSomwCXTNELZtBdupvBmAqvAmKFZXbqxf/7iyyDp66Ehi7r99YZX9sTDICdH5jtnY3H7JfyNS5uYyZkTeBczsRji+tUIf8rv5SbTI5d+m+kow82aIbvcWrFThKVuj3PCtUj/93T5V4eWhDDxVtIjqsg8AaPefoAQ2W5Xz2Twixg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 16, 2024 at 09:59:50AM +1100, Dave Chinner wrote: > From: Dave Chinner > > Noticed by inspection, simple factoring allows the same allocation > routine to be used for both transaction and recovery contexts. > > Signed-off-by: Dave Chinner Looks good to me, Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/libxfs/xfs_defer.c | 15 +++++---------- > 1 file changed, 5 insertions(+), 10 deletions(-) > > diff --git a/fs/xfs/libxfs/xfs_defer.c b/fs/xfs/libxfs/xfs_defer.c > index 8ae4401f6810..6ed3a5fda081 100644 > --- a/fs/xfs/libxfs/xfs_defer.c > +++ b/fs/xfs/libxfs/xfs_defer.c > @@ -819,7 +819,7 @@ xfs_defer_can_append( > /* Create a new pending item at the end of the transaction list. */ > static inline struct xfs_defer_pending * > xfs_defer_alloc( > - struct xfs_trans *tp, > + struct list_head *dfops, > const struct xfs_defer_op_type *ops) > { > struct xfs_defer_pending *dfp; > @@ -828,7 +828,7 @@ xfs_defer_alloc( > GFP_KERNEL | __GFP_NOFAIL); > dfp->dfp_ops = ops; > INIT_LIST_HEAD(&dfp->dfp_work); > - list_add_tail(&dfp->dfp_list, &tp->t_dfops); > + list_add_tail(&dfp->dfp_list, dfops); > > return dfp; > } > @@ -846,7 +846,7 @@ xfs_defer_add( > > dfp = xfs_defer_find_last(tp, ops); > if (!dfp || !xfs_defer_can_append(dfp, ops)) > - dfp = xfs_defer_alloc(tp, ops); > + dfp = xfs_defer_alloc(&tp->t_dfops, ops); > > xfs_defer_add_item(dfp, li); > trace_xfs_defer_add_item(tp->t_mountp, dfp, li); > @@ -870,7 +870,7 @@ xfs_defer_add_barrier( > if (dfp) > return; > > - xfs_defer_alloc(tp, &xfs_barrier_defer_type); > + xfs_defer_alloc(&tp->t_dfops, &xfs_barrier_defer_type); > > trace_xfs_defer_add_item(tp->t_mountp, dfp, NULL); > } > @@ -885,14 +885,9 @@ xfs_defer_start_recovery( > struct list_head *r_dfops, > const struct xfs_defer_op_type *ops) > { > - struct xfs_defer_pending *dfp; > + struct xfs_defer_pending *dfp = xfs_defer_alloc(r_dfops, ops); > > - dfp = kmem_cache_zalloc(xfs_defer_pending_cache, > - GFP_KERNEL | __GFP_NOFAIL); > - dfp->dfp_ops = ops; > dfp->dfp_intent = lip; > - INIT_LIST_HEAD(&dfp->dfp_work); > - list_add_tail(&dfp->dfp_list, r_dfops); > } > > /* > -- > 2.43.0 > >