From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82CD3C47DAF for ; Thu, 18 Jan 2024 19:19:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA4D26B008A; Thu, 18 Jan 2024 14:19:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C54E96B0092; Thu, 18 Jan 2024 14:19:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1CB86B0093; Thu, 18 Jan 2024 14:19:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A09CD6B008A for ; Thu, 18 Jan 2024 14:19:29 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 448CAA017A for ; Thu, 18 Jan 2024 19:19:29 +0000 (UTC) X-FDA: 81693395658.23.FC08C29 Received: from mail-vs1-f46.google.com (mail-vs1-f46.google.com [209.85.217.46]) by imf28.hostedemail.com (Postfix) with ESMTP id 408D7C000A for ; Thu, 18 Jan 2024 19:19:27 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=xAPBcHYY; spf=pass (imf28.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.217.46 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705605567; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9MU572EdVLdUkapQWYdIbhqtVcpdD79Cvhg2J7pciqk=; b=xP0kqGdlSIe0gy99R84ebaflIaeOpirHwHPYzWcJhoi95wGuI1he2Vb9b7xKqwwNblyIpl M/h1DJzDI4wZKthmaBxTjADv9vs1FQIUO8W9Ysa4TweVgB1k42Hzl2ZCPBI1RuT9SL9Kdg JBa2bAVF15WwWTYPFsrfmKJN5rfggZs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705605567; a=rsa-sha256; cv=none; b=g5PCCzoSL878ZzKQW1x0p7bPiwoPCqjD2ANoiKOr1E3K8kkaWm99QNpv+1PsG0Uqd+13dw +Dww40WMHf300fRkCF6o7oiDFEJELe8i+69Hdi6QCNdHjMxBYxcN//c9Un6rK4bM+sz/Vx pOshOQIHNQw+uY72h/a3AZkUhbbOvKg= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=xAPBcHYY; spf=pass (imf28.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.217.46 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org Received: by mail-vs1-f46.google.com with SMTP id ada2fe7eead31-46988038b26so674334137.3 for ; Thu, 18 Jan 2024 11:19:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1705605566; x=1706210366; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9MU572EdVLdUkapQWYdIbhqtVcpdD79Cvhg2J7pciqk=; b=xAPBcHYYBl3OQ20qwqfoM/eZSO7yao+uE/2dMh8eu/b8PWtoMwOjoAwOpaYh/W25T/ leiSbxb3wh3xjTDXMZF2aO9OC4Z+zdwKEIVs+As/MK5Sm0r24w7+ydWzz0aZwxaf0t1c cAkHYBTk9FNAlM3cywfhQQFBDF8SxT++nJE6WSoHYKpLRTnxvbUfClJKSSXLExXPvVM/ Dpa2Tm1F/mWKlt39TnhJViu1jcjG62QJYplzF3JWWHZ5C/p+QbdIOJJj1tkw4T7kfIQO OFesuJMG3AMQm8zipuryHUDSg+VkEmusvMTaS70MAdBrSFOnSwIZ0jXrOyx+u/2N2E7Y sGzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705605566; x=1706210366; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9MU572EdVLdUkapQWYdIbhqtVcpdD79Cvhg2J7pciqk=; b=p2TDUDZNFakweZKANa92H+zG/xMwpF/0EF0My/qYkTPSUGeulBZmlsD8teLCTDcOOb ARoE3Q/5P4BvRN/DFRgb8vjql6KrS9Y98F9kEFDaF0Uz6+/rgSiFlskULK70e7mThFZC f9+Ugwx5Ldjr5xaXSVYx3EXJLvK9fIXC9l4s0fZoi716uMxNAmyCX01oG6IZDX4ZIr2u bIoBTa7gh+uT7dOoe4uOn0WaHE9+VgNhkg6ezSal8EMCkbkJX76K2MG+KEaCKP84wpWN ArMIJKwJzAceIRVw8oXJHlOJIyTmLg1dDZUq10FWXCkDdqMNXDSCW4Vlr6mIMHihx74E pVqw== X-Gm-Message-State: AOJu0Yy01hldrND5UhEez2MxAYIy7b4ZI290VfQxT0pqKwMmq6oIwcNV kOMJt2xdZnwbe4YkJHivIO3HCtaVeAll/1lFUd7jMvJZptMEFH49jH2hhaG9WQ0= X-Google-Smtp-Source: AGHT+IGKfTocm4eVWCtnjc03F2xb43OO+W4kEUU4mAbk31KIM3WqWdepd95bP8ts1QqIQXTIPbACQA== X-Received: by 2002:a67:fe45:0:b0:468:1083:39ea with SMTP id m5-20020a67fe45000000b00468108339eamr1375691vsr.20.1705605566127; Thu, 18 Jan 2024 11:19:26 -0800 (PST) Received: from localhost ([2620:10d:c091:400::5:8773]) by smtp.gmail.com with ESMTPSA id om9-20020a0562143d8900b00681a83650b9sm64917qvb.41.2024.01.18.11.19.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 11:19:25 -0800 (PST) Date: Thu, 18 Jan 2024 14:19:24 -0500 From: Johannes Weiner To: Shakeel Butt Cc: Andrew Morton , Jens Axboe , Tejun Heo , Jan Kara , Roman Gushchin , Michal Hocko , Muchun Song , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: writeback: ratelimit stat flush from mem_cgroup_wb_stats Message-ID: <20240118191924.GN939255@cmpxchg.org> References: <20240118184235.618164-1-shakeelb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240118184235.618164-1-shakeelb@google.com> X-Rspamd-Queue-Id: 408D7C000A X-Rspam-User: X-Stat-Signature: 43agrn749epaxryp9pb9cstn6e8anmhr X-Rspamd-Server: rspam03 X-HE-Tag: 1705605567-787746 X-HE-Meta: U2FsdGVkX1+utn1GESujRCPEo9nTG/vetaimmQfDzvwF7cfgB/T8uu7xsqbDhf38WpdZtBFFALDnTiOBBZtQagrMf/CI80acx1ExBTsuUj7UuzoOdiaEBJE+Sw3od5fb53PKAk1SQg4U0jkexhbJWOGgVeMjXAGumDbYWIWhSlv4RsKBcfKUDs6jvcxukoAiOSYA4JA+3mlKyYpz+i2y2eFM/LG7PhS4Oy5wFSbPu70SMEdZzONAns5LJ7M6iEx9UwpnIsshZIM4mvEkODhAoNH7jNkR3cQAsriRgwzv3+lJZMPZI/jebaMJc4hUlqaRl1mi0V7W/4SzY3ua/BBCYKkjW0sVwbiSt2ZLq7yYDBxpsMUoXuMQ588BE7CjiBj6QD9pVJbF3PkGeUNy6In0n34cDCkHfh5brBdzOKGeqVp2jK6QfI5CqUrYl288TVYd6SpKRJK3rzduzKAMmnx4z4tFjaWlKYUmjeEgegsW1mM2MABi4hXlQTsrTUNgTimL7DMoX0Qu2UjT6RWt2obwHEGKx7Rf6TFc9m+AHsbmcKK2D0xgc06BP2i8CmcDZ42r7wo3mh8fU2HlvUvgh0AEvVPWnttOmtd07/RXjaAT5Pf6uaV/Mozn8zbJ9cloQJlxsK8a19ufAZojsYAn/i7FxfINjtuRJLmixJN6zHG6MkIqc8vmEIF/IEB4T2Z2ZEo6TuMq2+a8BhkaYjCRHpt+svePhz0vZeWa9TGmhEm+s9pmeOH3idWfnBb14JVa9A0xgPLtLxfVYFyu4epobW71z+gfD4tulIWmSe8ViYcKh4LkiW/SHstZtpFT6FL38zXPJIljGGEG2uGJNVNZQNxKlZ5fIq8LpYXITSknxqyS/hh9BmhrsGUEqb/z54KpLVQyW5OTa77U6ClzthA431NPXYQXKQ4s7+ZTFzjjyJE+KOysc80/CAr6Fa2NdPSbiSVEsuEk1bKuikNl1putUg/ BJAR5skB qsM0GpejtKCM/0JtcPa7PQWxKhdClzPwinZpph/dqf8Ug33HKOOoKKIcxCECs9PlIt5vzciLLMgzSX+zZam/sq2hCha0UjUXdM/auMw7oE85i626dIlrqowFz/zOEXyetFfKE9ERKt5EFQsOLNdQvczevvgCw/B0NDqJpsJeF+y9No4hGi0a7BhSAGb/VSnmjhjMT4S7LlSeVJ87diCLRXxCacTfev/mQelm5RR6FFuk9v+9vQbdvw0oKEoa+/PoVvTvCL+tfQe9JnQiieG23xQw+5utUjB9fGJLOLsdOI98cuf8WcekCTFLioiuN+QQnnGeDHSmspjgaFnfp8kytcuI0fVgnDTp3nIS13jq4gz7hSPFgd9SnwLrTK3vTWCjZgl7u9RXvQLXbsGMZZkKrcKoMFHeK5GS148sJO81h9Bsx/DeIOKH2ibpfoUBJNJKEy3ij8FVu8jle/+TRQiM4Q7sIBnfd+Uoxd7nXy0q3aJFzraxqq5SdRGN44cS5k3V1o9JKJ53dHFIVfGbgvl+5Y+0hTVepqB6qty68jKgumqeZug8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 18, 2024 at 06:42:35PM +0000, Shakeel Butt wrote: > One of our workloads (Postgres 14) has regressed when migrated from 5.10 > to 6.1 upstream kernel. The regression can be reproduced by sysbench's > oltp_write_only benchmark. It seems like the always on rstat flush in > mem_cgroup_wb_stats() is causing the regression. So, rate limit that > specific rstat flush. One potential consequence would be the dirty > throttling might be decided on stale memcg stats. However from our > benchmarks and production traffic we have not observed any change in the > dirty throttling behavior of the application. > > Signed-off-by: Shakeel Butt Acked-by: Johannes Weiner