From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5EC9C47DB3 for ; Thu, 18 Jan 2024 16:48:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E6C76B0074; Thu, 18 Jan 2024 11:48:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 296E26B0075; Thu, 18 Jan 2024 11:48:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15F896B0078; Thu, 18 Jan 2024 11:48:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 00E8B6B0074 for ; Thu, 18 Jan 2024 11:48:43 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C7DB01A0516 for ; Thu, 18 Jan 2024 16:48:43 +0000 (UTC) X-FDA: 81693015726.08.9870285 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) by imf02.hostedemail.com (Postfix) with ESMTP id BD8688001E for ; Thu, 18 Jan 2024 16:48:41 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=aCPBcabb; spf=pass (imf02.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.47 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705596522; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XD9Z4iDc/R0mEeH0NbCgxONlq7q9LhFIWJoJohbUbXU=; b=HluiFBZSXJYWLOidDzTc1P84f8UGvT8XXRyALR/a8MBGIBLq1HWKFTU+6hTyCEyfuzjeAw t5+dfJNHzhu/YQuWTHOxD9WljOXQN4ehJdKe41cjZcU9LeOKAQXU9n5RpnYcZp+kawAMwz TO1DXjtwmRCcDxHWXc6RlsBXm2u2t4E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705596522; a=rsa-sha256; cv=none; b=moZqsnYWlbmr6wMEzdav85VQ1VPfYRnFiyP7ShN3hKsUzISQstkWw7d7dc55RQqDj+gBnA +gjuozWBoAu7mfZAfR0r28FdzM/PEH5uKmyskpmSah12wMBvQHryytpWTYSqtpC32wtaEa dLC66iubsfDi2eZVq+Y6eD2z0v75MLI= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=aCPBcabb; spf=pass (imf02.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.47 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-681922a61baso5929086d6.1 for ; Thu, 18 Jan 2024 08:48:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1705596521; x=1706201321; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=XD9Z4iDc/R0mEeH0NbCgxONlq7q9LhFIWJoJohbUbXU=; b=aCPBcabbfdtriCwUjkd0PgeYw7bP8MmojyTKSJgLONOE44MZkqL4tsRRgSOtwfFHNm 3yQYQ/FJ5jGXqTZYRJ7JCFR7R77okYmwoPq8LL/Gvoj5E0yTkKFmGGcVyfErMSYEV/iz kG9WbW9yL8drjoeRK5UImFRkYsNLEKAYQgWjdcy8jn201/x1j1rHs0iQ8SSltMV8m1ES vW0bp5eFonzq/FZas2RA7zOiXEz4+P2qbUKdn/AwwEuT0PAWc5bx7TGioRopeGXxFx0O gPxRj0fKg6mueiP37E1hKw8U5asEoD68Kmo9r7oaatbe303vKLZjKKDdZlVxESIADBcp 1MSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705596521; x=1706201321; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XD9Z4iDc/R0mEeH0NbCgxONlq7q9LhFIWJoJohbUbXU=; b=c5IayNIhCOv62m5Q4Or5xQ0hH0HjtAp9OZ4d/OLkjpGtsLMnEA4xI+ozCwYgKs2KE3 0k7XyOOtDFTGpX1rUZD34ZRDzhih+nyaUqJEsJnwzZqJi1Vf0KhTt/1Hvg+1K1SbdHFT 8fDJd3HIWWONsWxkLW93P/PKxBUY7TVZncqNXgeuWOEfZ5jmr6Q/wMqubnubF9B0bfxg /A92tRdfE+wlTwuTF25nG2rq7ZPg4v15fs3vv2Eh2xzPlnoU2b+CBoS1a/5t8fjwSIO2 C3j6XLrlCitqdOcwvxL0p0RPhuYyzyWWU/Yd+yxDCOw5B+3jg8jeF9u2RTC8Ad8yocwa VijQ== X-Gm-Message-State: AOJu0Ywn7NE+/XVTk7QhtCxujWPeT2HZSja7EBLfVcjMAbUV2aWww9/2 YnPskuwgD+eiimMY5QGl8wOKS3VbaFdhe65RsY985HNBasNtA/kh2ri1qZnox3s= X-Google-Smtp-Source: AGHT+IFqQfxFfy+aahl8OgO7TmHJynpWPnHeQEB//FJPLZ9dNRqdYeQeJsbM1ucuuMBCED3mlJT/KA== X-Received: by 2002:a05:6214:d0c:b0:681:8c12:bdf1 with SMTP id 12-20020a0562140d0c00b006818c12bdf1mr1885590qvh.21.1705596520839; Thu, 18 Jan 2024 08:48:40 -0800 (PST) Received: from localhost ([2620:10d:c091:400::5:83d0]) by smtp.gmail.com with ESMTPSA id oj7-20020a056214440700b00681998c8330sm231043qvb.42.2024.01.18.08.48.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 08:48:40 -0800 (PST) Date: Thu, 18 Jan 2024 11:48:39 -0500 From: Johannes Weiner To: Yosry Ahmed Cc: Nhat Pham , Ronald Monthero , sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, akpm@linux-foundation.org, chrisl@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/zswap: Improve with alloc_workqueue() call Message-ID: <20240118164839.GK939255@cmpxchg.org> References: <20240116133145.12454-1-debug.penguin32@gmail.com> <20240118161601.GJ939255@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240118161601.GJ939255@cmpxchg.org> X-Rspamd-Queue-Id: BD8688001E X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: kh7y7epyd31mtw74bnten45jtgfxmmu4 X-HE-Tag: 1705596521-978436 X-HE-Meta: U2FsdGVkX19vF1wruXxT7U2FPkyos9yU2YWd4UBq96pwcdIQYV1WIWzq19a16ebfNvwZeKLX6wJ/p4L01haUZ8ia8vnWTy/8jSvfUNldGvLvGLtTu+XStzjmw1fxv6vlpZDKKO7dvl4pCES0zztc/fLw9fMV4sdQSM10Fu7Cy5jwxH2y/YolCoUp7al+4N43u1bZQPTkM/nEdhTinYVlqLAysUwmrGWt5bzEFD9FXnCfGHVxr66GKp+dk+SQmIiEv9sbzCl420PrDNWMDg+7qFIAKJjXL09r3kb5SV1swIe/1kdrlDgTXz7ew/BWFCyvyvzAsMj1BDQHlDp0Yp5+k+Pb02FiIAs5Vu2MMGta8d5JtEuJ8HsApilHH+qoY+NSH0CWXoyQEd2r4M3bidFJT4hNAB2/8EvabxyW2i90DJeETewi8DEwUqNQTC/HAoYJy8UqpU6nBGe+iMNCLI75wyVG7kprLutN+wA2urIJO4iuFtyzxq7YpA04Ab7Mq9x9LpTfW6FP8q4ZXwNyCbGD6RI3Aan8/cu3ErOQ/ziE6uYSS+6uziHDXIKTdHKH+TsZcczGuj3YYnOAIq9bmwJNFq+uoYpYMqFgc6erqa1VcTbFPJNaTFwyU/GL5udZs00bTHQObSxOBSNNNZDOn0ALfGAoU4H1g1W4RtJ9xaaJ4YH6/zkCgC0QkXdxdg8gVQ2K1eidT12K2B56lAEoTRw1DzF/lP/ypldG8s4x8RyAyiUmKlej7cq1YkuukRnz5zgRXfsPiOsBuhPNSsstvz+8tgi1ut+RW77mYsnlfQ7h3EU0P6NZvBKswNOkGUfxNtLWlqGqG5i03dI3pqr0qKFFh18CHMSJxyZzIv6wwiQa+xHStoWw9dS9dIrbZESduOvGPVJpZDX1HE5ju18parB86C1AkBbfCTXQ4Jq8q9zf1ZjFbEh9l1L926haMWsmAJcrJHaf1jYo5mdNIwi6UNt 574eCbHz GR9xAZNEFEF32IkJYA6pMGOcBf52jpNVJ+M7Gpwukw0ZoXQrtitynQAIlW3Yfeaw0wQZ6dE+68ZcItLpHb2lg2PCGHZBMSUM9fARVQwiRVK3tI3ii4TyunNZYGakOJxgfghBEkTkij+XS+2es+GUJrs5kfVMN01xgFKDrv13K6ks7VUk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000034, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 18, 2024 at 11:16:08AM -0500, Johannes Weiner wrote: > > > On Tue, Jan 16, 2024 at 5:32 AM Ronald Monthero > > > > @@ -1620,7 +1620,8 @@ static int zswap_setup(void) > > > > zswap_enabled = false; > > > > } > > > > > > > > - shrink_wq = create_workqueue("zswap-shrink"); > > > > + shrink_wq = alloc_workqueue("zswap-shrink", > > > > + WQ_UNBOUND|WQ_MEM_RECLAIM, 1); > What could make a difference though is the increased concurrency by > switching max_active from 1 to 0. This could cause a higher rate of > shrinker runs, which might increase lock contention and reclaim > volume. That part would be good to double check with the shrinker > benchmarks. Nevermind, I clearly can't read. Could still be worthwhile testing with the default 0, but it's not a concern in the patch as-is. Acked-by: Johannes Weiner