From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA0CBC4707B for ; Thu, 18 Jan 2024 15:05:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D92D6B0096; Thu, 18 Jan 2024 10:05:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 58AFB6B008A; Thu, 18 Jan 2024 10:05:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42C8A6B0096; Thu, 18 Jan 2024 10:05:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2B83F6B0080 for ; Thu, 18 Jan 2024 10:05:47 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 061F01A0754 for ; Thu, 18 Jan 2024 15:05:47 +0000 (UTC) X-FDA: 81692756334.16.FD6BD18 Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) by imf08.hostedemail.com (Postfix) with ESMTP id 5523016007C for ; Thu, 18 Jan 2024 15:05:33 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=gC7yJr6q; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf08.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.46 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705590334; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ai11Ox6ozQ1+i3t6b5EKtUxSZgIrQyAtf+uNDfugNVg=; b=QZ8uHm/5Aouinfg/8v6ZrD1OH8Xy9W4sxL3tIm2yK/w7hmqTL7axqG6bSnfmg3O9yrNOax Lk+rDdK0AUzCIuD1ffoIQZj6TOLmi6mWVrC5aipvGeeV1tzr9BszpdL3+8rG6lP4KK4BBM tSAHZ5A+uO1B/b23dBX/3EO9m1fx0uA= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=gC7yJr6q; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf08.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.46 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705590334; a=rsa-sha256; cv=none; b=SImJwuYLoIXRPApEr3lNY22W49Q6oDt8tYfnpYH7AXtWryshh1IANHaheS8wutr+5uJSpx tTs7kMHpRiezsPcdrxOripylRmHAHdI3zdcawSNGQ6vNPt6lEq2Qy5FOfp54G5c7gp7tSw wRvZK4tcOACz3f3TVPsNbtftni3xwuo= Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-6806914dba7so77079256d6.2 for ; Thu, 18 Jan 2024 07:05:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1705590333; x=1706195133; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Ai11Ox6ozQ1+i3t6b5EKtUxSZgIrQyAtf+uNDfugNVg=; b=gC7yJr6q/ZrE7IcQyYECJE14DcrNgJpbOTucw/kwWHYZ4OQh2V/21nPodmLqVDMgOl jWMLNMMaY/wnc8yvNpXq1/MXxx/BDcEHzxspqTBz9ULqLqgGuVgjQfLc6UsUH85AhQX/ g0ouLLRb+THBvvOjf+/e0KYD83SAnSs+riFtLbQU+57XKGruJrY15inzFaVt0i7zA37X Py2r94DJJaEDlOSZn5S8h7XyiG1tj6deJG+AH5HF4kC9H2FnstP3EtNy4nYPsblOpRcE /hkub2SysSCFezuMqZ2g97/+3HYbXmKDgwEXqdhJHV+Wf/XCCLAFhtb4aOamE2YUyGDq IOGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705590333; x=1706195133; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ai11Ox6ozQ1+i3t6b5EKtUxSZgIrQyAtf+uNDfugNVg=; b=cU2VeZde2CO4qcVWRNmBBtijV2uJcomsAAVaNYWSxlLKV47JNHvH+pnCBZEMVglIJT m/U9ebm4FSCZdV88SuaeLY1sM1wNzr49WzGunb2AGeyEf6GeX0RNYEG/CPZxaDOuipAL 9NGCCqr1A8/kC0OAXbX73gWl1JQUO1SGLlTH53uFcsGxsW+FiT+hOQyxE6ClBe+MXJ/2 jYDV7/mPoFwG0AY82kUjRh8XkyiUv1D0afkADBeGmDXv+x6pz8LZwLLD3dp8HJ0cyF5B DiKgkszSZpjScutICEUSdE0gugOY0CZ8jjvkPlX3dC4yS4q+oAiBut/1EtoMv/LdYS17 zZTg== X-Gm-Message-State: AOJu0Yzeqhol+n9FWOzuLxHkqmzj9s5oBOGKfQ0EdMjryMPdC7H58cU3 6ubDPQkDMVHAf9/XJiGqgJP7ap+8rZXkYmL8oV9kX7zvnF2t/wwkXojP0mNnX9M= X-Google-Smtp-Source: AGHT+IEgXHf9ivg5U2Ll+f0Jt0MWWJicZa/xCtMMLFINtlzUYMp8gOkic/6xG14X14r1eS4Gmy2cDA== X-Received: by 2002:a05:6214:21e9:b0:681:8739:9171 with SMTP id p9-20020a05621421e900b0068187399171mr952164qvj.119.1705590332640; Thu, 18 Jan 2024 07:05:32 -0800 (PST) Received: from localhost ([2620:10d:c091:400::5:c3fe]) by smtp.gmail.com with ESMTPSA id eb1-20020ad44e41000000b00680cbea3c84sm5968443qvb.84.2024.01.18.07.05.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 07:05:32 -0800 (PST) Date: Thu, 18 Jan 2024 10:05:31 -0500 From: Johannes Weiner To: Chengming Zhou Cc: Andrew Morton , Yosry Ahmed , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Chris Li , Nhat Pham Subject: Re: [PATCH 1/2] mm/zswap: make sure each swapfile always have zswap rb-tree Message-ID: <20240118150531.GG939255@cmpxchg.org> References: <20240117-b4-zswap-lock-optimize-v1-0-23f6effe5775@bytedance.com> <20240117-b4-zswap-lock-optimize-v1-1-23f6effe5775@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240117-b4-zswap-lock-optimize-v1-1-23f6effe5775@bytedance.com> X-Rspamd-Queue-Id: 5523016007C X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: sg5je4tjdzpuus8kcx6b7s7zrei3r6ba X-HE-Tag: 1705590333-201473 X-HE-Meta: U2FsdGVkX19XSeJ1t7kXeRoyWPUj7VvSHNSZjvx7BCbJ86tzZ4t6dAHZZWDEtnUrM0zhvPcTUo+8owl2/9vMSCCGh/XERvZKkvWqgmsqbeJJgoEkWruKjVfqHZB1nWUvP3efNUpj1eyD9orrDA5HmoBYR3W5DDYugHu7Fgcg0TUxZghyFd0agwuSU7DJqY+bZvPkdJlj47A+enSnm3D83Tx6VHRHzMMkcvgiOgpsNqz897TraxZ7N5kn9ocfAdeuAKsMca3L53LBONsz/vNGB6Wpkof4tieS5nUSz4vSa22YBEYb0NUy+BBnDaCnI1K9dghI4BeCT+OS6/NkghSNZuZRtpFar+u4Gvp7ifZk+HRB6SalGGrx14nPrnJd0OmXYR/OdAOB4aDCTdARYz0j2EkcBBDIACxShRLpZy1TDxw24q9FMUsNliSLpVbR7TdnRakSHZuSilwkjrKKW6IGTmV+GuP67G7gIBxWUyU2L/TN1iT+C2BhpDfz8+NOOWXZudlMyyEhXV5VBU4fzbByQi01Zu+ifA0+x0dsTE5RsLR+WhSB7SiLgK9jb/mVH/xFOS0O50E3Y7enypJX9cZLyPClOu4ViTqnLZ7KERNgLNt0WDKPwa25MORWj0EX9vM2Kw4+fzSp806QSQj+nwe5wtA+/kezr2OItDCbVNLkqx6L6xPXiV+hRy29AQvcPRZC+9iWT07xSKSGiXrIoZveo49rja9mu+GlxIP2bf5jLU/ktoetSR2EvJtN8wZkcngQjpKexeivGD93bD4r6v9cELTzNmo5d064ShCi9CO0WMl8fA5nu2F7zpPnDe9UTtE/8yFu8Was5bDmBO9OceLuqITuuSk+yEtpQEq8V83c1R3TEQt++zFsJHzS3vVMlZd2YaV9B1DKwsHUO37+FIQfgp5KujP4dZ4jlVl0ek52WBqGCXU3OrVmA87ZlZq6NIGIs7ZOw/jsyhNNMpDGcSz sJWNG6FR 3s+/yRIyi9XdCfGWdWEk+mAoYStXjx6SZdrzlDYPjGWjLbvA0fxl2DjJV0Rbc4bsPQ92jSK45HlGRwjv2lv4heCbcXsyGtziJKuBs3jxWWZOcnZaokTzQRzSIsbJF37Ne9G8uWQsjKPtdpdvfyYPZePc4J2ftMYquYVHy30/lai7Yw8I603BhvhoVTGScxmEGOZ5JUtPb9d3/Y9aToG26q2lPAvXTJStNv2nuOAOjNBb0yz9IVX/5n4tKtPQeqmpECQxf+oxy69b8z3OTDaE5As7QZIOlIGVAncWiTd8Bc5wSHJmmAgqUVwsnlp9avBK5dCzGQSidnk9vLTa3t0/HIqAjyG8aNd6suWdeIf19qT276f+DkT5GH3ix9N2cadTQRhOVtJnRckgwVugtOd9hD50Z+cJkstYidWXbMWD39lcQPcqGojHdLfAssye1d8aD0rm4NZKKuxirGToFnbfeYtPn/3+jYnVsUYKSwUGmqOkkldVvHZxUnvCIAXjZVpB8sRw4tFGne2KsVvQAJszkuTQfVrhQsn8jrnHc2NqEs/KXiKu1GtptLT9mTa6oAZ2bxl59AxwDVeD3a2drTBJiCol6UnH2McDN/IR0lyj8lyiJKiWO2Z11U9fNfw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 17, 2024 at 09:23:18AM +0000, Chengming Zhou wrote: > Not all zswap interfaces can handle the absence of the zswap rb-tree, > actually only zswap_store() has handled it for now. > > To make things simple, we make sure each swapfile always have the > zswap rb-tree prepared before being enabled and used. The preparation > is unlikely to fail in practice, this patch just make it explicit. > > Signed-off-by: Chengming Zhou Acked-by: Johannes Weiner