From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C156C47077 for ; Thu, 18 Jan 2024 06:47:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 907346B0089; Thu, 18 Jan 2024 01:47:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B7A76B008A; Thu, 18 Jan 2024 01:47:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75A046B008C; Thu, 18 Jan 2024 01:47:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 64F016B0089 for ; Thu, 18 Jan 2024 01:47:34 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 37191160AA2 for ; Thu, 18 Jan 2024 06:47:34 +0000 (UTC) X-FDA: 81691500828.10.19D69EC Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by imf01.hostedemail.com (Postfix) with ESMTP id 82E2640002 for ; Thu, 18 Jan 2024 06:47:31 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=S3xaYj1O; spf=pass (imf01.hostedemail.com: domain of lkp@intel.com designates 198.175.65.13 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705560452; a=rsa-sha256; cv=none; b=HmetRV75id9Tuw2+KS+UouiWs913ncI8CaqCZ0w/y+XC4wxVCWJ5VzlLwahwX7P52n0/pf 6LO8xLjCklAiYrKWwG+va2/yqY+awbpnbAJOnROJi4eG2OJyaS6R+qiQvEu/eDv4voWAtS Lsd89JWC/ktvOyH6o4PzLFQdxD4E/7E= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=S3xaYj1O; spf=pass (imf01.hostedemail.com: domain of lkp@intel.com designates 198.175.65.13 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705560452; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VKPqXvctb2WG7G5joPebdzovjgNNanubhQQYtokJxT0=; b=UMtLHpjZSICAVeqbcnd78W4+1ucDdVlOl35qcZum8inVv2BQNscJYdY8Dlq625DV7SvBQi AT3294LGkcFh4397SOShKh+bKy+yAXXjYC4fRhi5GJm59GUtxQ2Qy+ksTaYB8o98M2cq1A FECAiiSIhM1AP1gc7sFcWXikw3f2lew= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1705560452; x=1737096452; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=SWREub8VuUlUODzLU8q34Rk02UcISqoTmL/dacBll1w=; b=S3xaYj1OB+Uc8bDslAULIs7qnlQumGHaoC/pwo86ZSn2+qAsYlmQJi1+ HWZTXi1984sZ2aAF0pQOoN869oXbQ9bHWP3i4tqjFVcSANXXdZmuFRyJB voUmjTYUFv2LBBruzY/EFVZo/xDYWNN22eTJBDYW1O/o8mT1Dj4Edt/ZR vMlKsylC97PjidFyPA3HaPrSSC4KHdUyaXyY8mRHJ3D0byUBtz6Lj0gc/ n33vGaQd87RT7Nq2eBB6WiZCxfKirGkFTAdNEryBJ+WkEjNKmTvIk2Z81 j0gQV3PIV9tW30lXKFSjQQg1TZHhqivKqaETiZ971Mpw0Bgt8P4RMBZdU A==; X-IronPort-AV: E=McAfee;i="6600,9927,10956"; a="7459405" X-IronPort-AV: E=Sophos;i="6.05,201,1701158400"; d="scan'208";a="7459405" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2024 22:47:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,201,1701158400"; d="scan'208";a="204921" Received: from lkp-server01.sh.intel.com (HELO 961aaaa5b03c) ([10.239.97.150]) by fmviesa003.fm.intel.com with ESMTP; 17 Jan 2024 22:47:22 -0800 Received: from kbuild by 961aaaa5b03c with local (Exim 4.96) (envelope-from ) id 1rQMBL-0002jI-0y; Thu, 18 Jan 2024 06:47:19 +0000 Date: Thu, 18 Jan 2024 14:46:57 +0800 From: kernel test robot To: Alexander Graf , linux-kernel@vger.kernel.org Cc: oe-kbuild-all@lists.linux.dev, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kexec@lists.infradead.org, linux-doc@vger.kernel.org, x86@kernel.org, Eric Biederman , "H . Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Steven Rostedt , Andrew Morton , Mark Rutland , Tom Lendacky , Ashish Kalra , James Gowans , Stanislav Kinsburskii , arnd@arndb.de, pbonzini@redhat.com, madvenka@linux.microsoft.com, Anthony Yznaga , Usama Arif , David Woodhouse , Benjamin Herrenschmidt , Rob Herring , Krzysztof Kozlowski Subject: Re: [PATCH v3 13/17] tracing: Recover trace buffers from kexec handover Message-ID: <202401181457.dzB2femp-lkp@intel.com> References: <20240117144704.602-14-graf@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240117144704.602-14-graf@amazon.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 82E2640002 X-Stat-Signature: of5b7ie3j73sekabkdbq5ckrtqgqcumn X-Rspam-User: X-HE-Tag: 1705560451-647706 X-HE-Meta: U2FsdGVkX19HtuZcsC1mRAy/h6ewWA79nCj9OchPX70faUuP0pmjUQkwrrP32is59YpAiD0AuPgBwy2C0yT1NW5T28cU8P6Ia1xmEYzN4jBBvbJxSYzIl4nk9EEl1xl/NaPd3SlnVAVCKixqk6Za1fYs3l5GZ94G5rys9fdsA0JboFhBhBz+MT0RqkAsst55OghP0kxunnBPsGJ25p03zKI7ubem6bWjnj+p8Z9p0v7MdYrhcpggOFuaKfICAAohXra3GXHQaeJDIXbSywvh24BDQp6S2PYqkBrRz8b2RjOYlkqTZdIVmnEMOEVGkV3j5c8ygJeZHJDj09QOHFs80GTuTN5XvqwElEYQE/SPsii9rrPNaSZQ+Sry/+2hZBPzlCTrV0eWahrDP+w9DmtRO//nqIplU8Sa1+v62hXtFB5IuaqXr1qMvmftnoLZ4+GLcj/BNt7HYb9he4nI2JCTo+/gNmpRz/9hjjEZHCQnA2Xq4e+9Zdt97c5rS/11qgdloF5XqR9yMWmiLHB2laR85jBVViwDC37pXD+ikpzR5WCDpR+JWByWuDJduh0VZ9ZUknH72G+lEqufWlgjS8UWfr/dWRC/Tww0F8gtmvSRU1MGfw+TdmhBJoz7wCiK67J2r17vK+a02UO8hTjhjYVNWsHpQLR56Nq7UmhRkfKioXX0iO1dugCpX0gjarUp1/chj1YzRimGNtFl6mL8olql+PZ+TIWTSk3mijVA4h9995LVN2CKSer3VuVS9Cd8UV/ovjjdh/d+nxTeHsb1Zh41alPNVl+BuSSueZ8XQke5SJ0i69T+SOc7qkVS22U521Hf6yw1uFCV8ig5MXJYTjbf2A4bnSeazy93VaWFW3JY3lM8DPmvmZp1AG2LZe4NS+615N9JovY3hEiHnuEYZ9W/UgGTAOSrZg9X/H2r+U1mTKkQTJr0Agn8IU73IuZ5SOSkdB2XbUI307hOKPaD/sk AT9Z40s3 g29fsJRYUMBTej0xTw/zPL4WGvS3Lj2fSSv9XYXHhDOmafUeDP8dT3hdMJrINWVaTJM0rJF8ly5vRziXG/BTrd/zkMQJmVrd/ep5SLvlgc0nDtVkMyGyi5TaVL1u8Ymeuw6GFSL3OOfLHJl/Q4MtSFDcg3BQ8PPjmAA7cJ5dGCW3rmqhXlXuBSX2t2vPdF0YWtZtllqSTPKy8I7jDIM00rESSHJ3TG+0FwAPLBi7X/YSW0WQK9DNLGXs00YZfrvJK75eQCLqJn/WROddVTi7uYvBlciBrKAojiuTMpGQR0Nvi1T8AtIF4LBFgpOW8WNDPwzxhpqrGFAp3ThRsm3R4pgX3WeWrX1p7NrF+Q7yDpVsRSzFPi/5Tzfi8lnPAETUv/dmUm/ZT+Q/2GVuAzLUvMgJAT3bbUxOrPvZWxfiaoe2oXpM4v7V+9nzfnCInIEX9Yuyr1aDQhgMTZ6apFX66P08SSw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Alexander, kernel test robot noticed the following build warnings: [auto build test WARNING on linus/master] [cannot apply to tip/x86/core arm64/for-next/core akpm-mm/mm-everything v6.7 next-20240117] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Alexander-Graf/mm-memblock-Add-support-for-scratch-memory/20240117-225136 base: linus/master patch link: https://lore.kernel.org/r/20240117144704.602-14-graf%40amazon.com patch subject: [PATCH v3 13/17] tracing: Recover trace buffers from kexec handover config: arc-defconfig (https://download.01.org/0day-ci/archive/20240118/202401181457.dzB2femp-lkp@intel.com/config) compiler: arc-elf-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240118/202401181457.dzB2femp-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202401181457.dzB2femp-lkp@intel.com/ All warnings (new ones prefixed by >>): kernel/trace/ring_buffer.c: In function 'rb_kho_replace_buffers': >> kernel/trace/ring_buffer.c:5936:66: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] 5936 | cpu_buffer->head_page->list.prev->next = (struct list_head *) | ^ kernel/trace/ring_buffer.c:5939:44: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] 5939 | bpage->list.next = (struct list_head *)((ulong)new_lhead | rb_page_head); | ^ -- >> kernel/trace/ring_buffer.c:1783: warning: Function parameter or struct member 'tr_off' not described in '__ring_buffer_alloc' vim +5936 kernel/trace/ring_buffer.c 5896 5897 static int rb_kho_replace_buffers(struct ring_buffer_per_cpu *cpu_buffer, 5898 struct rb_kho_cpu *kho) 5899 { 5900 bool first_loop = true; 5901 struct list_head *tmp; 5902 int err = 0; 5903 int i = 0; 5904 5905 if (!IS_ENABLED(CONFIG_FTRACE_KHO)) 5906 return -EINVAL; 5907 5908 if (kho->nr_mems != cpu_buffer->nr_pages * 2) 5909 return -EINVAL; 5910 5911 for (tmp = rb_list_head(cpu_buffer->pages); 5912 tmp != rb_list_head(cpu_buffer->pages) || first_loop; 5913 tmp = rb_list_head(tmp->next), first_loop = false) { 5914 struct buffer_page *bpage = (struct buffer_page *)tmp; 5915 const struct kho_mem *mem_bpage = &kho->mem[i++]; 5916 const struct kho_mem *mem_page = &kho->mem[i++]; 5917 const uint64_t rb_page_head = 1; 5918 struct buffer_page *old_bpage; 5919 void *old_page; 5920 5921 old_bpage = __va(mem_bpage->addr); 5922 if (!bpage) 5923 goto out; 5924 5925 if ((ulong)old_bpage->list.next & rb_page_head) { 5926 struct list_head *new_lhead; 5927 struct buffer_page *new_head; 5928 5929 new_lhead = rb_list_head(bpage->list.next); 5930 new_head = (struct buffer_page *)new_lhead; 5931 5932 /* Assume the buffer is completely full */ 5933 cpu_buffer->tail_page = bpage; 5934 cpu_buffer->commit_page = bpage; 5935 /* Set the head pointers to what they were before */ > 5936 cpu_buffer->head_page->list.prev->next = (struct list_head *) 5937 ((ulong)cpu_buffer->head_page->list.prev->next & ~rb_page_head); 5938 cpu_buffer->head_page = new_head; 5939 bpage->list.next = (struct list_head *)((ulong)new_lhead | rb_page_head); 5940 } 5941 5942 if (rb_page_entries(old_bpage) || rb_page_write(old_bpage)) { 5943 /* 5944 * We want to recycle the pre-kho page, it contains 5945 * trace data. To do so, we unreserve it and swap the 5946 * current data page with the pre-kho one 5947 */ 5948 old_page = kho_claim_mem(mem_page); 5949 5950 /* Recycle the old page, it contains data */ 5951 free_page((ulong)bpage->page); 5952 bpage->page = old_page; 5953 5954 bpage->write = old_bpage->write; 5955 bpage->entries = old_bpage->entries; 5956 bpage->real_end = old_bpage->real_end; 5957 5958 local_inc(&cpu_buffer->pages_touched); 5959 } else { 5960 kho_return_mem(mem_page); 5961 } 5962 5963 kho_return_mem(mem_bpage); 5964 } 5965 5966 out: 5967 return err; 5968 } 5969 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki