From: Johannes Weiner <hannes@cmpxchg.org>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: "Christopher Li" <chrisl@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
"Wei Xu" <weixugc@google.com>, "Yu Zhao" <yuzhao@google.com>,
"Greg Thelen" <gthelen@google.com>,
"Chun-Tse Shao" <ctshao@google.com>,
"Suren Baghdasaryan" <surenb@google.com>,
"Brain Geffon" <bgeffon@google.com>,
"Minchan Kim" <minchan@kernel.org>,
"Michal Hocko" <mhocko@suse.com>,
"Mel Gorman" <mgorman@techsingularity.net>,
"Huang Ying" <ying.huang@intel.com>,
"Nhat Pham" <nphamcs@gmail.com>,
"Kairui Song" <kasong@tencent.com>,
"Zhongkun He" <hezhongkun.hzk@bytedance.com>,
"Kemeng Shi" <shikemeng@huaweicloud.com>,
"Barry Song" <v-songbaohua@oppo.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
"Joel Fernandes" <joel@joelfernandes.org>,
"Chengming Zhou" <zhouchengming@bytedance.com>
Subject: Re: [PATCH 0/2] RFC: zswap tree use xarray instead of RB tree
Date: Thu, 18 Jan 2024 09:48:19 -0500 [thread overview]
Message-ID: <20240118144819.GE939255@cmpxchg.org> (raw)
In-Reply-To: <CAJD7tkaTZz9-rtYab+pvf31dprjMLstnHeXk6HZ_0C-8Np=06A@mail.gmail.com>
On Wed, Jan 17, 2024 at 11:05:15PM -0800, Yosry Ahmed wrote:
> > I think it makes the review easier. The code adding and removing does
> > not have much overlap. Combining it to a single patch does not save
> > patch size. Having the assert check would be useful for some bisecting
> > to narrow down which step causing the problem. I am fine with squash
> > it to one patch as well.
>
> I think having two patches is unnecessarily noisy, and we add some
> debug code in this patch that we remove in the next patch anyway.
> Let's see what others think, but personally I prefer a single patch.
+1
next prev parent reply other threads:[~2024-01-18 14:48 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 3:05 Chris Li
2024-01-18 3:05 ` [PATCH 1/2] mm: zswap.c: add xarray tree to zswap Chris Li
2024-01-18 6:20 ` Yosry Ahmed
2024-01-18 13:52 ` Matthew Wilcox
2024-01-18 16:59 ` Yosry Ahmed
2024-01-18 18:25 ` Matthew Wilcox
2024-01-19 5:28 ` Chris Li
2024-01-19 19:30 ` Yosry Ahmed
2024-01-19 5:24 ` Chris Li
2024-01-19 19:29 ` Yosry Ahmed
2024-01-19 20:04 ` Matthew Wilcox
2024-01-19 21:41 ` Yosry Ahmed
2024-01-19 22:05 ` Chris Li
2024-01-19 22:08 ` Yosry Ahmed
2024-01-18 3:05 ` [PATCH 2/2] mm: zswap.c: remove RB tree Chris Li
2024-01-18 6:35 ` Yosry Ahmed
2024-01-18 19:35 ` Yosry Ahmed
2024-01-19 5:49 ` Chris Li
2024-01-19 19:37 ` Yosry Ahmed
2024-01-19 5:43 ` Chris Li
2024-01-19 19:36 ` Yosry Ahmed
2024-01-19 21:31 ` Chris Li
2024-01-19 21:44 ` Yosry Ahmed
2024-01-18 6:01 ` [PATCH 0/2] RFC: zswap tree use xarray instead of " Yosry Ahmed
2024-01-18 6:39 ` Yosry Ahmed
2024-01-18 6:57 ` Chengming Zhou
2024-01-18 7:02 ` Yosry Ahmed
2024-01-18 7:19 ` Chris Li
2024-01-18 7:35 ` Chengming Zhou
2024-01-19 4:59 ` Chris Li
2024-01-19 6:18 ` Chengming Zhou
2024-01-19 10:26 ` Chris Li
2024-01-19 11:12 ` Chengming Zhou
2024-01-19 11:59 ` Chris Li
2024-01-18 6:48 ` Christopher Li
2024-01-18 7:05 ` Yosry Ahmed
2024-01-18 7:28 ` Chris Li
2024-01-18 17:14 ` Yosry Ahmed
2024-01-18 14:48 ` Johannes Weiner [this message]
2024-01-18 18:59 ` Liam R. Howlett
2024-01-19 5:13 ` Chris Li
2024-01-18 18:01 ` Nhat Pham
2024-01-19 5:14 ` Chris Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240118144819.GE939255@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=bgeffon@google.com \
--cc=chrisl@kernel.org \
--cc=ctshao@google.com \
--cc=gthelen@google.com \
--cc=hezhongkun.hzk@bytedance.com \
--cc=joel@joelfernandes.org \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=nphamcs@gmail.com \
--cc=shikemeng@huaweicloud.com \
--cc=surenb@google.com \
--cc=v-songbaohua@oppo.com \
--cc=weixugc@google.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
--cc=yosryahmed@google.com \
--cc=yuzhao@google.com \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox