From: Andrew Morton <akpm@linux-foundation.org>
To: Lokesh Gidra <lokeshgidra@google.com>
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, selinux@vger.kernel.org,
surenb@google.com, kernel-team@android.com, aarcange@redhat.com,
peterx@redhat.com, david@redhat.com, axelrasmussen@google.com,
bgeffon@google.com, willy@infradead.org, jannh@google.com,
kaleshsingh@google.com, ngeoffray@google.com
Subject: Re: [PATCH] userfaultfd: fix mmap_changing checking in mfill_atomic_hugetlb
Date: Thu, 18 Jan 2024 13:59:41 -0800 [thread overview]
Message-ID: <20240118135941.c7795d52881f486aa21aeea8@linux-foundation.org> (raw)
In-Reply-To: <20240117223729.1444522-1-lokeshgidra@google.com>
On Wed, 17 Jan 2024 14:37:29 -0800 Lokesh Gidra <lokeshgidra@google.com> wrote:
> In mfill_atomic_hugetlb(), mmap_changing isn't being checked
> again if we drop mmap_lock and reacquire it. When the lock is not held,
> mmap_changing could have been incremented. This is also inconsistent
> with the behavior in mfill_atomic().
Thanks. Could you and reviewers please consider
- what might be the userspace-visible runtime effects?
- Should the fix be backported into earlier kernels?
- A suitable Fixes: target?
next prev parent reply other threads:[~2024-01-18 21:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 22:37 Lokesh Gidra
2024-01-18 21:59 ` Andrew Morton [this message]
2024-01-18 23:17 ` Axel Rasmussen
2024-01-25 9:36 ` Mike Rapoport
2024-01-18 23:29 ` Axel Rasmussen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240118135941.c7795d52881f486aa21aeea8@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=axelrasmussen@google.com \
--cc=bgeffon@google.com \
--cc=david@redhat.com \
--cc=jannh@google.com \
--cc=kaleshsingh@google.com \
--cc=kernel-team@android.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lokeshgidra@google.com \
--cc=ngeoffray@google.com \
--cc=peterx@redhat.com \
--cc=selinux@vger.kernel.org \
--cc=surenb@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox