From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89943C47422 for ; Thu, 18 Jan 2024 14:36:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 019326B0089; Thu, 18 Jan 2024 09:36:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F0C146B008A; Thu, 18 Jan 2024 09:36:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD4A36B008C; Thu, 18 Jan 2024 09:36:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CAE0B6B0089 for ; Thu, 18 Jan 2024 09:36:57 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A37941406AC for ; Thu, 18 Jan 2024 14:36:57 +0000 (UTC) X-FDA: 81692683674.01.FC3030F Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf14.hostedemail.com (Postfix) with ESMTP id 930EE100017 for ; Thu, 18 Jan 2024 14:36:54 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=EZEanvXW; spf=pass (imf14.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705588615; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lzxiHyqkp+7AJRrMNPAobkWc12+VrblzjnBGDYAQD4Y=; b=JO3sdDBco6gDBHBT+44fjngNu7cobzJQh38YTNyeGL477CTmDwQ6pAUKQywVSKapaW7zBt 1IxylZ6C81MfgJ72mJpH03c0sTQk05mDzNOFQYL0OiRZY4xCQRUV6+VwusnPwvYlwzSRVH l2yHBfo0nreg99mZ+gQ7jsEvz0bbx3s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705588615; a=rsa-sha256; cv=none; b=5Av+ephWNfwCS15WtSw16l5zQWnwW7L5dgNdGDR/FQDVtGMw+Xc8k7XTIA4VnnVOj45Vfu nZrFMHTdB7giHPHqBOusfpPE8f4WPvu8C58ZMl+9f5AXkcltY14BuRgmrPuRnXKz8TrbF0 0TIt6ZYJuhpBSktStadvMnEkEeiPDZg= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=EZEanvXW; spf=pass (imf14.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 4A787CE1F9D; Thu, 18 Jan 2024 14:36:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 282DBC433F1; Thu, 18 Jan 2024 14:36:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705588608; bh=qMt2J9WJVh8Lt5ah5A2hje2wNwvlh9tADBFQTncWdZ0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EZEanvXWX4JwfldgWL7suTBzVUCnAVAeMd7rwByUUcbkTM23v34drO9DkKByRHcsx bMbtTyLqKBtw1aTaAzIZ7W+s4FUcXThq17tZXtTujAqYocTUChK1Gk4zN66S/Yuwt8 HQ6Yv96H971uPjWFigf9xB1TkaHNSfBB6PIu+oulbJe3VNHjLBg8SjMZQiYR9KfLn6 gjbhRMu1I1aqCe5ZXKMLkPinpYVLTznO1QtlguVmTK2f+w7ZfVUaIW1YXDy4Dc3wHX u4sT9HL4Vb+pUjnrs40Ji3aVmJ7/WhVNjIIpOyeMrrOnTc7tKdT67kVquKnOyW7qrk ZXNOZxHyKsW+A== Date: Thu, 18 Jan 2024 15:36:43 +0100 From: Christian Brauner To: Kemeng Shi , jack@suse.cz Cc: viro@zeniv.linux.org.uk, akpm@linux-foundation.org, tj@kernel.org, xiujianfeng@huawei.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] writeback: move wb_wakeup_delayed defination to fs-writeback.c Message-ID: <20240118-werkvertrag-wahrsagung-3011377aef2d@brauner> References: <20240118203339.764093-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240118203339.764093-1-shikemeng@huaweicloud.com> X-Rspamd-Queue-Id: 930EE100017 X-Rspam-User: X-Stat-Signature: qjgp6bwrc7byqd9tbx3qwrrc3rpiuf8i X-Rspamd-Server: rspam03 X-HE-Tag: 1705588614-274889 X-HE-Meta: U2FsdGVkX18Pukg19pwGF3DiSi6atx8gq4q6Xn6tNTkOO+88H+hCTikwgFGfa0r6smrB5C8a4WKCs/Kz3pbGgS5G2b53gqKkXRUInnzqkP7CGs/tXIeT6xNhmq51Oo5QmzLoMlIp+eLFPgirM8QiMN9XMJ9U4pRV14qKBx4yCi4jtk0jy4QcBZ2Ngq7A09E+bR3+lD3dyWUXmgcyHkS3Ah1Xo8BTEpldTzgIDtrUGW8jpmGY5+G5+neGTK6G/x/T4YOOE8euruFnwNRv/HLOGVCp1X4CvLND5TOpiTKvbKy9oqj8rVB9xudhd+WQv1/O1rVcQ9/KitiTHwxuvObNHuD1P6coiLEEJJFIOey4UFDlvN3qGBM0yWvPmbGwiFI/38Z5gWB6bJe3zHuKCPjfZhuAlGkFBY9j3P/PNscqZEju+OZlyWQInlRRfsHAz/Tkf8ZBuAf1TKVX1l4tKnjgo4hzWlhotyeogvTiv/3AFfUhlYvXmIeCayrPz7HKNYu6wRSRUIfO5LldYVfYk+WSDOKhyyJf2FF8U9OA8rSRFNz5unGPBGp9Cxvew9Cef6d2gvKI8XreT6ssx+vK7C4yQR0jvDG92fOmCNtwo43kiLcUpLgxbCrjHxvw45NefAcyUi5Fe8oK1ZJewLJeocbAoGwE8Bs6U1Bx9E8747UuERdHPVkY1pFJDMH1ZNgD3biW7O3P4/SlN7wCKu8xgU7xQCUe2pOQ+8QOubJlV0Q91FXeA9fXOVflkuUKEOox0HRrUvX79CoeK5St7Gz1WeDwtkXmtxeyNLQ4yd+DdRe6qXRORaajK7nXTTMkOI0tkn4MSCQK3Avy7Gezl4LuhWMleWHCC3szQ1bzlD6QyaDcZUIaJ0dgH/OdBcbRE4TXm49RXobu05+HIi/YNDOZBzIC8/wK8YqT8tAY7zm7NJ0ksML4MtmWtUf4PGWJrfhX4olJFe310EaeBF1ZqVgOdK+ yaMleyOU UTpsPAw/ujtTuhgY4Be+m4EoSBpx9kw8Ury7Dz/5oHOuiiPjO8+Ah3xgtSVjmQU4aZD2EKovYQEXCrXPxERk3c07aN5rHUbCG02UimDK5SCg7xGJ8Rv8Sur8PktMbN7tXFFIKbut6PiQ0VxGaD9DiLfBLbkQxRQRxeXGq/kul+uE9cUNjR9zxZ/eZx7M4suIUPilbZbtr3FQc5e6SxukMZvmji8ZVjnE8ok8gT76L+1HAHKACh1OAabHAzUJQ4wj+FK+7Qfc4DkaDrI4EBj+GzeRFKQyghs54NabOPGF5dw+tYl8fAfVO6nEiHfPeAS/YV1cp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 19, 2024 at 04:33:39AM +0800, Kemeng Shi wrote: > The wb_wakeup_delayed is only used in fs-writeback.c. Move it to > fs-writeback.c after defination of wb_wakeup and make it static. > > Signed-off-by: Kemeng Shi > --- I'll leave that for Jan to review.