From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B36AC4707B for ; Thu, 18 Jan 2024 14:04:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C3986B0082; Thu, 18 Jan 2024 09:04:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 973656B0085; Thu, 18 Jan 2024 09:04:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 862C46B0087; Thu, 18 Jan 2024 09:04:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 75C166B0082 for ; Thu, 18 Jan 2024 09:04:15 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4A15D40C94 for ; Thu, 18 Jan 2024 14:04:15 +0000 (UTC) X-FDA: 81692601270.04.C7A7A28 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf19.hostedemail.com (Postfix) with ESMTP id ACDCF1A002A for ; Thu, 18 Jan 2024 14:04:12 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kMD+2c7m; spf=pass (imf19.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705586653; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bsaIuhb1mZ9jgtH2EUsMZiAsdJG1CSSZIyLC32R54Q8=; b=nFyr/9BijtPZ+Ph3KQRtWh6g7qX2YCwRiOkg79Ss5NREDHloKkwh6cDd7otUhWhSktj62h tEOGpWdNb6e6LfPRhKtw6wDOlaRV/2s2CiUBxVtPveQgLBh443UN/9R/tHhm7Xm4OB1qi7 Rhna96SXGMS0EHru+fQ61LNfRbMROSE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705586653; a=rsa-sha256; cv=none; b=BjyPKWGZhpPdkbxwq+iBcH+g0tcJvaOMI5H0kI65QkjWRBJclSDjMFcB28myx3Zl3lxX88 VsSlUzTCF0zAwQTZebtlJ3eWsLfxUowgjl17VlaVajghsLcgLqZRlumXknV6IKT5Bvd20n TUKVi9jqWDE97kBMyZ8b6bNHjHebOBU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kMD+2c7m; spf=pass (imf19.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 2C435CE1FAD; Thu, 18 Jan 2024 14:04:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 235EFC433C7; Thu, 18 Jan 2024 14:04:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705586646; bh=CUg/TAW5ytfIjj6h763t+wFJWAbSx/xoyYthkV8NQsw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kMD+2c7m48E+1LfIfW+gz6LyGmuyZHIcsjo4I51x0Xi4IGHP+SSSKLhhuj8pELn/e gcEr8byzzO2s9rRHsI39ryc5D/qCW8NI1KH2Nl8LX2wWHNF81V6om2WgY8Wu9fU8sU eBWzg7CWnzrbmYt7IzUWTqOJnAz9OEDpSPYDC/DDE5r56LLFxBoAgtHIc1vfClonU4 GhhkempOC9za8YIdB7a3HN/BzzaQBEIsaqPZZMy6pxp08wpvBv1543I2PuJlfsymnD bQAlyzsxkvz6cA6VzxFLSXgSbHX1e21brkbVw0GFg910JDMTY80FFPVnnk2el6rv6p j3iRVHA0xb/lw== Date: Thu, 18 Jan 2024 15:04:01 +0100 From: Christian Brauner To: Matthew Wilcox Cc: Al Viro , Baolin Wang , akpm@linux-foundation.org, jack@suse.cz, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fs: improve dump_mapping() robustness Message-ID: <20240118-etwas-anbruch-9075adb23bd2@brauner> References: <937ab1f87328516821d39be672b6bc18861d9d3e.1705391420.git.baolin.wang@linux.alibaba.com> <20240118013857.GO1674809@ZenIV> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Stat-Signature: ot8tn7sm3aof4dzc8j6urgeian3kcamb X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: ACDCF1A002A X-Rspam-User: X-HE-Tag: 1705586652-172316 X-HE-Meta: U2FsdGVkX19bTS8pv0wH/dpq3P3cl0TJR0GRAa6RNEkcIumM/d1copnX/MsasOSsSaQ6vL48GoWWSz6KichG12Z4p+QUJes9GHBIncn+ChLspNJ0WbHoyX2rTeqCBSC8hBWBmHp5trck/UlwjtQS1KO1tnLXvYHm895FuvvVUSrbRkpDFvoQ3+/TvH5E/+YPQ7+lKd5TEtpeXANO3Oi0sfwAMb8baJpRIoH6Ucwnh5eYAMSUXKMXwar5tUOPvbuEoqlcx5WGccLk5c583rk3Sjza/zJmS6kGvfcVodU2eaQBL9f+b1xT1OauqzvTwsGuGY1YAWH1B67IX2VuN+g0AaWP/zAHxJT5MhNAmNbIJa/Aox6u0uz+yvMh+tJolgOJ4ccoSxu9nUo1dR941MlyEX2xvaQB3hhuGOP6sUwaKmyVu+V0X8uwgZXelYhMI8c9k2RnWDZKxdJXu+fpXKE8kpKxQuZhYsy6GxZ34Tooc0NVBYi4/9p8mEF34BSFFsvseE0ieiTMsivPPGU6L9l2SpqiClyKeWMsJRWbW4XlCxzBqe+KUWMw8uNSjqBZJPVFZPAGoyyqeWjC+M64Xn+K534PJSLimXEPttZvFuEN6tKe0jyCeVozbZtg6DxuM438rfBZ9zSipDMqyRE90yBP9fCCi9o8V/M0Gtl3Xyu1AW6NGVrTKmtBNTK7t4NnK28Kl1JDVWmVT8tFSAdUCUf3xXK+nJjEgpaXYCMX33SAgPHVkIG9JMqdtyleE6fmfnPHTq8UyoE2fNWMmh2tXrs+B58Jc5DHn6mtylsD7DNa0lF6FcYhiomXuxzhj1BGfwT3ljZrsLZi2vN7NMxyWwGgfmfr1oEhle8/t+uKPuhMJyZ0VgCvWMTuui9+GBOkKyre/czssGgXw5zxmABUsl0cSQkYbnzTo2Ka519fP69/e615jpCmZ/T0yPo+o80R5ETJhMNxfEcDzWQ9W5ziBho hpKdLI7F xViD13caA00JDZ5cGl6XmW90pW2NGtFtywi9WI1WPnJjGCwkB/v+cBvGfKVvBeR6IjFgNggSwaL603TxjUoI3KaUreDx+gyZfy9KoLLuA1MkOl9nJxKvun0bF/EKt9HO4dv+/b+GhGNRlLKIdLL2xtthleoKBLm5uatCrnasM4H1UbqtSyV8mOa7gcjpd9S9noRQDFMk9jOCfeg6F2GB3hLrT1laxbCJMVoGYfjwp9kADvRM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > Agreed that it's not enough. It does usually work, and it's very Wasn't the intent to just get somewhat further and accepting that this might crash no matter what?