From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85464C47258 for ; Wed, 17 Jan 2024 13:54:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 078E86B00DA; Wed, 17 Jan 2024 08:54:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 028B96B00DC; Wed, 17 Jan 2024 08:54:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E327B6B00DE; Wed, 17 Jan 2024 08:54:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D094E6B00DA for ; Wed, 17 Jan 2024 08:54:17 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A208CA0CA0 for ; Wed, 17 Jan 2024 13:54:16 +0000 (UTC) X-FDA: 81688947312.10.CD05848 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by imf11.hostedemail.com (Postfix) with ESMTP id A1F2240003 for ; Wed, 17 Jan 2024 13:54:13 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=UpTTA+AJ; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf11.hostedemail.com: domain of lkp@intel.com designates 198.175.65.11 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705499654; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=5dhsf+h+9qzYnlY+9oZG+Sj1+8ajUxwG5HY2qOLpsAw=; b=zCNDhNliQPrSJ4Yf0nrtrytjvhzBCixEtZF2rbx9vXEy2BFAUsIiIzvDF1q8cpZhBOTZ2o 7eI86udBaw9aWqOdTn2VQexWWt88CDosY2tGM/zN4oPY1AAd3kK/RTgpUX77ViCpvX5ZG8 9eYTzKfNvgIPZwHBul/5YVKNXjatU1k= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=UpTTA+AJ; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf11.hostedemail.com: domain of lkp@intel.com designates 198.175.65.11 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705499654; a=rsa-sha256; cv=none; b=6DybX9e8SCTgaZvI6cii/G/jRmnqpRLkoo+kIYTukW9EFRwpTZbcYPDbx47wP43tSslShg UUE57LjbUxy46I1HUd2zCkXL4dW+pgOe5JcqPEsx4Fn1TCVo3AZhv38UgLmafWian1z8Jo Zf+XFI2OSWZ2xZCSmtyWQ8tO6yCFPRs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1705499654; x=1737035654; h=date:from:to:cc:subject:message-id:mime-version; bh=RsDYYhAXyCkg8b9dp9cHoIHW7NnKRGtWQb9rJsyA5KI=; b=UpTTA+AJuX1vhpCiqXx84WAnZQbYH4HekZdNC8iuo6WmwvF3y/uGJu3Y VCbjRZCFllL9tNxY+CLGNcNSnNs/lYgwEqVH9gzlHG0tF160IKyWyX0Xp Qlv6EVOBtSxiR6lmDvuS3oZI7x9GRFssRHvmEjLi3flcsJA9r+7dIB6in qAyjqbMzLw5iNPc7w4Oe1KioKGwIzCG7WR1WXvt9IRBM+kOlnqIPFvUjQ CPzTK1SVtCXw5i7w8IKpddkLDdNF8Dhg+HmUsy39gB9763lpzi0vA3F9F SFKhO17Y1HWFOr2eG9USdNOVZOS7JYfhR86ZpWoDLm8CnN7qnJZaGA8WC A==; X-IronPort-AV: E=McAfee;i="6600,9927,10955"; a="6874035" X-IronPort-AV: E=Sophos;i="6.05,200,1701158400"; d="scan'208";a="6874035" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2024 05:54:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,200,1701158400"; d="scan'208";a="26493561" Received: from lkp-server01.sh.intel.com (HELO 961aaaa5b03c) ([10.239.97.150]) by fmviesa001.fm.intel.com with ESMTP; 17 Jan 2024 05:54:05 -0800 Received: from kbuild by 961aaaa5b03c with local (Exim 4.96) (envelope-from ) id 1rQ6Ml-00023e-1L; Wed, 17 Jan 2024 13:54:03 +0000 Date: Wed, 17 Jan 2024 21:53:56 +0800 From: kernel test robot To: Kent Overstreet Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List Subject: [linux-next:master 13597/13716] fs/bcachefs/btree_write_buffer.c:128:24: warning: unused variable 'c' Message-ID: <202401172139.XSfsNhrJ-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Queue-Id: A1F2240003 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: run3yk1gzgqekywcidcux4ohj46st9yc X-HE-Tag: 1705499653-36700 X-HE-Meta: U2FsdGVkX1/YWe5AYxbSDgmgcEpVCaFqyCB/MWhdK/kSYUQs83znTwlZ1g1Xl31EtKL0d1kgHdW3gTJYKoin2w+Y/0i11ApWhIWuqOomp/53Q1O372Gqc0iiASne73XjSuQ1oAuf/aMh6jduCJYwtXvtrq8rczPyqra6H9DTY+FPNol1EB4opTrANI5idow/ADGNizI6MEDtvhQYTtpaHkhPdSe9CDKkwpMBa53q62dB4DFK0rLvUjrjFo6rR1y81/bMrKhVhJveXy77h92tUSPGHUzHfbYsX+tYtl302bDH2HxGsQ1T8Wmx8IRnbBIbuuRxYgAvsHeUiRlyCqkkmHpfZc6HTynaZS+6tD58/DAbRoigBRR33c+yW24sS3ItqoGAkKIeKydzp0ZbeE/cD0XZvCwzTvJAA6cwYfTeT6C8Oh1/0H50GaSb1A61AbJbzQiV6JnlvU+SHq16C7ESpKQNXzvOMhiGJLChr92OeMNI0mZ+Im33WFjkBqjF6Ei4L9ax9oCHpgcP+aiDSzKbKSwZs9Swg+cpjPa+hgIrlFP54MXgFooLz622/5ZB+3yVNDaEkVF6lD95lI4Sno0qnlb7XGkb3iGLXaMkcL0Yp6b3Rc5fBWobw9c6nN49xrpbhsK6HLndeZcSHlAVkRAHAxAuFoZ8OsDMWxtpEps86mPNMhNCOjPgy/ZhCOFH/l21r1WAZvLrKkzLijhRSCELkb6HX4B7qPa79lD7Cx3oFbuX8lgRAuocOV2TadfezpLRk1TqYZN+fsNVDGIrAxzWLuUw78XLNNiXyQiQKKTptTvqTanUrKShbYMVtOtJpZv7VI/13RmWQVix8IJADuiCuSQyrdhTplBwBuk00eF0w0Lo8/Q1kiwYvWUP75x2qXwBv527EYgIkuw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 943b9f0ab2cfbaea148dd6ac279957eb08b96904 commit: 3e76edb0f4db19fca9ee02a6c163a670bc66fa2c [13597/13716] bcachefs: Prep work for variable size btree node buffers config: x86_64-buildonly-randconfig-003-20240117 (https://download.01.org/0day-ci/archive/20240117/202401172139.XSfsNhrJ-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240117/202401172139.XSfsNhrJ-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202401172139.XSfsNhrJ-lkp@intel.com/ All warnings (new ones prefixed by >>): fs/bcachefs/btree_write_buffer.c: In function 'wb_flush_one': >> fs/bcachefs/btree_write_buffer.c:128:24: warning: unused variable 'c' [-Wunused-variable] 128 | struct bch_fs *c = trans->c; | ^ vim +/c +128 fs/bcachefs/btree_write_buffer.c ab4fb4b678c378 Kent Overstreet 2023-11-26 123 ab4fb4b678c378 Kent Overstreet 2023-11-26 124 static inline int wb_flush_one(struct btree_trans *trans, struct btree_iter *iter, 920e69bc3db88d Kent Overstreet 2023-01-04 125 struct btree_write_buffered_key *wb, ab4fb4b678c378 Kent Overstreet 2023-11-26 126 bool *write_locked, size_t *fast) 920e69bc3db88d Kent Overstreet 2023-01-04 127 { 920e69bc3db88d Kent Overstreet 2023-01-04 @128 struct bch_fs *c = trans->c; 920e69bc3db88d Kent Overstreet 2023-01-04 129 struct btree_path *path; 920e69bc3db88d Kent Overstreet 2023-01-04 130 int ret; 920e69bc3db88d Kent Overstreet 2023-01-04 131 ab4fb4b678c378 Kent Overstreet 2023-11-26 132 EBUG_ON(!wb->journal_seq); 09caeabe1a5daa Kent Overstreet 2023-11-02 133 EBUG_ON(!c->btree_write_buffer.flushing.pin.seq); 09caeabe1a5daa Kent Overstreet 2023-11-02 134 EBUG_ON(c->btree_write_buffer.flushing.pin.seq > wb->journal_seq); 09caeabe1a5daa Kent Overstreet 2023-11-02 135 920e69bc3db88d Kent Overstreet 2023-01-04 136 ret = bch2_btree_iter_traverse(iter); 920e69bc3db88d Kent Overstreet 2023-01-04 137 if (ret) 920e69bc3db88d Kent Overstreet 2023-01-04 138 return ret; 920e69bc3db88d Kent Overstreet 2023-01-04 139 e17b93eb36729c Kent Overstreet 2023-11-07 140 /* e17b93eb36729c Kent Overstreet 2023-11-07 141 * We can't clone a path that has write locks: unshare it now, before e17b93eb36729c Kent Overstreet 2023-11-07 142 * set_pos and traverse(): e17b93eb36729c Kent Overstreet 2023-11-07 143 */ 07f383c71fadc9 Kent Overstreet 2023-12-04 144 if (btree_iter_path(trans, iter)->ref > 1) 07f383c71fadc9 Kent Overstreet 2023-12-04 145 iter->path = __bch2_btree_path_make_mut(trans, iter->path, true, _THIS_IP_); e17b93eb36729c Kent Overstreet 2023-11-07 146 07f383c71fadc9 Kent Overstreet 2023-12-04 147 path = btree_iter_path(trans, iter); 920e69bc3db88d Kent Overstreet 2023-01-04 148 920e69bc3db88d Kent Overstreet 2023-01-04 149 if (!*write_locked) { 920e69bc3db88d Kent Overstreet 2023-01-04 150 ret = bch2_btree_node_lock_write(trans, path, &path->l[0].b->c); 920e69bc3db88d Kent Overstreet 2023-01-04 151 if (ret) 920e69bc3db88d Kent Overstreet 2023-01-04 152 return ret; 920e69bc3db88d Kent Overstreet 2023-01-04 153 920e69bc3db88d Kent Overstreet 2023-01-04 154 bch2_btree_node_prep_for_write(trans, path, path->l[0].b); 920e69bc3db88d Kent Overstreet 2023-01-04 155 *write_locked = true; 920e69bc3db88d Kent Overstreet 2023-01-04 156 } 920e69bc3db88d Kent Overstreet 2023-01-04 157 3e76edb0f4db19 Kent Overstreet 2024-01-16 158 if (unlikely(!bch2_btree_node_insert_fits(path->l[0].b, wb->k.k.u64s))) { 920e69bc3db88d Kent Overstreet 2023-01-04 159 *write_locked = false; ab4fb4b678c378 Kent Overstreet 2023-11-26 160 return wb_flush_one_slowpath(trans, iter, wb); 920e69bc3db88d Kent Overstreet 2023-01-04 161 } 920e69bc3db88d Kent Overstreet 2023-01-04 162 920e69bc3db88d Kent Overstreet 2023-01-04 163 bch2_btree_insert_key_leaf(trans, path, &wb->k, wb->journal_seq); 920e69bc3db88d Kent Overstreet 2023-01-04 164 (*fast)++; 920e69bc3db88d Kent Overstreet 2023-01-04 165 return 0; 920e69bc3db88d Kent Overstreet 2023-01-04 166 } 920e69bc3db88d Kent Overstreet 2023-01-04 167 :::::: The code at line 128 was first introduced by commit :::::: 920e69bc3db88d3825c69190cafd43f0a1918d3b bcachefs: Btree write buffer :::::: TO: Kent Overstreet :::::: CC: Kent Overstreet -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki