From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BBA1C47258 for ; Wed, 17 Jan 2024 09:49:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89A476B0087; Wed, 17 Jan 2024 04:49:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 84A7C6B009D; Wed, 17 Jan 2024 04:49:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7120E6B00A2; Wed, 17 Jan 2024 04:49:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 60C036B0087 for ; Wed, 17 Jan 2024 04:49:30 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 36791A1C85 for ; Wed, 17 Jan 2024 09:49:30 +0000 (UTC) X-FDA: 81688330500.09.5EC8151 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf17.hostedemail.com (Postfix) with ESMTP id 2F51540006 for ; Wed, 17 Jan 2024 09:49:27 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=AUPVTfrH; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf17.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705484968; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CjSLyfAbv41XmX0Cv5sZW7YHSOKxGuGf033WvhzwPIg=; b=0mmFF2NxGuMVAtOSAGGlcN8Bl4TNoJfwjk2mEqyPvVWiIBZjYGcXj6/ie8d2rzmaQ5kJPt 1DbtBfM80/ldnfTwqRtilVkH+Xr6ozriRbOuJtXu4BUpUN30JvKRSwywqE82J9yO4T7hVo VuWaZuj0+qItZCj2Eahmw4pgf/xhv/w= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=AUPVTfrH; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf17.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705484968; a=rsa-sha256; cv=none; b=T6F/hjGC+bdXr22yBP7eCZVy0FbuwKmLNGc+VPUGE/v8cHnGUZCvX4Tja5c7rXUKZxe0Md sXpGxO6UVuU4DhphfuNxKn29r4NfT82TKXV3puDXlrg0KhhPm1+EUI2yPr/hbQyRqaegGF C0qKMTxDK9G9fMkpTQdo/Aw/GgCeVTs= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 8DE3840E0177; Wed, 17 Jan 2024 09:49:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 73h8eGAiSvco; Wed, 17 Jan 2024 09:49:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1705484962; bh=CjSLyfAbv41XmX0Cv5sZW7YHSOKxGuGf033WvhzwPIg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AUPVTfrHiTingPKZFsEqLYK+TO00Iy3wbEj0fI4XxjUUpFdFJlDE/XHGxTyF8nNo4 VVarO1oPMsXUftLhWvSIRZLQ47Bo2voFTP1gEo4+hhuX7kAFqnYkYo7+NqfLY/uV7x w3KOTxa1iOIkskfSCrMQde/2pRbzPQuY69h+gNahEfptdViN4dIKJ1W6FCleIgSWEe CUkAZBF1by7UteEN7U2wuUWNo/W22/k1TU4LbMVGxvVzMHFBJjvdcbChVzoBZhNb36 oTgykRuhLSJ9UI7ECrukEUA0afo/IfqgN3GdaptmgQgdedHpMQto+oM4zz67TmD10h PYsXe+s1aGs1umDN8NlMjTYJBJQZXugAMHwhoeRPfhEUaYo+eYxIkcZDyJyOHmOPGo WTNGuznm7QQ+70yycVYpQhWrGOVDGcBljzDDbQVoc7cDjD0KV0tKRVohIfoR++sWx/ Ff/nNR578eIa8XaX2HnSPfonK33YzATVzjQbPgsbzjOUYtXpMPu0yp98yegOQonIcC rKkr85aYezQJWaYLAV7mG2gdRRW2FPECtlw+FMAoDg/o9K/FCOLPr65iTRc8vorClb 8HZJsWJHOZ2wNwTGoo59jdcsMfyhyvXm6PSAW7yKHhBfnOlPLypb2vQ7Vi4wlTzBY+ ITa9H0uT9nSwrrTWtNdFtXec= Received: from zn.tnic (pd9530f8c.dip0.t-ipconnect.de [217.83.15.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id BA00240E01B2; Wed, 17 Jan 2024 09:48:43 +0000 (UTC) Date: Wed, 17 Jan 2024 10:48:37 +0100 From: Borislav Petkov To: Michael Roth Cc: x86@kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com, Brijesh Singh Subject: Re: [PATCH v1 14/26] crypto: ccp: Provide API to issue SEV and SNP commands Message-ID: <20240117094837.GIZaeidSVUPFF7792g@fat_crate.local> References: <20231230161954.569267-1-michael.roth@amd.com> <20231230161954.569267-15-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231230161954.569267-15-michael.roth@amd.com> X-Rspamd-Queue-Id: 2F51540006 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: h7hbjc177i77h8cx7n7f1mc58toi9o78 X-HE-Tag: 1705484967-129822 X-HE-Meta: U2FsdGVkX1/gCyUC4u8tdW6NQCBmb6Oy9sMWxxCFdvUo9Y/W5wUjoq/+Ov+sM61i3Lr7M7P1E4V2sRba5nz+zp2ZzXd02zoga0R1zEtLFNTErbAkHV+s4wCDyFPhCJ1ERrNqMDb/omU/9onxL1iNk7tcoPgJd8+9cLvC/7Hgk5FE9iy8ii541d8UhRR4bTFw+PgQxcxDFzB0l52/wRsKMM/ZMV9xJlxGq8Xdo+mCz+bI0qSgbBn5dlZr8wnsRTsk2WNNJsOH9fg7tXgT9wcOyfZpoinnVYzJKuo2v+YSy0iJ4sPKxhwxc9eKEkI5EscEQGbkAsqfxVcB5BAlN7iGTAHeEQ87qcqFOjkSluZCLeoRcawQz/Gys8Om5dXYfDzR1wEpdFA6L45bvSBGsetq2AuAbK6dLdmkTNqW968r6xxJb8QsShKKHbuSmwxkIvUud6lopEZvOO+hmHJfN+sG3fhpEskr/BHpn+kQSilbKtVpuIUTE4iYyb10QFVec4e4fKUb9m5Z5dZxL/tQglCHMZuPoe2rcQpyZhIdLrWMN7wyCwOtsKCXJEgqmtNW84JLkzAOidHyCI2NnciOw16bcXNhUiBz0oAkT39/QodTvZmydPfVi/7++HhNUY1QGCXdGFLk7CAYjhMaCGCsWQjO25fcll67MdWJ1U6GYTpANMMrxO0xo48Yjf2r4Ffn1T6pVGAEWbss9GYp3m6TqveAwltCACF6Sj71/Fr8dNduGOscmr6ab7D0Ayrasrd1GCz+l18bHSwfJ4PBGJbIOndi+TZz5TTURUu549VR4i60reO2obwgmwIBzcaAzTdVL6tqg+jj46YY6PPWlWrYIKBRmTfG65BpEWHD0ZS8GkMj4N/bUz4dDxPiND6btuZYw0oPEIuHgs6SrwyNXtxdSHMIfD34eVaaESXyj4z324f54LRfljWLjOvJgTfkcUlvr3AmAU0kLYNj3/88/cP7ltj BLHD2Rf+ Luw0LWRCigpwueIEo2wKkcye27AJ8TnH2jV2pHfkjUYMCdUj2QwQv6S9rLDPP4F4CrLzvzZi7tQuIuqf/VT1q34/GTZJ9sGe97VmJIh1xbZ7lKnxa6ERP6X69IYzOOQenzts6fdj7wc6g8D5Zopg7LzQ0nuP/U7Uyoiu3P7hvcks1qafP83MVethDXRp7WMJAw9qqVLDoshFu7Lc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Dec 30, 2023 at 10:19:42AM -0600, Michael Roth wrote: > +/** > + * sev_do_cmd - issue an SEV or an SEV-SNP command > + * > + * @cmd: SEV or SEV-SNP firmware command to issue > + * @data: arguments for firmware command > + * @psp_ret: SEV command return code > + * > + * Returns: > + * 0 if the SEV successfully processed the command More forgotten feedback: --- diff --git a/include/linux/psp-sev.h b/include/linux/psp-sev.h index 0581f194cdd0..a356a7b7408e 100644 --- a/include/linux/psp-sev.h +++ b/include/linux/psp-sev.h @@ -922,7 +922,7 @@ int sev_guest_decommission(struct sev_data_decommission *data, int *error); * @psp_ret: SEV command return code * * Returns: - * 0 if the SEV successfully processed the command + * 0 if the SEV device successfully processed the command * -%ENODEV if the PSP device is not available * -%ENOTSUPP if PSP device does not support SEV * -%ETIMEDOUT if the SEV command timed out --- Also, pls add it to your TODO list as a very low prio item to fixup all this complains about: ./scripts/kernel-doc -none include/linux/psp-sev.h Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette