From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79F7CC47077 for ; Tue, 16 Jan 2024 23:41:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF4C96B0088; Tue, 16 Jan 2024 18:41:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CA4D36B0089; Tue, 16 Jan 2024 18:41:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6C1F6B009D; Tue, 16 Jan 2024 18:41:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A37E96B0088 for ; Tue, 16 Jan 2024 18:41:43 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7162FA0236 for ; Tue, 16 Jan 2024 23:41:43 +0000 (UTC) X-FDA: 81686798886.21.884AAD4 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by imf12.hostedemail.com (Postfix) with ESMTP id 35DFD40003 for ; Tue, 16 Jan 2024 23:41:39 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=eib8Fc7x; spf=pass (imf12.hostedemail.com: domain of lkp@intel.com designates 192.198.163.9 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705448500; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X/vCI3p9nfiHbKTR0FTiF4uG2L9gOnGEDcLbsFDUL6w=; b=y4RXn5pj0CrwckEZqxn19duqdcCPEFtRmPTGMNHacr8bG1es//eeFcZXcRQRt0DhvxffBt xeZ1BPvKvHaSQwFy+GVymC6I5Idwm/WPB4/No3w/21WTQ2gROTuR94yhvg955VCrUMAvlx J6ae4SIdFmyoDYVll51a6vMAJY1t0q8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=eib8Fc7x; spf=pass (imf12.hostedemail.com: domain of lkp@intel.com designates 192.198.163.9 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705448500; a=rsa-sha256; cv=none; b=Ulkp82+oRv/CEkzplkARVy1DKSQdtroKDBUrxArZ3g+pLJnkkSm1i8ooB2AVRPh3RFOzqb TxPExigIQaNiMPQSfp95gSbrYzRkpNywZ9DiCxRTNUzVEsdlBWOupwa4DvnqX+G3lR7FHQ goekAzcx5vbxH/dTmit9Uda6sO3J3Oo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1705448500; x=1736984500; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=W72U7S1Jt5TV+GwwBd0uYWUfAkSSUDs+SxFcWOvvgpA=; b=eib8Fc7xovesxHweUMGBF9jD1Cu3zITU/ZxjVHm4AZdkuiDRqbWCZ2pp RdX9/wDzs8kb7POTsUXiQFgsDkJeUJRcUoIswqpdrEprPxCac2NDZMkLV d6Y1X919c3UqOb+cgP3WFTJvFFSVj7h2xAcrttc2ddsJS0kvlNoE9xGPq uiSiuWvE1SKdQm1u7RrHzrVdJhs5gPfhDi9mauP7sS2WudP9KnmWadk/D T6DHsfY/xdzF6SCzZnAEOVa14idM5ToGjnNbrf2FNJSiXjbaeiVmYrN9B 7+q328rm72KvfHx0PYOHp3P7vJ2+rHWfKiPgtLg1S9YK+Zrx1d7BupDMR g==; X-IronPort-AV: E=McAfee;i="6600,9927,10955"; a="6778023" X-IronPort-AV: E=Sophos;i="6.05,200,1701158400"; d="scan'208";a="6778023" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2024 15:41:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10955"; a="874641224" X-IronPort-AV: E=Sophos;i="6.05,200,1701158400"; d="scan'208";a="874641224" Received: from lkp-server01.sh.intel.com (HELO 961aaaa5b03c) ([10.239.97.150]) by FMSMGA003.fm.intel.com with ESMTP; 16 Jan 2024 15:41:35 -0800 Received: from kbuild by 961aaaa5b03c with local (Exim 4.96) (envelope-from ) id 1rPt3l-0001MV-1H; Tue, 16 Jan 2024 23:41:33 +0000 Date: Wed, 17 Jan 2024 07:41:27 +0800 From: kernel test robot To: Kefeng Wang , Andrew Morton , linux-kernel@vger.kernel.org Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , ryan.roberts@arm.com, Matthew Wilcox , David Hildenbrand , Kefeng Wang Subject: Re: [PATCH] mm: memory: move mem_cgroup_charge() into alloc_anon_folio() Message-ID: <202401170708.XjVa9Trj-lkp@intel.com> References: <20240116071302.2282230-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240116071302.2282230-1-wangkefeng.wang@huawei.com> X-Rspamd-Queue-Id: 35DFD40003 X-Rspam-User: X-Stat-Signature: 7nhntmhnq1bwzyxfhhzkzo3hf85th1k9 X-Rspamd-Server: rspam01 X-HE-Tag: 1705448499-586556 X-HE-Meta: U2FsdGVkX19eu54z5K0VzVQJsM8L3ilrfuIm7tg7CthON4Juerj6DXHqa1Yz89zheklvvK8nGMJjr7ND/WDkqXm5zfswf7C1iw5FXMm48jM2Y+xqI+tqWHwDhGpDpRaAtY28Rv/1BMbvPU987xWDbBlqu5nsgVs6WKvrdsg26ihQh5DQYs5GFfa5DLW4XWJB2kidvuJuQqs+DJmLVMFfkIBb10HxHP8LETcjTM+9WugR7io0+TO9eWIz/gYygUl1bnfyGGSoleM8MuvtX9yMexEwoFVVeeW8cbevAm8OHkTw717KeVpXviTTmvBWMQfpU5ROZQej8mUlqe+KGkFXMWTktV3nJnpBbU5Qcq9uM1y/5ox0nrS1prRCzm66eVPiGdoSZztq/3EWWHQ00oz/TcHjOgPj2NTjZU1Y+REB5kMFb0atjejfFpHOc+qvd9wC0gLg0QTFjKLSizSXnbNnO3ZKMoAG4I4dzhGVPEtxABK6adOvu0JtnRqkY7kKe8HyfdCzAVAQCbhdcG686PHWlxjRYpA3WT2sSLtCKDnhUMbxGIBCLulsSefX4ra9TmysoNcSzslBHr81C0J4ZmDhJZVVxAE0ZOqCaBvmYRvlBF549rgC1zU3uD7o6SEQNhiUnseJECnQAXaPVrbDE8gZovxhkOG9eL1T1iJQvjUVZtTKEywoNlZuD87QWH5fQRvF8oAQk8ZCd1kyRiYtLJ7tX2gZxLL2we51v5Cx0RNHKawmtT2sOYllOI/ntA74ISrtFXaCPgt9BL/sa3ECT37dRq+iojl4GKRsyEr6L4i++v6o40JJ5piSA1shJlSjmQKMB2Jqcpkjrq0Obb+QGV7MJCXYZZu1BVoVvoOcABe++M8d7fzM/e9sHR+7UX04pOP7TyKukUdSaB9cwlrHXJexUAoc6739TUZwsvDaVvmfM6fe0zDh3ZUoq2/3PP/X+cVXA8jjaiEkrp9NxhnHPWn 7D5UDH40 N2HjrJPqwirTGcdQjOrTfY4PXcEHNv2yR/BlYws5nsNFgx3Aj1bUUe2z5CGDBlO2lrWa9H+sbvyr/dgKQ7U0AM5FjSEoi9JwlxRLVm1MX9D+xJD5zM1Z5b4J6ScP+6doZv7N0QDrfwlAVS9HYfnrWHA8UsqrHPhJjJ+CrLZC9rFD0VoFw9rSoWiUOF986Y8zAalrRyCl71BXsDK3sqZdHWyp6G7BI63D2Z2VzQHQao8v9n0rsv/eVMB4e2zKTc538e18y97vTOZh/dZR2JX+NvbKDGtctUA24AbLsL5Rw8TYmA/Qhrtl3kyYz2yA7sIqokJ9Yx1F/d12flbS6qX2ClKCxcRrW3o7BPeSvGqd+3HVM07pEXygPXRp7gA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Kefeng, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Kefeng-Wang/mm-memory-move-mem_cgroup_charge-into-alloc_anon_folio/20240116-151640 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20240116071302.2282230-1-wangkefeng.wang%40huawei.com patch subject: [PATCH] mm: memory: move mem_cgroup_charge() into alloc_anon_folio() config: i386-buildonly-randconfig-002-20240116 (https://download.01.org/0day-ci/archive/20240117/202401170708.XjVa9Trj-lkp@intel.com/config) compiler: ClangBuiltLinux clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240117/202401170708.XjVa9Trj-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202401170708.XjVa9Trj-lkp@intel.com/ All errors (new ones prefixed by >>): >> mm/memory.c:4223:24: error: use of undeclared identifier 'vma' 4223 | return folio_prealloc(vma->vm_mm, vma, vmf->address, true); | ^ mm/memory.c:4223:36: error: use of undeclared identifier 'vma' 4223 | return folio_prealloc(vma->vm_mm, vma, vmf->address, true); | ^ 2 errors generated. vim +/vma +4223 mm/memory.c 4153 4154 static struct folio *alloc_anon_folio(struct vm_fault *vmf) 4155 { 4156 #ifdef CONFIG_TRANSPARENT_HUGEPAGE 4157 struct vm_area_struct *vma = vmf->vma; 4158 unsigned long orders; 4159 struct folio *folio; 4160 unsigned long addr; 4161 pte_t *pte; 4162 gfp_t gfp; 4163 int order; 4164 4165 /* 4166 * If uffd is active for the vma we need per-page fault fidelity to 4167 * maintain the uffd semantics. 4168 */ 4169 if (unlikely(userfaultfd_armed(vma))) 4170 goto fallback; 4171 4172 /* 4173 * Get a list of all the (large) orders below PMD_ORDER that are enabled 4174 * for this vma. Then filter out the orders that can't be allocated over 4175 * the faulting address and still be fully contained in the vma. 4176 */ 4177 orders = thp_vma_allowable_orders(vma, vma->vm_flags, false, true, true, 4178 BIT(PMD_ORDER) - 1); 4179 orders = thp_vma_suitable_orders(vma, vmf->address, orders); 4180 4181 if (!orders) 4182 goto fallback; 4183 4184 pte = pte_offset_map(vmf->pmd, vmf->address & PMD_MASK); 4185 if (!pte) 4186 return ERR_PTR(-EAGAIN); 4187 4188 /* 4189 * Find the highest order where the aligned range is completely 4190 * pte_none(). Note that all remaining orders will be completely 4191 * pte_none(). 4192 */ 4193 order = highest_order(orders); 4194 while (orders) { 4195 addr = ALIGN_DOWN(vmf->address, PAGE_SIZE << order); 4196 if (pte_range_none(pte + pte_index(addr), 1 << order)) 4197 break; 4198 order = next_order(&orders, order); 4199 } 4200 4201 pte_unmap(pte); 4202 4203 /* Try allocating the highest of the remaining orders. */ 4204 gfp = vma_thp_gfp_mask(vma); 4205 while (orders) { 4206 addr = ALIGN_DOWN(vmf->address, PAGE_SIZE << order); 4207 folio = vma_alloc_folio(gfp, order, vma, addr, true); 4208 if (folio) { 4209 if (mem_cgroup_charge(folio, vma->vm_mm, gfp)) { 4210 folio_put(folio); 4211 goto next; 4212 } 4213 folio_throttle_swaprate(folio, gfp); 4214 clear_huge_page(&folio->page, vmf->address, 1 << order); 4215 return folio; 4216 } 4217 next: 4218 order = next_order(&orders, order); 4219 } 4220 4221 fallback: 4222 #endif > 4223 return folio_prealloc(vma->vm_mm, vma, vmf->address, true); 4224 } 4225 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki