From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84015C47077 for ; Tue, 16 Jan 2024 21:27:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18EDB6B00A3; Tue, 16 Jan 2024 16:27:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 118896B00AA; Tue, 16 Jan 2024 16:27:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED4466B00AB; Tue, 16 Jan 2024 16:27:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D53D96B00A3 for ; Tue, 16 Jan 2024 16:27:37 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9DFCA1C1502 for ; Tue, 16 Jan 2024 21:27:37 +0000 (UTC) X-FDA: 81686460954.17.A6AB340 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by imf20.hostedemail.com (Postfix) with ESMTP id E51921C000A for ; Tue, 16 Jan 2024 21:27:34 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=lXVsmJbx; spf=pass (imf20.hostedemail.com: domain of lkp@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705440455; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NOviJmr8mC9gWrHuEOYqNkeWSolIp9QJMZhy1yzQq0o=; b=zvHsoxiF0vrfoMdEWG8BCAiVy8Y16dG4VUcQP/aQnzaQJWtgzuXdgGewVwnk89v4QGza6o yoagAaVndPqx4MV0GuZ7UuEyE4frLSfmG4hS8tPfSk2W0pgV3UF3pXnwurm5yQb3mAJmcu LNgeDv4gagyb2lkr7jHakTC6hWn5Y84= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705440455; a=rsa-sha256; cv=none; b=Er520wra+yTY29fUlCpxjK2vwT4ItpLqioUfkDaidxDd2MZzFyFsW8uuKLIjNpzOQQFRWF U0lib9Mz0DhytnNnnkNUDppPgDDyir0ZavNl1+yAF7t33YsI7yZvgZCTFxJzsO+EMQFfFR 4XqPDHrGHYfHgL5vr2Qpov1s2NQ2qTQ= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=lXVsmJbx; spf=pass (imf20.hostedemail.com: domain of lkp@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1705440455; x=1736976455; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=tTB1Chezho9b8AhhxeEGmrGzWtaHiHCg0jhnEGqHiRs=; b=lXVsmJbxsbiI+UDByWRwuwiMDtc9EKAgN6tZ7IHELtrgNQtxbZ1rXtW0 bEdec0zNkzDN7eX30cuddamt7CpTr2rwApY5vAQUSsE0O+ePG2cS/sgo1 PDXGZfL+7bUygXHsLET1XGGr0md4A4aJBiGENHBaN59Twqsv4Vb6Ee/bQ JZhH9UUAsxtjJhXmM0cmAb8d5o8LSTF6iZDhTbO7xoU09NWczqne9iPaC CROhO0W+vDy+LjF82prtIIUYiKZLpRJO5sRcyXmBHmZu3mNZNJVzx5+t6 NJg5xrJntJqne25XxLnQ0cjTzTLo3SW5wsS7dogCdUmeBJccCSNvWi7gC g==; X-IronPort-AV: E=McAfee;i="6600,9927,10955"; a="486149254" X-IronPort-AV: E=Sophos;i="6.05,200,1701158400"; d="scan'208";a="486149254" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2024 13:27:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10955"; a="787585730" X-IronPort-AV: E=Sophos;i="6.05,200,1701158400"; d="scan'208";a="787585730" Received: from lkp-server01.sh.intel.com (HELO 961aaaa5b03c) ([10.239.97.150]) by fmsmga007.fm.intel.com with ESMTP; 16 Jan 2024 13:27:31 -0800 Received: from kbuild by 961aaaa5b03c with local (Exim 4.96) (envelope-from ) id 1rPqy1-0001G6-04; Tue, 16 Jan 2024 21:27:29 +0000 Date: Wed, 17 Jan 2024 05:26:58 +0800 From: kernel test robot To: Kefeng Wang , Andrew Morton , linux-kernel@vger.kernel.org Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , ryan.roberts@arm.com, Matthew Wilcox , David Hildenbrand , Kefeng Wang Subject: Re: [PATCH] mm: memory: move mem_cgroup_charge() into alloc_anon_folio() Message-ID: <202401170535.2TfJ7u74-lkp@intel.com> References: <20240116071302.2282230-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240116071302.2282230-1-wangkefeng.wang@huawei.com> X-Stat-Signature: 1jkj3nh9txsbfs8qsnga73heakooms4m X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: E51921C000A X-Rspam-User: X-HE-Tag: 1705440454-191132 X-HE-Meta: U2FsdGVkX18sfkC0A1wyfMFrj1qlhgJ/KGGZ2yeGWCUDFqiG+FLq239DRkH7dhRnnyUXa8gVk4Uy9LYUCBCQvIRThaJ9eQTrZ2YB6ice3mwbLfgiI889zeb75SwWR7x1kMTaCo+knNUVw3Ss8dZvwmEZL5SsJT0lwKbrCOTVTAIEMX9ZnAyfXtXy0mBMHJ0XSU3ntHQOe7OrAe0y8Ti2eVLDcGbwlKFzpq2nmTAMe8AMOWBBbRgbn/bWrXws7q3+xTaq2ZukppP/U5awBHDjo6r9THAgDLEWRDz1SjhsxWH2ue4XBLi06dC68wDBvEaykrw8cklPbPlGaTcx2U24cMC9YloS0PCFkYnrvBA/sMQ2X/UVmD1xffRlxR08zAwq7xEX6pcnFMazMhRnUF/gHZ8QOGps3jP3zI12td+tfCKWzghp6oRdXVntwEW7Egl7DvkyLBrUp8ELHOhJlIuyeIMy/ZYMrz4bq33FMRVtVck6nmbzqvFHeQvX8xGOa9xYr78/wy0esB/N/U6nNE9o8EcRu4H7IiC61hHJlewzlXvY8g3Han5kBf7QjdrMfUgVVJsBuywNOtGxJoskhMa6f6JcJj9oStkWe7vYCQojxfAosT15At8s3Ymw3NFycC/cbUiOhD4tJgma8+/gcyunHoblICiQu1iWnWgK35rMTkAomUY5XE3bvVo87JbcvsM7qkK/gyBBZJ6U2U3Wv+V9Ssfp/w4NPwRSuTyC94lGvt8J5HdZAbpY9R+bIYSWPxfZr8RzAAdTrhbl+NnEXn7/tACkPz0e3eRkoonAqSnLmrLaOi2o0Zt8Sa86EnqDxk0tcm2YSYDAitn5anqBVk7gCj0Vj3hVVPkeZsLKq9lMPsgjM+lTDYU2z4lKX1oc8vP0boBuu5Kh4TQybnQ9cKrkPfNGUHd5vyF3m0/qWBHHn0QRIIwgVD1nKBKEQ2dT3wLGhW99+HyJJuTGJ5pMONG y7uE2W+i +CyI52IvTZgwL1l8KqUz1KdSUhgPqEklIEYnpCY6leaFWB+JgppGXiQ2r5VlXg2mzIkjLcZytUX7nFEBMR3K1rxr0V9o8aWGvGjjIrR13qzftGo10O9Uu2g1pwec+/sIAMEBLXbwMNtXEw8fV3qVyzojKgb0O+XEr3LqKArSXDN0vdXj60WKHqFznLixa1MV/JR3yrZTrnvtwwgY/8xHis8VVl/U+jMYBsndtoRMK4oEY+57ikc8hVHXl8gufO/UTYCLxVcKY64a0Kvo/Y+L0X7V2hFFS5oG2x8yOtXxyhAnxTdEazucmp0UKaRszUP7OnRYRjD5h719cRqgxuPcKyNnp3hDZDerblvLmIBCc4fI2aJsQZ3uRPUqysA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Kefeng, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Kefeng-Wang/mm-memory-move-mem_cgroup_charge-into-alloc_anon_folio/20240116-151640 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20240116071302.2282230-1-wangkefeng.wang%40huawei.com patch subject: [PATCH] mm: memory: move mem_cgroup_charge() into alloc_anon_folio() config: x86_64-allnoconfig (https://download.01.org/0day-ci/archive/20240117/202401170535.2TfJ7u74-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240117/202401170535.2TfJ7u74-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202401170535.2TfJ7u74-lkp@intel.com/ All error/warnings (new ones prefixed by >>): mm/memory.c: In function 'alloc_anon_folio': >> mm/memory.c:4223:31: error: 'vma' undeclared (first use in this function); did you mean 'vmf'? 4223 | return folio_prealloc(vma->vm_mm, vma, vmf->address, true); | ^~~ | vmf mm/memory.c:4223:31: note: each undeclared identifier is reported only once for each function it appears in >> mm/memory.c:4224:1: warning: control reaches end of non-void function [-Wreturn-type] 4224 | } | ^ vim +4223 mm/memory.c 4153 4154 static struct folio *alloc_anon_folio(struct vm_fault *vmf) 4155 { 4156 #ifdef CONFIG_TRANSPARENT_HUGEPAGE 4157 struct vm_area_struct *vma = vmf->vma; 4158 unsigned long orders; 4159 struct folio *folio; 4160 unsigned long addr; 4161 pte_t *pte; 4162 gfp_t gfp; 4163 int order; 4164 4165 /* 4166 * If uffd is active for the vma we need per-page fault fidelity to 4167 * maintain the uffd semantics. 4168 */ 4169 if (unlikely(userfaultfd_armed(vma))) 4170 goto fallback; 4171 4172 /* 4173 * Get a list of all the (large) orders below PMD_ORDER that are enabled 4174 * for this vma. Then filter out the orders that can't be allocated over 4175 * the faulting address and still be fully contained in the vma. 4176 */ 4177 orders = thp_vma_allowable_orders(vma, vma->vm_flags, false, true, true, 4178 BIT(PMD_ORDER) - 1); 4179 orders = thp_vma_suitable_orders(vma, vmf->address, orders); 4180 4181 if (!orders) 4182 goto fallback; 4183 4184 pte = pte_offset_map(vmf->pmd, vmf->address & PMD_MASK); 4185 if (!pte) 4186 return ERR_PTR(-EAGAIN); 4187 4188 /* 4189 * Find the highest order where the aligned range is completely 4190 * pte_none(). Note that all remaining orders will be completely 4191 * pte_none(). 4192 */ 4193 order = highest_order(orders); 4194 while (orders) { 4195 addr = ALIGN_DOWN(vmf->address, PAGE_SIZE << order); 4196 if (pte_range_none(pte + pte_index(addr), 1 << order)) 4197 break; 4198 order = next_order(&orders, order); 4199 } 4200 4201 pte_unmap(pte); 4202 4203 /* Try allocating the highest of the remaining orders. */ 4204 gfp = vma_thp_gfp_mask(vma); 4205 while (orders) { 4206 addr = ALIGN_DOWN(vmf->address, PAGE_SIZE << order); 4207 folio = vma_alloc_folio(gfp, order, vma, addr, true); 4208 if (folio) { 4209 if (mem_cgroup_charge(folio, vma->vm_mm, gfp)) { 4210 folio_put(folio); 4211 goto next; 4212 } 4213 folio_throttle_swaprate(folio, gfp); 4214 clear_huge_page(&folio->page, vmf->address, 1 << order); 4215 return folio; 4216 } 4217 next: 4218 order = next_order(&orders, order); 4219 } 4220 4221 fallback: 4222 #endif > 4223 return folio_prealloc(vma->vm_mm, vma, vmf->address, true); > 4224 } 4225 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki